From 4f89b707cc28658d41b38a1e03bb240894975f15 Mon Sep 17 00:00:00 2001 From: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> Date: Mon, 9 Dec 2019 13:05:58 +0800 Subject: [PATCH] remove python 3.4 support (#11432) --- doc/command_guidelines.md | 2 +- scripts/ci/build.sh | 3 ++- src/azure-cli-command_modules-nspkg/setup.py | 1 - src/azure-cli-core/setup.py | 1 - src/azure-cli-nspkg/setup.py | 1 - src/azure-cli-telemetry/setup.py | 1 - src/azure-cli-testsdk/setup.py | 1 - src/azure-cli/HISTORY.rst | 4 ++++ src/azure-cli/setup.py | 1 - tools/setup.py | 3 ++- 10 files changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/command_guidelines.md b/doc/command_guidelines.md index 6bde37b5f..82800e1cc 100644 --- a/doc/command_guidelines.md +++ b/doc/command_guidelines.md @@ -421,7 +421,7 @@ Virtual Network Rule Arguments ## Coding Practices - All code must support Python 2 & 3. -The CLI supports 2.7, 3.4, 3.5 and 3.6 +The CLI supports 2.7, 3.5, 3.6, 3.7 and 3.8 - PRs to Azure/azure-cli and Azure/azure-cli-extensions must pass CI - Code must pass style checks with pylint and pep8 - (*) All commands should have tests diff --git a/scripts/ci/build.sh b/scripts/ci/build.sh index 9a0805d97..c4697c228 100755 --- a/scripts/ci/build.sh +++ b/scripts/ci/build.sh @@ -95,9 +95,10 @@ CLASSIFIERS = [ 'Programming Language :: Python :: 2', 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.4', 'Programming Language :: Python :: 3.5', 'Programming Language :: Python :: 3.6', + 'Programming Language :: Python :: 3.7', + 'Programming Language :: Python :: 3.8', 'License :: OSI Approved :: MIT License', ] diff --git a/src/azure-cli-command_modules-nspkg/setup.py b/src/azure-cli-command_modules-nspkg/setup.py index 8929d9f8d..7621cb7be 100644 --- a/src/azure-cli-command_modules-nspkg/setup.py +++ b/src/azure-cli-command_modules-nspkg/setup.py @@ -18,7 +18,6 @@ CLASSIFIERS = [ 'Programming Language :: Python :: 2', 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.4', 'Programming Language :: Python :: 3.5', 'Programming Language :: Python :: 3.6', 'Programming Language :: Python :: 3.7', diff --git a/src/azure-cli-core/setup.py b/src/azure-cli-core/setup.py index 5c44985b2..c4ba92ddb 100644 --- a/src/azure-cli-core/setup.py +++ b/src/azure-cli-core/setup.py @@ -45,7 +45,6 @@ CLASSIFIERS = [ 'Programming Language :: Python :: 2', 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.4', 'Programming Language :: Python :: 3.5', 'Programming Language :: Python :: 3.6', 'Programming Language :: Python :: 3.7', diff --git a/src/azure-cli-nspkg/setup.py b/src/azure-cli-nspkg/setup.py index f6e3173c1..589447109 100644 --- a/src/azure-cli-nspkg/setup.py +++ b/src/azure-cli-nspkg/setup.py @@ -18,7 +18,6 @@ CLASSIFIERS = [ 'Programming Language :: Python :: 2', 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.4', 'Programming Language :: Python :: 3.5', 'Programming Language :: Python :: 3.6', 'Programming Language :: Python :: 3.7', diff --git a/src/azure-cli-telemetry/setup.py b/src/azure-cli-telemetry/setup.py index c8e13d56c..8b9dee4e3 100755 --- a/src/azure-cli-telemetry/setup.py +++ b/src/azure-cli-telemetry/setup.py @@ -26,7 +26,6 @@ CLASSIFIERS = [ 'Programming Language :: Python :: 2', 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.4', 'Programming Language :: Python :: 3.5', 'Programming Language :: Python :: 3.6', 'Programming Language :: Python :: 3.7', diff --git a/src/azure-cli-testsdk/setup.py b/src/azure-cli-testsdk/setup.py index 1824bc1ef..30f8181a0 100644 --- a/src/azure-cli-testsdk/setup.py +++ b/src/azure-cli-testsdk/setup.py @@ -23,7 +23,6 @@ CLASSIFIERS = [ 'Programming Language :: Python :: 2', 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.4', 'Programming Language :: Python :: 3.5', 'Programming Language :: Python :: 3.6', 'Programming Language :: Python :: 3.7', diff --git a/src/azure-cli/HISTORY.rst b/src/azure-cli/HISTORY.rst index 1163c1612..7c1acbc42 100644 --- a/src/azure-cli/HISTORY.rst +++ b/src/azure-cli/HISTORY.rst @@ -11,6 +11,10 @@ Release History * vmss create/update: Add --scale-in-policy, which decides which virtual machines are chosen for removal when a VMSS is scaled-in +**Core** + +* Remove support for Python 3.4 + **Install** * Install script support python 3.8 diff --git a/src/azure-cli/setup.py b/src/azure-cli/setup.py index ac4bf89ce..861fcfad3 100644 --- a/src/azure-cli/setup.py +++ b/src/azure-cli/setup.py @@ -45,7 +45,6 @@ CLASSIFIERS = [ 'Programming Language :: Python :: 2', 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.4', 'Programming Language :: Python :: 3.5', 'Programming Language :: Python :: 3.6', 'Programming Language :: Python :: 3.7', diff --git a/tools/setup.py b/tools/setup.py index ea10a90f0..8f4e041a4 100644 --- a/tools/setup.py +++ b/tools/setup.py @@ -15,9 +15,10 @@ CLASSIFIERS = [ 'Programming Language :: Python :: 2', 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.4', 'Programming Language :: Python :: 3.5', 'Programming Language :: Python :: 3.6', + 'Programming Language :: Python :: 3.7', + 'Programming Language :: Python :: 3.8', 'License :: OSI Approved :: MIT License', ]