azuredatastudio/CONTRIBUTING.md

51 строка
2.6 KiB
Markdown
Исходник Постоянная ссылка Обычный вид История

## Contributing Issues
### Before Submitting an Issue
Merge Azure Data Studio branding changes (#2689) * Bump Electron to 2.0.8 and SQL Ops to 0.33.3 (#2466) * Merged PR 328: Initial "Azure Data Studio" branding changes * Alanren/icon overwrite issue (#2484) * fix the error icon too large issue * formatting * add logic to hide and add grid panel based on size (#2481) * add grid styles (#2483) * Add check for potential failure in handling drag (#2499) * add check for potential failure in handling drag * move check to avoid ui glitches * Reorder Connection Name field in Connection Dialog (#2498) * change cursor in message panel to default (#2494) * add select all handler to grid (#2496) * Fix macOS titlebar branding * add animation when button is clicked and fix title in button (#2488) * add animation similar to toolbar in vscode and fix title in button * remove bur method in button * Disable the User Setup prompt (#2501) * fixes a rendering problem in splitview (#2512) * add listener to change action bar on maximize change (#2505) * fix the save and save all for untitled file (#2526) * add check for selection model in edit data (#2517) * add min size for row num column (#2518) * expand messages panel on error (#2519) * Selection in grid context (#2527) * update action context on selection change * correctly add ranges rather than a new range for every row * add required functions to typings * Fixes #2523 (#2528) The IdGenerator was recreated each time and had a high likelihood of conflicts. Invitably after adding dozens or hundreds of icons you'll start seeing the CSS class replaced and overridden. The solution is to do like elsewhere: have 1 const that is loaded on first import of the file and keeps a global track. Side note is that it'd be a good idea to cache CSS rules with the same iconPath so we don't create lots of additional rules unnecessarily. If we reuse the same icon a bunch we should cache them - #2524 is tracking this. * Fix grid gaps (#2531) * modifying grid gaps * reduce gaps and increase gap for action bar * fix grid action bar not updating (#2532) * Turn-off Git missing prompt (#2533) * Reduce message panel min size to 0 (#2534) * reduce message panel minimum size to 0; attempt to restore panel sizing on requery sizes; default grid panel size to 80% * formatting * Fix bug around debounced event not being flushed in time (#2536) * fix bug around debounced event not being flushed in time * add comment * Fix build break in Git extension (#2538) * Update SQL Ops to 0.33.4 * Fix sizing error when switching windows (#2544) * add work around for when we need to resize while we don't have a dimension to resize off of * formatting * change active cell during change to fix focus shift (#2545) * fix the account not found error when creating firewall rules (#2543) * Support isDirty flag for model view editors and begin plumb through of save support (#2547) * Add dirty and save support to model view * Add issue # for a TODO * add divcontainer in modelview (#2559) * add divcontainer in modelview * address comment * Bug/extension contribution (#2560) * revert 4ab5d84b9431b4a9cc23687fb2d9ecfc839f41c1 * fixed extensions * Merged PR 352: Switch settings folder back to .sqlops Switch settings folder back to .sqlops * fix the connection issue when opening new query after connection (#2561) * Update SQL Ops to 0.33.5 * Disabled connection name input when connecting to a server. (#2566) * Disabled connection name input when connecting to a server. #2557 * Fixed reset state of connection inputs * added context to chart buttons so they work (#2575) * accessibility setting based select database dropdown (#2579) * Maintain Query State (#2571) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * fix tests by adding missing node module * formatting * refactor interfaces out to get around testing restrictions * more refactoring of importants to avoid loading errors * use latest slickgrid library (#2584) * Add OE node refresh API method (#2578) * Initial working commit for refreshing OE node via API * Add test and fix up code * Run tsfmt * Fix test * Merged PR 356: Fix getDefaultLogLocation to use 'Azure Data Studio' Update getDefaultLogLocation to use 'Azure Data Studio' to fix Azure Account creation on macOS. * Update SQL Ops to 0.33.6 * Fix crash when reverting in edit data with no changes (#2594) * edit data issue with column index handling (#2595) * fixed insights crash (#2596) * Changed the "Configure" link to "Learn How To Configure The Dashboard". (#2599) * Changed the "Configure" link to "Learn How To Configure the Dashboard". This inlcudes the command as well as the tile label #1227 * Capitalizing first character in each word * The "New Query" context menu is now only available from the server & db (#2598) #1890 * Merged PR 366: Revert to using 'sqlops' so settings are maintained during upgraded Revert to using 'sqlops' so settings are maintained during upgraded * Merged PR 371: Fix casing for AZURE DATA STUDIO in EULA Fix casing for AZURE DATA STUDIO in EULA * Merged PR 375: Create new appid Create new appid * Merged PR 376: Update settings path back to 'azuredatastudio' Update settings path back to 'azuredatastudio' * Fix/bump dependency versions (#2608) * Use version 2.0.9 of electron (#2606) * fixes scrolling in query plan (#2609) * Dashboard: Fixed all insight bugs (#2612) * fixed all insight bugs * removed unused imports * added comment * add view area options to pick up chart background fix (#2613) * Respect message settings (#2614) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * add configuration to state * address comments * Fix stating for scrolls (#2615) * nearly working * add accounting for the downsides to slickgrid * Update SQL Ops to 0.33.7 * Added text underline CSS for DB NULL values when editing / showing data (#2597) * Added text underline CSS for DB NULL values when editing / showing data #217 * Changed db nulls styling to italic * Bug/oetimeout Fix - When timeout happens while fetching node children, the node becomes unusable (#2616) This commit fixes issue when multiple OE nodes are expanded simultaneously. While the error was getting displayed the node was left in incorrect state which was leading to the node being unusable in future. This commit repairs this defect. * fixed actual show plan command (#2620) * Bump SQL Tools Service to 1.5.0-alpha.34 (#2621) * Feat/add dom component (#2622) * add dom component for model view * formatting * make css style hardcoded in dom.component * comment out the unused CSS * address comments * address comment * Hide tabs on reexecute (#2624) * add logic to hide tabs when a query rerun is executed * remove double entry in the map * Bump Azure Data Studio to 1.0.0 * Bump Azure Data Studio to 0.33.8 * Scroll query editor when clicking batch links (#2644) * Fix broken 'Clear Token Cache' command (#2643) * fixed right click context menu bug in jobs view (#2632) * fix css issue (#2650) * reload the chart types when we actually need it (#2651) * Bump Azure Data Studio to 1.0.0 * Fix chart error that caused query editor to close (#2652) * Bump Agent, Import and Profiler extension versions
2018-09-25 01:39:19 +03:00
First, please do a search in [open issues](https://github.com/Microsoft/azuredatastudio/issues) to see if the issue or feature request has already been filed. Use this [query](https://github.com/Microsoft/azuredatastudio/issues?q=is%3Aopen+is%3Aissue+label%3Afeature-request+sort%3Areactions-%2B1-desc) to search for the most popular feature requests.
If you find your issue already exists, make relevant comments and add your [reaction](https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments). Use a reaction in place of a "+1" comment.
:+1: - upvote
:-1: - downvote
If you cannot find an existing issue that describes your bug or feature, submit an issue using the guidelines below.
## Writing Good Bug Reports and Feature Requests
File a single issue per problem and feature request.
* Do not enumerate multiple bugs or feature requests in the same issue.
* Do not add your issue as a comment to an existing issue unless it's for the identical input. Many issues look similar, but have different causes.
2019-02-22 04:56:04 +03:00
The more information you can provide, the more likely someone will be successful at reproducing the issue and finding a fix.
The built-in tool for reporting an issue, which you can access by using `Report Issue` in Azure Data Studio's Help menu, can help streamline this process by automatically providing the version of Azure Data Studio, all your installed extensions, and your system info.
Merge Azure Data Studio branding changes (#2689) * Bump Electron to 2.0.8 and SQL Ops to 0.33.3 (#2466) * Merged PR 328: Initial "Azure Data Studio" branding changes * Alanren/icon overwrite issue (#2484) * fix the error icon too large issue * formatting * add logic to hide and add grid panel based on size (#2481) * add grid styles (#2483) * Add check for potential failure in handling drag (#2499) * add check for potential failure in handling drag * move check to avoid ui glitches * Reorder Connection Name field in Connection Dialog (#2498) * change cursor in message panel to default (#2494) * add select all handler to grid (#2496) * Fix macOS titlebar branding * add animation when button is clicked and fix title in button (#2488) * add animation similar to toolbar in vscode and fix title in button * remove bur method in button * Disable the User Setup prompt (#2501) * fixes a rendering problem in splitview (#2512) * add listener to change action bar on maximize change (#2505) * fix the save and save all for untitled file (#2526) * add check for selection model in edit data (#2517) * add min size for row num column (#2518) * expand messages panel on error (#2519) * Selection in grid context (#2527) * update action context on selection change * correctly add ranges rather than a new range for every row * add required functions to typings * Fixes #2523 (#2528) The IdGenerator was recreated each time and had a high likelihood of conflicts. Invitably after adding dozens or hundreds of icons you'll start seeing the CSS class replaced and overridden. The solution is to do like elsewhere: have 1 const that is loaded on first import of the file and keeps a global track. Side note is that it'd be a good idea to cache CSS rules with the same iconPath so we don't create lots of additional rules unnecessarily. If we reuse the same icon a bunch we should cache them - #2524 is tracking this. * Fix grid gaps (#2531) * modifying grid gaps * reduce gaps and increase gap for action bar * fix grid action bar not updating (#2532) * Turn-off Git missing prompt (#2533) * Reduce message panel min size to 0 (#2534) * reduce message panel minimum size to 0; attempt to restore panel sizing on requery sizes; default grid panel size to 80% * formatting * Fix bug around debounced event not being flushed in time (#2536) * fix bug around debounced event not being flushed in time * add comment * Fix build break in Git extension (#2538) * Update SQL Ops to 0.33.4 * Fix sizing error when switching windows (#2544) * add work around for when we need to resize while we don't have a dimension to resize off of * formatting * change active cell during change to fix focus shift (#2545) * fix the account not found error when creating firewall rules (#2543) * Support isDirty flag for model view editors and begin plumb through of save support (#2547) * Add dirty and save support to model view * Add issue # for a TODO * add divcontainer in modelview (#2559) * add divcontainer in modelview * address comment * Bug/extension contribution (#2560) * revert 4ab5d84b9431b4a9cc23687fb2d9ecfc839f41c1 * fixed extensions * Merged PR 352: Switch settings folder back to .sqlops Switch settings folder back to .sqlops * fix the connection issue when opening new query after connection (#2561) * Update SQL Ops to 0.33.5 * Disabled connection name input when connecting to a server. (#2566) * Disabled connection name input when connecting to a server. #2557 * Fixed reset state of connection inputs * added context to chart buttons so they work (#2575) * accessibility setting based select database dropdown (#2579) * Maintain Query State (#2571) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * fix tests by adding missing node module * formatting * refactor interfaces out to get around testing restrictions * more refactoring of importants to avoid loading errors * use latest slickgrid library (#2584) * Add OE node refresh API method (#2578) * Initial working commit for refreshing OE node via API * Add test and fix up code * Run tsfmt * Fix test * Merged PR 356: Fix getDefaultLogLocation to use 'Azure Data Studio' Update getDefaultLogLocation to use 'Azure Data Studio' to fix Azure Account creation on macOS. * Update SQL Ops to 0.33.6 * Fix crash when reverting in edit data with no changes (#2594) * edit data issue with column index handling (#2595) * fixed insights crash (#2596) * Changed the "Configure" link to "Learn How To Configure The Dashboard". (#2599) * Changed the "Configure" link to "Learn How To Configure the Dashboard". This inlcudes the command as well as the tile label #1227 * Capitalizing first character in each word * The "New Query" context menu is now only available from the server & db (#2598) #1890 * Merged PR 366: Revert to using 'sqlops' so settings are maintained during upgraded Revert to using 'sqlops' so settings are maintained during upgraded * Merged PR 371: Fix casing for AZURE DATA STUDIO in EULA Fix casing for AZURE DATA STUDIO in EULA * Merged PR 375: Create new appid Create new appid * Merged PR 376: Update settings path back to 'azuredatastudio' Update settings path back to 'azuredatastudio' * Fix/bump dependency versions (#2608) * Use version 2.0.9 of electron (#2606) * fixes scrolling in query plan (#2609) * Dashboard: Fixed all insight bugs (#2612) * fixed all insight bugs * removed unused imports * added comment * add view area options to pick up chart background fix (#2613) * Respect message settings (#2614) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * add configuration to state * address comments * Fix stating for scrolls (#2615) * nearly working * add accounting for the downsides to slickgrid * Update SQL Ops to 0.33.7 * Added text underline CSS for DB NULL values when editing / showing data (#2597) * Added text underline CSS for DB NULL values when editing / showing data #217 * Changed db nulls styling to italic * Bug/oetimeout Fix - When timeout happens while fetching node children, the node becomes unusable (#2616) This commit fixes issue when multiple OE nodes are expanded simultaneously. While the error was getting displayed the node was left in incorrect state which was leading to the node being unusable in future. This commit repairs this defect. * fixed actual show plan command (#2620) * Bump SQL Tools Service to 1.5.0-alpha.34 (#2621) * Feat/add dom component (#2622) * add dom component for model view * formatting * make css style hardcoded in dom.component * comment out the unused CSS * address comments * address comment * Hide tabs on reexecute (#2624) * add logic to hide tabs when a query rerun is executed * remove double entry in the map * Bump Azure Data Studio to 1.0.0 * Bump Azure Data Studio to 0.33.8 * Scroll query editor when clicking batch links (#2644) * Fix broken 'Clear Token Cache' command (#2643) * fixed right click context menu bug in jobs view (#2632) * fix css issue (#2650) * reload the chart types when we actually need it (#2651) * Bump Azure Data Studio to 1.0.0 * Fix chart error that caused query editor to close (#2652) * Bump Agent, Import and Profiler extension versions
2018-09-25 01:39:19 +03:00
Please include the following with each issue.
2019-03-15 23:09:45 +03:00
* Version of Azure Data Studio (formerly SQL Operations Studio)
* Your operating system
Merge Azure Data Studio branding changes (#2689) * Bump Electron to 2.0.8 and SQL Ops to 0.33.3 (#2466) * Merged PR 328: Initial "Azure Data Studio" branding changes * Alanren/icon overwrite issue (#2484) * fix the error icon too large issue * formatting * add logic to hide and add grid panel based on size (#2481) * add grid styles (#2483) * Add check for potential failure in handling drag (#2499) * add check for potential failure in handling drag * move check to avoid ui glitches * Reorder Connection Name field in Connection Dialog (#2498) * change cursor in message panel to default (#2494) * add select all handler to grid (#2496) * Fix macOS titlebar branding * add animation when button is clicked and fix title in button (#2488) * add animation similar to toolbar in vscode and fix title in button * remove bur method in button * Disable the User Setup prompt (#2501) * fixes a rendering problem in splitview (#2512) * add listener to change action bar on maximize change (#2505) * fix the save and save all for untitled file (#2526) * add check for selection model in edit data (#2517) * add min size for row num column (#2518) * expand messages panel on error (#2519) * Selection in grid context (#2527) * update action context on selection change * correctly add ranges rather than a new range for every row * add required functions to typings * Fixes #2523 (#2528) The IdGenerator was recreated each time and had a high likelihood of conflicts. Invitably after adding dozens or hundreds of icons you'll start seeing the CSS class replaced and overridden. The solution is to do like elsewhere: have 1 const that is loaded on first import of the file and keeps a global track. Side note is that it'd be a good idea to cache CSS rules with the same iconPath so we don't create lots of additional rules unnecessarily. If we reuse the same icon a bunch we should cache them - #2524 is tracking this. * Fix grid gaps (#2531) * modifying grid gaps * reduce gaps and increase gap for action bar * fix grid action bar not updating (#2532) * Turn-off Git missing prompt (#2533) * Reduce message panel min size to 0 (#2534) * reduce message panel minimum size to 0; attempt to restore panel sizing on requery sizes; default grid panel size to 80% * formatting * Fix bug around debounced event not being flushed in time (#2536) * fix bug around debounced event not being flushed in time * add comment * Fix build break in Git extension (#2538) * Update SQL Ops to 0.33.4 * Fix sizing error when switching windows (#2544) * add work around for when we need to resize while we don't have a dimension to resize off of * formatting * change active cell during change to fix focus shift (#2545) * fix the account not found error when creating firewall rules (#2543) * Support isDirty flag for model view editors and begin plumb through of save support (#2547) * Add dirty and save support to model view * Add issue # for a TODO * add divcontainer in modelview (#2559) * add divcontainer in modelview * address comment * Bug/extension contribution (#2560) * revert 4ab5d84b9431b4a9cc23687fb2d9ecfc839f41c1 * fixed extensions * Merged PR 352: Switch settings folder back to .sqlops Switch settings folder back to .sqlops * fix the connection issue when opening new query after connection (#2561) * Update SQL Ops to 0.33.5 * Disabled connection name input when connecting to a server. (#2566) * Disabled connection name input when connecting to a server. #2557 * Fixed reset state of connection inputs * added context to chart buttons so they work (#2575) * accessibility setting based select database dropdown (#2579) * Maintain Query State (#2571) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * fix tests by adding missing node module * formatting * refactor interfaces out to get around testing restrictions * more refactoring of importants to avoid loading errors * use latest slickgrid library (#2584) * Add OE node refresh API method (#2578) * Initial working commit for refreshing OE node via API * Add test and fix up code * Run tsfmt * Fix test * Merged PR 356: Fix getDefaultLogLocation to use 'Azure Data Studio' Update getDefaultLogLocation to use 'Azure Data Studio' to fix Azure Account creation on macOS. * Update SQL Ops to 0.33.6 * Fix crash when reverting in edit data with no changes (#2594) * edit data issue with column index handling (#2595) * fixed insights crash (#2596) * Changed the "Configure" link to "Learn How To Configure The Dashboard". (#2599) * Changed the "Configure" link to "Learn How To Configure the Dashboard". This inlcudes the command as well as the tile label #1227 * Capitalizing first character in each word * The "New Query" context menu is now only available from the server & db (#2598) #1890 * Merged PR 366: Revert to using 'sqlops' so settings are maintained during upgraded Revert to using 'sqlops' so settings are maintained during upgraded * Merged PR 371: Fix casing for AZURE DATA STUDIO in EULA Fix casing for AZURE DATA STUDIO in EULA * Merged PR 375: Create new appid Create new appid * Merged PR 376: Update settings path back to 'azuredatastudio' Update settings path back to 'azuredatastudio' * Fix/bump dependency versions (#2608) * Use version 2.0.9 of electron (#2606) * fixes scrolling in query plan (#2609) * Dashboard: Fixed all insight bugs (#2612) * fixed all insight bugs * removed unused imports * added comment * add view area options to pick up chart background fix (#2613) * Respect message settings (#2614) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * add configuration to state * address comments * Fix stating for scrolls (#2615) * nearly working * add accounting for the downsides to slickgrid * Update SQL Ops to 0.33.7 * Added text underline CSS for DB NULL values when editing / showing data (#2597) * Added text underline CSS for DB NULL values when editing / showing data #217 * Changed db nulls styling to italic * Bug/oetimeout Fix - When timeout happens while fetching node children, the node becomes unusable (#2616) This commit fixes issue when multiple OE nodes are expanded simultaneously. While the error was getting displayed the node was left in incorrect state which was leading to the node being unusable in future. This commit repairs this defect. * fixed actual show plan command (#2620) * Bump SQL Tools Service to 1.5.0-alpha.34 (#2621) * Feat/add dom component (#2622) * add dom component for model view * formatting * make css style hardcoded in dom.component * comment out the unused CSS * address comments * address comment * Hide tabs on reexecute (#2624) * add logic to hide tabs when a query rerun is executed * remove double entry in the map * Bump Azure Data Studio to 1.0.0 * Bump Azure Data Studio to 0.33.8 * Scroll query editor when clicking batch links (#2644) * Fix broken 'Clear Token Cache' command (#2643) * fixed right click context menu bug in jobs view (#2632) * fix css issue (#2650) * reload the chart types when we actually need it (#2651) * Bump Azure Data Studio to 1.0.0 * Fix chart error that caused query editor to close (#2652) * Bump Agent, Import and Profiler extension versions
2018-09-25 01:39:19 +03:00
> **Tip:** You can easily create an issue using `Report Issues` from Azure Data Studio Help menu.
Merge Azure Data Studio branding changes (#2689) * Bump Electron to 2.0.8 and SQL Ops to 0.33.3 (#2466) * Merged PR 328: Initial "Azure Data Studio" branding changes * Alanren/icon overwrite issue (#2484) * fix the error icon too large issue * formatting * add logic to hide and add grid panel based on size (#2481) * add grid styles (#2483) * Add check for potential failure in handling drag (#2499) * add check for potential failure in handling drag * move check to avoid ui glitches * Reorder Connection Name field in Connection Dialog (#2498) * change cursor in message panel to default (#2494) * add select all handler to grid (#2496) * Fix macOS titlebar branding * add animation when button is clicked and fix title in button (#2488) * add animation similar to toolbar in vscode and fix title in button * remove bur method in button * Disable the User Setup prompt (#2501) * fixes a rendering problem in splitview (#2512) * add listener to change action bar on maximize change (#2505) * fix the save and save all for untitled file (#2526) * add check for selection model in edit data (#2517) * add min size for row num column (#2518) * expand messages panel on error (#2519) * Selection in grid context (#2527) * update action context on selection change * correctly add ranges rather than a new range for every row * add required functions to typings * Fixes #2523 (#2528) The IdGenerator was recreated each time and had a high likelihood of conflicts. Invitably after adding dozens or hundreds of icons you'll start seeing the CSS class replaced and overridden. The solution is to do like elsewhere: have 1 const that is loaded on first import of the file and keeps a global track. Side note is that it'd be a good idea to cache CSS rules with the same iconPath so we don't create lots of additional rules unnecessarily. If we reuse the same icon a bunch we should cache them - #2524 is tracking this. * Fix grid gaps (#2531) * modifying grid gaps * reduce gaps and increase gap for action bar * fix grid action bar not updating (#2532) * Turn-off Git missing prompt (#2533) * Reduce message panel min size to 0 (#2534) * reduce message panel minimum size to 0; attempt to restore panel sizing on requery sizes; default grid panel size to 80% * formatting * Fix bug around debounced event not being flushed in time (#2536) * fix bug around debounced event not being flushed in time * add comment * Fix build break in Git extension (#2538) * Update SQL Ops to 0.33.4 * Fix sizing error when switching windows (#2544) * add work around for when we need to resize while we don't have a dimension to resize off of * formatting * change active cell during change to fix focus shift (#2545) * fix the account not found error when creating firewall rules (#2543) * Support isDirty flag for model view editors and begin plumb through of save support (#2547) * Add dirty and save support to model view * Add issue # for a TODO * add divcontainer in modelview (#2559) * add divcontainer in modelview * address comment * Bug/extension contribution (#2560) * revert 4ab5d84b9431b4a9cc23687fb2d9ecfc839f41c1 * fixed extensions * Merged PR 352: Switch settings folder back to .sqlops Switch settings folder back to .sqlops * fix the connection issue when opening new query after connection (#2561) * Update SQL Ops to 0.33.5 * Disabled connection name input when connecting to a server. (#2566) * Disabled connection name input when connecting to a server. #2557 * Fixed reset state of connection inputs * added context to chart buttons so they work (#2575) * accessibility setting based select database dropdown (#2579) * Maintain Query State (#2571) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * fix tests by adding missing node module * formatting * refactor interfaces out to get around testing restrictions * more refactoring of importants to avoid loading errors * use latest slickgrid library (#2584) * Add OE node refresh API method (#2578) * Initial working commit for refreshing OE node via API * Add test and fix up code * Run tsfmt * Fix test * Merged PR 356: Fix getDefaultLogLocation to use 'Azure Data Studio' Update getDefaultLogLocation to use 'Azure Data Studio' to fix Azure Account creation on macOS. * Update SQL Ops to 0.33.6 * Fix crash when reverting in edit data with no changes (#2594) * edit data issue with column index handling (#2595) * fixed insights crash (#2596) * Changed the "Configure" link to "Learn How To Configure The Dashboard". (#2599) * Changed the "Configure" link to "Learn How To Configure the Dashboard". This inlcudes the command as well as the tile label #1227 * Capitalizing first character in each word * The "New Query" context menu is now only available from the server & db (#2598) #1890 * Merged PR 366: Revert to using 'sqlops' so settings are maintained during upgraded Revert to using 'sqlops' so settings are maintained during upgraded * Merged PR 371: Fix casing for AZURE DATA STUDIO in EULA Fix casing for AZURE DATA STUDIO in EULA * Merged PR 375: Create new appid Create new appid * Merged PR 376: Update settings path back to 'azuredatastudio' Update settings path back to 'azuredatastudio' * Fix/bump dependency versions (#2608) * Use version 2.0.9 of electron (#2606) * fixes scrolling in query plan (#2609) * Dashboard: Fixed all insight bugs (#2612) * fixed all insight bugs * removed unused imports * added comment * add view area options to pick up chart background fix (#2613) * Respect message settings (#2614) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * add configuration to state * address comments * Fix stating for scrolls (#2615) * nearly working * add accounting for the downsides to slickgrid * Update SQL Ops to 0.33.7 * Added text underline CSS for DB NULL values when editing / showing data (#2597) * Added text underline CSS for DB NULL values when editing / showing data #217 * Changed db nulls styling to italic * Bug/oetimeout Fix - When timeout happens while fetching node children, the node becomes unusable (#2616) This commit fixes issue when multiple OE nodes are expanded simultaneously. While the error was getting displayed the node was left in incorrect state which was leading to the node being unusable in future. This commit repairs this defect. * fixed actual show plan command (#2620) * Bump SQL Tools Service to 1.5.0-alpha.34 (#2621) * Feat/add dom component (#2622) * add dom component for model view * formatting * make css style hardcoded in dom.component * comment out the unused CSS * address comments * address comment * Hide tabs on reexecute (#2624) * add logic to hide tabs when a query rerun is executed * remove double entry in the map * Bump Azure Data Studio to 1.0.0 * Bump Azure Data Studio to 0.33.8 * Scroll query editor when clicking batch links (#2644) * Fix broken 'Clear Token Cache' command (#2643) * fixed right click context menu bug in jobs view (#2632) * fix css issue (#2650) * reload the chart types when we actually need it (#2651) * Bump Azure Data Studio to 1.0.0 * Fix chart error that caused query editor to close (#2652) * Bump Agent, Import and Profiler extension versions
2018-09-25 01:39:19 +03:00
* Reproducible steps (1... 2... 3...) and what you expected versus what you actually saw.
* Images, animations, or a link to a video.
* A code snippet that demonstrates the issue or a link to a code repository we can easily pull down onto our machine to recreate the issue.
Merge Azure Data Studio branding changes (#2689) * Bump Electron to 2.0.8 and SQL Ops to 0.33.3 (#2466) * Merged PR 328: Initial "Azure Data Studio" branding changes * Alanren/icon overwrite issue (#2484) * fix the error icon too large issue * formatting * add logic to hide and add grid panel based on size (#2481) * add grid styles (#2483) * Add check for potential failure in handling drag (#2499) * add check for potential failure in handling drag * move check to avoid ui glitches * Reorder Connection Name field in Connection Dialog (#2498) * change cursor in message panel to default (#2494) * add select all handler to grid (#2496) * Fix macOS titlebar branding * add animation when button is clicked and fix title in button (#2488) * add animation similar to toolbar in vscode and fix title in button * remove bur method in button * Disable the User Setup prompt (#2501) * fixes a rendering problem in splitview (#2512) * add listener to change action bar on maximize change (#2505) * fix the save and save all for untitled file (#2526) * add check for selection model in edit data (#2517) * add min size for row num column (#2518) * expand messages panel on error (#2519) * Selection in grid context (#2527) * update action context on selection change * correctly add ranges rather than a new range for every row * add required functions to typings * Fixes #2523 (#2528) The IdGenerator was recreated each time and had a high likelihood of conflicts. Invitably after adding dozens or hundreds of icons you'll start seeing the CSS class replaced and overridden. The solution is to do like elsewhere: have 1 const that is loaded on first import of the file and keeps a global track. Side note is that it'd be a good idea to cache CSS rules with the same iconPath so we don't create lots of additional rules unnecessarily. If we reuse the same icon a bunch we should cache them - #2524 is tracking this. * Fix grid gaps (#2531) * modifying grid gaps * reduce gaps and increase gap for action bar * fix grid action bar not updating (#2532) * Turn-off Git missing prompt (#2533) * Reduce message panel min size to 0 (#2534) * reduce message panel minimum size to 0; attempt to restore panel sizing on requery sizes; default grid panel size to 80% * formatting * Fix bug around debounced event not being flushed in time (#2536) * fix bug around debounced event not being flushed in time * add comment * Fix build break in Git extension (#2538) * Update SQL Ops to 0.33.4 * Fix sizing error when switching windows (#2544) * add work around for when we need to resize while we don't have a dimension to resize off of * formatting * change active cell during change to fix focus shift (#2545) * fix the account not found error when creating firewall rules (#2543) * Support isDirty flag for model view editors and begin plumb through of save support (#2547) * Add dirty and save support to model view * Add issue # for a TODO * add divcontainer in modelview (#2559) * add divcontainer in modelview * address comment * Bug/extension contribution (#2560) * revert 4ab5d84b9431b4a9cc23687fb2d9ecfc839f41c1 * fixed extensions * Merged PR 352: Switch settings folder back to .sqlops Switch settings folder back to .sqlops * fix the connection issue when opening new query after connection (#2561) * Update SQL Ops to 0.33.5 * Disabled connection name input when connecting to a server. (#2566) * Disabled connection name input when connecting to a server. #2557 * Fixed reset state of connection inputs * added context to chart buttons so they work (#2575) * accessibility setting based select database dropdown (#2579) * Maintain Query State (#2571) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * fix tests by adding missing node module * formatting * refactor interfaces out to get around testing restrictions * more refactoring of importants to avoid loading errors * use latest slickgrid library (#2584) * Add OE node refresh API method (#2578) * Initial working commit for refreshing OE node via API * Add test and fix up code * Run tsfmt * Fix test * Merged PR 356: Fix getDefaultLogLocation to use 'Azure Data Studio' Update getDefaultLogLocation to use 'Azure Data Studio' to fix Azure Account creation on macOS. * Update SQL Ops to 0.33.6 * Fix crash when reverting in edit data with no changes (#2594) * edit data issue with column index handling (#2595) * fixed insights crash (#2596) * Changed the "Configure" link to "Learn How To Configure The Dashboard". (#2599) * Changed the "Configure" link to "Learn How To Configure the Dashboard". This inlcudes the command as well as the tile label #1227 * Capitalizing first character in each word * The "New Query" context menu is now only available from the server & db (#2598) #1890 * Merged PR 366: Revert to using 'sqlops' so settings are maintained during upgraded Revert to using 'sqlops' so settings are maintained during upgraded * Merged PR 371: Fix casing for AZURE DATA STUDIO in EULA Fix casing for AZURE DATA STUDIO in EULA * Merged PR 375: Create new appid Create new appid * Merged PR 376: Update settings path back to 'azuredatastudio' Update settings path back to 'azuredatastudio' * Fix/bump dependency versions (#2608) * Use version 2.0.9 of electron (#2606) * fixes scrolling in query plan (#2609) * Dashboard: Fixed all insight bugs (#2612) * fixed all insight bugs * removed unused imports * added comment * add view area options to pick up chart background fix (#2613) * Respect message settings (#2614) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * add configuration to state * address comments * Fix stating for scrolls (#2615) * nearly working * add accounting for the downsides to slickgrid * Update SQL Ops to 0.33.7 * Added text underline CSS for DB NULL values when editing / showing data (#2597) * Added text underline CSS for DB NULL values when editing / showing data #217 * Changed db nulls styling to italic * Bug/oetimeout Fix - When timeout happens while fetching node children, the node becomes unusable (#2616) This commit fixes issue when multiple OE nodes are expanded simultaneously. While the error was getting displayed the node was left in incorrect state which was leading to the node being unusable in future. This commit repairs this defect. * fixed actual show plan command (#2620) * Bump SQL Tools Service to 1.5.0-alpha.34 (#2621) * Feat/add dom component (#2622) * add dom component for model view * formatting * make css style hardcoded in dom.component * comment out the unused CSS * address comments * address comment * Hide tabs on reexecute (#2624) * add logic to hide tabs when a query rerun is executed * remove double entry in the map * Bump Azure Data Studio to 1.0.0 * Bump Azure Data Studio to 0.33.8 * Scroll query editor when clicking batch links (#2644) * Fix broken 'Clear Token Cache' command (#2643) * fixed right click context menu bug in jobs view (#2632) * fix css issue (#2650) * reload the chart types when we actually need it (#2651) * Bump Azure Data Studio to 1.0.0 * Fix chart error that caused query editor to close (#2652) * Bump Agent, Import and Profiler extension versions
2018-09-25 01:39:19 +03:00
> **Note:** Because we need to copy and paste the code snippet, including a code snippet as a media file (i.e. .gif) is not sufficient.
* Errors in the Dev Tools Console (Help | Toggle Developer Tools)
Please remember to do the following:
Merge Azure Data Studio branding changes (#2689) * Bump Electron to 2.0.8 and SQL Ops to 0.33.3 (#2466) * Merged PR 328: Initial "Azure Data Studio" branding changes * Alanren/icon overwrite issue (#2484) * fix the error icon too large issue * formatting * add logic to hide and add grid panel based on size (#2481) * add grid styles (#2483) * Add check for potential failure in handling drag (#2499) * add check for potential failure in handling drag * move check to avoid ui glitches * Reorder Connection Name field in Connection Dialog (#2498) * change cursor in message panel to default (#2494) * add select all handler to grid (#2496) * Fix macOS titlebar branding * add animation when button is clicked and fix title in button (#2488) * add animation similar to toolbar in vscode and fix title in button * remove bur method in button * Disable the User Setup prompt (#2501) * fixes a rendering problem in splitview (#2512) * add listener to change action bar on maximize change (#2505) * fix the save and save all for untitled file (#2526) * add check for selection model in edit data (#2517) * add min size for row num column (#2518) * expand messages panel on error (#2519) * Selection in grid context (#2527) * update action context on selection change * correctly add ranges rather than a new range for every row * add required functions to typings * Fixes #2523 (#2528) The IdGenerator was recreated each time and had a high likelihood of conflicts. Invitably after adding dozens or hundreds of icons you'll start seeing the CSS class replaced and overridden. The solution is to do like elsewhere: have 1 const that is loaded on first import of the file and keeps a global track. Side note is that it'd be a good idea to cache CSS rules with the same iconPath so we don't create lots of additional rules unnecessarily. If we reuse the same icon a bunch we should cache them - #2524 is tracking this. * Fix grid gaps (#2531) * modifying grid gaps * reduce gaps and increase gap for action bar * fix grid action bar not updating (#2532) * Turn-off Git missing prompt (#2533) * Reduce message panel min size to 0 (#2534) * reduce message panel minimum size to 0; attempt to restore panel sizing on requery sizes; default grid panel size to 80% * formatting * Fix bug around debounced event not being flushed in time (#2536) * fix bug around debounced event not being flushed in time * add comment * Fix build break in Git extension (#2538) * Update SQL Ops to 0.33.4 * Fix sizing error when switching windows (#2544) * add work around for when we need to resize while we don't have a dimension to resize off of * formatting * change active cell during change to fix focus shift (#2545) * fix the account not found error when creating firewall rules (#2543) * Support isDirty flag for model view editors and begin plumb through of save support (#2547) * Add dirty and save support to model view * Add issue # for a TODO * add divcontainer in modelview (#2559) * add divcontainer in modelview * address comment * Bug/extension contribution (#2560) * revert 4ab5d84b9431b4a9cc23687fb2d9ecfc839f41c1 * fixed extensions * Merged PR 352: Switch settings folder back to .sqlops Switch settings folder back to .sqlops * fix the connection issue when opening new query after connection (#2561) * Update SQL Ops to 0.33.5 * Disabled connection name input when connecting to a server. (#2566) * Disabled connection name input when connecting to a server. #2557 * Fixed reset state of connection inputs * added context to chart buttons so they work (#2575) * accessibility setting based select database dropdown (#2579) * Maintain Query State (#2571) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * fix tests by adding missing node module * formatting * refactor interfaces out to get around testing restrictions * more refactoring of importants to avoid loading errors * use latest slickgrid library (#2584) * Add OE node refresh API method (#2578) * Initial working commit for refreshing OE node via API * Add test and fix up code * Run tsfmt * Fix test * Merged PR 356: Fix getDefaultLogLocation to use 'Azure Data Studio' Update getDefaultLogLocation to use 'Azure Data Studio' to fix Azure Account creation on macOS. * Update SQL Ops to 0.33.6 * Fix crash when reverting in edit data with no changes (#2594) * edit data issue with column index handling (#2595) * fixed insights crash (#2596) * Changed the "Configure" link to "Learn How To Configure The Dashboard". (#2599) * Changed the "Configure" link to "Learn How To Configure the Dashboard". This inlcudes the command as well as the tile label #1227 * Capitalizing first character in each word * The "New Query" context menu is now only available from the server & db (#2598) #1890 * Merged PR 366: Revert to using 'sqlops' so settings are maintained during upgraded Revert to using 'sqlops' so settings are maintained during upgraded * Merged PR 371: Fix casing for AZURE DATA STUDIO in EULA Fix casing for AZURE DATA STUDIO in EULA * Merged PR 375: Create new appid Create new appid * Merged PR 376: Update settings path back to 'azuredatastudio' Update settings path back to 'azuredatastudio' * Fix/bump dependency versions (#2608) * Use version 2.0.9 of electron (#2606) * fixes scrolling in query plan (#2609) * Dashboard: Fixed all insight bugs (#2612) * fixed all insight bugs * removed unused imports * added comment * add view area options to pick up chart background fix (#2613) * Respect message settings (#2614) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * add configuration to state * address comments * Fix stating for scrolls (#2615) * nearly working * add accounting for the downsides to slickgrid * Update SQL Ops to 0.33.7 * Added text underline CSS for DB NULL values when editing / showing data (#2597) * Added text underline CSS for DB NULL values when editing / showing data #217 * Changed db nulls styling to italic * Bug/oetimeout Fix - When timeout happens while fetching node children, the node becomes unusable (#2616) This commit fixes issue when multiple OE nodes are expanded simultaneously. While the error was getting displayed the node was left in incorrect state which was leading to the node being unusable in future. This commit repairs this defect. * fixed actual show plan command (#2620) * Bump SQL Tools Service to 1.5.0-alpha.34 (#2621) * Feat/add dom component (#2622) * add dom component for model view * formatting * make css style hardcoded in dom.component * comment out the unused CSS * address comments * address comment * Hide tabs on reexecute (#2624) * add logic to hide tabs when a query rerun is executed * remove double entry in the map * Bump Azure Data Studio to 1.0.0 * Bump Azure Data Studio to 0.33.8 * Scroll query editor when clicking batch links (#2644) * Fix broken 'Clear Token Cache' command (#2643) * fixed right click context menu bug in jobs view (#2632) * fix css issue (#2650) * reload the chart types when we actually need it (#2651) * Bump Azure Data Studio to 1.0.0 * Fix chart error that caused query editor to close (#2652) * Bump Agent, Import and Profiler extension versions
2018-09-25 01:39:19 +03:00
* Search the issue repository to see if there exists a duplicate.
* Simplify your scripts around the issue so we can better isolate the problem.
Don't feel bad if we can't reproduce the issue and ask for more information!
## Contributing Fixes
If you are interested in fixing issues and contributing directly to the code base,
Merge Azure Data Studio branding changes (#2689) * Bump Electron to 2.0.8 and SQL Ops to 0.33.3 (#2466) * Merged PR 328: Initial "Azure Data Studio" branding changes * Alanren/icon overwrite issue (#2484) * fix the error icon too large issue * formatting * add logic to hide and add grid panel based on size (#2481) * add grid styles (#2483) * Add check for potential failure in handling drag (#2499) * add check for potential failure in handling drag * move check to avoid ui glitches * Reorder Connection Name field in Connection Dialog (#2498) * change cursor in message panel to default (#2494) * add select all handler to grid (#2496) * Fix macOS titlebar branding * add animation when button is clicked and fix title in button (#2488) * add animation similar to toolbar in vscode and fix title in button * remove bur method in button * Disable the User Setup prompt (#2501) * fixes a rendering problem in splitview (#2512) * add listener to change action bar on maximize change (#2505) * fix the save and save all for untitled file (#2526) * add check for selection model in edit data (#2517) * add min size for row num column (#2518) * expand messages panel on error (#2519) * Selection in grid context (#2527) * update action context on selection change * correctly add ranges rather than a new range for every row * add required functions to typings * Fixes #2523 (#2528) The IdGenerator was recreated each time and had a high likelihood of conflicts. Invitably after adding dozens or hundreds of icons you'll start seeing the CSS class replaced and overridden. The solution is to do like elsewhere: have 1 const that is loaded on first import of the file and keeps a global track. Side note is that it'd be a good idea to cache CSS rules with the same iconPath so we don't create lots of additional rules unnecessarily. If we reuse the same icon a bunch we should cache them - #2524 is tracking this. * Fix grid gaps (#2531) * modifying grid gaps * reduce gaps and increase gap for action bar * fix grid action bar not updating (#2532) * Turn-off Git missing prompt (#2533) * Reduce message panel min size to 0 (#2534) * reduce message panel minimum size to 0; attempt to restore panel sizing on requery sizes; default grid panel size to 80% * formatting * Fix bug around debounced event not being flushed in time (#2536) * fix bug around debounced event not being flushed in time * add comment * Fix build break in Git extension (#2538) * Update SQL Ops to 0.33.4 * Fix sizing error when switching windows (#2544) * add work around for when we need to resize while we don't have a dimension to resize off of * formatting * change active cell during change to fix focus shift (#2545) * fix the account not found error when creating firewall rules (#2543) * Support isDirty flag for model view editors and begin plumb through of save support (#2547) * Add dirty and save support to model view * Add issue # for a TODO * add divcontainer in modelview (#2559) * add divcontainer in modelview * address comment * Bug/extension contribution (#2560) * revert 4ab5d84b9431b4a9cc23687fb2d9ecfc839f41c1 * fixed extensions * Merged PR 352: Switch settings folder back to .sqlops Switch settings folder back to .sqlops * fix the connection issue when opening new query after connection (#2561) * Update SQL Ops to 0.33.5 * Disabled connection name input when connecting to a server. (#2566) * Disabled connection name input when connecting to a server. #2557 * Fixed reset state of connection inputs * added context to chart buttons so they work (#2575) * accessibility setting based select database dropdown (#2579) * Maintain Query State (#2571) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * fix tests by adding missing node module * formatting * refactor interfaces out to get around testing restrictions * more refactoring of importants to avoid loading errors * use latest slickgrid library (#2584) * Add OE node refresh API method (#2578) * Initial working commit for refreshing OE node via API * Add test and fix up code * Run tsfmt * Fix test * Merged PR 356: Fix getDefaultLogLocation to use 'Azure Data Studio' Update getDefaultLogLocation to use 'Azure Data Studio' to fix Azure Account creation on macOS. * Update SQL Ops to 0.33.6 * Fix crash when reverting in edit data with no changes (#2594) * edit data issue with column index handling (#2595) * fixed insights crash (#2596) * Changed the "Configure" link to "Learn How To Configure The Dashboard". (#2599) * Changed the "Configure" link to "Learn How To Configure the Dashboard". This inlcudes the command as well as the tile label #1227 * Capitalizing first character in each word * The "New Query" context menu is now only available from the server & db (#2598) #1890 * Merged PR 366: Revert to using 'sqlops' so settings are maintained during upgraded Revert to using 'sqlops' so settings are maintained during upgraded * Merged PR 371: Fix casing for AZURE DATA STUDIO in EULA Fix casing for AZURE DATA STUDIO in EULA * Merged PR 375: Create new appid Create new appid * Merged PR 376: Update settings path back to 'azuredatastudio' Update settings path back to 'azuredatastudio' * Fix/bump dependency versions (#2608) * Use version 2.0.9 of electron (#2606) * fixes scrolling in query plan (#2609) * Dashboard: Fixed all insight bugs (#2612) * fixed all insight bugs * removed unused imports * added comment * add view area options to pick up chart background fix (#2613) * Respect message settings (#2614) * add results view stating * working through the bugs * handle various resizing bugs * gnale resizing better * add configuration to state * address comments * Fix stating for scrolls (#2615) * nearly working * add accounting for the downsides to slickgrid * Update SQL Ops to 0.33.7 * Added text underline CSS for DB NULL values when editing / showing data (#2597) * Added text underline CSS for DB NULL values when editing / showing data #217 * Changed db nulls styling to italic * Bug/oetimeout Fix - When timeout happens while fetching node children, the node becomes unusable (#2616) This commit fixes issue when multiple OE nodes are expanded simultaneously. While the error was getting displayed the node was left in incorrect state which was leading to the node being unusable in future. This commit repairs this defect. * fixed actual show plan command (#2620) * Bump SQL Tools Service to 1.5.0-alpha.34 (#2621) * Feat/add dom component (#2622) * add dom component for model view * formatting * make css style hardcoded in dom.component * comment out the unused CSS * address comments * address comment * Hide tabs on reexecute (#2624) * add logic to hide tabs when a query rerun is executed * remove double entry in the map * Bump Azure Data Studio to 1.0.0 * Bump Azure Data Studio to 0.33.8 * Scroll query editor when clicking batch links (#2644) * Fix broken 'Clear Token Cache' command (#2643) * fixed right click context menu bug in jobs view (#2632) * fix css issue (#2650) * reload the chart types when we actually need it (#2651) * Bump Azure Data Studio to 1.0.0 * Fix chart error that caused query editor to close (#2652) * Bump Agent, Import and Profiler extension versions
2018-09-25 01:39:19 +03:00
please see the document [How to Contribute](https://github.com/Microsoft/azuredatastudio/wiki/How-to-Contribute).