From c6a5722805d84e74bb6b78e734121606364f42f3 Mon Sep 17 00:00:00 2001 From: Yao Yao Date: Thu, 21 Sep 2017 20:40:15 +0800 Subject: [PATCH] a11y fix --- js/dropdown-item.jade | 2 +- js/dropdown-radio-group.jade | 9 ++++----- js/menu-button-mixin.jade | 2 +- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/js/dropdown-item.jade b/js/dropdown-item.jade index 97af29b..46c2bb4 100644 --- a/js/dropdown-item.jade +++ b/js/dropdown-item.jade @@ -1,5 +1,5 @@ li.dropdown-item(role='presentation', class=classes, id=id) - a(role='menuitem' href='javascript:void(0);') + a(role='menuitem', href='javascript:void(0);') if iconRight span.icon-right(class=iconRight) if iconLeft diff --git a/js/dropdown-radio-group.jade b/js/dropdown-radio-group.jade index 40e54d8..b88f9ef 100644 --- a/js/dropdown-radio-group.jade +++ b/js/dropdown-radio-group.jade @@ -3,16 +3,15 @@ li.dropdown-radio-group(class=classes, id=id) li.dropdown-header(role='presentation')=title each item in items li.dropdown-radio-item(role='presentation', data-value=item.value) - span(role='menuitem') + span if item.value === value span.selection.selection-selected(class=checkIcon) else span.selection(class=checkIcon) - span.text=item.text + span.text(role='menuitem' tabindex='0')=item.text if !item.locked span.remove if removeText - a.pull-right.remove-text=removeText + a.pull-right.remove-text(role='button' tabindex='0', href='javascript:void(0);')=removeText if removeIcon - span.pull-right.remove-icon(class=removeIcon) - + span.pull-right.remove-icon(role='button' tabindex='0', class=removeIcon) diff --git a/js/menu-button-mixin.jade b/js/menu-button-mixin.jade index 171e978..1295c93 100644 --- a/js/menu-button-mixin.jade +++ b/js/menu-button-mixin.jade @@ -1,5 +1,5 @@ mixin menuButtonMixin(options) - a(role='menuitem', class=options.classes, id=options.id) + a(role='menuitem', class=options.classes, id=options.id, href='javascript:void(0);') if options.iconLeft span.icon-left(class=options.iconLeft) span.text=options.text