* Update test projects to .NET8
* Update test bots to .NET8
* Update CI yamls to .NET8
* Apply feedback
* keep support for netcoreapp3.1
* fix pipeline task name
* separate target framework conditionals
* add missing task to pipeline
---------
Co-authored-by: JhontSouth <jhonatan.sandoval@southworks.com>
* Update test projects to target .net6
* Update test bots to target .net6
* Update CI pipelines to target .net6
* Remove old vmImage from comments & fix Webex test
* Remove multitarget from FunctionalTests project
* Change target framework in FunctionalTests project
* Apply feedback for NET6 exceptions and tests
* Fix Serialization error in LogActivityAsync
* Add pipeline for secondary FB test bot.
* Switch to using primary ARM templates.
* Fix test to accept "Echo Secondary"
* Improve test message
* Test message tweak
* Add Sleep 1 minute to test secondary
* Tweak display names
* Cleanup
* Cleanup 2
* Authentication: Add opt-in support for MSAL to acquire tokens
* MsalAppCredentials: move comment
* MSAL: add logger and update visibility
* Authentication bot: add back removed line.
* msal tests: reuse app id as token audience, given that we don't need 2
* Msal app credentials: fix outdated / unclear comment
* Adds check to TranscriptLoggerMiddleware doesn't log contine conversation event activities.
Changes include:
- Added check in TranscriptLoggerMiddleware to filter incoming ContinueConversation events.
- Introduced EventActivityNames class with constant strings for ContinueConversation so we don't have those strings hardcoded.
- Added also CreateConversation to the EventActivityNames helper (not related to this issue but saw it and decided to add it since it is better to have constants).
- Refactored ConversationReferenceEx to use the new constant (and use more straightforward code to create the event).
- Added tests for new logic in TranscriptLoggerMiddleware.
- Updated Skills testing projects to use the new constant
* Renamed EventActivityNames to ActivityEventNames
* Updated a couple of files that I missed after the rename.
* Change Assert.Inconclusive() to Assert.Fail()
* Add #if !AUTOMATEDBUILD
* Add var TESTAPPID
* Move env vars to dotnet test task
* Change env var name to TestPassword
* Add TestAppId: $(LinuxTestBotAppId)
* Add AUTOMATEDBUILD precompiler directive, change Assert.Inconclusive() to Assert.Fail
* Fix DefineConstants in Microsoft.Bot.Builder.FunctionalTests.csproj
* Fix environment vars for dotnet test
* Set twilio env vars
* Fix linux yaml
* Fix dependsOn in new-rg templates
* Facebook completed
* Webex test .yml partly done.
* Webex done.
* Done with tests windows
* Fix webex typo
* Remove var ReleasePackageVersion from builds
* Change Assert.Inconclusive to Assert.Fail in WebexClientTest.cs
* Add WebexTestBotWebexRoomId and others to dotnet test env vars
* Revert WebexClientTest.cs
* Remove env var WebexTestBotWebexRoomId
* suppressing warnings
* reverting async
* Revert "reverting async"
This reverts commit 7675775d69.
* suppressing await warning
* Removed explicit ref to json 10.x from AppInsightsWebApi to avoid version warnings.
Updated Twilio.TestBot to target only netcoreapp3.1, removed reference to Microsoft.AspNetCore.App and avoided warning
Removed unused variable from OAuthPromptTests.cs
Updated NamedPipesTest to capture the task returned by ConnectAsync.
Removed Razore references from TestProtocol to avoid warning.
Added TreatWarningsAsErrors to the Directory.Build.props for tests so we keep things clean going forward
* Consolidated some nuget packages to see if that addresses some msbuild warnings.
* Added explicit ref to Config on test project to see if that fixes warning
* Added explicit packages to see if we can avoid warnings
* Added explicit reference to solve build warnings.
Consolidated assembly versions
* Added explicit assembly reference to solve build warning
* Updated httpheaders version in streaming and removed explicit refs from other projects.
* Changed headers to 2.1.14
* Added explicit ref for headers to Adaptive.Profiling
* Added explicit ref
* More explicit refs for Http.Headers
* One more explicit ref to http headers
* Added explicit version for Http.Headers to all web projects
* Removed all explicit references to http.headers
* Removed Http.Headers from functional tests
* Set the build log to detailed to see if I can narrow down the issue.
* Trying lout explicit ref for Microsoft.Net.Http.Headers in ApsNet.Core
* Cleanup: Removed detailed parameter from yaml
Cleamup: reverted steam to use the lowest version of httpheaders and also lowered the version in Integration.AspNet.Core
Added explicit versions for Microsoft.Net.Http.Headers to FunctionalTests
* Lowered headers version to match streaming
* Added 3.1 targets for Slack and Webex adapters.
Added explicit Microsoft.AspNetCore.App to Functional tests
* Cleanup: reverted some changes that don't seem to be needed
* Changed TestFrameworks to TestFramework for the project that only target one framework.
Co-authored-by: Gabo Gilabert <ggilaber@microsoft.com>
* update build yaml
- remove unnecessary install of net core specifics
- add maximunCpuCount: true variable to build resources in parallel
* update yaml to split tests for netcore 21 and 31
* update ci test steps to target netcore 21 or 31
* change artifact name to use
* update target framework to be set with variable for tests
* fix properties indentation
* fix indentation properties for schema csproj
* add missing space in comment
Co-authored-by: Santiago Grangetto <santiagograngetto@gmail.com>
* Fixes issue with InvokeResponse<T> hidding the underlying value for Body.
Makes methods ins SkillHttpClient virtual so they can be mocked in tests.
Updated BotFrameworkClient to use a deepclone of the activity rather than try/catch/finally to simply code and make sure we don't risk altering the original activity while the async request is being executed.
Improved test coverage for BotFrameworkClient and SkillHttpClient.
* Updated Skill test projects to match samples.
* Deleted composer testing project
* Added FxCop to Microsoft.BotBuilder and addressed errors.
Enabled the SX1309 (FieldNamesShouldBeginWithUnderscores) stylecop rule and addressed the violations on BotBuilder but excluded it from the other projects for now to avoid collisions.
Enabled CA1309 (Use ordinal StringComparison) to the main ruleset and addressed violations.
Added ($NoWarn) to root dir props to make sure tests take this value.
* Enabled AsyncUsage analyzer and fixed violations wherever ir was possible.
* Refactore Task.Run usages to await/async equivalents.
* Updated Adapters folder to use FxCop 3.0
* Refactored ShowTypingMiddleware to avoid using Task.Run so we don't create unnecessary threads.
* Updated constructor to use _httpClient field instead of the expression.
* add az group create
* Switch to template-with-preexisting-rg.json
* Fix template args for az deployment sub create
* Fix arg appServicePlanLocation
* Try "call az deployment group create"
* Fix call az deployment group create #4
* Fix facebook pipeline
* Fix facebook call az deployment group create
* Fix template reference
* Fix webex pipeline
* Drop --location "westus"
* Fix windows func test build
* Fix botgroup
* Remove slack refs from windows template
* Add message to "Set up directline keys"
* Further WIP
* - Removed unused files
- Updated tests
- Removed remaining dependencies on client model classes
* Remove redundant error supression
* Added missing classes as per PR #3760
* Fix up namespaces for model classes
* Fix up tests
* Fixed warnings on build
* Removed redundant XML comment
* Configured TreatWarningsAsErrors on all projects in the libraries folder except for Microsoft.Bot.Builder.Dialogs.Adaptive.Testing (that needs to be addressed separatelly).
Created Directory.Build.props for FunctionalTests and Tests to manage excludes for the projects in those folders.
Added NoWarn properties for documentation on each project (these will be addressed by another issue).
Fixed long hanging fruit warnings.
Added Roslyn FxCop analyzer to Microsoft.Bot.Schema and fixed violation or excluded them using #pragma.
* Fixed binary compat issues
* Fixed more binary compat issues
* [Expression] Add formatNumber, formatEpoch and formatTicks as prebuilt functions (#3876) (#3883)
* add formatNumber prebuilt function
* change to string output to keep tailing zeors
* Add formatEpoch and formatTicks.
Removed ticks from formatDate and fixed some bugs.
Fixed a bug in JSON conversion where 64 bit/double values were getting truncated.
* Add tests that were dropped.
* Add locale to formatNumber.
* Add 1000's seperators.
* fix a test case
* change a test case
Co-authored-by: Chris McConnell <chrimc@microsoft.com>
Co-authored-by: Chris McConnell <chrimc@microsoft.com>
* override OnComputeId in AdaptiveSkillDialog (#3882)
* override OnComputeId in AdaptiveSkillDialog
* refactor AdaptiveSkillDialog.OnComputeId()
* remove superfluous parenthesis around activity
* apply @stevenic's PR feedback
* Rename $kind Microsoft.SkillDialog => Microsoft.BeginSkillDialog
Rename class AdaptiveSkillDialog => BeginSkillDialog
Move files into actions folders
replace all $kind => new $kind
* Style: Async method nomenclature, missing ConfigureAwait and CancellationTokens
* Rename $kind Microsoft.BeginSkillDialog => Microsoft.BeginSkill
Rename class BeginSkillDialog to BeginSkill
* update title for begin skill
* Cancellation, nomenclature and style improvements
* Cancellation tokens and propagation
* merge CheckForVersionChangeAsync()
* Missing cancellation tokens
Co-authored-by: Shuai Wang <shuwan@microsoft.com>
Co-authored-by: Chris McConnell <chrimc@microsoft.com>
Co-authored-by: Tom Laird-McConnell <tomlm@microsoft.com>
Co-authored-by: Carlos Castro <ccastro@microsoft.com>
Co-authored-by: Carlos Castro <carlosscastro@users.noreply.github.com>
* Replace UseState with UseBotState() which is simpler in implementation and usage pattern.
Fix all unit tests that were using it.
* switch to params signature
* update
* Updated adatpive skills test project to use the new UseBotState method and remvoed dependency on UserState from the test projects
* changed method signatures to be backward compatible.
Added obselete to UseState() helper.
* Removed explicit ref to TimexExpression
Co-authored-by: Gabo Gilabert <ggilaber@microsoft.com>
BF code updates
* Refactored DialogExtensions and created tests for it
* Updated SkillHandler to store SkillConversationReference in state.
* Refactored and cleaned up unit tests.
* Fixed class comments.
Test code updates:
* Updated DialogToDialog to align with samples and fixed issue in DialogSkillBot calling EchoSkill
* Updated DialogSkillBot to be a skill consumer and consume DialogEchoSkillBot and test Parent -> Skill 1 -> Skill 2.
* Updated DialogManager to handle skill requests (in adition to parent bot requests).
Added unit tests.
Added end to end Parent->Skill sample with DialogManager for testing.
* Fixed typos, unused namespaces and removed redundant default.
* Added check for active dialog in reprompt and unit test for it.
* Added RepromptDialogAsync and ResumeDialogAsync to SkillDialog.
Moved skill request handling logic into Dialog.RunAsync
Updated sample DialogToDialog sample to handle interruptions
* Renamed SkillDialogArgs to BeginSkillDialogOptions for parity.
Updated SkillConversationIdFactory in DialogRootBot to use the new methods.
Updated BotFrameworkHttpClient to restore RelatesTo after is done with it.
Namepsaced OAuthScopeKey key in BotAdapter to avoid collisions.
Updated SkillDialog to use new methods from ConversationIdFactory.
* Added support for using DeliveryMode in SkillDialog.
Updated MainDialog to set the property if present.
* Fixed broken tests
* Add originatingAudience to SkillHttpClient.PostActivityAsync
* Deprecated old methods in SkillCOnversationIdFactoryBase and added new ones.
Updated related classes to use the new methods.
* clone ConversationReference for FunctionalTest's SkillConversationIdFactory
* change skill conversation.id in SimpleRootBot example
* Skill Unit test updates
Co-authored-by: Gabo Gilabert <gabog@users.noreply.github.com>
Moved ConversationState from SkillDialog constructor to SkillDialogOptions.
Updated DialogTestClient to expose DialogContext so we can test dialog cancellation and added tests for it.
Ipdate DialogRootBot sample to use new options.
* Updates to SkillDialog based on VA feedback.
* Updated samples to work with new changes, cleaned up namespace and added Error Handling code based on skill samples.
* Updated MainDialog to show a remote skill cancelation from the a parent.
* Remove FnTest project from the Skills solution that references Adapter projects that are not in scope
* Update functional tests project to add target framework 3.1
* Nudge build
* Attempting fix for NuGet restore error.
* Re-added platform condition to see if tests pass
* Moved trace constant into main property group in project file
* RE-moving the Trace constant to a conditional property group. Previous error is occuring on other branches.
* First pass at SkillDialog
Created preview Skills project and placeholder for unit test.
Added DialotToDialog and SimpleSkillBot for local testing.
Added abstract BotFrameworkClient base class to decouple http dependency.
Added Skills Solution.
* Refactored DialogToDialog to use EchoSkillBot and DialogSkillBot.
Deleted simplebot to bot for now.
Updated code to make it work.
* Forced adding launchSettings.json to code to make it easier to configure locally during dev.
* Added support for InvokeActivities in SkillDialog.
Updated welcome card.
* Added guard in SkillDialog to only process Message and event activities.
Removed invoke handling funcitonality from SkillDialog and sample call.
* Removed Invoke Code from skilldialog
Added new projects to the Mcirosoft.Bot.Builder.sln file
* Revreated Skill.sln after merge and remove 31 suffix from DialogSkill Test projects.
* Removed icon.png ref from csproj file
* Readded projects lost after merge
Removed Expressions.Properties from skills solution.
* Touched to force another build
* Updated SkillDialog to take activities instead of creating them and updated MainDialog to create the activities.
Updated SkillDialogArgs to take the skill and the activity to forward.
Addressed other comments from PR
Joel Mut
Jhonatan Sandoval Velasco
tracyboehrer
Cecilia Avila
BruceHaley
Carlos Castro
Ashley Finafrock
Gabo Gilabert
BruceHaley
Monica Rivera
Josh
Denise Scollo
Gary Pretty
Phil Haack
Steven Gum
Tom Laird-McConnell
Eric Dahlvang
Gabo Gilabert
bothosting.runtime@bf.ai