Граф коммитов

9 Коммитов

Автор SHA1 Сообщение Дата
Cecilia Avila 731e157b9a
Set MaxDepth prop in Json Serialize/Deserialize (#6398) 2022-07-05 13:01:42 -05:00
Monica Rivera fd8e495cfe Add missing documentation 2. 2020-07-24 17:11:18 -07:00
Gabo Gilabert 6720f2cec6
Added FxCop to Microsoft.BotBuilder and addressed errors. (#4141)
* Added FxCop to Microsoft.BotBuilder and addressed errors.
Enabled the SX1309 (FieldNamesShouldBeginWithUnderscores) stylecop rule and addressed the violations on BotBuilder but excluded it from the other projects for now to avoid collisions.
Enabled CA1309 (Use ordinal StringComparison) to the main ruleset and addressed violations.
Added ($NoWarn) to root dir props to make sure tests take this value.

* Enabled AsyncUsage analyzer and fixed violations wherever ir was possible.

* Refactore Task.Run usages to await/async equivalents.

* Updated Adapters folder to use FxCop 3.0

* Refactored ShowTypingMiddleware to avoid using Task.Run so we don't create unnecessary threads.

* Updated constructor to use _httpClient field instead of the expression.
2020-06-24 20:02:33 -07:00
Jonathan Fingold c2a4a06800
Fix typos [mostly] in the bot.builder namespace (#3349) 2020-02-07 12:48:42 -08:00
Tom Laird-McConnell c949e42abd [DCR] Normalize all expression and add '=' to force expression. (#3253)
* snapshot of all expression property work and unit tests

* choiceset works all unit tests pass

* fixup some more tests

* restore default null states to inputdialog

* cleanup defaults

* more cleanup

* fix expression<list<string>>

* fix changed declarative unit tests with  to use "="

* fix qna unit tests to not be escaping strings

* make all property path properties StringExpressions
rename FloatExpression to NumberExpression to better align with javascript (int, number) and json schema (int, number)
Remove LongExpression
changed to dcState pattern

* added ArrayExpression, ObjectExpression, DialogExpression

* fix datetimeinput reftime

* remove commented out line

* changes from code review feedback

* restore 2 of the expression unit tets

* fix trace robustness with null from

* remove file transcript logger from unit tests

* fix back compat constructor

* kick the tires
2020-01-17 16:00:34 -08:00
Jonathan Fingold 87527269ba work in progress 2018-07-05 16:19:26 -07:00
John Taylor 9e9d9769d3 stylecop changes - mostly adding Async to method names 2018-07-03 15:52:45 -07:00
John Taylor 52e8ff78da use using rather than inline namespace 2018-06-22 15:13:28 -07:00
John Taylor f702a49488 consolidate a little code on integration 2018-06-22 15:07:06 -07:00