Added CultureInfo and StringComparison parameters to several string operations.
Added some using statements for disposable objects.
Added project wide exclude for CA2225 (Operator overloads have named alternates) in Dialogs.Adaptive we should address this if we want to support other platforms than C# see https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2225?view=vs-2019.
Added several #pragme exlcudes to collection properties that shouln't have a setter.
Added several other #pragma disable for other rules for code that can't be changed because of binary compat.
Replaced several Count() calls by the Count property.
Added solution wide exclude for CA1308 Normalize strings to uppercase and removed specific excludes from projects and code (we mostly use lowercase in our project and the rule doesn't apply).
* Added FxCop and Async analyzers to the LUIS project.
I suppressed some Dispose warnings for now, we will address those once we start using HttpClientFactory in a future release.
Deprecated the DefaultHttpClient static property in LuisRecognizeer and crated an internal HttpClient instance property that can be seen for testing (that's the only reason why is there).
Added AssemblyInfo to make internal methods visible to tests.
Added exclude for rule CA1822 (Mark members as static) as requested by Tom.
* Update BotBuilder-DotNet.ruleset
Touched file to see if it triggers a build
* Add missing code docs for the AI libraries (LUIS / QnA)
* Manually fixed some merge conflicts to match master
* Fixed other naming errors for new variables that came with the merge
Co-authored-by: Gabo Gilabert <ggilaber@microsoft.com>
* Add HostContext for global assets like IConfiguration
* Add ComponentRegistration discovery
* Break interfaces apart for components registrations
* Added Expression.Parse with global function table
* Removed IExpressionEngineFactory
* drop SetStateConfiguration
* Merge TypeFactory and DeclarativeTypeLoader with ResourceExplorer
* Added DialogManager.TurnState to allow dialog manager to set initial TurnState for registering components like LanguageGenerator and ResourceExplorer
* Dropped adapter .Use methods and moved them to DialogManager (UseResourceExplorer/UseLanguageGeneration etc)
* Drop Resource Plugins
* Merge RefResolver into ResourceExplorer
* rename TypeRegistration to KindRegistration
* Add Configuration.UseLuisSettings()
* add updateluis
* update coments
* add IComponentExpressionFunction for custom functions
* fix issue with netcore31
* changes based on code review
* comments
* headers
* fixed expression optional/ignore and added unit tets
* restored jsonload
* make transcript tests run faster by reducing delay by 10x
* fix optional/ignore semantics
Gabo Gilabert
Gary Pretty
Lu Han
Chris McConnell
Tom Laird-McConnell