Граф коммитов

71 Коммитов

Автор SHA1 Сообщение Дата
Cecilia Avila 6a7f93ceba
bump: [#4684] Update nock dependency to latest version (#4760)
* Upgrade nock in adaptive-testing library

* Upgrade nock package to latest version
2024-09-30 12:20:35 -05:00
Jhonatan Sandoval Velasco de27db4047
port: [#6793][#6792] Composer Bot with QnA Intent recognized triggers duplicate QnA queries (#4700)
* fix qna double trace error

* fix qna double trace error
2024-07-01 08:00:11 -05:00
Joel Mut 3418fa9bdf
Fix bot's state skipped properties in cache hash (#4594) 2024-01-08 08:09:07 -06:00
Joel Mut 8bd9dbaf45
fix: [#4325] Skip Storage properties from BotState class (#4326)
* Add skip storage properties functionality to BotState

* Add unit tests for BotState skipProperties

* Fix test:compat

* test for linux
2022-09-19 10:18:58 -05:00
Cecilia Avila c692c81df7
port: [#4277] Catch HttpRequestException in HttpRequest (#6404) (#4304)
* HttpRequest class updated. Unit test created.

* Added botbuilder-core dependency.

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
2022-08-09 09:26:10 -05:00
Joel Mut 2bb74756e0
port: [#4270] Choice options separator should be multi language (#6366) (#4293)
* Add ChoiceOptionsSet

* Add unit tests for ChoiceOptionsSet

* Update schema files

* Fix test:compat
2022-07-25 08:19:15 -05:00
Cecilia Avila 0cd28d8716
port: [#5837] Fix sentiment values not being set for None / Unknown intent (#6348) (#4275)
* Set sentiment props for None intents

* Add unit tests
2022-07-13 14:02:36 -05:00
Joel Mut 0305b7da5b
fix: [#4204] Fix remaining eslint warnings - Rest of botbuilder-dialogs libraries - botbuilder adaptive testing (#4237)
* Warnings fixed. Missing documentation, unused parameters and imports, disabling detect-non-literal-fs-filename rule and no-constant-condition rule.

* Void changes removed. Unknown type restored to Any. Documentation added.

* api.md file moved to etc folder

* Suggested changes applied.

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com>
2022-07-13 13:21:30 -05:00
Josh Gummersall a5ae17eac3
Revert "fix: [#3969] useLanguagePolicy setting turn state, instead of languagePolicy (#3972)" (#3976)
This reverts commit 98dd347ebf.
2021-11-08 10:57:55 -08:00
Joel Mut 98dd347ebf
fix: [#3969] useLanguagePolicy setting turn state, instead of languagePolicy (#3972)
* Revert "Revert "port: Register missingProperties custom function to get all variables the template contains (#3885)" (#3970)"

This reverts commit 619ac1399d.

* fix: useLanguagePolicy setting turn state, instead of languagePolicy
2021-11-05 11:51:45 -07:00
Josh Gummersall 619ac1399d
Revert "port: Register missingProperties custom function to get all variables the template contains (#3885)" (#3970)
This reverts commit 3e2beae24e.
2021-11-03 16:22:04 -07:00
Hongyang Du (hond) 26f7f447da
port: Make Multi-language recognizer case-insensitive (#3893)
* Make Multi-language recognizer case-insensitive

* fix

* fix comments
2021-08-04 08:24:52 -07:00
Hongyang Du (hond) 3e2beae24e
port: Register missingProperties custom function to get all variables the template contains (#3885)
* init

* init

* fix issue

* fix API extractor error

* fix

* fix comments

* fix test:compat

Co-authored-by: Josh Gummersall <jgummersall@microsoft.com>
2021-08-02 12:50:55 -07:00
Shuai Wang 290c7e0101
port: Fix: add cache for luis recognizer result to avoid extra requests (#3829)
* port cache luis result

* remove only

* remove usused code

* fix failed tests

* fix lint issue

* remove Iterable

* fix failed tests

* fix api compat test

* remove unused import

Co-authored-by: Josh Gummersall <jgummersall@microsoft.com>
2021-07-02 15:13:18 -07:00
Hongyang Du (hond) 9719123981
feat: AdaptiveExpressions: Allow 0 to convert as false bool (#3801) 2021-06-24 09:55:07 -07:00
Josh Gummersall 542641d0e8
chore: add missing packages to consumer test (#3737)
* feat: depcheck

* feat: separate workflows instead of conditional exec

* Revert "bump: runtypes (#3648)"

This reverts commit c7a22fb465.

* Downgrade other runtypes references

* chore: add missing packages to consumer test

Fixes #3736

* fix: downlevel runtime integrations

* fix: better consumer test errors

* feat: zod replaces runtypes for tsc compat

* fix: runtime error devexp, luis tests

* clean botframework-schema references in tests

Co-authored-by: stevengum <14935595+stevengum@users.noreply.github.com>
2021-06-22 09:29:11 -07:00
Hongyang Du (hond) 2bc15c67be
port: Support iteration for object in ForEach action (#3772)
* Support iteration for object in ForEach action

* refine

* refine code
2021-06-18 09:29:24 -07:00
Hongyang Du (hond) cb2145b16d
fix: Maxturn count increase while interruption in composer prompts (#3774) 2021-06-18 09:26:39 -07:00
Hongyang Du (hond) 87ecf382bc
port: Fix double evaluation and filter sensitive settings (#3740)
* init

* a

* move on

* add tests

* revert some files

* remove unused file

* Quick review fixes

* add test

Co-authored-by: Josh Gummersall <jgummersall@microsoft.com>
2021-06-14 19:21:35 -07:00
Michael Richardson c9564c1309
feat: allow wildcard in mock paths (#3713) 2021-06-01 11:03:59 -07:00
Michael Richardson a71af890bc
chore: Replace `catch` with `assert.rejects|throws` in tests (part 3 of 3) (#3661)
* convert try/catch to assert.rejects|throws

* no-op linitng

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>
2021-05-07 11:52:11 -07:00
Michael Richardson d3f881df45
port: Several Adaptive parity fixes and additions (#3628)
* feat: Update package reference for orchestrator-core to GA (#3577)

* ensure inspector and manager match

* update onAssignEntity and onChooseEntity

* parity w/ .NET

* refactor and ensure onChoose test passes

* make cachedResponses dir if not exist

* load local schema

* minor cleanup

* fix merge conflict resolution mistakes

* PR review adjustments

* remove unnecessary casting

* remove more unnecessary castings

* PR review adjustments

* convert to strict equality

* fix reducer
2021-04-29 16:30:16 -07:00
Josh Gummersall 6bd641eb13
port: resume dialog fix from .net (#3525)
Fixes #3524
2021-04-06 10:12:20 -07:00
Hongyang Du (hond) b7dba8d3b1
port: Add alias feature for LG import (#3496)
* init

* add tests

* add test data

* update

* fix comments

* remove esModuleInterop

* retrigger

* retrigger

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>
2021-04-01 10:13:24 -07:00
Zichuan Ma 02423c0d4e
port: Add support of Expressions in BeginDialog Actions (#3460)
* implemented DialogSetConverter

* tests for begin dialog with expression

* schema update

* fix: run with npx

* updated adaptive dialog schema

* updated tests.schema

Co-authored-by: Josh Gummersall <1235378+joshgummersall@users.noreply.github.com>
Co-authored-by: Josh Gummersall <jgummersall@microsoft.com>
2021-03-30 16:14:42 +08:00
Josh Gummersall ca261db8d9
fix: rename runtime packages (#3481)
* fix: rename runtime packages

Fixes #3480

* fix: descriptions
2021-03-29 16:26:30 -07:00
Josh Gummersall 85ff1febb9
port: component registration -> bot components (#3471)
* feat: BotComponent instead of ComponentRegistration

* fix: serviceCollection sync

* feat: dialogs to bot component, shim registration

* fix: dialogs adaptive testing component registration

* fix: adaptive teams tests

* fix: dialogs declarative tests

* fix: orchestrator bot component

* fix: remove unused p-reduce dep

* fix: orchestrator rename

* fix: corebot initial turn state

* fix: turn state undefined

* fix: component load error

* fix: use no-op configuration for configure services calls

* fix: shim luis/qna component registrations

* port: collect bot component load exceptions and report once

* fix: orchestrator exports

* fix: noOpConfiguration docstring
2021-03-29 15:28:13 -07:00
Hongyang Du (hond) fe7ce62d79
port: Assign a default TemplateEngineLanguageGenerator to Generator (#3444)
* Assign a default TemplateEngineLanguageGenerator to Generator

* revert some tests

* fix comments
2021-03-26 08:59:50 -07:00
Hongyang Du (hond) 4c9120f616
port: Change ChoiceSet to support LG (#3443)
* Change ChoiceSet to support LG

* fix bug

* fix schema

* retrigger

* fix comments

* retrigger
2021-03-26 08:58:25 -07:00
Josh Gummersall c18d3878a7
port: do nothing when activity is null (#3421)
Fixes #3417
2021-03-24 14:27:33 -07:00
Hongyang Du (hond) 59a276f006
port: Check null for input prompt (#3425)
* Check null for input prompt

* fix error

* retrigger
2021-03-23 09:11:08 -07:00
Zichuan Ma e09dc68224
port: enable LG syntax in OAuthInput (#3409)
* fixed a bug in expression parse to trim beginning '='

* fixed a bug in templates to recognize multiline correctly

* updated OAuthPrompt to make sendOAuthCard() public static

* Updated OAuthInput to enable LG syntax

* added tests

* make channelSupportOAuthCard() private

* added inline comments

* minor fix

* Revert "minor fix"

This reverts commit 09e30f0500.

Co-authored-by: Josh Gummersall <1235378+joshgummersall@users.noreply.github.com>
2021-03-22 14:30:13 -07:00
Ashley Finafrock e0d9198929
Add logPersonalInformation to recognizers (#3296)
* Recognizers in bb-dialogs-adaptive derive from AdaptiveRecognizer

* Pass DialogContext in call to fillRecognizerResultTelemetryProperties

* Ported AdaptiveRecognizer

* MultiLanguageRecognizer now passes dc to fillRecognizerResultTelemetryProperties

* Set up recognizerIntentAndValidateTelemetry

* Handle spy in mocha hooks

* Finished RegexRecognizer tests

* Added default logPii test for RegexRecognizer test

* Fixed RecognizerSet intent bug + tests

* Added MultiLinguageRecognizer tests

* Removed commented out broken code in RecognizerSet

* Recognizer.createChooseIntentResult returns {} for default entities instead of undefined

* prettier + docs + (index signature --> Record<...>)

* Make DialogContext required in fillREcfillRecognizerResultTelemetryProperties

* Run prettier

* Refactored RecognizerResult.getTopScoringIntent

* Refactored RecognizerSet to use for...of loop

* CrossTrainedRecognizerSet results now actually return 'id' prop + tests

* Comment back in other CrossTrainedRecognizerSet tests

* Try debugging broken CrossTrainRecognizerSet tests -- looked into RecognizerSet

* Removed redundant code in recognizerSet.ts

* Check for result.entities in RecognizerSet.recognize before processing

* Finished CrossTrainedRecognizerSet tests

* Updated activityUtils to allow locale

* ChannelMentionEntityRecognizer derives from AdaptiveRecognizer + tests

* QnAMakerRecognizer has fillRecognizerResultTelemetryProperties override + tests + tests cleanup

* entityRecognizerRecognizer.test.js cleanup

* Fixed QnAMakerRecognizer tests spacing

* Reverted changes in CrossTrainedRecognizerSetTests_CircleDefer.test.dialog

* Change to QnAMakerRecognizer doc

* linting batch 1

* Fix lint errs in qna recognizer & added plugins 'only-warn' to bb-ai eslintrc

* Linted dialogs-adaptive/recognizerTelemetryUtils

* Lint activityUtils

* Linted entityRecognizerRecognizer.test.js

* Added AdaptiveRecognizerConfiguration interface; linted regex tests + intentValidations

* Linted AdaptiveRecognizer

* Linted CrossTrainedRecognizerSet

* Finished linting botbuilder-dialogs-adaptive

* Linted crossTrainedRecognizerSet.test

* Linted dialogs-adaptive-testing/intentValidations

* Linted multiLanguageRecognizer.test

* Linted recognizerSet.test

* Linted adaptive-testing/recognizerTelemetryUtils

* Per linting errs, added @microsoft/recognizers-text-suit as dialogs-adaptive-testing dependency

* Reverted changes to streaming bits

* Test if works w/o escape chars in telemetry data

* Test removing all \ from testTelemetryProps

* Removed escap \ from test telemetry props

* Test only dependency addition

* Make OrchestratorAdaptiveRecognizer derive from AdaptiveRecognizer

* Add OrchestratorAdaptiveRecognizer tests

* Cleaned up comments in test

* Lint qna recognizer tests

* Linted recognizer.ts

* doc cleanup

* Added eslint 'only-warn' botbuilder-dialogs-adaptive

* Removed explicit type from CrossTrainedRecognizerSet

* testTelemetryProperties formatted

* Refactor bb-ai recognizer telem. utils

* Refactor reocognizer telem. utils in bb-dialogs-adaptive tests

* Refactor recognizer telm. utils, pt. 3

* disable/enableNetConnect + cleanAll for nocks in qna tests

* JSON.stringify expected telemetry props

* Added unstaged change from conflict resolution in channel mention entity

* Only use .getValue if object is bool in qna dialog

* Added botbuilder-dialogs-declarative back into orc deps.

* Removed plugins 'only-warn' lint setting

* stringify qna telemetry props in tests

* use array.every(...) to test expected v. actual

* Linted changes in bb-ai

* use implicit returns in tests

* Use implicit return throughout PR

* lint telemetryUtils

* lint adaptiveDialog.test.js

* lint bb-dialogs-adaptive tests

* Undo accidental removal of usage of lodash omit

* corrected lodash import statement in qnamakerrecognizer
2021-03-10 09:08:33 -08:00
Shuai Wang c91bf148e2
[Port] Localization: fix bugs around inconsistent locale + first step to centralize locale resolution (#3340)
* port locale changes and fix bugs

* fix tests fail

* add a comment

* fix some lint issue and type annotations

* fix set and get type different issue

* change turn key from Symbol to string

* fix typo and naming

Co-authored-by: Josh Gummersall <1235378+joshgummersall@users.noreply.github.com>
2021-03-10 10:46:02 +08:00
Zichuan Ma c28ab7f931
feat: language generation component registration (#3370)
* added language generation component registration

* updated tests
2021-03-09 10:07:32 +08:00
Shuai Wang bbad73361f
support float priority (#3362) 2021-03-05 09:47:10 -08:00
Zichuan Ma d5adca1d5f
feat: LuisAdaptiveRecognizer and test mocks (#3275)
* new LuisAdaptivePredictionOptions

* let luis recognizer accept dialog context

* minor fix

* assign default values for luis recognizer options

* added method registerType in rp

* resource explorer jsdoc clean up

* minor fix

* add jsdoc for http request mocks

* minor fix

* add fallback to http request mock middleware

* add mock luis

* add mockLuisExtensions

* add dep to murmurhash3

* add HttpRequestLuisMock

* avoid nock conflicts

* map dynamic lists

* add jsdocs for mock luis loader

* add jsdoc for mock luis recognizer

* safer xor

* allow parsing external entity recognizers

* ported tests

* fixed lint errors

* updated dependencies

* export models of botbuilder-ai

* add generic type to external entity

* add types

* Newable

* minor fix

* add inline comment

* removed hasOwnProperty

Co-authored-by: Josh Gummersall <1235378+joshgummersall@users.noreply.github.com>
2021-02-08 10:35:33 -08:00
Zichuan Ma bc2bda03a8
feat: adaptive dialog functions (#3250)
* added adaptive dialog functions

* ported tests for adaptive dialog functions

* fix error catch inside for loop

Co-authored-by: Josh Gummersall <1235378+joshgummersall@users.noreply.github.com>
2021-02-08 10:43:55 +08:00
Zichuan Ma 427675b3ca
feat: Mock QnAMaker via http request mocks (#3278)
* added null check in resource load type

* ported tests of qnamaker mocks
2021-02-07 11:06:13 -08:00
Fei Chen 69b1e0da12
port dotnet 4966 PR (#3277) 2021-02-07 11:18:55 +08:00
Zichuan Ma 6c740cedf4
fix: update access modifiers in QnAMakerDialog (#3230)
* updated access modifier in QnAMakerDialog

* removed JoinOperator in QnAMaker

* added logPersonalInformation to QnAMakerRecognizer

* updated tests

* make RankerTypes enum

* added back strictFiltersJoinOperator

* safer code

* fixed tests

* merge imports

* code clean up

* try to fix failed test

* fix: lint errors

Co-authored-by: Josh Gummersall <1235378+joshgummersall@users.noreply.github.com>
Co-authored-by: Josh Gummersall <jgummersall@microsoft.com>
2021-02-01 10:21:56 +08:00
Zichuan Ma 92339a8e1f
feat: settings mock (#3221)
* added configuration to turn state

* added settings mock

* added tests

* added schema

* fixed tests

* replace all via regex

* use `map`

* added visualized docs

* make const

* Node.isLeaf()

* use reduce()

* prefer forEach

* make $kind readonly

* avoid modifying settings when calling getMemory()

* fixed memory scope test

* add types

Co-authored-by: Josh Gummersall <1235378+joshgummersall@users.noreply.github.com>
2021-01-29 10:44:21 -08:00
Zichuan Ma e5a4fc60f4
feat: http request mock (#3201)
* added HttpRequestMock

* updated HttpRequestMock related tests

* extract type ResponseContent

* removed duplicated persist()

* minor fixes

* fixed build issue

* minor fixes
2021-01-25 16:20:06 +08:00
Michael Richardson f739ef0f87
Ensure UserActivity activities inherit from set activity (#3187)
* respect activity.from in userActivity

* minor adjustments

* adjust activity.from

Co-authored-by: Michael Richardson <v-micric@microsoft.com>
2021-01-14 15:37:23 -08:00
Michael Richardson d086640ffc
fix MemoryAssertions (#3180)
Co-authored-by: Michael Richardson <v-micric@microsoft.com>
2021-01-12 14:20:25 +08:00
Zichuan Ma 28eb35d76c
feat: DialogInspector and new test actions (#3168)
* added dialog inspector

* updated test actions to have inspector

* new test actions

* added tests for TestScript

* centralize resetting retries

* minor fix

* fix build issue
2021-01-07 10:58:13 +08:00
Zichuan Ma f07983082e
fix: tests for BeginSkill with middlewares (#3167)
* registered template types

* added tests for BeginSkill
2021-01-05 06:54:42 +08:00
Zichuan Ma 09f9d63180
New action: ThrowException (#3081)
* added action: ThrowException

* added test for ThrowException

* fixed DialogContextError to expose error message/stack

* use Record<string, unkown> instead of object

* omit Error constructor argument if there is no error value

* removed await keyword

* Make DialogContextError enumerable

Co-authored-by: Josh Gummersall <1235378+joshgummersall@users.noreply.github.com>
2020-12-11 07:40:58 -08:00
Zichuan Ma 1c06b7a540
Register container dialogs in DialogManager (#3105)
* implemented getDialogs() method of DialogSet

* register container dialogs in DialogManager

* tests for container dialogs registeration

* replace dialog fix

* tests for replace dialog

* tests for adaptive dialog on replacing dialogs

* minor improvement
2020-12-07 09:02:10 -08:00
Zichuan Ma 96f452095c
added OnInstallationUpdateActivity (#3082) 2020-11-25 14:02:57 +08:00