From 2d46eb21eb2c904831b0e9f75ab3523384c70e66 Mon Sep 17 00:00:00 2001 From: Anders Carlsson Date: Sun, 16 Aug 2009 04:11:06 +0000 Subject: [PATCH] Call MaybeBindToTemporary for overloaded binary and unary operators. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@79173 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/AST/Expr.cpp | 3 +++ lib/Sema/SemaOverload.cpp | 13 +++++++------ test/CodeGenCXX/temp-1.cpp | 16 +++++++++++++++- 3 files changed, 25 insertions(+), 7 deletions(-) diff --git a/lib/AST/Expr.cpp b/lib/AST/Expr.cpp index b92ecac6a3..fa5ce9f047 100644 --- a/lib/AST/Expr.cpp +++ b/lib/AST/Expr.cpp @@ -588,6 +588,9 @@ bool Expr::isUnusedResultAWarning(SourceLocation &Loc, SourceRange &R1, // effects (e.g. a placement new with an uninitialized POD). case CXXDeleteExprClass: return false; + case CXXBindTemporaryExprClass: + return cast(this) + ->getSubExpr()->isUnusedResultAWarning(Loc, R1, R2); case CXXExprWithTemporariesClass: return cast(this) ->getSubExpr()->isUnusedResultAWarning(Loc, R1, R2); diff --git a/lib/Sema/SemaOverload.cpp b/lib/Sema/SemaOverload.cpp index d4187f2ce1..6b76ce80d7 100644 --- a/lib/Sema/SemaOverload.cpp +++ b/lib/Sema/SemaOverload.cpp @@ -4041,9 +4041,10 @@ Sema::OwningExprResult Sema::CreateOverloadedUnaryOp(SourceLocation OpLoc, UsualUnaryConversions(FnExpr); input.release(); - return Owned(new (Context) CXXOperatorCallExpr(Context, Op, FnExpr, - &Input, 1, ResultTy, - OpLoc)); + + Expr *CE = new (Context) CXXOperatorCallExpr(Context, Op, FnExpr, + &Input, 1, ResultTy, OpLoc); + return MaybeBindToTemporary(CE); } else { // We matched a built-in operator. Convert the arguments, then // break out so that we will build the appropriate built-in @@ -4196,9 +4197,9 @@ Sema::CreateOverloadedBinOp(SourceLocation OpLoc, OpLoc); UsualUnaryConversions(FnExpr); - return Owned(new (Context) CXXOperatorCallExpr(Context, Op, FnExpr, - Args, 2, ResultTy, - OpLoc)); + Expr *CE = new (Context) CXXOperatorCallExpr(Context, Op, FnExpr, + Args, 2, ResultTy, OpLoc); + return MaybeBindToTemporary(CE); } else { // We matched a built-in operator. Convert the arguments, then // break out so that we will build the appropriate built-in diff --git a/test/CodeGenCXX/temp-1.cpp b/test/CodeGenCXX/temp-1.cpp index 737bf65b47..19a6acecf2 100644 --- a/test/CodeGenCXX/temp-1.cpp +++ b/test/CodeGenCXX/temp-1.cpp @@ -49,9 +49,23 @@ struct D { }; // RUN: grep "call void @_ZN1DC1Ev" %t | count 1 && -// RUN: grep "call void @_ZN1DD1Ev" %t | count 2 +// RUN: grep "call void @_ZN1DD1Ev" %t | count 2 && void f4() { D()(); } +// Overloaded operators +struct E { + E(); + ~E(); + E operator+(const E&); + E operator!(); +}; + +// RUN: grep "call void @_ZN1EC1Ev" %t | count 3 && +// RUN: grep "call void @_ZN1ED1Ev" %t | count 5 +void f5() { + E() + E(); + !E(); +}