From 915c07db05375d563187f8b75fa4f766a5220b75 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Tue, 16 Oct 2012 23:45:15 +0000 Subject: [PATCH] Fix pretty-printing for variables declared in a condition. Patch by Grzegorz Jablonski. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@166073 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/AST/StmtPrinter.cpp | 21 +++++++++++++++------ test/CXX/ast-print.cpp | 11 +++++++++++ 2 files changed, 26 insertions(+), 6 deletions(-) diff --git a/lib/AST/StmtPrinter.cpp b/lib/AST/StmtPrinter.cpp index 93d10f7aaf..892442ea3b 100644 --- a/lib/AST/StmtPrinter.cpp +++ b/lib/AST/StmtPrinter.cpp @@ -61,7 +61,7 @@ namespace { void PrintRawCompoundStmt(CompoundStmt *S); void PrintRawDecl(Decl *D); - void PrintRawDeclStmt(DeclStmt *S); + void PrintRawDeclStmt(const DeclStmt *S); void PrintRawIfStmt(IfStmt *If); void PrintRawCXXCatchStmt(CXXCatchStmt *Catch); void PrintCallArgs(CallExpr *E); @@ -121,8 +121,8 @@ void StmtPrinter::PrintRawDecl(Decl *D) { D->print(OS, Policy, IndentLevel); } -void StmtPrinter::PrintRawDeclStmt(DeclStmt *S) { - DeclStmt::decl_iterator Begin = S->decl_begin(), End = S->decl_end(); +void StmtPrinter::PrintRawDeclStmt(const DeclStmt *S) { + DeclStmt::const_decl_iterator Begin = S->decl_begin(), End = S->decl_end(); SmallVector Decls; for ( ; Begin != End; ++Begin) Decls.push_back(*Begin); @@ -187,7 +187,10 @@ void StmtPrinter::VisitAttributedStmt(AttributedStmt *Node) { void StmtPrinter::PrintRawIfStmt(IfStmt *If) { OS << "if ("; - PrintExpr(If->getCond()); + if (const DeclStmt *DS = If->getConditionVariableDeclStmt()) + PrintRawDeclStmt(DS); + else + PrintExpr(If->getCond()); OS << ')'; if (CompoundStmt *CS = dyn_cast(If->getThen())) { @@ -224,7 +227,10 @@ void StmtPrinter::VisitIfStmt(IfStmt *If) { void StmtPrinter::VisitSwitchStmt(SwitchStmt *Node) { Indent() << "switch ("; - PrintExpr(Node->getCond()); + if (const DeclStmt *DS = Node->getConditionVariableDeclStmt()) + PrintRawDeclStmt(DS); + else + PrintExpr(Node->getCond()); OS << ")"; // Pretty print compoundstmt bodies (very common). @@ -240,7 +246,10 @@ void StmtPrinter::VisitSwitchStmt(SwitchStmt *Node) { void StmtPrinter::VisitWhileStmt(WhileStmt *Node) { Indent() << "while ("; - PrintExpr(Node->getCond()); + if (const DeclStmt *DS = Node->getConditionVariableDeclStmt()) + PrintRawDeclStmt(DS); + else + PrintExpr(Node->getCond()); OS << ")\n"; PrintStmt(Node->getBody()); } diff --git a/test/CXX/ast-print.cpp b/test/CXX/ast-print.cpp index fb8588d4b1..44b34aa12c 100644 --- a/test/CXX/ast-print.cpp +++ b/test/CXX/ast-print.cpp @@ -19,3 +19,14 @@ int main() (r->method()); } +// CHECK: if (int a = 1) +// CHECK: while (int a = 1) +// CHECK: switch (int a = 1) + +void f() +{ + if (int a = 1) { } + while (int a = 1) { } + switch (int a = 1) { } +} +