diff --git a/lib/Analysis/FormatString.cpp b/lib/Analysis/FormatString.cpp index 30bfe4bf88..1c911c45c3 100644 --- a/lib/Analysis/FormatString.cpp +++ b/lib/Analysis/FormatString.cpp @@ -336,9 +336,23 @@ bool ArgTypeResult::matchesType(ASTContext &C, QualType argTy) const { return argTy->isPointerType() || argTy->isObjCObjectPointerType() || argTy->isNullPtrType(); - case ObjCPointerTy: - return argTy->getAs() || - argTy->getAs(); + case ObjCPointerTy: { + if (argTy->getAs() || + argTy->getAs()) + return true; + + // Handle implicit toll-free bridging. + if (const PointerType *PT = argTy->getAs()) { + // Things such as CFTypeRef are really just opaque pointers + // to C structs representing CF types that can often be bridged + // to Objective-C objects. Since the compiler doesn't know which + // structs can be toll-free bridged, we just accept them all. + QualType pointee = PT->getPointeeType(); + if (pointee->getAsStructureType() || pointee->isVoidType()) + return true; + } + return false; + } } llvm_unreachable("Invalid ArgTypeResult Kind!"); diff --git a/test/SemaObjC/format-strings-objc.m b/test/SemaObjC/format-strings-objc.m index a4d6eebbac..675729ca1e 100644 --- a/test/SemaObjC/format-strings-objc.m +++ b/test/SemaObjC/format-strings-objc.m @@ -146,3 +146,8 @@ void test_percent_C() { const wchar_t wchar_data = L'a'; NSLog(@"%C", wchar_data); // expected-warning{{format specifies type 'unsigned short' but the argument has type 'wchar_t'}} } + +// Test that %@ works with toll-free bridging (). +void test_toll_free_bridging(CFStringRef x) { + NSLog(@"%@", x); // no-warning +}