For debug and coverage analysis if we're not optimizing go ahead

and emit a relatively empty block for a plain break statement. This
enables us to track where we went through a switch.

PR9796 & rdar://11215207

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@154420 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Eric Christopher 2012-04-10 18:20:19 +00:00
Родитель 10ccf12a06
Коммит c07833795a
3 изменённых файлов: 29 добавлений и 23 удалений

Просмотреть файл

@ -892,7 +892,7 @@ void CodeGenFunction::EmitCaseStmt(const CaseStmt &S) {
// If the body of the case is just a 'break', and if there was no fallthrough,
// try to not emit an empty block.
if (isa<BreakStmt>(S.getSubStmt())) {
if ((CGM.getCodeGenOpts().OptimizationLevel > 0) && isa<BreakStmt>(S.getSubStmt())) {
JumpDest Block = BreakContinueStack.back().BreakBlock;
// Only do this optimization if there are no cleanups that need emitting.

Просмотреть файл

@ -0,0 +1,19 @@
// RUN: %clang_cc1 -triple x86_64-unk-unk -o - -emit-llvm -g %s | FileCheck %s
// PR9796
// Check to make sure that we emit the block for the break so that we can count the line.
// CHECK: sw.bb: ; preds = %entry
// CHECK: br label %sw.epilog, !dbg !21
extern int atoi(const char *);
int f(char* arg) {
int x = atoi(arg);
switch(x) {
case 1:
break;
}
return 0;
}

Просмотреть файл

@ -216,32 +216,19 @@ void test12() {
}
}
// rdar://9289524 - Check that the empty cases don't produce an empty block.
// Verify that case 42 only calls test14 once.
// CHECK: @test13
// CHECK: switch
// CHECK: i32 42, label [[EPILOG:%[0-9.a-z]+]]
// CHECK: i32 11, label [[EPILOG]]
// CHECK: call void @test13(i32 97)
// CHECK-NEXT: br label %[[EPILOG2:[0-9.a-z]+]]
// CHECK: [[EPILOG2]]
// CHECK-NEXT: br label [[EPILOG:%[0-9.a-z]+]]
// CHECK: call void @test13(i32 42)
// CHECK-NEXT: br label [[EPILOG]]
void test13(int x) {
switch (x) {
case 42: break; // No empty block please.
case 11: break; // No empty block please.
default: test13(42); break;
}
}
// Verify that case 42 only calls test14 once.
// CHECK: @test14
// CHECK: call void @test14(i32 97)
// CHECK-NEXT: br label [[EPILOG2:%[0-9.a-z]+]]
// CHECK: call void @test14(i32 42)
// CHECK-NEXT: br label [[EPILOG2]]
void test14(int x) {
switch (x) {
case 42: test14(97); // fallthrough
case 42: test13(97); // fallthrough
case 11: break;
default: test14(42); break;
default: test13(42); break;
}
}