From e42ac98bc2d50506216b6ef258594bdaa59c47c1 Mon Sep 17 00:00:00 2001 From: Ted Kremenek Date: Wed, 8 Apr 2009 18:49:36 +0000 Subject: [PATCH] Fix bug in ParentMap::isConsumedExpr. A BinaryOperator always "consumes" the value of its subexpressions unless it is a comma (in which case it doesn't consume the left subexpression). git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@68628 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/AST/ParentMap.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/AST/ParentMap.cpp b/lib/AST/ParentMap.cpp index 877b43b6de..33731c63ed 100644 --- a/lib/AST/ParentMap.cpp +++ b/lib/AST/ParentMap.cpp @@ -66,7 +66,9 @@ bool ParentMap::isConsumedExpr(Expr* E) const { return true; case Stmt::BinaryOperatorClass: { BinaryOperator *BE = cast(P); - return BE->getOpcode()==BinaryOperator::Comma && DirectChild==BE->getLHS(); + // If it is a comma, only the left side is consumed. + // If it isn't a comma, both sides are consumed. + return BE->getOpcode()!=BinaryOperator::Comma || DirectChild==BE->getLHS(); } case Stmt::ForStmtClass: return DirectChild == cast(P)->getCond();