2 Коммитов

Автор	SHA1	Сообщение	Дата
Etienne Bergeron	623c3e8671	[clang-tidy] Reduce false-positive ratio in misc-suspicious-missing-comma check. ... Summary: This patch is adding detection of common string literal patterns that should not trigger warnings. [*] Add a limit on the number of concatenated token, [*] Add support for parenthese sequence of tokens, [*] Add detection of valid indentation. As an example, this code will no longer trigger a warning: ``` const char* Array[] = { "first literal" "indented literal" "indented literal", "second literal", [...] ``` Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D18695 git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@265303 91177308-0d34-0410-b5e6-96231b3b80d8	2016-04-04 15:46:38 +00:00
Etienne Bergeron	5e64620bd6	[clang-tidy] Add a new checker to detect missing comma in initializer list. ... Summary: This checker is able to detect missing comma in an array of string literals. ``` const char* A[] = { "abc", "def" // missing comma (no compiler warnings) "ghi", }; ``` The ratio of false-positive is reduced by restricting the size of the array considered and the ratio of missing comma. To validate the quantity of false positive, the checker was tried over LLVM and chromium code and detected these cases: [[ http://reviews.llvm.org/D18454 | http://reviews.llvm.org/D18454 ]] [[https://codereview.chromium.org/1807753002/ | https://codereview.chromium.org/1807753002/]] [[https://codereview.chromium.org/1826193002/ | https://codereview.chromium.org/1826193002/]] [[https://codereview.chromium.org/1805713002/ | https://codereview.chromium.org/1805713002/]] Reviewers: alexfh Subscribers: LegalizeAdulthood, szdominik, xazax.hun, cfe-commits Differential Revision: http://reviews.llvm.org/D18457 git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@265033 91177308-0d34-0410-b5e6-96231b3b80d8	2016-03-31 18:12:23 +00:00