Fixed pipeline jobs to respect AGENT_POOL (#291)

* add agent `pool` attributes to all `job` defs

* point the `release/provision` jobs at an `agent pool` not a `vmImage`

* move the `pool` def up, alike the build-stage
(and help keep it at the right indentation level)

devops/providers/azure-devops/templates/infrastructure/azure-pipeline-build-stage.yml

@@ -10,7 +10,9 @@ jobs:
   variables:
   - group: '${{ parameters.environment }} Environment Variables'
   displayName: Determine CI Targets to Run
+  pool: $(AGENT_POOL)
   condition: not(coalesce(variables.FORCE_RUN, ${{ parameters.forceRun }}))
+
   steps:
   - ${{ each config in parameters.configurationMatrix }}:
     - task: Bash@3

devops/providers/azure-devops/templates/infrastructure/azure-pipeline-release-stage.yml

@@ -7,6 +7,7 @@ parameters:
 jobs:
 
 - job: TemplateChangeDetection
+  pool: $(AGENT_POOL)
   variables:
   - group: '${{ parameters.environment }} Environment Variables'
   displayName: Determine CD Targets to Run
@@ -25,14 +26,12 @@ jobs:
 - ${{ each config in parameters.configurationMatrix }}:
   - deployment: Provision_${{ config.jobName }}_${{ parameters.environment }}
     dependsOn: TemplateChangeDetection
+    pool: $(AGENT_POOL)
     condition: or(coalesce(variables.FORCE_RUN, ${{ parameters.forceRun }}), eq(dependencies.TemplateChangeDetection.outputs['${{ config.jobName }}.needs_cicd'], 'true'))
 
     ${{ if config.deploymentTimeoutInMinutes }}:
       timeoutInMinutes: '${{ config.deploymentTimeoutInMinutes }}'
 
-    pool:
-      vmImage: $(AGENT_POOL)
-
     variables:
     - group: '${{ parameters.environment }} Environment Variables'
 

infra/modules/providers/azure/provider/main.tf

@@ -9,4 +9,3 @@ provider "null" {
 provider "azuread" {
   version = "~>0.4.0"
 }
-