Removing notebook command

CHANGELOG.md

@@ -1,12 +1,17 @@
+## v0.0.24 (05/03/2020)
+
+- Explicitly marking the `CodeTour` extension as a "workspace extension", since it needs access to the workspace files and Git extension.
+- Temporarily removed the `View Notebook` command, since this isn't officially supported in VS Code.
+
 ## v0.0.23 (04/19/2020)
 
 - Added the `View Notebook` command to tour nodes in the `CodeTour` tree, which allows you to view a tour as a notebook
-- 
+
 ## v0.0.22 (04/18/2020)
 
 - New tours are now written to the workspace's `.tours` folder, instead of the `.vscode/tours` folder. Both folders are still valid locations for tours, but the former sets up CodeTour to be more editor-agnostic (e.g. adding a Visual Studio client)
 - New tours are now written using a `.tour` extension (instead of `.json`). Both formats are still supported, but `.tour` will be the new default.
-  
+
 ## v0.0.21 (04/10/2020)
 
 - Added the `CodeTour: Open Tour URL...` command, that allows opening a tour file by URL, in addition to the existing `CodeTour: Open Tour File...` command.

README.md

@@ -43,12 +43,15 @@ If you want to disable tour markers, you can perform one of the following action
 - Click the "eye icon" in the title bar of the `CodeTour` tree view
 - Set the `codetour.showMarkers` configuration setting to `false`. _Note that the above two actions do this for you automatically._
 
+<!--
 ### Notebook View
 
 In addition to taking a tour through a series of files, you can also view a tour as a "notebook", which displays the tour's steps within a single document. Simply right-click a tour in the `CodeTour` tree and select `View Notebook`.
 
 <img width="700px" src="https://user-images.githubusercontent.com/116461/79699658-bd63a580-8245-11ea-81cc-6208e2784acf.gif" />
 
+-->
+
 ## Navigating a tour
 
 Once you've started a tour, the comment UI will guide you, and includes navigation actions that allow you to perform the following:

package.json

@@ -3,7 +3,7 @@
   "displayName": "CodeTour",
   "description": "VS Code extension that allows you to record and playback guided tours of codebases, directly within the editor",
   "publisher": "vsls-contrib",
-  "version": "0.0.23",
+  "version": "0.0.24",
   "repository": {
     "type": "git",
     "url": "https://github.com/vsls-contrib/codetour"
@@ -25,12 +25,10 @@
     "Sharing"
   ],
   "extensionKind": [
-    "workspace",
-    "ui"
+    "workspace"
   ],
   "activationEvents": [
-    "*",
-    "onNotebookEditor:codetour"
+    "*"
   ],
   "main": "./out/extension.js",
   "contributes": {
@@ -359,11 +357,6 @@
           "when": "viewItem == codetour.tour",
           "group": "basic@1"
         },
-        {
-          "command": "codetour.viewNotebook",
-          "when": "viewItem == codetour.tour",
-          "group": "basic@2"
-        },
         {
           "command": "codetour.changeTourTitle",
           "when": "viewItem =~ /^codetour.tour(.recording)?(.active)?$/",
@@ -465,17 +458,6 @@
           "CodeTour"
         ]
       }
-    ],
-    "notebookProvider": [
-      {
-        "viewType": "codetour",
-        "displayName": "CodeTour Notebook",
-        "selector": [
-          {
-            "filenamePattern": "*.tour"
-          }
-        ]
-      }
     ]
   },
   "dependencies": {

src/commands.ts

@@ -597,7 +597,7 @@ export function registerCommands() {
   ): Promise<string | undefined> {
     // If for some reason the Git extension isn't available,
     // then we won't be able to ask the user to select a git ref.
-    if (!api) {
+    if (!api || !api.getRepository) {
       return;
     }
 

src/extension.ts

@@ -13,7 +13,6 @@ import { discoverTours } from "./store/provider";
 import { registerTreeProvider } from "./tree";
 import { registerDecorators } from "./decorator";
 import { store } from "./store";
-import { registerNotebookProvider } from "./notebook";
 
 export async function activate(context: vscode.ExtensionContext) {
   registerCommands();
@@ -47,7 +46,6 @@ export async function activate(context: vscode.ExtensionContext) {
   registerTreeProvider(context.extensionPath);
   registerFileSystemProvider();
   registerStatusBar();
-  registerNotebookProvider();
 
   return {
     startTour: startCodeTour,