Promote VCPKG detector to enabled by default (#1203)

src/Microsoft.ComponentDetection.Detectors/vcpkg/VcpkgComponentDetector.cs

@@ -13,7 +13,7 @@ using Microsoft.ComponentDetection.Detectors.Vcpkg.Contracts;
 using Microsoft.Extensions.Logging;
 using Newtonsoft.Json;
 
-public class VcpkgComponentDetector : FileComponentDetector, IExperimentalDetector
+public class VcpkgComponentDetector : FileComponentDetector
 {
     private readonly HashSet<string> projectRoots = new HashSet<string>();
 

src/Microsoft.ComponentDetection.Orchestrator/Experiments/Configs/VcpkgExperiment.cs

@@ -1,18 +0,0 @@
-namespace Microsoft.ComponentDetection.Orchestrator.Experiments.Configs;
-
-using Microsoft.ComponentDetection.Contracts;
-using Microsoft.ComponentDetection.Detectors.Vcpkg;
-
-/// <summary>
-/// Validating the <see cref="VcpkgComponentDetector"/>.
-/// </summary>
-public class VcpkgExperiment : IExperimentConfiguration
-{
-    public string Name => "VcpkgDetector";
-
-    public bool IsInControlGroup(IComponentDetector componentDetector) => false; // There is no baseline, completely new detector
-
-    public bool IsInExperimentGroup(IComponentDetector componentDetector) => componentDetector is VcpkgComponentDetector;
-
-    public bool ShouldRecord(IComponentDetector componentDetector, int numComponents) => true;
-}

src/Microsoft.ComponentDetection.Orchestrator/Extensions/ServiceCollectionExtensions.cs

@@ -62,7 +62,6 @@ public static class ServiceCollectionExtensions
         services.AddSingleton<IExperimentProcessor, DefaultExperimentProcessor>();
         services.AddSingleton<IExperimentConfiguration, SimplePipExperiment>();
         services.AddSingleton<IExperimentConfiguration, RustCliDetectorExperiment>();
-        services.AddSingleton<IExperimentConfiguration, VcpkgExperiment>();
         services.AddSingleton<IExperimentConfiguration, GoDetectorReplaceExperiment>();
         services.AddSingleton<IExperimentConfiguration, PipReportExperiment>();