Promote VCPKG detector to enabled by default (#1203)

This commit is contained in:
Greg Villicana 2024-07-17 10:50:26 -07:00 коммит произвёл GitHub
Родитель 024e2a57ce
Коммит 13744eeec1
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: B5690EEEBB952194
3 изменённых файлов: 1 добавлений и 20 удалений

Просмотреть файл

@ -13,7 +13,7 @@ using Microsoft.ComponentDetection.Detectors.Vcpkg.Contracts;
using Microsoft.Extensions.Logging; using Microsoft.Extensions.Logging;
using Newtonsoft.Json; using Newtonsoft.Json;
public class VcpkgComponentDetector : FileComponentDetector, IExperimentalDetector public class VcpkgComponentDetector : FileComponentDetector
{ {
private readonly HashSet<string> projectRoots = new HashSet<string>(); private readonly HashSet<string> projectRoots = new HashSet<string>();

Просмотреть файл

@ -1,18 +0,0 @@
namespace Microsoft.ComponentDetection.Orchestrator.Experiments.Configs;
using Microsoft.ComponentDetection.Contracts;
using Microsoft.ComponentDetection.Detectors.Vcpkg;
/// <summary>
/// Validating the <see cref="VcpkgComponentDetector"/>.
/// </summary>
public class VcpkgExperiment : IExperimentConfiguration
{
public string Name => "VcpkgDetector";
public bool IsInControlGroup(IComponentDetector componentDetector) => false; // There is no baseline, completely new detector
public bool IsInExperimentGroup(IComponentDetector componentDetector) => componentDetector is VcpkgComponentDetector;
public bool ShouldRecord(IComponentDetector componentDetector, int numComponents) => true;
}

Просмотреть файл

@ -62,7 +62,6 @@ public static class ServiceCollectionExtensions
services.AddSingleton<IExperimentProcessor, DefaultExperimentProcessor>(); services.AddSingleton<IExperimentProcessor, DefaultExperimentProcessor>();
services.AddSingleton<IExperimentConfiguration, SimplePipExperiment>(); services.AddSingleton<IExperimentConfiguration, SimplePipExperiment>();
services.AddSingleton<IExperimentConfiguration, RustCliDetectorExperiment>(); services.AddSingleton<IExperimentConfiguration, RustCliDetectorExperiment>();
services.AddSingleton<IExperimentConfiguration, VcpkgExperiment>();
services.AddSingleton<IExperimentConfiguration, GoDetectorReplaceExperiment>(); services.AddSingleton<IExperimentConfiguration, GoDetectorReplaceExperiment>();
services.AddSingleton<IExperimentConfiguration, PipReportExperiment>(); services.AddSingleton<IExperimentConfiguration, PipReportExperiment>();