Merged PR 2304: update some tests

Tests/SystematicTesting.Tests/Actors/Threading/UncontrolledDelayTests.cs

@@ -46,8 +46,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Actors
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing."
-            },
-            replay: true);
+            });
         }
 
         private class M1 : StateMachine
@@ -82,8 +81,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Actors
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing.",
-            },
-            replay: true);
+            });
         }
 
         [OnEventDoAction(typeof(UnitEvent), nameof(IgnoreUnitEvent))]
@@ -116,8 +114,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Actors
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing.",
-            },
-            replay: true);
+            });
         }
 
         private class M2 : StateMachine
@@ -152,8 +149,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Actors
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing.",
-            },
-            replay: true);
+            });
         }
 
         private class A3 : Actor
@@ -191,8 +187,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Actors
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing.",
-            },
-            replay: true);
+            });
         }
 
         private class M3 : StateMachine
@@ -236,8 +231,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Actors
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing.",
-            },
-            replay: true);
+            });
         }
     }
 }

Tests/SystematicTesting.Tests/Actors/Threading/UncontrolledTaskTests.cs

@@ -42,8 +42,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Actors
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing.",
-            },
-            replay: true);
+            });
         }
 
         private class M1 : StateMachine
@@ -78,8 +77,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Actors
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing.",
-            },
-            replay: true);
+            });
         }
 
         private class A2 : Actor
@@ -108,8 +106,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Actors
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing.",
-            },
-            replay: true);
+            });
         }
 
         private class M2 : StateMachine
@@ -144,8 +141,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Actors
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing.",
-            },
-            replay: true);
+            });
         }
     }
 }

Tests/SystematicTesting.Tests/Tasks/MixedTypes/MixedControlledTaskAwaitTests.cs

@@ -44,8 +44,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -89,8 +88,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -124,8 +122,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -171,8 +168,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
     }
 }

Tests/SystematicTesting.Tests/Tasks/MixedTypes/MixedMultipleTaskAwaitTests.cs

@@ -30,8 +30,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -49,8 +48,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -74,14 +72,13 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedErrors: new string[]
-                {
-                    "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                    "Please make sure to use Coyote APIs to express concurrency ().",
-                    "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
-                    "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
-                    "concurrently, you will need to mock them during testing."
-                },
-            replay: true);
+            {
+                "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
+                "Please make sure to use Coyote APIs to express concurrency ().",
+                "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
+                "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
+                "concurrently, you will need to mock them during testing."
+            });
         }
 
         [Fact(Timeout = 5000)]
@@ -105,8 +102,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -125,8 +121,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -145,8 +140,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -171,14 +165,13 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedErrors: new string[]
-                {
-                    "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                    "Please make sure to use Coyote APIs to express concurrency ().",
-                    "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
-                    "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
-                    "concurrently, you will need to mock them during testing."
-                },
-            replay: true);
+            {
+                "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
+                "Please make sure to use Coyote APIs to express concurrency ().",
+                "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
+                "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
+                "concurrently, you will need to mock them during testing."
+            });
         }
 
         [Fact(Timeout = 5000)]
@@ -203,14 +196,13 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedErrors: new string[]
-                {
-                    "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                    "Please make sure to use Coyote APIs to express concurrency ().",
-                    "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
-                    "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
-                    "concurrently, you will need to mock them during testing."
-                },
-            replay: true);
+            {
+                "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
+                "Please make sure to use Coyote APIs to express concurrency ().",
+                "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
+                "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
+                "concurrently, you will need to mock them during testing."
+            });
         }
     }
 }

Tests/SystematicTesting.Tests/Tasks/MixedTypes/MixedSkipTaskAwaitTests.cs

@@ -80,8 +80,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing.",
-            },
-            replay: true);
+            });
         }
 
         [Fact(Timeout = 5000)]
@@ -105,8 +104,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -125,8 +123,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -145,8 +142,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -171,8 +167,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -203,8 +198,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
                 "Uncontrolled task '' invoked a runtime method. Please make sure to avoid using concurrency APIs () " +
                 "inside actor handlers or controlled tasks. If you are using external libraries that are executing " +
                 "concurrently, you will need to mock them during testing.",
-            },
-            replay: true);
+            });
         }
     }
 }

Tests/SystematicTesting.Tests/Tasks/MixedTypes/MixedUncontrolledTaskAwaitTests.cs

@@ -59,8 +59,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -77,8 +76,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -143,8 +141,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -167,8 +164,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -218,8 +214,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -237,8 +232,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -306,8 +300,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
 
         [Fact(Timeout = 5000)]
@@ -331,8 +324,7 @@ namespace Microsoft.Coyote.SystematicTesting.Tests.Tasks
             },
             configuration: GetConfiguration().WithTestingIterations(200),
             expectedError: "Controlled task '' is trying to wait for an uncontrolled task or awaiter to complete. " +
-                "Please make sure to use Coyote APIs to express concurrency ().",
-            replay: true);
+                "Please make sure to use Coyote APIs to express concurrency ().");
         }
     }
 }