From a5bd5a6ee3f957d5e83ee1e98eabcadcfb791445 Mon Sep 17 00:00:00 2001
From: Matthew Koscumb <49213788+mkoscumb@users.noreply.github.com>
Date: Mon, 5 Feb 2024 10:30:57 -0800
Subject: [PATCH] Add noexcept annotation where applicable (#1244)

* NetworkDetector::RegisterAndListen does not throw exceptions, thus mark the method as noexcept.

* RequestHandler::RequestHandler does not throw exceptions, thus mark the constructor as noexcept.

* Constant intialization of member variables should be done using in-class initializers, not in the initializer-list.
---
 lib/pal/desktop/NetworkDetector.cpp          | 2 +-
 lib/pal/desktop/NetworkDetector.hpp          | 2 +-
 tests/functests/MultipleLogManagersTests.cpp | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/pal/desktop/NetworkDetector.cpp b/lib/pal/desktop/NetworkDetector.cpp
index 90c3e572..ee99b7bc 100644
--- a/lib/pal/desktop/NetworkDetector.cpp
+++ b/lib/pal/desktop/NetworkDetector.cpp
@@ -330,7 +330,7 @@ namespace MAT_NS_BEGIN
             return true;
         }
 
-        bool NetworkDetector::RegisterAndListen()
+        bool NetworkDetector::RegisterAndListen() noexcept
         {
             // ???
             HRESULT hr = pNlm->QueryInterface(IID_IUnknown, (void**)&pSink);
diff --git a/lib/pal/desktop/NetworkDetector.hpp b/lib/pal/desktop/NetworkDetector.hpp
index a3f976d6..66f8b6ae 100644
--- a/lib/pal/desktop/NetworkDetector.hpp
+++ b/lib/pal/desktop/NetworkDetector.hpp
@@ -153,7 +153,7 @@ namespace MAT_NS_BEGIN
                     /// Register and listen to network state notifications
                     /// </summary>
                     /// <returns></returns>
-                    bool RegisterAndListen();
+                    bool RegisterAndListen() noexcept;
 
                     /// <summary>
                     /// Reset network state listener to uninitialized state
diff --git a/tests/functests/MultipleLogManagersTests.cpp b/tests/functests/MultipleLogManagersTests.cpp
index 9c7c833a..70ae735f 100644
--- a/tests/functests/MultipleLogManagersTests.cpp
+++ b/tests/functests/MultipleLogManagersTests.cpp
@@ -39,7 +39,7 @@ using namespace MAT;
 class RequestHandler : public HttpServer::Callback 
 {
    public:
-    RequestHandler(int id) : m_count(0), m_id(id){}
+    RequestHandler(int id) noexcept : m_id(id){}
 
     int onHttpRequest(HttpServer::Request const& request, HttpServer::Response& /*response*/) override
     {
@@ -54,7 +54,7 @@ class RequestHandler : public HttpServer::Callback
     }
 
    private:
-    size_t m_count;
+    size_t m_count {};
     int m_id ;
 };