* Pause management
Add API to ILogManager to support Pause/Resume/Wait
* Android wrapper and tests
* Change expected values for PauseManager
* Documentation (use-after-free)
* Repair git merge damage
* Enable Warning as Error on GCC and Clang builds for symmetry with Windows.
* Fix -Wreorder issues in HttpClient_Curl.hpp
* Default assign variables using in-class initializer per CppStandardGuidelines C.48
* Disable -Wtype-limits on clang in parity with MSVC
* Handle GCC separately from Clang for manipulating the warning state.
* Undo a clang-format change.
* Exec is used on non-Apple platforms, however this means that the method fires -Wunused-function on Apple platforms. Locally supress that warning.
* Suppress missing field initializer warning around tm, as I'm not 100% what the most correct fix is here.
* Avoid multi-line comment continuation in -Wcomment
* GCC throws -Wunknown-pragmas on #pragma clang, surround invocations with #ifdef __clang__
* Remove unused local variable, as it's not necessary for the test.
* Suppress -Wobjc-missing-super warnings in third_party code.
* Fix a -Wformat-security warning by treating the message string as an argument.
* Fix error: comparison between ‘const enum Microsoft::Applications::Events::EventProperty::<unnamed>’ and ‘const enum evt_prop_t’ [-Werror=enum-compare]
* Rather than %@, use %s for c-style strings.
* The two types here aren't safely default comparable, cast to underlying types.
* Rather than raising an exception directly, call ODWLogger raiseException
* Wrap #pragma warning with _MSC_VER ifdefs.
* No need for an NSString when NSException prefers a string literal.
* Fix -Wreorder issues in HttpResponseDecoderTests
* Fix error: 'ShadowBondSplicer::addRecord' hides overloaded virtual function [-Werror,-Woverloaded-virtual] by renaming the helper to addCsRecord
* Fix unused local variable warnings by removing the unused locals.
* Fix error: local variable 'output' will be copied despite being returned by name [-Werror,-Wreturn-std-move]. Note that this won't be necessary with guaranteed NVRO in C++17, yay!
* Remove unused locals in MetaStatsTests::GenerateStartEvent
* Fix -Wswitch error on non-Android.
* Fix error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] in OfflineStorageTests_Room.cpp
* More unsigned-signed comparison warning fixes.
* howMany is used in a lambda capture, but clang thinks it isn't used. Odd.
* The unused-lambda-capture warning appears to be a Clang9 bug, don't disable this warning for GCC
* More signed-unsigned comparison fixes.
* Fix signed-unsigned comparison warning in TransmissionPolicyManagerTests. Used long long since that's the return type of std::chrono::duration::milliseconds::count()
* Don't need the long long, default int is fine.
* Fix -wsign-compare in TransmitProfilesTests.cpp
* Missed assigning isAborted to false, std::atomic<T> will zero init its details, but not the T (until C++20).
* Fix -Wdeprecated-copy by defining the copy and move constructors for the Variant type.
* Add copy and move c'tors and assignment operators to the GUID_t type.
* Add copy and move constructors and assignment operators on time_ticks_t
* Fix -Wformat-truncation on GCC 9.3.0 in Pal.cpp by suppressing the warning on this line. This appears to be a false positive.
* INSTANTIATE_TEST_CASE_P is deprecated, using INSTANTIATE_TEST_SUITE_P
* Clang also defines __GNUC__, so since this warning is a GCC only issue suppress the warning when !defined __clang__
* Missed closing #endif in PAL.cpp
* Some versions of GTest deprecate INSTANTIATE_TEST_CASE_P and others do not, the 1DS SDK should unify on a single version of GTest that's part of the repo, or via a package manager. That's not going to be part of this changelist, so simply suppress this warning.
Co-authored-by: Max Golovanov <maxgolov@microsoft.com>
- change LICENSE file as per agreement with CELA: all code has not been previously released and is now licensed as Apache License 2.0
- move couple 3rd party code units to third_party
- scripts to search and replace
- add SPDX copyright to all compilation units
Lalit Kumar Bhasin
Sid Dahiya
Lalit Kumar Bhasin
Martin Harriman
Matthew Koscumb
Eduardo Camacho Camacho
Max Golovanov