2014-10-15 01:32:25 +04:00
package main
import (
2015-05-02 01:01:10 +03:00
"archive/tar"
2014-10-15 01:32:25 +04:00
"bytes"
"encoding/json"
2015-07-25 00:12:55 +03:00
"fmt"
2014-10-15 01:32:25 +04:00
"io"
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
"io/ioutil"
2015-04-14 11:00:46 +03:00
"net/http"
2015-07-25 00:12:55 +03:00
"net/url"
2015-05-03 15:54:55 +03:00
"os"
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
"path/filepath"
2015-11-26 15:14:09 +03:00
"regexp"
2015-06-12 19:49:53 +03:00
"strconv"
2014-12-12 19:01:05 +03:00
"strings"
2015-01-20 03:10:26 +03:00
"time"
2015-04-12 00:49:14 +03:00
2016-09-06 21:18:12 +03:00
"github.com/docker/docker/api/types"
containertypes "github.com/docker/docker/api/types/container"
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
mounttypes "github.com/docker/docker/api/types/mount"
2016-09-06 21:18:12 +03:00
networktypes "github.com/docker/docker/api/types/network"
2016-12-30 20:23:00 +03:00
"github.com/docker/docker/integration-cli/checker"
2016-12-30 12:49:36 +03:00
"github.com/docker/docker/integration-cli/request"
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
"github.com/docker/docker/pkg/ioutils"
"github.com/docker/docker/pkg/mount"
2015-04-12 00:49:14 +03:00
"github.com/docker/docker/pkg/stringid"
2016-12-30 20:23:00 +03:00
"github.com/docker/docker/pkg/testutil"
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
"github.com/docker/docker/volume"
2015-04-18 19:46:47 +03:00
"github.com/go-check/check"
2014-10-15 01:32:25 +04:00
)
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIGetAll ( c * check . C ) {
2017-01-16 18:39:12 +03:00
startCount := getContainerCount ( c )
2014-10-22 02:48:32 +04:00
name := "getall"
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "run" , "--name" , name , "busybox" , "true" )
2014-10-15 01:32:25 +04:00
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "GET" , "/containers/json?all=1" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
2014-10-15 01:32:25 +04:00
2014-10-22 02:48:32 +04:00
var inspectJSON [ ] struct {
Names [ ] string
}
2015-11-19 03:37:42 +03:00
err = json . Unmarshal ( body , & inspectJSON )
c . Assert ( err , checker . IsNil , check . Commentf ( "unable to unmarshal response body" ) )
2014-10-15 01:32:25 +04:00
2015-11-19 03:37:42 +03:00
c . Assert ( inspectJSON , checker . HasLen , startCount + 1 )
2014-10-22 02:48:32 +04:00
2015-11-19 03:37:42 +03:00
actual := inspectJSON [ 0 ] . Names [ 0 ]
c . Assert ( actual , checker . Equals , "/" + name )
2014-10-15 01:32:25 +04:00
}
2015-06-03 19:23:14 +03:00
// regression test for empty json field being omitted #13691
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIGetJSONNoFieldsOmitted ( c * check . C ) {
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "run" , "busybox" , "true" )
2015-06-03 19:23:14 +03:00
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "GET" , "/containers/json?all=1" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
2015-06-03 19:23:14 +03:00
// empty Labels field triggered this bug, make sense to check for everything
// cause even Ports for instance can trigger this bug
// better safe than sorry..
fields := [ ] string {
"Id" ,
"Names" ,
"Image" ,
"Command" ,
"Created" ,
"Ports" ,
"Labels" ,
"Status" ,
Add containers’ networks to /containers/json
After addition of multi-host networking in Docker 1.9, Docker Remote
API is still returning only the network specified during creation
of the container in the “List Containers” (`/containers/json`) endpoint:
...
"HostConfig": {
"NetworkMode": "default"
},
The list of networks containers are attached to is only available at
Get Container (`/containers/<id>/json`) endpoint.
This does not allow applications utilizing multi-host networking to
be built on top of Docker Remote API.
Therefore I added a simple `"NetworkSettings"` section to the
`/containers/json` endpoint. This is not identical to the NetworkSettings
returned in Get Container (`/containers/<id>/json`) endpoint. It only
contains a single field `"Networks"`, which is essentially the same
value shown in inspect output of a container.
This change adds the following section to the `/containers/json`:
"NetworkSettings": {
"Networks": {
"bridge": {
"EndpointID": "2cdc4edb1ded3631c81f57966563e...",
"Gateway": "172.17.0.1",
"IPAddress": "172.17.0.2",
"IPPrefixLen": 16,
"IPv6Gateway": "",
"GlobalIPv6Address": "",
"GlobalIPv6PrefixLen": 0,
"MacAddress": "02:42:ac:11:00:02"
}
}
}
This is of type `SummaryNetworkSettings` type, a minimal version of
`api/types#NetworkSettings`.
Actually all I need is the network name and the IPAddress fields. If folks
find this addition too big, I can create a `SummaryEndpointSettings` field
as well, containing just the IPAddress field.
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
2015-12-10 07:48:50 +03:00
"NetworkSettings" ,
2015-06-03 19:23:14 +03:00
}
// decoding into types.Container do not work since it eventually unmarshal
// and empty field to an empty go map, so we just check for a string
for _ , f := range fields {
if ! strings . Contains ( string ( body ) , f ) {
c . Fatalf ( "Field %s is missing and it shouldn't" , f )
}
}
}
2015-06-12 19:49:53 +03:00
type containerPs struct {
Names [ ] string
Ports [ ] map [ string ] interface { }
}
// regression test for non-empty fields from #13901
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIPsOmitFields ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// Problematic for Windows porting due to networking not yet being passed back
2015-08-28 20:36:42 +03:00
testRequires ( c , DaemonIsLinux )
2015-06-12 19:49:53 +03:00
name := "pstest"
port := 80
2016-01-27 07:16:36 +03:00
runSleepingContainer ( c , "--name" , name , "--expose" , strconv . Itoa ( port ) )
2015-06-12 19:49:53 +03:00
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "GET" , "/containers/json?all=1" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
2015-06-12 19:49:53 +03:00
var resp [ ] containerPs
err = json . Unmarshal ( body , & resp )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-06-12 19:49:53 +03:00
var foundContainer * containerPs
for _ , container := range resp {
for _ , testName := range container . Names {
if "/" + name == testName {
foundContainer = & container
break
}
}
}
2015-11-19 03:37:42 +03:00
c . Assert ( foundContainer . Ports , checker . HasLen , 1 )
c . Assert ( foundContainer . Ports [ 0 ] [ "PrivatePort" ] , checker . Equals , float64 ( port ) )
2015-06-12 19:49:53 +03:00
_ , ok := foundContainer . Ports [ 0 ] [ "PublicPort" ]
2015-11-19 03:37:42 +03:00
c . Assert ( ok , checker . Not ( checker . Equals ) , true )
2015-06-12 19:49:53 +03:00
_ , ok = foundContainer . Ports [ 0 ] [ "IP" ]
2015-11-19 03:37:42 +03:00
c . Assert ( ok , checker . Not ( checker . Equals ) , true )
2015-06-12 19:49:53 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIGetExport ( c * check . C ) {
2016-10-07 03:18:42 +03:00
// Not supported on Windows as Windows does not support docker export
2015-08-28 20:36:42 +03:00
testRequires ( c , DaemonIsLinux )
2014-10-22 02:48:32 +04:00
name := "exportcontainer"
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "run" , "--name" , name , "busybox" , "touch" , "/test" )
2014-10-15 01:32:25 +04:00
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "GET" , "/containers/" + name + "/export" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
2014-10-15 01:32:25 +04:00
found := false
for tarReader := tar . NewReader ( bytes . NewReader ( body ) ) ; ; {
h , err := tarReader . Next ( )
2015-11-19 03:37:42 +03:00
if err != nil && err == io . EOF {
break
2014-10-15 01:32:25 +04:00
}
if h . Name == "test" {
found = true
break
}
}
2015-11-19 03:37:42 +03:00
c . Assert ( found , checker . True , check . Commentf ( "The created test file has not been found in the exported image" ) )
2014-10-15 01:32:25 +04:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIGetChanges ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// Not supported on Windows as Windows does not support docker diff (/containers/name/changes)
2015-08-28 20:36:42 +03:00
testRequires ( c , DaemonIsLinux )
2014-10-22 02:48:32 +04:00
name := "changescontainer"
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "run" , "--name" , name , "busybox" , "rm" , "/etc/passwd" )
2014-10-15 01:32:25 +04:00
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "GET" , "/containers/" + name + "/changes" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
2014-10-15 01:32:25 +04:00
changes := [ ] struct {
Kind int
Path string
} { }
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( body , & changes ) , checker . IsNil , check . Commentf ( "unable to unmarshal response body" ) )
2014-10-15 01:32:25 +04:00
// Check the changelog for removal of /etc/passwd
success := false
for _ , elem := range changes {
if elem . Path == "/etc/passwd" && elem . Kind == 2 {
success = true
}
}
2015-11-19 03:37:42 +03:00
c . Assert ( success , checker . True , check . Commentf ( "/etc/passwd has been removed but is not present in the diff" ) )
2014-10-15 01:32:25 +04:00
}
2014-12-12 19:01:05 +03:00
2015-04-18 19:46:47 +03:00
func ( s * DockerSuite ) TestGetContainerStats ( c * check . C ) {
2015-01-21 23:14:28 +03:00
var (
2015-07-14 09:35:36 +03:00
name = "statscontainer"
2015-01-21 23:14:28 +03:00
)
2016-09-08 02:08:51 +03:00
runSleepingContainer ( c , "--name" , name )
2015-07-14 09:35:36 +03:00
2015-01-21 23:14:28 +03:00
type b struct {
2015-04-27 20:29:48 +03:00
status int
body [ ] byte
err error
2015-01-21 23:14:28 +03:00
}
bc := make ( chan b , 1 )
2015-01-20 03:10:26 +03:00
go func ( ) {
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "GET" , "/containers/" + name + "/stats" , nil , daemonHost ( ) )
2015-04-27 20:29:48 +03:00
bc <- b { status , body , err }
2015-01-20 03:10:26 +03:00
} ( )
2015-01-21 23:14:28 +03:00
// allow some time to stream the stats from the container
time . Sleep ( 4 * time . Second )
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "rm" , "-f" , name )
2015-01-20 03:10:26 +03:00
2015-01-21 23:14:28 +03:00
// collect the results from the stats stream or timeout and fail
// if the stream was not disconnected.
select {
case <- time . After ( 2 * time . Second ) :
2015-04-18 19:46:47 +03:00
c . Fatal ( "stream was not closed after container was removed" )
2015-01-21 23:14:28 +03:00
case sr := <- bc :
2015-11-19 03:37:42 +03:00
c . Assert ( sr . err , checker . IsNil )
c . Assert ( sr . status , checker . Equals , http . StatusOK )
2015-01-21 23:14:28 +03:00
dec := json . NewDecoder ( bytes . NewBuffer ( sr . body ) )
2015-02-24 21:47:47 +03:00
var s * types . Stats
2015-01-21 23:14:28 +03:00
// decode only one object from the stream
2015-11-19 03:37:42 +03:00
c . Assert ( dec . Decode ( & s ) , checker . IsNil )
2015-01-20 03:10:26 +03:00
}
}
2015-01-21 22:08:19 +03:00
2015-05-23 17:09:39 +03:00
func ( s * DockerSuite ) TestGetContainerStatsRmRunning ( c * check . C ) {
2016-09-08 02:08:51 +03:00
out , _ := runSleepingContainer ( c )
2015-05-27 05:22:03 +03:00
id := strings . TrimSpace ( out )
2017-02-28 19:12:30 +03:00
buf := & testutil . ChannelBuffer { C : make ( chan [ ] byte , 1 ) }
2015-05-27 05:22:03 +03:00
defer buf . Close ( )
2016-07-15 02:59:44 +03:00
2017-03-06 18:35:27 +03:00
_ , body , err := request . Get ( "/containers/" + id + "/stats?stream=1" , request . JSON )
2016-07-15 02:59:44 +03:00
c . Assert ( err , checker . IsNil )
defer body . Close ( )
2016-01-30 06:27:27 +03:00
chErr := make ( chan error , 1 )
2015-05-27 05:22:03 +03:00
go func ( ) {
_ , err = io . Copy ( buf , body )
chErr <- err
} ( )
b := make ( [ ] byte , 32 )
// make sure we've got some stats
2016-07-15 02:59:44 +03:00
_ , err = buf . ReadTimeout ( b , 2 * time . Second )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-05-27 05:22:03 +03:00
// Now remove without `-f` and make sure we are still pulling stats
2015-07-27 21:13:25 +03:00
_ , _ , err = dockerCmdWithError ( "rm" , id )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . Not ( checker . IsNil ) , check . Commentf ( "rm should have failed but didn't" ) )
2015-05-27 05:22:03 +03:00
_ , err = buf . ReadTimeout ( b , 2 * time . Second )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-05-27 05:22:03 +03:00
2016-07-15 02:59:44 +03:00
dockerCmd ( c , "rm" , "-f" , id )
c . Assert ( <- chErr , checker . IsNil )
2015-05-27 05:22:03 +03:00
}
2015-05-23 17:09:39 +03:00
// regression test for gh13421
// previous test was just checking one stat entry so it didn't fail (stats with
// stream false always return one stat)
func ( s * DockerSuite ) TestGetContainerStatsStream ( c * check . C ) {
name := "statscontainer"
2016-09-08 02:08:51 +03:00
runSleepingContainer ( c , "--name" , name )
2015-05-23 17:09:39 +03:00
type b struct {
status int
2017-02-28 19:12:30 +03:00
body io . ReadCloser
2015-05-23 17:09:39 +03:00
err error
}
bc := make ( chan b , 1 )
go func ( ) {
2017-03-06 18:35:27 +03:00
status , body , err := request . Get ( "/containers/" + name + "/stats" )
2017-02-28 19:12:30 +03:00
bc <- b { status . StatusCode , body , err }
2015-05-23 17:09:39 +03:00
} ( )
// allow some time to stream the stats from the container
time . Sleep ( 4 * time . Second )
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "rm" , "-f" , name )
2015-05-23 17:09:39 +03:00
// collect the results from the stats stream or timeout and fail
// if the stream was not disconnected.
select {
case <- time . After ( 2 * time . Second ) :
c . Fatal ( "stream was not closed after container was removed" )
case sr := <- bc :
2015-11-19 03:37:42 +03:00
c . Assert ( sr . err , checker . IsNil )
c . Assert ( sr . status , checker . Equals , http . StatusOK )
2015-05-23 17:09:39 +03:00
2017-02-28 19:12:30 +03:00
b , err := ioutil . ReadAll ( sr . body )
c . Assert ( err , checker . IsNil )
s := string ( b )
2015-05-23 17:09:39 +03:00
// count occurrences of "read" of types.Stats
if l := strings . Count ( s , "read" ) ; l < 2 {
c . Fatalf ( "Expected more than one stat streamed, got %d" , l )
}
}
}
func ( s * DockerSuite ) TestGetContainerStatsNoStream ( c * check . C ) {
name := "statscontainer"
2016-09-08 02:08:51 +03:00
runSleepingContainer ( c , "--name" , name )
2015-05-23 17:09:39 +03:00
type b struct {
status int
body [ ] byte
err error
}
bc := make ( chan b , 1 )
go func ( ) {
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "GET" , "/containers/" + name + "/stats?stream=0" , nil , daemonHost ( ) )
2015-05-23 17:09:39 +03:00
bc <- b { status , body , err }
} ( )
// allow some time to stream the stats from the container
time . Sleep ( 4 * time . Second )
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "rm" , "-f" , name )
2015-05-23 17:09:39 +03:00
// collect the results from the stats stream or timeout and fail
// if the stream was not disconnected.
select {
case <- time . After ( 2 * time . Second ) :
c . Fatal ( "stream was not closed after container was removed" )
case sr := <- bc :
2015-11-19 03:37:42 +03:00
c . Assert ( sr . err , checker . IsNil )
c . Assert ( sr . status , checker . Equals , http . StatusOK )
2015-05-23 17:09:39 +03:00
s := string ( sr . body )
2016-09-08 02:08:51 +03:00
// count occurrences of `"read"` of types.Stats
c . Assert ( strings . Count ( s , ` "read" ` ) , checker . Equals , 1 , check . Commentf ( "Expected only one stat streamed, got %d" , strings . Count ( s , ` "read" ` ) ) )
2015-05-23 17:09:39 +03:00
}
}
2015-04-18 19:46:47 +03:00
func ( s * DockerSuite ) TestGetStoppedContainerStats ( c * check . C ) {
2015-12-30 07:29:31 +03:00
name := "statscontainer"
2016-09-08 02:08:51 +03:00
dockerCmd ( c , "create" , "--name" , name , "busybox" , "ps" )
2015-03-16 14:55:34 +03:00
2015-12-30 07:29:31 +03:00
type stats struct {
status int
err error
}
chResp := make ( chan stats )
// We expect an immediate response, but if it's not immediate, the test would hang, so put it in a goroutine
// below we'll check this on a timeout.
2015-03-16 14:55:34 +03:00
go func ( ) {
2017-03-06 18:35:27 +03:00
resp , body , err := request . Get ( "/containers/" + name + "/stats" )
2015-12-30 07:29:31 +03:00
body . Close ( )
chResp <- stats { resp . StatusCode , err }
2015-03-16 14:55:34 +03:00
} ( )
2015-12-30 07:29:31 +03:00
select {
case r := <- chResp :
c . Assert ( r . err , checker . IsNil )
c . Assert ( r . status , checker . Equals , http . StatusOK )
case <- time . After ( 10 * time . Second ) :
2016-02-22 22:22:20 +03:00
c . Fatal ( "timeout waiting for stats response for stopped container" )
2015-12-30 07:29:31 +03:00
}
2015-03-16 14:55:34 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIPause ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// Problematic on Windows as Windows does not support pause
2015-08-28 20:36:42 +03:00
testRequires ( c , DaemonIsLinux )
2016-12-08 12:56:29 +03:00
defer unpauseAllContainers ( c )
2015-07-14 09:35:36 +03:00
out , _ := dockerCmd ( c , "run" , "-d" , "busybox" , "sleep" , "30" )
2015-04-10 04:14:01 +03:00
ContainerID := strings . TrimSpace ( out )
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "POST" , "/containers/" + ContainerID + "/pause" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNoContent )
2015-04-10 04:14:01 +03:00
2017-01-16 18:39:12 +03:00
pausedContainers := getPausedContainers ( c )
2015-04-10 04:14:01 +03:00
if len ( pausedContainers ) != 1 || stringid . TruncateID ( ContainerID ) != pausedContainers [ 0 ] {
2015-04-18 19:46:47 +03:00
c . Fatalf ( "there should be one paused container and not %d" , len ( pausedContainers ) )
2015-04-10 04:14:01 +03:00
}
2016-12-30 12:49:36 +03:00
status , _ , err = request . SockRequest ( "POST" , "/containers/" + ContainerID + "/unpause" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNoContent )
2015-04-10 04:14:01 +03:00
2017-01-16 18:39:12 +03:00
pausedContainers = getPausedContainers ( c )
2016-12-21 00:26:55 +03:00
c . Assert ( pausedContainers , checker . HasLen , 0 , check . Commentf ( "There should be no paused container." ) )
2015-04-10 04:14:01 +03:00
}
2015-04-15 00:14:29 +03:00
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPITop ( c * check . C ) {
2015-08-28 20:36:42 +03:00
testRequires ( c , DaemonIsLinux )
2015-07-14 09:35:36 +03:00
out , _ := dockerCmd ( c , "run" , "-d" , "busybox" , "/bin/sh" , "-c" , "top" )
2015-04-18 19:46:47 +03:00
id := strings . TrimSpace ( string ( out ) )
2015-11-19 03:37:42 +03:00
c . Assert ( waitRun ( id ) , checker . IsNil )
2015-04-15 00:14:29 +03:00
type topResp struct {
Titles [ ] string
Processes [ ] [ ] string
}
var top topResp
2016-12-30 12:49:36 +03:00
status , b , err := request . SockRequest ( "GET" , "/containers/" + id + "/top?ps_args=aux" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
c . Assert ( json . Unmarshal ( b , & top ) , checker . IsNil )
c . Assert ( top . Titles , checker . HasLen , 11 , check . Commentf ( "expected 11 titles, found %d: %v" , len ( top . Titles ) , top . Titles ) )
2015-04-15 00:14:29 +03:00
if top . Titles [ 0 ] != "USER" || top . Titles [ 10 ] != "COMMAND" {
2015-04-18 19:46:47 +03:00
c . Fatalf ( "expected `USER` at `Titles[0]` and `COMMAND` at Titles[10]: %v" , top . Titles )
2015-04-15 00:14:29 +03:00
}
2015-11-19 03:37:42 +03:00
c . Assert ( top . Processes , checker . HasLen , 2 , check . Commentf ( "expected 2 processes, found %d: %v" , len ( top . Processes ) , top . Processes ) )
c . Assert ( top . Processes [ 0 ] [ 10 ] , checker . Equals , "/bin/sh -c top" )
c . Assert ( top . Processes [ 1 ] [ 10 ] , checker . Equals , "top" )
2015-04-15 00:14:29 +03:00
}
2015-04-15 03:48:03 +03:00
2016-10-07 03:18:42 +03:00
func ( s * DockerSuite ) TestContainerAPITopWindows ( c * check . C ) {
testRequires ( c , DaemonIsWindows )
out , _ := runSleepingContainer ( c , "-d" )
id := strings . TrimSpace ( string ( out ) )
c . Assert ( waitRun ( id ) , checker . IsNil )
type topResp struct {
Titles [ ] string
Processes [ ] [ ] string
}
var top topResp
2016-12-30 12:49:36 +03:00
status , b , err := request . SockRequest ( "GET" , "/containers/" + id + "/top" , nil , daemonHost ( ) )
2016-10-07 03:18:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
c . Assert ( json . Unmarshal ( b , & top ) , checker . IsNil )
c . Assert ( top . Titles , checker . HasLen , 4 , check . Commentf ( "expected 4 titles, found %d: %v" , len ( top . Titles ) , top . Titles ) )
if top . Titles [ 0 ] != "Name" || top . Titles [ 3 ] != "Private Working Set" {
c . Fatalf ( "expected `Name` at `Titles[0]` and `Private Working Set` at Titles[3]: %v" , top . Titles )
}
c . Assert ( len ( top . Processes ) , checker . GreaterOrEqualThan , 2 , check . Commentf ( "expected at least 2 processes, found %d: %v" , len ( top . Processes ) , top . Processes ) )
foundProcess := false
expectedProcess := "busybox.exe"
for _ , process := range top . Processes {
if process [ 0 ] == expectedProcess {
foundProcess = true
break
}
}
c . Assert ( foundProcess , checker . Equals , true , check . Commentf ( "expected to find %s: %v" , expectedProcess , top . Processes ) )
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICommit ( c * check . C ) {
2015-04-25 15:46:47 +03:00
cName := "testapicommit"
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "run" , "--name=" + cName , "busybox" , "/bin/sh" , "-c" , "touch /test" )
2015-04-15 03:48:03 +03:00
2015-11-19 01:20:54 +03:00
name := "testcontainerapicommit"
2016-12-30 12:49:36 +03:00
status , b , err := request . SockRequest ( "POST" , "/commit?repo=" + name + "&testtag=tag&container=" + cName , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusCreated )
2015-04-15 03:48:03 +03:00
type resp struct {
2015-07-22 15:59:24 +03:00
ID string
2015-04-15 03:48:03 +03:00
}
var img resp
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( b , & img ) , checker . IsNil )
2015-04-15 03:48:03 +03:00
2016-01-28 17:19:25 +03:00
cmd := inspectField ( c , img . ID , "Config.Cmd" )
2016-02-29 14:28:37 +03:00
c . Assert ( cmd , checker . Equals , "[/bin/sh -c touch /test]" , check . Commentf ( "got wrong Cmd from commit: %q" , cmd ) )
2015-11-19 03:37:42 +03:00
2015-04-15 03:48:03 +03:00
// sanity check, make sure the image is what we think it is
2015-07-22 15:59:24 +03:00
dockerCmd ( c , "run" , img . ID , "ls" , "/test" )
2015-05-30 12:31:51 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICommitWithLabelInConfig ( c * check . C ) {
2015-05-30 12:31:51 +03:00
cName := "testapicommitwithconfig"
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "run" , "--name=" + cName , "busybox" , "/bin/sh" , "-c" , "touch /test" )
2015-05-30 12:31:51 +03:00
config := map [ string ] interface { } {
"Labels" : map [ string ] string { "key1" : "value1" , "key2" : "value2" } ,
}
2015-11-19 01:20:54 +03:00
name := "testcontainerapicommitwithconfig"
2016-12-30 12:49:36 +03:00
status , b , err := request . SockRequest ( "POST" , "/commit?repo=" + name + "&container=" + cName , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusCreated )
2015-05-30 12:31:51 +03:00
type resp struct {
2015-07-22 15:59:24 +03:00
ID string
2015-05-30 12:31:51 +03:00
}
var img resp
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( b , & img ) , checker . IsNil )
2015-05-30 12:31:51 +03:00
2016-01-28 17:19:25 +03:00
label1 := inspectFieldMap ( c , img . ID , "Config.Labels" , "key1" )
2015-11-19 03:37:42 +03:00
c . Assert ( label1 , checker . Equals , "value1" )
2015-05-30 12:31:51 +03:00
2016-01-28 17:19:25 +03:00
label2 := inspectFieldMap ( c , img . ID , "Config.Labels" , "key2" )
2015-11-19 03:37:42 +03:00
c . Assert ( label2 , checker . Equals , "value2" )
2015-05-30 12:31:51 +03:00
2016-01-28 17:19:25 +03:00
cmd := inspectField ( c , img . ID , "Config.Cmd" )
2016-02-29 14:28:37 +03:00
c . Assert ( cmd , checker . Equals , "[/bin/sh -c touch /test]" , check . Commentf ( "got wrong Cmd from commit: %q" , cmd ) )
2015-05-30 12:31:51 +03:00
// sanity check, make sure the image is what we think it is
2015-07-22 15:59:24 +03:00
dockerCmd ( c , "run" , img . ID , "ls" , "/test" )
2015-04-15 03:48:03 +03:00
}
2015-04-15 04:04:43 +03:00
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIBadPort ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// TODO Windows to Windows CI - Port this test
2015-08-28 20:36:42 +03:00
testRequires ( c , DaemonIsLinux )
2015-07-16 06:45:48 +03:00
config := map [ string ] interface { } {
"Image" : "busybox" ,
"Cmd" : [ ] string { "/bin/sh" , "-c" , "echo test" } ,
"PortBindings" : map [ string ] interface { } {
"8080/tcp" : [ ] map [ string ] interface { } {
{
2015-07-21 16:43:32 +03:00
"HostIP" : "" ,
2015-07-16 06:45:48 +03:00
"HostPort" : "aa80" ,
} ,
} ,
} ,
}
jsonData := bytes . NewBuffer ( nil )
json . NewEncoder ( jsonData ) . Encode ( config )
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusInternalServerError )
2016-06-09 18:32:20 +03:00
c . Assert ( getErrorMessage ( c , body ) , checker . Equals , ` invalid port specification: "aa80" ` , check . Commentf ( "Incorrect error msg: %s" , body ) )
2015-07-16 06:45:48 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICreate ( c * check . C ) {
2015-04-15 04:04:43 +03:00
config := map [ string ] interface { } {
"Image" : "busybox" ,
"Cmd" : [ ] string { "/bin/sh" , "-c" , "touch /test && ls /test" } ,
}
2016-12-30 12:49:36 +03:00
status , b , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusCreated )
2015-04-21 00:03:56 +03:00
2015-04-15 04:04:43 +03:00
type createResp struct {
2015-07-22 15:59:24 +03:00
ID string
2015-04-15 04:04:43 +03:00
}
var container createResp
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( b , & container ) , checker . IsNil )
2015-04-15 04:04:43 +03:00
2015-07-22 15:59:24 +03:00
out , _ := dockerCmd ( c , "start" , "-a" , container . ID )
2015-11-19 03:37:42 +03:00
c . Assert ( strings . TrimSpace ( out ) , checker . Equals , "/test" )
2015-04-15 04:04:43 +03:00
}
2015-04-15 04:55:04 +03:00
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICreateEmptyConfig ( c * check . C ) {
2015-06-06 19:41:42 +03:00
config := map [ string ] interface { } { }
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusInternalServerError )
2015-06-06 19:41:42 +03:00
2016-05-21 14:56:04 +03:00
expected := "Config cannot be empty in order to create a container"
c . Assert ( getErrorMessage ( c , body ) , checker . Equals , expected )
2015-06-06 19:41:42 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICreateMultipleNetworksConfig ( c * check . C ) {
2016-01-22 01:24:35 +03:00
// Container creation must fail if client specified configurations for more than one network
config := map [ string ] interface { } {
"Image" : "busybox" ,
"NetworkingConfig" : networktypes . NetworkingConfig {
EndpointsConfig : map [ string ] * networktypes . EndpointSettings {
"net1" : { } ,
"net2" : { } ,
"net3" : { } ,
} ,
} ,
}
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2016-01-22 01:24:35 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusBadRequest )
2016-05-21 14:56:04 +03:00
msg := getErrorMessage ( c , body )
2016-01-22 01:24:35 +03:00
// network name order in error message is not deterministic
2016-05-21 14:56:04 +03:00
c . Assert ( msg , checker . Contains , "Container cannot be connected to network endpoints" )
c . Assert ( msg , checker . Contains , "net1" )
c . Assert ( msg , checker . Contains , "net2" )
c . Assert ( msg , checker . Contains , "net3" )
2016-01-22 01:24:35 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICreateWithHostName ( c * check . C ) {
2015-04-25 11:53:38 +03:00
domainName := "test-domain"
2017-01-03 01:42:45 +03:00
hostName := "test-hostname"
2015-04-25 11:53:38 +03:00
config := map [ string ] interface { } {
"Image" : "busybox" ,
2017-01-03 01:42:45 +03:00
"Hostname" : hostName ,
2015-04-25 11:53:38 +03:00
"Domainname" : domainName ,
}
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusCreated )
2015-04-25 11:53:38 +03:00
2016-10-14 23:28:47 +03:00
var container containertypes . ContainerCreateCreatedBody
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( body , & container ) , checker . IsNil )
2015-04-25 11:53:38 +03:00
2016-12-30 12:49:36 +03:00
status , body , err = request . SockRequest ( "GET" , "/containers/" + container . ID + "/json" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
2015-04-25 11:53:38 +03:00
var containerJSON types . ContainerJSON
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( body , & containerJSON ) , checker . IsNil )
2017-01-03 01:42:45 +03:00
c . Assert ( containerJSON . Config . Hostname , checker . Equals , hostName , check . Commentf ( "Mismatched Hostname" ) )
2015-11-19 03:37:42 +03:00
c . Assert ( containerJSON . Config . Domainname , checker . Equals , domainName , check . Commentf ( "Mismatched Domainname" ) )
2015-04-25 11:53:38 +03:00
}
2015-04-22 14:03:57 +03:00
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICreateBridgeNetworkMode ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// Windows does not support bridge
2015-08-28 20:36:42 +03:00
testRequires ( c , DaemonIsLinux )
2015-04-25 11:53:38 +03:00
UtilCreateNetworkMode ( c , "bridge" )
2016-01-08 06:43:11 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICreateOtherNetworkModes ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// Windows does not support these network modes
2016-01-08 06:43:11 +03:00
testRequires ( c , DaemonIsLinux , NotUserNamespace )
UtilCreateNetworkMode ( c , "host" )
2015-04-25 11:53:38 +03:00
UtilCreateNetworkMode ( c , "container:web1" )
}
2015-04-22 14:03:57 +03:00
2015-04-25 11:53:38 +03:00
func UtilCreateNetworkMode ( c * check . C , networkMode string ) {
config := map [ string ] interface { } {
"Image" : "busybox" ,
"HostConfig" : map [ string ] interface { } { "NetworkMode" : networkMode } ,
2015-04-22 14:03:57 +03:00
}
2015-04-25 11:53:38 +03:00
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusCreated )
2015-04-25 11:53:38 +03:00
2016-10-14 23:28:47 +03:00
var container containertypes . ContainerCreateCreatedBody
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( body , & container ) , checker . IsNil )
2015-04-22 14:03:57 +03:00
2016-12-30 12:49:36 +03:00
status , body , err = request . SockRequest ( "GET" , "/containers/" + container . ID + "/json" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
2015-04-25 11:53:38 +03:00
var containerJSON types . ContainerJSON
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( body , & containerJSON ) , checker . IsNil )
2015-12-18 21:36:17 +03:00
c . Assert ( containerJSON . HostConfig . NetworkMode , checker . Equals , containertypes . NetworkMode ( networkMode ) , check . Commentf ( "Mismatched NetworkMode" ) )
2015-04-22 14:03:57 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICreateWithCpuSharesCpuset ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// TODO Windows to Windows CI. The CpuShares part could be ported.
2015-08-28 20:36:42 +03:00
testRequires ( c , DaemonIsLinux )
2015-05-16 00:00:54 +03:00
config := map [ string ] interface { } {
"Image" : "busybox" ,
"CpuShares" : 512 ,
2015-11-16 01:00:39 +03:00
"CpusetCpus" : "0" ,
2015-05-16 00:00:54 +03:00
}
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusCreated )
2015-05-16 00:00:54 +03:00
2016-10-14 23:28:47 +03:00
var container containertypes . ContainerCreateCreatedBody
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( body , & container ) , checker . IsNil )
2015-05-16 00:00:54 +03:00
2016-12-30 12:49:36 +03:00
status , body , err = request . SockRequest ( "GET" , "/containers/" + container . ID + "/json" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
2015-05-16 00:00:54 +03:00
2015-07-22 15:59:24 +03:00
var containerJSON types . ContainerJSON
2015-05-16 00:00:54 +03:00
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( body , & containerJSON ) , checker . IsNil )
2015-05-16 00:00:54 +03:00
2016-01-28 17:19:25 +03:00
out := inspectField ( c , containerJSON . ID , "HostConfig.CpuShares" )
2015-11-19 03:37:42 +03:00
c . Assert ( out , checker . Equals , "512" )
2015-05-16 00:00:54 +03:00
2016-01-28 17:19:25 +03:00
outCpuset := inspectField ( c , containerJSON . ID , "HostConfig.CpusetCpus" )
2015-11-19 03:37:42 +03:00
c . Assert ( outCpuset , checker . Equals , "0" )
2015-05-16 00:00:54 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIVerifyHeader ( c * check . C ) {
2015-04-15 04:55:04 +03:00
config := map [ string ] interface { } {
"Image" : "busybox" ,
}
2015-04-27 19:33:08 +03:00
create := func ( ct string ) ( * http . Response , io . ReadCloser , error ) {
2015-04-15 04:55:04 +03:00
jsonData := bytes . NewBuffer ( nil )
2015-11-19 03:37:42 +03:00
c . Assert ( json . NewEncoder ( jsonData ) . Encode ( config ) , checker . IsNil )
2017-03-06 18:35:27 +03:00
return request . Post ( "/containers/create" , request . RawContent ( ioutil . NopCloser ( jsonData ) ) , request . ContentType ( ct ) )
2015-04-15 04:55:04 +03:00
}
// Try with no content-type
2015-04-27 19:33:08 +03:00
res , body , err := create ( "" )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( res . StatusCode , checker . Equals , http . StatusInternalServerError )
2015-04-15 04:55:04 +03:00
body . Close ( )
2015-04-21 00:03:56 +03:00
2015-04-15 04:55:04 +03:00
// Try with wrong content-type
2015-04-27 19:33:08 +03:00
res , body , err = create ( "application/xml" )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( res . StatusCode , checker . Equals , http . StatusInternalServerError )
2015-04-15 04:55:04 +03:00
body . Close ( )
// now application/json
2015-04-27 19:33:08 +03:00
res , body , err = create ( "application/json" )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( res . StatusCode , checker . Equals , http . StatusCreated )
2015-04-15 04:55:04 +03:00
body . Close ( )
}
2015-04-15 05:07:04 +03:00
2015-06-28 13:16:24 +03:00
//Issue 14230. daemon should return 500 for invalid port syntax
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIInvalidPortSyntax ( c * check . C ) {
2015-06-28 13:16:24 +03:00
config := ` {
"Image" : "busybox" ,
"HostConfig" : {
2016-01-23 22:04:57 +03:00
"NetworkMode" : "default" ,
2015-06-28 13:16:24 +03:00
"PortBindings" : {
"19039;1230" : [
{ }
]
}
}
} `
2017-03-06 18:35:27 +03:00
res , body , err := request . Post ( "/containers/create" , request . RawString ( config ) , request . JSON )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( res . StatusCode , checker . Equals , http . StatusInternalServerError )
2015-06-28 13:16:24 +03:00
2016-12-30 20:23:00 +03:00
b , err := testutil . ReadBody ( body )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2016-06-09 18:32:20 +03:00
c . Assert ( string ( b [ : ] ) , checker . Contains , "invalid port" )
2015-06-28 13:16:24 +03:00
}
2016-12-02 00:24:30 +03:00
func ( s * DockerSuite ) TestContainerAPIRestartPolicyInvalidPolicyName ( c * check . C ) {
2016-06-29 01:33:55 +03:00
config := ` {
"Image" : "busybox" ,
"HostConfig" : {
"RestartPolicy" : {
"Name" : "something" ,
"MaximumRetryCount" : 0
}
}
} `
2017-03-06 18:35:27 +03:00
res , body , err := request . Post ( "/containers/create" , request . RawString ( config ) , request . JSON )
2016-06-29 01:33:55 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( res . StatusCode , checker . Equals , http . StatusInternalServerError )
2016-12-30 20:23:00 +03:00
b , err := testutil . ReadBody ( body )
2016-06-29 01:33:55 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( string ( b [ : ] ) , checker . Contains , "invalid restart policy" )
}
2016-12-02 00:24:30 +03:00
func ( s * DockerSuite ) TestContainerAPIRestartPolicyRetryMismatch ( c * check . C ) {
2016-06-29 01:33:55 +03:00
config := ` {
"Image" : "busybox" ,
"HostConfig" : {
"RestartPolicy" : {
"Name" : "always" ,
"MaximumRetryCount" : 2
}
}
} `
2017-03-06 18:35:27 +03:00
res , body , err := request . Post ( "/containers/create" , request . RawString ( config ) , request . JSON )
2016-06-29 01:33:55 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( res . StatusCode , checker . Equals , http . StatusInternalServerError )
2016-12-30 20:23:00 +03:00
b , err := testutil . ReadBody ( body )
2016-06-29 01:33:55 +03:00
c . Assert ( err , checker . IsNil )
2016-12-02 00:24:30 +03:00
c . Assert ( string ( b [ : ] ) , checker . Contains , "maximum retry count cannot be used with restart policy" )
2016-06-29 01:33:55 +03:00
}
2016-12-02 00:24:30 +03:00
func ( s * DockerSuite ) TestContainerAPIRestartPolicyNegativeRetryCount ( c * check . C ) {
2016-06-29 01:33:55 +03:00
config := ` {
"Image" : "busybox" ,
"HostConfig" : {
"RestartPolicy" : {
"Name" : "on-failure" ,
"MaximumRetryCount" : - 2
}
}
} `
2017-03-06 18:35:27 +03:00
res , body , err := request . Post ( "/containers/create" , request . RawString ( config ) , request . JSON )
2016-06-29 01:33:55 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( res . StatusCode , checker . Equals , http . StatusInternalServerError )
2016-12-30 20:23:00 +03:00
b , err := testutil . ReadBody ( body )
2016-06-29 01:33:55 +03:00
c . Assert ( err , checker . IsNil )
2016-12-02 00:24:30 +03:00
c . Assert ( string ( b [ : ] ) , checker . Contains , "maximum retry count cannot be negative" )
}
func ( s * DockerSuite ) TestContainerAPIRestartPolicyDefaultRetryCount ( c * check . C ) {
config := ` {
"Image" : "busybox" ,
"HostConfig" : {
"RestartPolicy" : {
"Name" : "on-failure" ,
"MaximumRetryCount" : 0
}
}
} `
2017-03-06 18:35:27 +03:00
res , _ , err := request . Post ( "/containers/create" , request . RawString ( config ) , request . JSON )
2016-12-02 00:24:30 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( res . StatusCode , checker . Equals , http . StatusCreated )
2016-06-29 01:33:55 +03:00
}
2015-04-15 05:07:04 +03:00
// Issue 7941 - test to make sure a "null" in JSON is just ignored.
// W/o this fix a null in JSON would be parsed into a string var as "null"
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIPostCreateNull ( c * check . C ) {
2015-04-15 05:07:04 +03:00
config := ` {
"Hostname" : "" ,
"Domainname" : "" ,
"Memory" : 0 ,
"MemorySwap" : 0 ,
"CpuShares" : 0 ,
"Cpuset" : null ,
"AttachStdin" : true ,
"AttachStdout" : true ,
"AttachStderr" : true ,
"ExposedPorts" : { } ,
"Tty" : true ,
"OpenStdin" : true ,
"StdinOnce" : true ,
"Env" : [ ] ,
"Cmd" : "ls" ,
"Image" : "busybox" ,
"Volumes" : { } ,
"WorkingDir" : "" ,
"Entrypoint" : null ,
"NetworkDisabled" : false ,
"OnBuild" : null } `
2017-03-06 18:35:27 +03:00
res , body , err := request . Post ( "/containers/create" , request . RawString ( config ) , request . JSON )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( res . StatusCode , checker . Equals , http . StatusCreated )
2015-04-15 05:07:04 +03:00
2016-12-30 20:23:00 +03:00
b , err := testutil . ReadBody ( body )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-04-15 05:07:04 +03:00
type createResp struct {
2015-07-22 15:59:24 +03:00
ID string
2015-04-15 05:07:04 +03:00
}
var container createResp
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( b , & container ) , checker . IsNil )
2016-01-28 17:19:25 +03:00
out := inspectField ( c , container . ID , "HostConfig.CpusetCpus" )
2015-11-19 03:37:42 +03:00
c . Assert ( out , checker . Equals , "" )
2015-05-12 09:30:16 +03:00
2016-01-28 17:19:25 +03:00
outMemory := inspectField ( c , container . ID , "HostConfig.Memory" )
2015-11-19 03:37:42 +03:00
c . Assert ( outMemory , checker . Equals , "0" )
2016-01-28 17:19:25 +03:00
outMemorySwap := inspectField ( c , container . ID , "HostConfig.MemorySwap" )
2015-11-19 03:37:42 +03:00
c . Assert ( outMemorySwap , checker . Equals , "0" )
2015-04-15 05:07:04 +03:00
}
2015-04-16 01:43:18 +03:00
2015-04-18 19:46:47 +03:00
func ( s * DockerSuite ) TestCreateWithTooLowMemoryLimit ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// TODO Windows: Port once memory is supported
2015-08-28 20:36:42 +03:00
testRequires ( c , DaemonIsLinux )
2015-04-16 01:43:18 +03:00
config := ` {
"Image" : "busybox" ,
"Cmd" : "ls" ,
"OpenStdin" : true ,
"CpuShares" : 100 ,
"Memory" : 524287
} `
2017-03-06 18:35:27 +03:00
res , body , err := request . Post ( "/containers/create" , request . RawString ( config ) , request . JSON )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2016-12-30 20:23:00 +03:00
b , err2 := testutil . ReadBody ( body )
2015-11-19 03:37:42 +03:00
c . Assert ( err2 , checker . IsNil )
2015-04-16 01:43:18 +03:00
2015-11-19 03:37:42 +03:00
c . Assert ( res . StatusCode , checker . Equals , http . StatusInternalServerError )
c . Assert ( string ( b ) , checker . Contains , "Minimum memory limit allowed is 4MB" )
2015-04-16 01:43:18 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIRename ( c * check . C ) {
out , _ := dockerCmd ( c , "run" , "--name" , "TestContainerAPIRename" , "-d" , "busybox" , "sh" )
2015-04-24 14:57:04 +03:00
containerID := strings . TrimSpace ( out )
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
newName := "TestContainerAPIRenameNew"
2016-12-30 12:49:36 +03:00
statusCode , _ , err := request . SockRequest ( "POST" , "/containers/" + containerID + "/rename?name=" + newName , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-04-24 14:57:04 +03:00
// 204 No Content is expected, not 200
2015-11-19 03:37:42 +03:00
c . Assert ( statusCode , checker . Equals , http . StatusNoContent )
2015-04-24 14:57:04 +03:00
2016-01-28 17:19:25 +03:00
name := inspectField ( c , containerID , "Name" )
2015-11-19 03:37:42 +03:00
c . Assert ( name , checker . Equals , "/" + newName , check . Commentf ( "Failed to rename container" ) )
2015-04-24 14:57:04 +03:00
}
2015-04-29 14:56:45 +03:00
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIKill ( c * check . C ) {
2015-04-29 14:56:45 +03:00
name := "test-api-kill"
2016-01-27 07:16:36 +03:00
runSleepingContainer ( c , "-i" , "--name" , name )
2015-04-29 14:56:45 +03:00
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "POST" , "/containers/" + name + "/kill" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNoContent )
2015-04-29 14:56:45 +03:00
2016-01-28 17:19:25 +03:00
state := inspectField ( c , name , "State.Running" )
2015-11-19 03:37:42 +03:00
c . Assert ( state , checker . Equals , "false" , check . Commentf ( "got wrong State from container %s: %q" , name , state ) )
2015-04-29 14:56:45 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIRestart ( c * check . C ) {
2015-04-29 14:56:45 +03:00
name := "test-api-restart"
2016-10-07 03:18:42 +03:00
runSleepingContainer ( c , "-di" , "--name" , name )
2015-04-29 14:56:45 +03:00
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "POST" , "/containers/" + name + "/restart?t=1" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNoContent )
2016-10-07 03:18:42 +03:00
c . Assert ( waitInspect ( name , "{{ .State.Restarting }} {{ .State.Running }}" , "false true" , 15 * time . Second ) , checker . IsNil )
2015-04-29 14:56:45 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIRestartNotimeoutParam ( c * check . C ) {
2015-05-07 02:49:16 +03:00
name := "test-api-restart-no-timeout-param"
2016-10-07 03:18:42 +03:00
out , _ := runSleepingContainer ( c , "-di" , "--name" , name )
2015-05-07 02:49:16 +03:00
id := strings . TrimSpace ( out )
2015-11-19 03:37:42 +03:00
c . Assert ( waitRun ( id ) , checker . IsNil )
2015-05-07 02:49:16 +03:00
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "POST" , "/containers/" + name + "/restart" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNoContent )
2016-10-07 03:18:42 +03:00
c . Assert ( waitInspect ( name , "{{ .State.Restarting }} {{ .State.Running }}" , "false true" , 15 * time . Second ) , checker . IsNil )
2015-05-07 02:49:16 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIStart ( c * check . C ) {
2015-04-29 14:56:45 +03:00
name := "testing-start"
config := map [ string ] interface { } {
"Image" : "busybox" ,
2016-08-18 01:46:28 +03:00
"Cmd" : append ( [ ] string { "/bin/sh" , "-c" } , sleepCommandForDaemonPlatform ( ) ... ) ,
2015-04-29 14:56:45 +03:00
"OpenStdin" : true ,
}
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "POST" , "/containers/create?name=" + name , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusCreated )
2015-04-29 14:56:45 +03:00
2016-12-30 12:49:36 +03:00
status , _ , err = request . SockRequest ( "POST" , "/containers/" + name + "/start" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNoContent )
2015-04-29 14:56:45 +03:00
// second call to start should give 304
2016-12-30 12:49:36 +03:00
status , _ , err = request . SockRequest ( "POST" , "/containers/" + name + "/start" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2016-02-25 01:59:11 +03:00
// TODO(tibor): figure out why this doesn't work on windows
2017-01-13 19:23:28 +03:00
if testEnv . LocalDaemon ( ) {
2016-02-25 01:59:11 +03:00
c . Assert ( status , checker . Equals , http . StatusNotModified )
}
2015-04-29 14:56:45 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIStop ( c * check . C ) {
2015-04-29 14:56:45 +03:00
name := "test-api-stop"
2016-01-27 07:16:36 +03:00
runSleepingContainer ( c , "-i" , "--name" , name )
2015-04-29 14:56:45 +03:00
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "POST" , "/containers/" + name + "/stop?t=30" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNoContent )
2016-01-23 22:04:57 +03:00
c . Assert ( waitInspect ( name , "{{ .State.Running }}" , "false" , 60 * time . Second ) , checker . IsNil )
2015-04-29 14:56:45 +03:00
// second call to start should give 304
2016-12-30 12:49:36 +03:00
status , _ , err = request . SockRequest ( "POST" , "/containers/" + name + "/stop?t=30" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNotModified )
2015-04-29 14:56:45 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIWait ( c * check . C ) {
2015-04-29 14:56:45 +03:00
name := "test-api-wait"
2016-01-27 07:16:36 +03:00
sleepCmd := "/bin/sleep"
2017-01-13 19:23:28 +03:00
if testEnv . DaemonPlatform ( ) == "windows" {
2016-01-27 07:16:36 +03:00
sleepCmd = "sleep"
}
2016-08-04 01:25:27 +03:00
dockerCmd ( c , "run" , "--name" , name , "busybox" , sleepCmd , "2" )
2015-04-29 14:56:45 +03:00
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/" + name + "/wait" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
2016-01-23 22:04:57 +03:00
c . Assert ( waitInspect ( name , "{{ .State.Running }}" , "false" , 60 * time . Second ) , checker . IsNil )
2015-04-29 14:56:45 +03:00
2016-10-21 01:56:27 +03:00
var waitres containertypes . ContainerWaitOKBody
2015-11-19 03:37:42 +03:00
c . Assert ( json . Unmarshal ( body , & waitres ) , checker . IsNil )
2016-10-21 01:56:27 +03:00
c . Assert ( waitres . StatusCode , checker . Equals , int64 ( 0 ) )
2015-04-29 14:56:45 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICopyNotExistsAnyMore ( c * check . C ) {
2015-04-29 14:56:45 +03:00
name := "test-container-api-copy"
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "run" , "--name" , name , "busybox" , "touch" , "/test.txt" )
2015-04-29 14:56:45 +03:00
postData := types . CopyConfig {
Resource : "/test.txt" ,
}
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "POST" , "/containers/" + name + "/copy" , postData , daemonHost ( ) )
2016-06-03 20:38:03 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNotFound )
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICopyPre124 ( c * check . C ) {
2016-10-31 20:15:43 +03:00
testRequires ( c , DaemonIsLinux ) // Windows only supports 1.25 or later
2016-06-03 20:38:03 +03:00
name := "test-container-api-copy"
dockerCmd ( c , "run" , "--name" , name , "busybox" , "touch" , "/test.txt" )
postData := types . CopyConfig {
Resource : "/test.txt" ,
}
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/v1.23/containers/" + name + "/copy" , postData , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
2015-04-29 14:56:45 +03:00
found := false
for tarReader := tar . NewReader ( bytes . NewReader ( body ) ) ; ; {
h , err := tarReader . Next ( )
if err != nil {
if err == io . EOF {
break
}
c . Fatal ( err )
}
if h . Name == "test.txt" {
found = true
break
}
}
2015-11-19 03:37:42 +03:00
c . Assert ( found , checker . True )
2015-04-29 14:56:45 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICopyResourcePathEmptyPr124 ( c * check . C ) {
2016-10-31 20:15:43 +03:00
testRequires ( c , DaemonIsLinux ) // Windows only supports 1.25 or later
2015-04-29 14:56:45 +03:00
name := "test-container-api-copy-resource-empty"
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "run" , "--name" , name , "busybox" , "touch" , "/test.txt" )
2015-04-29 14:56:45 +03:00
postData := types . CopyConfig {
Resource : "" ,
}
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/v1.23/containers/" + name + "/copy" , postData , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusInternalServerError )
c . Assert ( string ( body ) , checker . Matches , "Path cannot be empty\n" )
2015-04-29 14:56:45 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICopyResourcePathNotFoundPre124 ( c * check . C ) {
2016-10-31 20:15:43 +03:00
testRequires ( c , DaemonIsLinux ) // Windows only supports 1.25 or later
2015-04-29 14:56:45 +03:00
name := "test-container-api-copy-resource-not-found"
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "run" , "--name" , name , "busybox" )
2015-04-29 14:56:45 +03:00
postData := types . CopyConfig {
Resource : "/notexist" ,
}
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/v1.23/containers/" + name + "/copy" , postData , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusInternalServerError )
c . Assert ( string ( body ) , checker . Matches , "Could not find the file /notexist in container " + name + "\n" )
2015-04-29 14:56:45 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICopyContainerNotFoundPr124 ( c * check . C ) {
2016-10-31 20:15:43 +03:00
testRequires ( c , DaemonIsLinux ) // Windows only supports 1.25 or later
2015-04-29 14:56:45 +03:00
postData := types . CopyConfig {
Resource : "/something" ,
}
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "POST" , "/v1.23/containers/notexists/copy" , postData , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNotFound )
2015-04-29 14:56:45 +03:00
}
2015-05-03 15:54:55 +03:00
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIDelete ( c * check . C ) {
2016-01-27 07:16:36 +03:00
out , _ := runSleepingContainer ( c )
2015-05-03 15:54:55 +03:00
id := strings . TrimSpace ( out )
2015-11-19 03:37:42 +03:00
c . Assert ( waitRun ( id ) , checker . IsNil )
2015-05-03 15:54:55 +03:00
2015-07-14 09:35:36 +03:00
dockerCmd ( c , "stop" , id )
2015-05-03 15:54:55 +03:00
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "DELETE" , "/containers/" + id , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNoContent )
2015-05-03 15:54:55 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIDeleteNotExist ( c * check . C ) {
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "DELETE" , "/containers/doesnotexist" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNotFound )
2016-05-21 14:56:04 +03:00
c . Assert ( getErrorMessage ( c , body ) , checker . Matches , "No such container: doesnotexist" )
2015-05-03 15:54:55 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIDeleteForce ( c * check . C ) {
2016-01-27 07:16:36 +03:00
out , _ := runSleepingContainer ( c )
2015-05-03 15:54:55 +03:00
id := strings . TrimSpace ( out )
2015-11-19 03:37:42 +03:00
c . Assert ( waitRun ( id ) , checker . IsNil )
2015-05-03 15:54:55 +03:00
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "DELETE" , "/containers/" + id + "?force=1" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNoContent )
2015-05-03 15:54:55 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIDeleteRemoveLinks ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// Windows does not support links
2015-08-28 20:36:42 +03:00
testRequires ( c , DaemonIsLinux )
2015-07-14 09:35:36 +03:00
out , _ := dockerCmd ( c , "run" , "-d" , "--name" , "tlink1" , "busybox" , "top" )
2015-05-03 15:54:55 +03:00
id := strings . TrimSpace ( out )
2015-11-19 03:37:42 +03:00
c . Assert ( waitRun ( id ) , checker . IsNil )
2015-05-03 15:54:55 +03:00
2015-07-14 09:35:36 +03:00
out , _ = dockerCmd ( c , "run" , "--link" , "tlink1:tlink1" , "--name" , "tlink2" , "-d" , "busybox" , "top" )
2015-05-03 15:54:55 +03:00
id2 := strings . TrimSpace ( out )
2015-11-19 03:37:42 +03:00
c . Assert ( waitRun ( id2 ) , checker . IsNil )
2015-05-03 15:54:55 +03:00
2016-01-28 17:19:25 +03:00
links := inspectFieldJSON ( c , id2 , "HostConfig.Links" )
2015-11-19 03:37:42 +03:00
c . Assert ( links , checker . Equals , "[\"/tlink1:/tlink2/tlink1\"]" , check . Commentf ( "expected to have links between containers" ) )
2015-05-03 15:54:55 +03:00
2016-12-30 12:49:36 +03:00
status , b , err := request . SockRequest ( "DELETE" , "/containers/tlink2/tlink1?link=1" , nil , daemonHost ( ) )
2015-09-04 03:51:04 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusNoContent , check . Commentf ( string ( b ) ) )
2015-05-03 15:54:55 +03:00
2016-01-28 17:19:25 +03:00
linksPostRm := inspectFieldJSON ( c , id2 , "HostConfig.Links" )
2015-11-19 03:37:42 +03:00
c . Assert ( linksPostRm , checker . Equals , "null" , check . Commentf ( "call to api deleteContainer links should have removed the specified links" ) )
2015-05-03 15:54:55 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIDeleteConflict ( c * check . C ) {
2016-01-27 07:16:36 +03:00
out , _ := runSleepingContainer ( c )
2015-05-03 15:54:55 +03:00
id := strings . TrimSpace ( out )
2015-11-19 03:37:42 +03:00
c . Assert ( waitRun ( id ) , checker . IsNil )
2015-05-03 15:54:55 +03:00
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "DELETE" , "/containers/" + id , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusConflict )
2015-05-03 15:54:55 +03:00
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIDeleteRemoveVolume ( c * check . C ) {
2015-05-03 15:54:55 +03:00
testRequires ( c , SameHostDaemon )
2016-01-23 22:04:57 +03:00
vol := "/testvolume"
2017-01-13 19:23:28 +03:00
if testEnv . DaemonPlatform ( ) == "windows" {
2016-01-23 22:04:57 +03:00
vol = ` c:\testvolume `
}
2016-01-27 07:16:36 +03:00
out , _ := runSleepingContainer ( c , "-v" , vol )
2015-05-03 15:54:55 +03:00
id := strings . TrimSpace ( out )
2015-11-19 03:37:42 +03:00
c . Assert ( waitRun ( id ) , checker . IsNil )
2015-05-03 15:54:55 +03:00
2016-01-23 22:04:57 +03:00
source , err := inspectMountSourceField ( id , vol )
2015-06-03 22:21:38 +03:00
_ , err = os . Stat ( source )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-05-03 15:54:55 +03:00
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "DELETE" , "/containers/" + id + "?v=1&force=1" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNoContent )
_ , err = os . Stat ( source )
c . Assert ( os . IsNotExist ( err ) , checker . True , check . Commentf ( "expected to get ErrNotExist error, got %v" , err ) )
2015-05-03 15:54:55 +03:00
}
2015-04-29 20:48:30 +03:00
// Regression test for https://github.com/docker/docker/issues/6231
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIChunkedEncoding ( c * check . C ) {
2015-04-29 20:48:30 +03:00
2016-05-07 13:05:26 +03:00
config := map [ string ] interface { } {
"Image" : "busybox" ,
2016-08-18 01:46:28 +03:00
"Cmd" : append ( [ ] string { "/bin/sh" , "-c" } , sleepCommandForDaemonPlatform ( ) ... ) ,
2016-05-07 13:05:26 +03:00
"OpenStdin" : true ,
}
2017-03-06 18:35:27 +03:00
resp , _ , err := request . Post ( "/containers/create" , request . JSONBody ( config ) , func ( req * http . Request ) error {
2016-12-30 12:49:36 +03:00
// This is a cheat to make the http request do chunked encoding
// Otherwise (just setting the Content-Encoding to chunked) net/http will overwrite
// https://golang.org/src/pkg/net/http/request.go?s=11980:12172
req . ContentLength = - 1
return nil
} )
2016-05-07 13:05:26 +03:00
c . Assert ( err , checker . IsNil , check . Commentf ( "error creating container with chunked encoding" ) )
2017-01-11 23:38:52 +03:00
defer resp . Body . Close ( )
2016-05-07 13:05:26 +03:00
c . Assert ( resp . StatusCode , checker . Equals , http . StatusCreated )
2015-04-29 20:48:30 +03:00
}
2015-04-27 21:55:11 +03:00
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIPostContainerStop ( c * check . C ) {
2016-01-27 07:16:36 +03:00
out , _ := runSleepingContainer ( c )
2015-04-27 21:55:11 +03:00
containerID := strings . TrimSpace ( out )
2015-11-19 03:37:42 +03:00
c . Assert ( waitRun ( containerID ) , checker . IsNil )
2015-04-27 21:55:11 +03:00
2016-12-30 12:49:36 +03:00
statusCode , _ , err := request . SockRequest ( "POST" , "/containers/" + containerID + "/stop" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-04-27 21:55:11 +03:00
// 204 No Content is expected, not 200
2015-11-19 03:37:42 +03:00
c . Assert ( statusCode , checker . Equals , http . StatusNoContent )
2016-04-12 06:48:00 +03:00
c . Assert ( waitInspect ( containerID , "{{ .State.Running }}" , "false" , 60 * time . Second ) , checker . IsNil )
2015-04-27 21:55:11 +03:00
}
2015-06-26 08:15:57 +03:00
// #14170
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestPostContainerAPICreateWithStringOrSliceEntrypoint ( c * check . C ) {
2015-06-26 08:15:57 +03:00
config := struct {
Image string
Entrypoint string
Cmd [ ] string
} { "busybox" , "echo" , [ ] string { "hello" , "world" } }
2016-12-30 12:49:36 +03:00
_ , _ , err := request . SockRequest ( "POST" , "/containers/create?name=echotest" , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-06-26 08:15:57 +03:00
out , _ := dockerCmd ( c , "start" , "-a" , "echotest" )
2015-11-19 03:37:42 +03:00
c . Assert ( strings . TrimSpace ( out ) , checker . Equals , "hello world" )
2015-06-26 08:15:57 +03:00
config2 := struct {
Image string
Entrypoint [ ] string
Cmd [ ] string
} { "busybox" , [ ] string { "echo" } , [ ] string { "hello" , "world" } }
2016-12-30 12:49:36 +03:00
_ , _ , err = request . SockRequest ( "POST" , "/containers/create?name=echotest2" , config2 , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-06-26 08:15:57 +03:00
out , _ = dockerCmd ( c , "start" , "-a" , "echotest2" )
2015-11-19 03:37:42 +03:00
c . Assert ( strings . TrimSpace ( out ) , checker . Equals , "hello world" )
2015-06-26 08:15:57 +03:00
}
// #14170
func ( s * DockerSuite ) TestPostContainersCreateWithStringOrSliceCmd ( c * check . C ) {
config := struct {
Image string
Entrypoint string
Cmd string
} { "busybox" , "echo" , "hello world" }
2016-12-30 12:49:36 +03:00
_ , _ , err := request . SockRequest ( "POST" , "/containers/create?name=echotest" , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-06-26 08:15:57 +03:00
out , _ := dockerCmd ( c , "start" , "-a" , "echotest" )
2015-11-19 03:37:42 +03:00
c . Assert ( strings . TrimSpace ( out ) , checker . Equals , "hello world" )
2015-06-26 08:15:57 +03:00
config2 := struct {
Image string
Cmd [ ] string
} { "busybox" , [ ] string { "echo" , "hello" , "world" } }
2016-12-30 12:49:36 +03:00
_ , _ , err = request . SockRequest ( "POST" , "/containers/create?name=echotest2" , config2 , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-06-26 08:15:57 +03:00
out , _ = dockerCmd ( c , "start" , "-a" , "echotest2" )
2015-11-19 03:37:42 +03:00
c . Assert ( strings . TrimSpace ( out ) , checker . Equals , "hello world" )
2015-06-26 08:15:57 +03:00
}
2015-07-01 20:59:18 +03:00
// regression #14318
func ( s * DockerSuite ) TestPostContainersCreateWithStringOrSliceCapAddDrop ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// Windows doesn't support CapAdd/CapDrop
2015-08-28 20:36:42 +03:00
testRequires ( c , DaemonIsLinux )
2015-07-01 20:59:18 +03:00
config := struct {
Image string
CapAdd string
CapDrop string
} { "busybox" , "NET_ADMIN" , "SYS_ADMIN" }
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "POST" , "/containers/create?name=capaddtest0" , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusCreated )
2015-07-01 20:59:18 +03:00
config2 := struct {
Image string
CapAdd [ ] string
CapDrop [ ] string
} { "busybox" , [ ] string { "NET_ADMIN" , "SYS_ADMIN" } , [ ] string { "SETGID" } }
2016-12-30 12:49:36 +03:00
status , _ , err = request . SockRequest ( "POST" , "/containers/create?name=capaddtest1" , config2 , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusCreated )
2015-07-01 20:59:18 +03:00
}
2015-07-21 22:18:56 +03:00
2015-07-25 14:39:13 +03:00
// #14915
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICreateNoHostConfig118 ( c * check . C ) {
2016-10-31 20:15:43 +03:00
testRequires ( c , DaemonIsLinux ) // Windows only support 1.25 or later
2015-07-25 14:39:13 +03:00
config := struct {
Image string
} { "busybox" }
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "POST" , "/v1.18/containers/create" , config , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusCreated )
2015-07-25 14:39:13 +03:00
}
2015-07-25 00:12:55 +03:00
// Ensure an error occurs when you have a container read-only rootfs but you
// extract an archive to a symlink in a writable volume which points to a
// directory outside of the volume.
func ( s * DockerSuite ) TestPutContainerArchiveErrSymlinkInVolumeToReadOnlyRootfs ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// Windows does not support read-only rootfs
2015-09-18 20:41:12 +03:00
// Requires local volume mount bind.
// --read-only + userns has remount issues
2016-01-09 00:49:43 +03:00
testRequires ( c , SameHostDaemon , NotUserNamespace , DaemonIsLinux )
2015-07-25 00:12:55 +03:00
testVol := getTestDir ( c , "test-put-container-archive-err-symlink-in-volume-to-read-only-rootfs-" )
defer os . RemoveAll ( testVol )
makeTestContentInDir ( c , testVol )
cID := makeTestContainer ( c , testContainerOptions {
readOnly : true ,
volumes : defaultVolumes ( testVol ) , // Our bind mount is at /vol2
} )
2017-03-03 17:44:22 +03:00
defer deleteContainer ( cID )
2015-07-25 00:12:55 +03:00
// Attempt to extract to a symlink in the volume which points to a
// directory outside the volume. This should cause an error because the
// rootfs is read-only.
query := make ( url . Values , 1 )
query . Set ( "path" , "/vol2/symlinkToAbsDir" )
urlPath := fmt . Sprintf ( "/v1.20/containers/%s/archive?%s" , cID , query . Encode ( ) )
2016-12-30 12:49:36 +03:00
statusCode , body , err := request . SockRequest ( "PUT" , urlPath , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
2015-07-25 00:12:55 +03:00
if ! isCpCannotCopyReadOnly ( fmt . Errorf ( string ( body ) ) ) {
c . Fatalf ( "expected ErrContainerRootfsReadonly error, but got %d: %s" , statusCode , string ( body ) )
}
}
2015-09-18 19:39:14 +03:00
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIGetContainersJSONEmpty ( c * check . C ) {
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "GET" , "/containers/json?all=1" , nil , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusOK )
c . Assert ( string ( body ) , checker . Equals , "[]\n" )
2015-09-18 19:39:14 +03:00
}
2015-09-08 21:40:55 +03:00
func ( s * DockerSuite ) TestPostContainersCreateWithWrongCpusetValues ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// Not supported on Windows
2015-09-08 21:40:55 +03:00
testRequires ( c , DaemonIsLinux )
c1 := struct {
Image string
CpusetCpus string
} { "busybox" , "1-42,," }
name := "wrong-cpuset-cpus"
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create?name=" + name , c1 , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusInternalServerError )
2016-05-21 14:56:04 +03:00
expected := "Invalid value 1-42,, for cpuset cpus"
c . Assert ( getErrorMessage ( c , body ) , checker . Equals , expected )
2015-09-08 21:40:55 +03:00
c2 := struct {
Image string
CpusetMems string
} { "busybox" , "42-3,1--" }
name = "wrong-cpuset-mems"
2016-12-30 12:49:36 +03:00
status , body , err = request . SockRequest ( "POST" , "/containers/create?name=" + name , c2 , daemonHost ( ) )
2015-11-19 03:37:42 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusInternalServerError )
2016-05-21 14:56:04 +03:00
expected = "Invalid value 42-3,1-- for cpuset mems"
c . Assert ( getErrorMessage ( c , body ) , checker . Equals , expected )
2015-09-08 21:40:55 +03:00
}
2015-12-01 01:44:34 +03:00
2015-11-26 15:14:09 +03:00
func ( s * DockerSuite ) TestPostContainersCreateShmSizeNegative ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// ShmSize is not supported on Windows
2016-01-09 00:49:43 +03:00
testRequires ( c , DaemonIsLinux )
2015-11-26 15:14:09 +03:00
config := map [ string ] interface { } {
"Image" : "busybox" ,
"HostConfig" : map [ string ] interface { } { "ShmSize" : - 1 } ,
}
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2015-11-26 15:14:09 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusInternalServerError )
2016-07-11 13:29:17 +03:00
c . Assert ( getErrorMessage ( c , body ) , checker . Contains , "SHM size can not be less than 0" )
2015-11-26 15:14:09 +03:00
}
func ( s * DockerSuite ) TestPostContainersCreateShmSizeHostConfigOmitted ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// ShmSize is not supported on Windows
2016-01-09 00:49:43 +03:00
testRequires ( c , DaemonIsLinux )
2015-12-02 23:43:51 +03:00
var defaultSHMSize int64 = 67108864
2015-11-26 15:14:09 +03:00
config := map [ string ] interface { } {
"Image" : "busybox" ,
"Cmd" : "mount" ,
}
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2015-11-26 15:14:09 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusCreated )
2016-10-14 23:28:47 +03:00
var container containertypes . ContainerCreateCreatedBody
2015-11-26 15:14:09 +03:00
c . Assert ( json . Unmarshal ( body , & container ) , check . IsNil )
2016-12-30 12:49:36 +03:00
status , body , err = request . SockRequest ( "GET" , "/containers/" + container . ID + "/json" , nil , daemonHost ( ) )
2015-11-26 15:14:09 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusOK )
var containerJSON types . ContainerJSON
c . Assert ( json . Unmarshal ( body , & containerJSON ) , check . IsNil )
2015-12-29 23:49:17 +03:00
c . Assert ( containerJSON . HostConfig . ShmSize , check . Equals , defaultSHMSize )
2015-11-26 15:14:09 +03:00
out , _ := dockerCmd ( c , "start" , "-i" , containerJSON . ID )
shmRegexp := regexp . MustCompile ( ` shm on /dev/shm type tmpfs(.*)size=65536k ` )
if ! shmRegexp . MatchString ( out ) {
c . Fatalf ( "Expected shm of 64MB in mount command, got %v" , out )
}
}
func ( s * DockerSuite ) TestPostContainersCreateShmSizeOmitted ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// ShmSize is not supported on Windows
2016-01-09 00:49:43 +03:00
testRequires ( c , DaemonIsLinux )
2015-11-26 15:14:09 +03:00
config := map [ string ] interface { } {
"Image" : "busybox" ,
"HostConfig" : map [ string ] interface { } { } ,
"Cmd" : "mount" ,
}
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2015-11-26 15:14:09 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusCreated )
2016-10-14 23:28:47 +03:00
var container containertypes . ContainerCreateCreatedBody
2015-11-26 15:14:09 +03:00
c . Assert ( json . Unmarshal ( body , & container ) , check . IsNil )
2016-12-30 12:49:36 +03:00
status , body , err = request . SockRequest ( "GET" , "/containers/" + container . ID + "/json" , nil , daemonHost ( ) )
2015-11-26 15:14:09 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusOK )
var containerJSON types . ContainerJSON
c . Assert ( json . Unmarshal ( body , & containerJSON ) , check . IsNil )
2015-12-29 23:49:17 +03:00
c . Assert ( containerJSON . HostConfig . ShmSize , check . Equals , int64 ( 67108864 ) )
2015-11-26 15:14:09 +03:00
out , _ := dockerCmd ( c , "start" , "-i" , containerJSON . ID )
shmRegexp := regexp . MustCompile ( ` shm on /dev/shm type tmpfs(.*)size=65536k ` )
if ! shmRegexp . MatchString ( out ) {
c . Fatalf ( "Expected shm of 64MB in mount command, got %v" , out )
}
}
func ( s * DockerSuite ) TestPostContainersCreateWithShmSize ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// ShmSize is not supported on Windows
2016-01-09 00:49:43 +03:00
testRequires ( c , DaemonIsLinux )
2015-11-26 15:14:09 +03:00
config := map [ string ] interface { } {
"Image" : "busybox" ,
"Cmd" : "mount" ,
"HostConfig" : map [ string ] interface { } { "ShmSize" : 1073741824 } ,
}
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2015-11-26 15:14:09 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusCreated )
2016-10-14 23:28:47 +03:00
var container containertypes . ContainerCreateCreatedBody
2015-11-26 15:14:09 +03:00
c . Assert ( json . Unmarshal ( body , & container ) , check . IsNil )
2016-12-30 12:49:36 +03:00
status , body , err = request . SockRequest ( "GET" , "/containers/" + container . ID + "/json" , nil , daemonHost ( ) )
2015-11-26 15:14:09 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusOK )
var containerJSON types . ContainerJSON
c . Assert ( json . Unmarshal ( body , & containerJSON ) , check . IsNil )
2015-12-29 23:49:17 +03:00
c . Assert ( containerJSON . HostConfig . ShmSize , check . Equals , int64 ( 1073741824 ) )
2015-11-26 15:14:09 +03:00
out , _ := dockerCmd ( c , "start" , "-i" , containerJSON . ID )
shmRegex := regexp . MustCompile ( ` shm on /dev/shm type tmpfs(.*)size=1048576k ` )
if ! shmRegex . MatchString ( out ) {
c . Fatalf ( "Expected shm of 1GB in mount command, got %v" , out )
}
}
func ( s * DockerSuite ) TestPostContainersCreateMemorySwappinessHostConfigOmitted ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// Swappiness is not supported on Windows
2016-01-09 00:49:43 +03:00
testRequires ( c , DaemonIsLinux )
2015-11-26 15:14:09 +03:00
config := map [ string ] interface { } {
"Image" : "busybox" ,
}
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "POST" , "/containers/create" , config , daemonHost ( ) )
2015-11-26 15:14:09 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusCreated )
2016-10-14 23:28:47 +03:00
var container containertypes . ContainerCreateCreatedBody
2015-11-26 15:14:09 +03:00
c . Assert ( json . Unmarshal ( body , & container ) , check . IsNil )
2016-12-30 12:49:36 +03:00
status , body , err = request . SockRequest ( "GET" , "/containers/" + container . ID + "/json" , nil , daemonHost ( ) )
2015-11-26 15:14:09 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusOK )
var containerJSON types . ContainerJSON
c . Assert ( json . Unmarshal ( body , & containerJSON ) , check . IsNil )
2015-12-02 05:53:52 +03:00
c . Assert ( * containerJSON . HostConfig . MemorySwappiness , check . Equals , int64 ( - 1 ) )
2015-11-26 15:14:09 +03:00
}
2015-10-13 12:26:27 +03:00
// check validation is done daemon side and not only in cli
func ( s * DockerSuite ) TestPostContainersCreateWithOomScoreAdjInvalidRange ( c * check . C ) {
2016-01-23 22:04:57 +03:00
// OomScoreAdj is not supported on Windows
2015-10-13 12:26:27 +03:00
testRequires ( c , DaemonIsLinux )
config := struct {
Image string
OomScoreAdj int
} { "busybox" , 1001 }
name := "oomscoreadj-over"
2016-12-30 12:49:36 +03:00
status , b , err := request . SockRequest ( "POST" , "/containers/create?name=" + name , config , daemonHost ( ) )
2015-10-13 12:26:27 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusInternalServerError )
2016-05-21 14:56:04 +03:00
2016-03-22 03:53:57 +03:00
expected := "Invalid value 1001, range for oom score adj is [-1000, 1000]"
2016-05-21 14:56:04 +03:00
msg := getErrorMessage ( c , b )
if ! strings . Contains ( msg , expected ) {
c . Fatalf ( "Expected output to contain %q, got %q" , expected , msg )
2015-10-13 12:26:27 +03:00
}
config = struct {
Image string
OomScoreAdj int
} { "busybox" , - 1001 }
name = "oomscoreadj-low"
2016-12-30 12:49:36 +03:00
status , b , err = request . SockRequest ( "POST" , "/containers/create?name=" + name , config , daemonHost ( ) )
2015-10-13 12:26:27 +03:00
c . Assert ( err , check . IsNil )
c . Assert ( status , check . Equals , http . StatusInternalServerError )
2016-03-22 03:53:57 +03:00
expected = "Invalid value -1001, range for oom score adj is [-1000, 1000]"
2016-05-21 14:56:04 +03:00
msg = getErrorMessage ( c , b )
if ! strings . Contains ( msg , expected ) {
c . Fatalf ( "Expected output to contain %q, got %q" , expected , msg )
2015-10-13 12:26:27 +03:00
}
}
2016-04-21 04:33:53 +03:00
2016-07-03 20:58:11 +03:00
// test case for #22210 where an empty container name caused panic.
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIDeleteWithEmptyName ( c * check . C ) {
2016-12-30 12:49:36 +03:00
status , out , err := request . SockRequest ( "DELETE" , "/containers/" , nil , daemonHost ( ) )
2016-04-21 04:33:53 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusBadRequest )
c . Assert ( string ( out ) , checker . Contains , "No container name or ID supplied" )
}
2016-08-21 01:43:15 +03:00
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPIStatsWithNetworkDisabled ( c * check . C ) {
2016-08-21 01:43:15 +03:00
// Problematic on Windows as Windows does not support stats
testRequires ( c , DaemonIsLinux )
name := "testing-network-disabled"
config := map [ string ] interface { } {
"Image" : "busybox" ,
"Cmd" : [ ] string { "top" } ,
"NetworkDisabled" : true ,
}
2016-12-30 12:49:36 +03:00
status , _ , err := request . SockRequest ( "POST" , "/containers/create?name=" + name , config , daemonHost ( ) )
2016-08-21 01:43:15 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusCreated )
2016-12-30 12:49:36 +03:00
status , _ , err = request . SockRequest ( "POST" , "/containers/" + name + "/start" , nil , daemonHost ( ) )
2016-08-21 01:43:15 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , http . StatusNoContent )
c . Assert ( waitRun ( name ) , check . IsNil )
type b struct {
status int
body [ ] byte
err error
}
bc := make ( chan b , 1 )
go func ( ) {
2016-12-30 12:49:36 +03:00
status , body , err := request . SockRequest ( "GET" , "/containers/" + name + "/stats" , nil , daemonHost ( ) )
2016-08-21 01:43:15 +03:00
bc <- b { status , body , err }
} ( )
// allow some time to stream the stats from the container
time . Sleep ( 4 * time . Second )
dockerCmd ( c , "rm" , "-f" , name )
// collect the results from the stats stream or timeout and fail
// if the stream was not disconnected.
select {
case <- time . After ( 2 * time . Second ) :
c . Fatal ( "stream was not closed after container was removed" )
case sr := <- bc :
c . Assert ( sr . err , checker . IsNil )
c . Assert ( sr . status , checker . Equals , http . StatusOK )
// decode only one object from the stream
var s * types . Stats
dec := json . NewDecoder ( bytes . NewBuffer ( sr . body ) )
c . Assert ( dec . Decode ( & s ) , checker . IsNil )
}
}
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainersAPICreateMountsValidation ( c * check . C ) {
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
type m mounttypes . Mount
type hc struct { Mounts [ ] m }
type cfg struct {
Image string
HostConfig hc
}
type testCase struct {
config cfg
status int
msg string
}
prefix , slash := getPrefixAndSlashFromDaemonPlatform ( )
destPath := prefix + slash + "foo"
notExistPath := prefix + slash + "notexist"
cases := [ ] testCase {
2016-09-22 23:14:15 +03:00
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "notreal" ,
Target : destPath } } } } ,
status : http . StatusBadRequest ,
msg : "mount type unknown" ,
} ,
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "bind" } } } } ,
status : http . StatusBadRequest ,
msg : "Target must not be empty" ,
} ,
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "bind" ,
Target : destPath } } } } ,
status : http . StatusBadRequest ,
msg : "Source must not be empty" ,
} ,
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "bind" ,
Source : notExistPath ,
Target : destPath } } } } ,
status : http . StatusBadRequest ,
msg : "bind source path does not exist" ,
} ,
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "volume" } } } } ,
status : http . StatusBadRequest ,
msg : "Target must not be empty" ,
} ,
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "volume" ,
Source : "hello" ,
Target : destPath } } } } ,
status : http . StatusCreated ,
msg : "" ,
} ,
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "volume" ,
Source : "hello2" ,
Target : destPath ,
VolumeOptions : & mounttypes . VolumeOptions {
DriverConfig : & mounttypes . Driver {
Name : "local" } } } } } } ,
status : http . StatusCreated ,
msg : "" ,
} ,
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
}
2016-12-16 17:13:23 +03:00
if SameHostDaemon ( ) {
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
tmpDir , err := ioutils . TempDir ( "" , "test-mounts-api" )
c . Assert ( err , checker . IsNil )
defer os . RemoveAll ( tmpDir )
cases = append ( cases , [ ] testCase {
2016-09-22 23:14:15 +03:00
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "bind" ,
Source : tmpDir ,
Target : destPath } } } } ,
status : http . StatusCreated ,
msg : "" ,
} ,
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "bind" ,
Source : tmpDir ,
Target : destPath ,
VolumeOptions : & mounttypes . VolumeOptions { } } } } } ,
status : http . StatusBadRequest ,
msg : "VolumeOptions must not be specified" ,
} ,
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
} ... )
}
2016-12-16 17:13:23 +03:00
if DaemonIsLinux ( ) {
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
cases = append ( cases , [ ] testCase {
2016-09-22 23:14:15 +03:00
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "volume" ,
Source : "hello3" ,
Target : destPath ,
VolumeOptions : & mounttypes . VolumeOptions {
DriverConfig : & mounttypes . Driver {
Name : "local" ,
Options : map [ string ] string { "o" : "size=1" } } } } } } } ,
status : http . StatusCreated ,
msg : "" ,
} ,
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "tmpfs" ,
Target : destPath } } } } ,
status : http . StatusCreated ,
msg : "" ,
} ,
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "tmpfs" ,
Target : destPath ,
TmpfsOptions : & mounttypes . TmpfsOptions {
SizeBytes : 4096 * 1024 ,
Mode : 0700 ,
} } } } } ,
status : http . StatusCreated ,
msg : "" ,
} ,
{
config : cfg {
Image : "busybox" ,
HostConfig : hc {
Mounts : [ ] m { {
Type : "tmpfs" ,
Source : "/shouldnotbespecified" ,
Target : destPath } } } } ,
status : http . StatusBadRequest ,
msg : "Source must not be specified" ,
} ,
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
} ... )
}
for i , x := range cases {
c . Logf ( "case %d" , i )
2016-12-30 12:49:36 +03:00
status , b , err := request . SockRequest ( "POST" , "/containers/create" , x . config , daemonHost ( ) )
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
c . Assert ( err , checker . IsNil )
c . Assert ( status , checker . Equals , x . status , check . Commentf ( "%s\n%v" , string ( b ) , cases [ i ] . config ) )
if len ( x . msg ) > 0 {
c . Assert ( string ( b ) , checker . Contains , x . msg , check . Commentf ( "%v" , cases [ i ] . config ) )
}
}
}
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainerAPICreateMountsBindRead ( c * check . C ) {
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
testRequires ( c , NotUserNamespace , SameHostDaemon )
// also with data in the host side
prefix , slash := getPrefixAndSlashFromDaemonPlatform ( )
destPath := prefix + slash + "foo"
tmpDir , err := ioutil . TempDir ( "" , "test-mounts-api-bind" )
c . Assert ( err , checker . IsNil )
defer os . RemoveAll ( tmpDir )
err = ioutil . WriteFile ( filepath . Join ( tmpDir , "bar" ) , [ ] byte ( "hello" ) , 666 )
c . Assert ( err , checker . IsNil )
data := map [ string ] interface { } {
"Image" : "busybox" ,
"Cmd" : [ ] string { "/bin/sh" , "-c" , "cat /foo/bar" } ,
"HostConfig" : map [ string ] interface { } { "Mounts" : [ ] map [ string ] interface { } { { "Type" : "bind" , "Source" : tmpDir , "Target" : destPath } } } ,
}
2016-12-30 12:49:36 +03:00
status , resp , err := request . SockRequest ( "POST" , "/containers/create?name=test" , data , daemonHost ( ) )
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
c . Assert ( err , checker . IsNil , check . Commentf ( string ( resp ) ) )
c . Assert ( status , checker . Equals , http . StatusCreated , check . Commentf ( string ( resp ) ) )
out , _ := dockerCmd ( c , "start" , "-a" , "test" )
c . Assert ( out , checker . Equals , "hello" )
}
// Test Mounts comes out as expected for the MountPoint
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-28 04:50:12 +03:00
func ( s * DockerSuite ) TestContainersAPICreateMountsCreate ( c * check . C ) {
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
prefix , slash := getPrefixAndSlashFromDaemonPlatform ( )
destPath := prefix + slash + "foo"
var (
testImg string
)
2017-01-13 19:23:28 +03:00
if testEnv . DaemonPlatform ( ) != "windows" {
2017-01-16 13:30:14 +03:00
testImg = "test-mount-config"
buildImageSuccessfully ( c , testImg , withDockerfile ( `
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
FROM busybox
RUN mkdir ` +destPath+ ` && touch ` +destPath+slash+ ` bar
CMD cat ` +destPath+slash+ ` bar
2017-01-16 13:30:14 +03:00
` ) )
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
} else {
testImg = "busybox"
}
type testCase struct {
cfg mounttypes . Mount
expected types . MountPoint
}
cases := [ ] testCase {
// use literal strings here for `Type` instead of the defined constants in the volume package to keep this honest
// Validation of the actual `Mount` struct is done in another test is not needed here
{ mounttypes . Mount { Type : "volume" , Target : destPath } , types . MountPoint { Driver : volume . DefaultDriverName , Type : "volume" , RW : true , Destination : destPath } } ,
{ mounttypes . Mount { Type : "volume" , Target : destPath + slash } , types . MountPoint { Driver : volume . DefaultDriverName , Type : "volume" , RW : true , Destination : destPath } } ,
{ mounttypes . Mount { Type : "volume" , Target : destPath , Source : "test1" } , types . MountPoint { Type : "volume" , Name : "test1" , RW : true , Destination : destPath } } ,
{ mounttypes . Mount { Type : "volume" , Target : destPath , ReadOnly : true , Source : "test2" } , types . MountPoint { Type : "volume" , Name : "test2" , RW : false , Destination : destPath } } ,
{ mounttypes . Mount { Type : "volume" , Target : destPath , Source : "test3" , VolumeOptions : & mounttypes . VolumeOptions { DriverConfig : & mounttypes . Driver { Name : volume . DefaultDriverName } } } , types . MountPoint { Driver : volume . DefaultDriverName , Type : "volume" , Name : "test3" , RW : true , Destination : destPath } } ,
}
2016-12-16 17:13:23 +03:00
if SameHostDaemon ( ) {
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
// setup temp dir for testing binds
tmpDir1 , err := ioutil . TempDir ( "" , "test-mounts-api-1" )
c . Assert ( err , checker . IsNil )
defer os . RemoveAll ( tmpDir1 )
cases = append ( cases , [ ] testCase {
{ mounttypes . Mount { Type : "bind" , Source : tmpDir1 , Target : destPath } , types . MountPoint { Type : "bind" , RW : true , Destination : destPath , Source : tmpDir1 } } ,
{ mounttypes . Mount { Type : "bind" , Source : tmpDir1 , Target : destPath , ReadOnly : true } , types . MountPoint { Type : "bind" , RW : false , Destination : destPath , Source : tmpDir1 } } ,
} ... )
// for modes only supported on Linux
2016-12-16 17:13:23 +03:00
if DaemonIsLinux ( ) {
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
tmpDir3 , err := ioutils . TempDir ( "" , "test-mounts-api-3" )
c . Assert ( err , checker . IsNil )
defer os . RemoveAll ( tmpDir3 )
c . Assert ( mount . Mount ( tmpDir3 , tmpDir3 , "none" , "bind,rw" ) , checker . IsNil )
c . Assert ( mount . ForceMount ( "" , tmpDir3 , "none" , "shared" ) , checker . IsNil )
cases = append ( cases , [ ] testCase {
{ mounttypes . Mount { Type : "bind" , Source : tmpDir3 , Target : destPath } , types . MountPoint { Type : "bind" , RW : true , Destination : destPath , Source : tmpDir3 } } ,
{ mounttypes . Mount { Type : "bind" , Source : tmpDir3 , Target : destPath , ReadOnly : true } , types . MountPoint { Type : "bind" , RW : false , Destination : destPath , Source : tmpDir3 } } ,
{ mounttypes . Mount { Type : "bind" , Source : tmpDir3 , Target : destPath , ReadOnly : true , BindOptions : & mounttypes . BindOptions { Propagation : "shared" } } , types . MountPoint { Type : "bind" , RW : false , Destination : destPath , Source : tmpDir3 , Propagation : "shared" } } ,
} ... )
}
}
2017-01-13 19:23:28 +03:00
if testEnv . DaemonPlatform ( ) != "windows" { // Windows does not support volume populate
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
cases = append ( cases , [ ] testCase {
{ mounttypes . Mount { Type : "volume" , Target : destPath , VolumeOptions : & mounttypes . VolumeOptions { NoCopy : true } } , types . MountPoint { Driver : volume . DefaultDriverName , Type : "volume" , RW : true , Destination : destPath } } ,
{ mounttypes . Mount { Type : "volume" , Target : destPath + slash , VolumeOptions : & mounttypes . VolumeOptions { NoCopy : true } } , types . MountPoint { Driver : volume . DefaultDriverName , Type : "volume" , RW : true , Destination : destPath } } ,
{ mounttypes . Mount { Type : "volume" , Target : destPath , Source : "test4" , VolumeOptions : & mounttypes . VolumeOptions { NoCopy : true } } , types . MountPoint { Type : "volume" , Name : "test4" , RW : true , Destination : destPath } } ,
{ mounttypes . Mount { Type : "volume" , Target : destPath , Source : "test5" , ReadOnly : true , VolumeOptions : & mounttypes . VolumeOptions { NoCopy : true } } , types . MountPoint { Type : "volume" , Name : "test5" , RW : false , Destination : destPath } } ,
} ... )
}
type wrapper struct {
containertypes . Config
HostConfig containertypes . HostConfig
}
type createResp struct {
ID string ` json:"Id" `
}
for i , x := range cases {
c . Logf ( "case %d - config: %v" , i , x . cfg )
2016-12-30 12:49:36 +03:00
status , data , err := request . SockRequest ( "POST" , "/containers/create" , wrapper { containertypes . Config { Image : testImg } , containertypes . HostConfig { Mounts : [ ] mounttypes . Mount { x . cfg } } } , daemonHost ( ) )
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
c . Assert ( err , checker . IsNil , check . Commentf ( string ( data ) ) )
c . Assert ( status , checker . Equals , http . StatusCreated , check . Commentf ( string ( data ) ) )
var resp createResp
err = json . Unmarshal ( data , & resp )
c . Assert ( err , checker . IsNil , check . Commentf ( string ( data ) ) )
id := resp . ID
var mps [ ] types . MountPoint
err = json . NewDecoder ( strings . NewReader ( inspectFieldJSON ( c , id , "Mounts" ) ) ) . Decode ( & mps )
c . Assert ( err , checker . IsNil )
c . Assert ( mps , checker . HasLen , 1 )
c . Assert ( mps [ 0 ] . Destination , checker . Equals , x . expected . Destination )
if len ( x . expected . Source ) > 0 {
c . Assert ( mps [ 0 ] . Source , checker . Equals , x . expected . Source )
}
if len ( x . expected . Name ) > 0 {
c . Assert ( mps [ 0 ] . Name , checker . Equals , x . expected . Name )
}
if len ( x . expected . Driver ) > 0 {
c . Assert ( mps [ 0 ] . Driver , checker . Equals , x . expected . Driver )
}
c . Assert ( mps [ 0 ] . RW , checker . Equals , x . expected . RW )
c . Assert ( mps [ 0 ] . Type , checker . Equals , x . expected . Type )
c . Assert ( mps [ 0 ] . Mode , checker . Equals , x . expected . Mode )
if len ( x . expected . Propagation ) > 0 {
c . Assert ( mps [ 0 ] . Propagation , checker . Equals , x . expected . Propagation )
}
out , _ , err := dockerCmdWithError ( "start" , "-a" , id )
2017-01-13 19:23:28 +03:00
if ( x . cfg . Type != "volume" || ( x . cfg . VolumeOptions != nil && x . cfg . VolumeOptions . NoCopy ) ) && testEnv . DaemonPlatform ( ) != "windows" {
Add new `HostConfig` field, `Mounts`.
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2016-04-26 21:25:35 +03:00
c . Assert ( err , checker . NotNil , check . Commentf ( "%s\n%v" , out , mps [ 0 ] ) )
} else {
c . Assert ( err , checker . IsNil , check . Commentf ( "%s\n%v" , out , mps [ 0 ] ) )
}
dockerCmd ( c , "rm" , "-fv" , id )
if x . cfg . Type == "volume" && len ( x . cfg . Source ) > 0 {
// This should still exist even though we removed the container
dockerCmd ( c , "volume" , "inspect" , mps [ 0 ] . Name )
} else {
// This should be removed automatically when we removed the container
out , _ , err := dockerCmdWithError ( "volume" , "inspect" , mps [ 0 ] . Name )
c . Assert ( err , checker . NotNil , check . Commentf ( out ) )
}
}
}
2016-09-22 23:14:15 +03:00
func ( s * DockerSuite ) TestContainersAPICreateMountsTmpfs ( c * check . C ) {
testRequires ( c , DaemonIsLinux )
type testCase struct {
cfg map [ string ] interface { }
expectedOptions [ ] string
}
target := "/foo"
cases := [ ] testCase {
{
cfg : map [ string ] interface { } {
"Type" : "tmpfs" ,
"Target" : target } ,
expectedOptions : [ ] string { "rw" , "nosuid" , "nodev" , "noexec" , "relatime" } ,
} ,
{
cfg : map [ string ] interface { } {
"Type" : "tmpfs" ,
"Target" : target ,
"TmpfsOptions" : map [ string ] interface { } {
"SizeBytes" : 4096 * 1024 , "Mode" : 0700 } } ,
expectedOptions : [ ] string { "rw" , "nosuid" , "nodev" , "noexec" , "relatime" , "size=4096k" , "mode=700" } ,
} ,
}
for i , x := range cases {
cName := fmt . Sprintf ( "test-tmpfs-%d" , i )
data := map [ string ] interface { } {
"Image" : "busybox" ,
"Cmd" : [ ] string { "/bin/sh" , "-c" ,
fmt . Sprintf ( "mount | grep 'tmpfs on %s'" , target ) } ,
"HostConfig" : map [ string ] interface { } { "Mounts" : [ ] map [ string ] interface { } { x . cfg } } ,
}
2016-12-30 12:49:36 +03:00
status , resp , err := request . SockRequest ( "POST" , "/containers/create?name=" + cName , data , daemonHost ( ) )
2016-09-22 23:14:15 +03:00
c . Assert ( err , checker . IsNil , check . Commentf ( string ( resp ) ) )
c . Assert ( status , checker . Equals , http . StatusCreated , check . Commentf ( string ( resp ) ) )
out , _ := dockerCmd ( c , "start" , "-a" , cName )
for _ , option := range x . expectedOptions {
c . Assert ( out , checker . Contains , option )
}
}
}