2015-11-12 22:55:17 +03:00
|
|
|
// +build linux freebsd
|
|
|
|
|
|
|
|
package container
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"io/ioutil"
|
|
|
|
"net"
|
|
|
|
"os"
|
|
|
|
"path/filepath"
|
|
|
|
"strconv"
|
|
|
|
"strings"
|
|
|
|
"syscall"
|
|
|
|
|
|
|
|
"github.com/Sirupsen/logrus"
|
|
|
|
"github.com/docker/docker/daemon/execdriver"
|
|
|
|
"github.com/docker/docker/pkg/chrootarchive"
|
|
|
|
"github.com/docker/docker/pkg/symlink"
|
|
|
|
"github.com/docker/docker/pkg/system"
|
2016-01-05 22:20:47 +03:00
|
|
|
runconfigopts "github.com/docker/docker/runconfig/opts"
|
2015-11-12 22:55:17 +03:00
|
|
|
"github.com/docker/docker/utils"
|
|
|
|
"github.com/docker/docker/volume"
|
2016-01-22 07:49:02 +03:00
|
|
|
containertypes "github.com/docker/engine-api/types/container"
|
2016-01-05 03:05:26 +03:00
|
|
|
"github.com/docker/engine-api/types/network"
|
2015-12-18 20:58:48 +03:00
|
|
|
"github.com/docker/go-connections/nat"
|
2015-11-12 22:55:17 +03:00
|
|
|
"github.com/docker/libnetwork"
|
|
|
|
"github.com/docker/libnetwork/netlabel"
|
|
|
|
"github.com/docker/libnetwork/options"
|
|
|
|
"github.com/docker/libnetwork/types"
|
|
|
|
"github.com/opencontainers/runc/libcontainer/label"
|
|
|
|
)
|
|
|
|
|
2015-12-10 17:35:53 +03:00
|
|
|
// DefaultSHMSize is the default size (64MB) of the SHM which will be mounted in the container
|
|
|
|
const DefaultSHMSize int64 = 67108864
|
2015-11-12 22:55:17 +03:00
|
|
|
|
Remove static errors from errors package.
Moving all strings to the errors package wasn't a good idea after all.
Our custom implementation of Go errors predates everything that's nice
and good about working with errors in Go. Take as an example what we
have to do to get an error message:
```go
func GetErrorMessage(err error) string {
switch err.(type) {
case errcode.Error:
e, _ := err.(errcode.Error)
return e.Message
case errcode.ErrorCode:
ec, _ := err.(errcode.ErrorCode)
return ec.Message()
default:
return err.Error()
}
}
```
This goes against every good practice for Go development. The language already provides a simple, intuitive and standard way to get error messages, that is calling the `Error()` method from an error. Reinventing the error interface is a mistake.
Our custom implementation also makes very hard to reason about errors, another nice thing about Go. I found several (>10) error declarations that we don't use anywhere. This is a clear sign about how little we know about the errors we return. I also found several error usages where the number of arguments was different than the parameters declared in the error, another clear example of how difficult is to reason about errors.
Moreover, our custom implementation didn't really make easier for people to return custom HTTP status code depending on the errors. Again, it's hard to reason about when to set custom codes and how. Take an example what we have to do to extract the message and status code from an error before returning a response from the API:
```go
switch err.(type) {
case errcode.ErrorCode:
daError, _ := err.(errcode.ErrorCode)
statusCode = daError.Descriptor().HTTPStatusCode
errMsg = daError.Message()
case errcode.Error:
// For reference, if you're looking for a particular error
// then you can do something like :
// import ( derr "github.com/docker/docker/errors" )
// if daError.ErrorCode() == derr.ErrorCodeNoSuchContainer { ... }
daError, _ := err.(errcode.Error)
statusCode = daError.ErrorCode().Descriptor().HTTPStatusCode
errMsg = daError.Message
default:
// This part of will be removed once we've
// converted everything over to use the errcode package
// FIXME: this is brittle and should not be necessary.
// If we need to differentiate between different possible error types,
// we should create appropriate error types with clearly defined meaning
errStr := strings.ToLower(err.Error())
for keyword, status := range map[string]int{
"not found": http.StatusNotFound,
"no such": http.StatusNotFound,
"bad parameter": http.StatusBadRequest,
"conflict": http.StatusConflict,
"impossible": http.StatusNotAcceptable,
"wrong login/password": http.StatusUnauthorized,
"hasn't been activated": http.StatusForbidden,
} {
if strings.Contains(errStr, keyword) {
statusCode = status
break
}
}
}
```
You can notice two things in that code:
1. We have to explain how errors work, because our implementation goes against how easy to use Go errors are.
2. At no moment we arrived to remove that `switch` statement that was the original reason to use our custom implementation.
This change removes all our status errors from the errors package and puts them back in their specific contexts.
IT puts the messages back with their contexts. That way, we know right away when errors used and how to generate their messages.
It uses custom interfaces to reason about errors. Errors that need to response with a custom status code MUST implementent this simple interface:
```go
type errorWithStatus interface {
HTTPErrorStatusCode() int
}
```
This interface is very straightforward to implement. It also preserves Go errors real behavior, getting the message is as simple as using the `Error()` method.
I included helper functions to generate errors that use custom status code in `errors/errors.go`.
By doing this, we remove the hard dependency we have eeverywhere to our custom errors package. Yes, you can use it as a helper to generate error, but it's still very easy to generate errors without it.
Please, read this fantastic blog post about errors in Go: http://dave.cheney.net/2014/12/24/inspecting-errors
Signed-off-by: David Calavera <david.calavera@gmail.com>
2016-02-25 18:53:35 +03:00
|
|
|
var (
|
|
|
|
errInvalidEndpoint = fmt.Errorf("invalid endpoint while building port map info")
|
|
|
|
errInvalidNetwork = fmt.Errorf("invalid network settings while building port map info")
|
|
|
|
)
|
|
|
|
|
2016-01-14 08:46:59 +03:00
|
|
|
// Container holds the fields specific to unixen implementations.
|
|
|
|
// See CommonContainer for standard fields common to all containers.
|
2015-11-12 22:55:17 +03:00
|
|
|
type Container struct {
|
|
|
|
CommonContainer
|
|
|
|
|
|
|
|
// Fields below here are platform specific.
|
|
|
|
AppArmorProfile string
|
|
|
|
HostnamePath string
|
|
|
|
HostsPath string
|
|
|
|
ShmPath string
|
|
|
|
ResolvConfPath string
|
2015-11-15 05:02:26 +03:00
|
|
|
SeccompProfile string
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
// CreateDaemonEnvironment returns the list of all environment variables given the list of
|
|
|
|
// environment variables related to links.
|
|
|
|
// Sets PATH, HOSTNAME and if container.Config.Tty is set: TERM.
|
|
|
|
// The defaults set here do not override the values in container.Config.Env
|
|
|
|
func (container *Container) CreateDaemonEnvironment(linkedEnv []string) []string {
|
|
|
|
// if a domain name was specified, append it to the hostname (see #7851)
|
|
|
|
fullHostname := container.Config.Hostname
|
|
|
|
if container.Config.Domainname != "" {
|
|
|
|
fullHostname = fmt.Sprintf("%s.%s", fullHostname, container.Config.Domainname)
|
|
|
|
}
|
|
|
|
// Setup environment
|
|
|
|
env := []string{
|
2015-12-10 17:35:53 +03:00
|
|
|
"PATH=" + system.DefaultPathEnv,
|
2015-11-12 22:55:17 +03:00
|
|
|
"HOSTNAME=" + fullHostname,
|
|
|
|
}
|
|
|
|
if container.Config.Tty {
|
|
|
|
env = append(env, "TERM=xterm")
|
|
|
|
}
|
|
|
|
env = append(env, linkedEnv...)
|
|
|
|
// because the env on the container can override certain default values
|
|
|
|
// we need to replace the 'env' keys where they match and append anything
|
|
|
|
// else.
|
|
|
|
env = utils.ReplaceOrAppendEnvValues(env, container.Config.Env)
|
|
|
|
|
|
|
|
return env
|
|
|
|
}
|
|
|
|
|
|
|
|
// TrySetNetworkMount attempts to set the network mounts given a provided destination and
|
|
|
|
// the path to use for it; return true if the given destination was a network mount file
|
|
|
|
func (container *Container) TrySetNetworkMount(destination string, path string) bool {
|
|
|
|
if destination == "/etc/resolv.conf" {
|
|
|
|
container.ResolvConfPath = path
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
if destination == "/etc/hostname" {
|
|
|
|
container.HostnamePath = path
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
if destination == "/etc/hosts" {
|
|
|
|
container.HostsPath = path
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
// BuildHostnameFile writes the container's hostname file.
|
|
|
|
func (container *Container) BuildHostnameFile() error {
|
|
|
|
hostnamePath, err := container.GetRootResourcePath("hostname")
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
container.HostnamePath = hostnamePath
|
|
|
|
|
|
|
|
if container.Config.Domainname != "" {
|
|
|
|
return ioutil.WriteFile(container.HostnamePath, []byte(fmt.Sprintf("%s.%s\n", container.Config.Hostname, container.Config.Domainname)), 0644)
|
|
|
|
}
|
|
|
|
return ioutil.WriteFile(container.HostnamePath, []byte(container.Config.Hostname+"\n"), 0644)
|
|
|
|
}
|
|
|
|
|
|
|
|
// GetEndpointInNetwork returns the container's endpoint to the provided network.
|
|
|
|
func (container *Container) GetEndpointInNetwork(n libnetwork.Network) (libnetwork.Endpoint, error) {
|
|
|
|
endpointName := strings.TrimPrefix(container.Name, "/")
|
|
|
|
return n.EndpointByName(endpointName)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (container *Container) buildPortMapInfo(ep libnetwork.Endpoint) error {
|
|
|
|
if ep == nil {
|
Remove static errors from errors package.
Moving all strings to the errors package wasn't a good idea after all.
Our custom implementation of Go errors predates everything that's nice
and good about working with errors in Go. Take as an example what we
have to do to get an error message:
```go
func GetErrorMessage(err error) string {
switch err.(type) {
case errcode.Error:
e, _ := err.(errcode.Error)
return e.Message
case errcode.ErrorCode:
ec, _ := err.(errcode.ErrorCode)
return ec.Message()
default:
return err.Error()
}
}
```
This goes against every good practice for Go development. The language already provides a simple, intuitive and standard way to get error messages, that is calling the `Error()` method from an error. Reinventing the error interface is a mistake.
Our custom implementation also makes very hard to reason about errors, another nice thing about Go. I found several (>10) error declarations that we don't use anywhere. This is a clear sign about how little we know about the errors we return. I also found several error usages where the number of arguments was different than the parameters declared in the error, another clear example of how difficult is to reason about errors.
Moreover, our custom implementation didn't really make easier for people to return custom HTTP status code depending on the errors. Again, it's hard to reason about when to set custom codes and how. Take an example what we have to do to extract the message and status code from an error before returning a response from the API:
```go
switch err.(type) {
case errcode.ErrorCode:
daError, _ := err.(errcode.ErrorCode)
statusCode = daError.Descriptor().HTTPStatusCode
errMsg = daError.Message()
case errcode.Error:
// For reference, if you're looking for a particular error
// then you can do something like :
// import ( derr "github.com/docker/docker/errors" )
// if daError.ErrorCode() == derr.ErrorCodeNoSuchContainer { ... }
daError, _ := err.(errcode.Error)
statusCode = daError.ErrorCode().Descriptor().HTTPStatusCode
errMsg = daError.Message
default:
// This part of will be removed once we've
// converted everything over to use the errcode package
// FIXME: this is brittle and should not be necessary.
// If we need to differentiate between different possible error types,
// we should create appropriate error types with clearly defined meaning
errStr := strings.ToLower(err.Error())
for keyword, status := range map[string]int{
"not found": http.StatusNotFound,
"no such": http.StatusNotFound,
"bad parameter": http.StatusBadRequest,
"conflict": http.StatusConflict,
"impossible": http.StatusNotAcceptable,
"wrong login/password": http.StatusUnauthorized,
"hasn't been activated": http.StatusForbidden,
} {
if strings.Contains(errStr, keyword) {
statusCode = status
break
}
}
}
```
You can notice two things in that code:
1. We have to explain how errors work, because our implementation goes against how easy to use Go errors are.
2. At no moment we arrived to remove that `switch` statement that was the original reason to use our custom implementation.
This change removes all our status errors from the errors package and puts them back in their specific contexts.
IT puts the messages back with their contexts. That way, we know right away when errors used and how to generate their messages.
It uses custom interfaces to reason about errors. Errors that need to response with a custom status code MUST implementent this simple interface:
```go
type errorWithStatus interface {
HTTPErrorStatusCode() int
}
```
This interface is very straightforward to implement. It also preserves Go errors real behavior, getting the message is as simple as using the `Error()` method.
I included helper functions to generate errors that use custom status code in `errors/errors.go`.
By doing this, we remove the hard dependency we have eeverywhere to our custom errors package. Yes, you can use it as a helper to generate error, but it's still very easy to generate errors without it.
Please, read this fantastic blog post about errors in Go: http://dave.cheney.net/2014/12/24/inspecting-errors
Signed-off-by: David Calavera <david.calavera@gmail.com>
2016-02-25 18:53:35 +03:00
|
|
|
return errInvalidEndpoint
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
networkSettings := container.NetworkSettings
|
|
|
|
if networkSettings == nil {
|
Remove static errors from errors package.
Moving all strings to the errors package wasn't a good idea after all.
Our custom implementation of Go errors predates everything that's nice
and good about working with errors in Go. Take as an example what we
have to do to get an error message:
```go
func GetErrorMessage(err error) string {
switch err.(type) {
case errcode.Error:
e, _ := err.(errcode.Error)
return e.Message
case errcode.ErrorCode:
ec, _ := err.(errcode.ErrorCode)
return ec.Message()
default:
return err.Error()
}
}
```
This goes against every good practice for Go development. The language already provides a simple, intuitive and standard way to get error messages, that is calling the `Error()` method from an error. Reinventing the error interface is a mistake.
Our custom implementation also makes very hard to reason about errors, another nice thing about Go. I found several (>10) error declarations that we don't use anywhere. This is a clear sign about how little we know about the errors we return. I also found several error usages where the number of arguments was different than the parameters declared in the error, another clear example of how difficult is to reason about errors.
Moreover, our custom implementation didn't really make easier for people to return custom HTTP status code depending on the errors. Again, it's hard to reason about when to set custom codes and how. Take an example what we have to do to extract the message and status code from an error before returning a response from the API:
```go
switch err.(type) {
case errcode.ErrorCode:
daError, _ := err.(errcode.ErrorCode)
statusCode = daError.Descriptor().HTTPStatusCode
errMsg = daError.Message()
case errcode.Error:
// For reference, if you're looking for a particular error
// then you can do something like :
// import ( derr "github.com/docker/docker/errors" )
// if daError.ErrorCode() == derr.ErrorCodeNoSuchContainer { ... }
daError, _ := err.(errcode.Error)
statusCode = daError.ErrorCode().Descriptor().HTTPStatusCode
errMsg = daError.Message
default:
// This part of will be removed once we've
// converted everything over to use the errcode package
// FIXME: this is brittle and should not be necessary.
// If we need to differentiate between different possible error types,
// we should create appropriate error types with clearly defined meaning
errStr := strings.ToLower(err.Error())
for keyword, status := range map[string]int{
"not found": http.StatusNotFound,
"no such": http.StatusNotFound,
"bad parameter": http.StatusBadRequest,
"conflict": http.StatusConflict,
"impossible": http.StatusNotAcceptable,
"wrong login/password": http.StatusUnauthorized,
"hasn't been activated": http.StatusForbidden,
} {
if strings.Contains(errStr, keyword) {
statusCode = status
break
}
}
}
```
You can notice two things in that code:
1. We have to explain how errors work, because our implementation goes against how easy to use Go errors are.
2. At no moment we arrived to remove that `switch` statement that was the original reason to use our custom implementation.
This change removes all our status errors from the errors package and puts them back in their specific contexts.
IT puts the messages back with their contexts. That way, we know right away when errors used and how to generate their messages.
It uses custom interfaces to reason about errors. Errors that need to response with a custom status code MUST implementent this simple interface:
```go
type errorWithStatus interface {
HTTPErrorStatusCode() int
}
```
This interface is very straightforward to implement. It also preserves Go errors real behavior, getting the message is as simple as using the `Error()` method.
I included helper functions to generate errors that use custom status code in `errors/errors.go`.
By doing this, we remove the hard dependency we have eeverywhere to our custom errors package. Yes, you can use it as a helper to generate error, but it's still very easy to generate errors without it.
Please, read this fantastic blog post about errors in Go: http://dave.cheney.net/2014/12/24/inspecting-errors
Signed-off-by: David Calavera <david.calavera@gmail.com>
2016-02-25 18:53:35 +03:00
|
|
|
return errInvalidNetwork
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
|
2016-01-26 06:55:18 +03:00
|
|
|
if len(networkSettings.Ports) == 0 {
|
|
|
|
pm, err := getEndpointPortMapInfo(ep)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
networkSettings.Ports = pm
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func getEndpointPortMapInfo(ep libnetwork.Endpoint) (nat.PortMap, error) {
|
|
|
|
pm := nat.PortMap{}
|
2015-11-12 22:55:17 +03:00
|
|
|
driverInfo, err := ep.DriverInfo()
|
|
|
|
if err != nil {
|
2016-01-26 06:55:18 +03:00
|
|
|
return pm, err
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if driverInfo == nil {
|
|
|
|
// It is not an error for epInfo to be nil
|
2016-01-26 06:55:18 +03:00
|
|
|
return pm, nil
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if expData, ok := driverInfo[netlabel.ExposedPorts]; ok {
|
|
|
|
if exposedPorts, ok := expData.([]types.TransportPort); ok {
|
|
|
|
for _, tp := range exposedPorts {
|
|
|
|
natPort, err := nat.NewPort(tp.Proto.String(), strconv.Itoa(int(tp.Port)))
|
|
|
|
if err != nil {
|
Remove static errors from errors package.
Moving all strings to the errors package wasn't a good idea after all.
Our custom implementation of Go errors predates everything that's nice
and good about working with errors in Go. Take as an example what we
have to do to get an error message:
```go
func GetErrorMessage(err error) string {
switch err.(type) {
case errcode.Error:
e, _ := err.(errcode.Error)
return e.Message
case errcode.ErrorCode:
ec, _ := err.(errcode.ErrorCode)
return ec.Message()
default:
return err.Error()
}
}
```
This goes against every good practice for Go development. The language already provides a simple, intuitive and standard way to get error messages, that is calling the `Error()` method from an error. Reinventing the error interface is a mistake.
Our custom implementation also makes very hard to reason about errors, another nice thing about Go. I found several (>10) error declarations that we don't use anywhere. This is a clear sign about how little we know about the errors we return. I also found several error usages where the number of arguments was different than the parameters declared in the error, another clear example of how difficult is to reason about errors.
Moreover, our custom implementation didn't really make easier for people to return custom HTTP status code depending on the errors. Again, it's hard to reason about when to set custom codes and how. Take an example what we have to do to extract the message and status code from an error before returning a response from the API:
```go
switch err.(type) {
case errcode.ErrorCode:
daError, _ := err.(errcode.ErrorCode)
statusCode = daError.Descriptor().HTTPStatusCode
errMsg = daError.Message()
case errcode.Error:
// For reference, if you're looking for a particular error
// then you can do something like :
// import ( derr "github.com/docker/docker/errors" )
// if daError.ErrorCode() == derr.ErrorCodeNoSuchContainer { ... }
daError, _ := err.(errcode.Error)
statusCode = daError.ErrorCode().Descriptor().HTTPStatusCode
errMsg = daError.Message
default:
// This part of will be removed once we've
// converted everything over to use the errcode package
// FIXME: this is brittle and should not be necessary.
// If we need to differentiate between different possible error types,
// we should create appropriate error types with clearly defined meaning
errStr := strings.ToLower(err.Error())
for keyword, status := range map[string]int{
"not found": http.StatusNotFound,
"no such": http.StatusNotFound,
"bad parameter": http.StatusBadRequest,
"conflict": http.StatusConflict,
"impossible": http.StatusNotAcceptable,
"wrong login/password": http.StatusUnauthorized,
"hasn't been activated": http.StatusForbidden,
} {
if strings.Contains(errStr, keyword) {
statusCode = status
break
}
}
}
```
You can notice two things in that code:
1. We have to explain how errors work, because our implementation goes against how easy to use Go errors are.
2. At no moment we arrived to remove that `switch` statement that was the original reason to use our custom implementation.
This change removes all our status errors from the errors package and puts them back in their specific contexts.
IT puts the messages back with their contexts. That way, we know right away when errors used and how to generate their messages.
It uses custom interfaces to reason about errors. Errors that need to response with a custom status code MUST implementent this simple interface:
```go
type errorWithStatus interface {
HTTPErrorStatusCode() int
}
```
This interface is very straightforward to implement. It also preserves Go errors real behavior, getting the message is as simple as using the `Error()` method.
I included helper functions to generate errors that use custom status code in `errors/errors.go`.
By doing this, we remove the hard dependency we have eeverywhere to our custom errors package. Yes, you can use it as a helper to generate error, but it's still very easy to generate errors without it.
Please, read this fantastic blog post about errors in Go: http://dave.cheney.net/2014/12/24/inspecting-errors
Signed-off-by: David Calavera <david.calavera@gmail.com>
2016-02-25 18:53:35 +03:00
|
|
|
return pm, fmt.Errorf("Error parsing Port value(%v):%v", tp.Port, err)
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
2016-01-26 06:55:18 +03:00
|
|
|
pm[natPort] = nil
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mapData, ok := driverInfo[netlabel.PortMap]
|
|
|
|
if !ok {
|
2016-01-26 06:55:18 +03:00
|
|
|
return pm, nil
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
if portMapping, ok := mapData.([]types.PortBinding); ok {
|
|
|
|
for _, pp := range portMapping {
|
|
|
|
natPort, err := nat.NewPort(pp.Proto.String(), strconv.Itoa(int(pp.Port)))
|
|
|
|
if err != nil {
|
2016-01-26 06:55:18 +03:00
|
|
|
return pm, err
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
natBndg := nat.PortBinding{HostIP: pp.HostIP.String(), HostPort: strconv.Itoa(int(pp.HostPort))}
|
2016-01-26 06:55:18 +03:00
|
|
|
pm[natPort] = append(pm[natPort], natBndg)
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-01-26 06:55:18 +03:00
|
|
|
return pm, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func getSandboxPortMapInfo(sb libnetwork.Sandbox) nat.PortMap {
|
|
|
|
pm := nat.PortMap{}
|
|
|
|
if sb == nil {
|
|
|
|
return pm
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, ep := range sb.Endpoints() {
|
|
|
|
pm, _ = getEndpointPortMapInfo(ep)
|
|
|
|
if len(pm) > 0 {
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return pm
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
// BuildEndpointInfo sets endpoint-related fields on container.NetworkSettings based on the provided network and endpoint.
|
|
|
|
func (container *Container) BuildEndpointInfo(n libnetwork.Network, ep libnetwork.Endpoint) error {
|
|
|
|
if ep == nil {
|
Remove static errors from errors package.
Moving all strings to the errors package wasn't a good idea after all.
Our custom implementation of Go errors predates everything that's nice
and good about working with errors in Go. Take as an example what we
have to do to get an error message:
```go
func GetErrorMessage(err error) string {
switch err.(type) {
case errcode.Error:
e, _ := err.(errcode.Error)
return e.Message
case errcode.ErrorCode:
ec, _ := err.(errcode.ErrorCode)
return ec.Message()
default:
return err.Error()
}
}
```
This goes against every good practice for Go development. The language already provides a simple, intuitive and standard way to get error messages, that is calling the `Error()` method from an error. Reinventing the error interface is a mistake.
Our custom implementation also makes very hard to reason about errors, another nice thing about Go. I found several (>10) error declarations that we don't use anywhere. This is a clear sign about how little we know about the errors we return. I also found several error usages where the number of arguments was different than the parameters declared in the error, another clear example of how difficult is to reason about errors.
Moreover, our custom implementation didn't really make easier for people to return custom HTTP status code depending on the errors. Again, it's hard to reason about when to set custom codes and how. Take an example what we have to do to extract the message and status code from an error before returning a response from the API:
```go
switch err.(type) {
case errcode.ErrorCode:
daError, _ := err.(errcode.ErrorCode)
statusCode = daError.Descriptor().HTTPStatusCode
errMsg = daError.Message()
case errcode.Error:
// For reference, if you're looking for a particular error
// then you can do something like :
// import ( derr "github.com/docker/docker/errors" )
// if daError.ErrorCode() == derr.ErrorCodeNoSuchContainer { ... }
daError, _ := err.(errcode.Error)
statusCode = daError.ErrorCode().Descriptor().HTTPStatusCode
errMsg = daError.Message
default:
// This part of will be removed once we've
// converted everything over to use the errcode package
// FIXME: this is brittle and should not be necessary.
// If we need to differentiate between different possible error types,
// we should create appropriate error types with clearly defined meaning
errStr := strings.ToLower(err.Error())
for keyword, status := range map[string]int{
"not found": http.StatusNotFound,
"no such": http.StatusNotFound,
"bad parameter": http.StatusBadRequest,
"conflict": http.StatusConflict,
"impossible": http.StatusNotAcceptable,
"wrong login/password": http.StatusUnauthorized,
"hasn't been activated": http.StatusForbidden,
} {
if strings.Contains(errStr, keyword) {
statusCode = status
break
}
}
}
```
You can notice two things in that code:
1. We have to explain how errors work, because our implementation goes against how easy to use Go errors are.
2. At no moment we arrived to remove that `switch` statement that was the original reason to use our custom implementation.
This change removes all our status errors from the errors package and puts them back in their specific contexts.
IT puts the messages back with their contexts. That way, we know right away when errors used and how to generate their messages.
It uses custom interfaces to reason about errors. Errors that need to response with a custom status code MUST implementent this simple interface:
```go
type errorWithStatus interface {
HTTPErrorStatusCode() int
}
```
This interface is very straightforward to implement. It also preserves Go errors real behavior, getting the message is as simple as using the `Error()` method.
I included helper functions to generate errors that use custom status code in `errors/errors.go`.
By doing this, we remove the hard dependency we have eeverywhere to our custom errors package. Yes, you can use it as a helper to generate error, but it's still very easy to generate errors without it.
Please, read this fantastic blog post about errors in Go: http://dave.cheney.net/2014/12/24/inspecting-errors
Signed-off-by: David Calavera <david.calavera@gmail.com>
2016-02-25 18:53:35 +03:00
|
|
|
return errInvalidEndpoint
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
networkSettings := container.NetworkSettings
|
|
|
|
if networkSettings == nil {
|
Remove static errors from errors package.
Moving all strings to the errors package wasn't a good idea after all.
Our custom implementation of Go errors predates everything that's nice
and good about working with errors in Go. Take as an example what we
have to do to get an error message:
```go
func GetErrorMessage(err error) string {
switch err.(type) {
case errcode.Error:
e, _ := err.(errcode.Error)
return e.Message
case errcode.ErrorCode:
ec, _ := err.(errcode.ErrorCode)
return ec.Message()
default:
return err.Error()
}
}
```
This goes against every good practice for Go development. The language already provides a simple, intuitive and standard way to get error messages, that is calling the `Error()` method from an error. Reinventing the error interface is a mistake.
Our custom implementation also makes very hard to reason about errors, another nice thing about Go. I found several (>10) error declarations that we don't use anywhere. This is a clear sign about how little we know about the errors we return. I also found several error usages where the number of arguments was different than the parameters declared in the error, another clear example of how difficult is to reason about errors.
Moreover, our custom implementation didn't really make easier for people to return custom HTTP status code depending on the errors. Again, it's hard to reason about when to set custom codes and how. Take an example what we have to do to extract the message and status code from an error before returning a response from the API:
```go
switch err.(type) {
case errcode.ErrorCode:
daError, _ := err.(errcode.ErrorCode)
statusCode = daError.Descriptor().HTTPStatusCode
errMsg = daError.Message()
case errcode.Error:
// For reference, if you're looking for a particular error
// then you can do something like :
// import ( derr "github.com/docker/docker/errors" )
// if daError.ErrorCode() == derr.ErrorCodeNoSuchContainer { ... }
daError, _ := err.(errcode.Error)
statusCode = daError.ErrorCode().Descriptor().HTTPStatusCode
errMsg = daError.Message
default:
// This part of will be removed once we've
// converted everything over to use the errcode package
// FIXME: this is brittle and should not be necessary.
// If we need to differentiate between different possible error types,
// we should create appropriate error types with clearly defined meaning
errStr := strings.ToLower(err.Error())
for keyword, status := range map[string]int{
"not found": http.StatusNotFound,
"no such": http.StatusNotFound,
"bad parameter": http.StatusBadRequest,
"conflict": http.StatusConflict,
"impossible": http.StatusNotAcceptable,
"wrong login/password": http.StatusUnauthorized,
"hasn't been activated": http.StatusForbidden,
} {
if strings.Contains(errStr, keyword) {
statusCode = status
break
}
}
}
```
You can notice two things in that code:
1. We have to explain how errors work, because our implementation goes against how easy to use Go errors are.
2. At no moment we arrived to remove that `switch` statement that was the original reason to use our custom implementation.
This change removes all our status errors from the errors package and puts them back in their specific contexts.
IT puts the messages back with their contexts. That way, we know right away when errors used and how to generate their messages.
It uses custom interfaces to reason about errors. Errors that need to response with a custom status code MUST implementent this simple interface:
```go
type errorWithStatus interface {
HTTPErrorStatusCode() int
}
```
This interface is very straightforward to implement. It also preserves Go errors real behavior, getting the message is as simple as using the `Error()` method.
I included helper functions to generate errors that use custom status code in `errors/errors.go`.
By doing this, we remove the hard dependency we have eeverywhere to our custom errors package. Yes, you can use it as a helper to generate error, but it's still very easy to generate errors without it.
Please, read this fantastic blog post about errors in Go: http://dave.cheney.net/2014/12/24/inspecting-errors
Signed-off-by: David Calavera <david.calavera@gmail.com>
2016-02-25 18:53:35 +03:00
|
|
|
return errInvalidNetwork
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
epInfo := ep.Info()
|
|
|
|
if epInfo == nil {
|
|
|
|
// It is not an error to get an empty endpoint info
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
if _, ok := networkSettings.Networks[n.Name()]; !ok {
|
|
|
|
networkSettings.Networks[n.Name()] = new(network.EndpointSettings)
|
|
|
|
}
|
2016-01-14 08:46:59 +03:00
|
|
|
networkSettings.Networks[n.Name()].NetworkID = n.ID()
|
2015-11-12 22:55:17 +03:00
|
|
|
networkSettings.Networks[n.Name()].EndpointID = ep.ID()
|
|
|
|
|
|
|
|
iface := epInfo.Iface()
|
|
|
|
if iface == nil {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
if iface.MacAddress() != nil {
|
|
|
|
networkSettings.Networks[n.Name()].MacAddress = iface.MacAddress().String()
|
|
|
|
}
|
|
|
|
|
|
|
|
if iface.Address() != nil {
|
|
|
|
ones, _ := iface.Address().Mask.Size()
|
|
|
|
networkSettings.Networks[n.Name()].IPAddress = iface.Address().IP.String()
|
|
|
|
networkSettings.Networks[n.Name()].IPPrefixLen = ones
|
|
|
|
}
|
|
|
|
|
|
|
|
if iface.AddressIPv6() != nil && iface.AddressIPv6().IP.To16() != nil {
|
|
|
|
onesv6, _ := iface.AddressIPv6().Mask.Size()
|
|
|
|
networkSettings.Networks[n.Name()].GlobalIPv6Address = iface.AddressIPv6().IP.String()
|
|
|
|
networkSettings.Networks[n.Name()].GlobalIPv6PrefixLen = onesv6
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// UpdateJoinInfo updates network settings when container joins network n with endpoint ep.
|
|
|
|
func (container *Container) UpdateJoinInfo(n libnetwork.Network, ep libnetwork.Endpoint) error {
|
|
|
|
if err := container.buildPortMapInfo(ep); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
epInfo := ep.Info()
|
|
|
|
if epInfo == nil {
|
|
|
|
// It is not an error to get an empty endpoint info
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
if epInfo.Gateway() != nil {
|
|
|
|
container.NetworkSettings.Networks[n.Name()].Gateway = epInfo.Gateway().String()
|
|
|
|
}
|
|
|
|
if epInfo.GatewayIPv6().To16() != nil {
|
|
|
|
container.NetworkSettings.Networks[n.Name()].IPv6Gateway = epInfo.GatewayIPv6().String()
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// UpdateSandboxNetworkSettings updates the sandbox ID and Key.
|
|
|
|
func (container *Container) UpdateSandboxNetworkSettings(sb libnetwork.Sandbox) error {
|
|
|
|
container.NetworkSettings.SandboxID = sb.ID()
|
|
|
|
container.NetworkSettings.SandboxKey = sb.Key()
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2016-01-05 22:20:47 +03:00
|
|
|
// BuildJoinOptions builds endpoint Join options from a given network.
|
|
|
|
func (container *Container) BuildJoinOptions(n libnetwork.Network) ([]libnetwork.EndpointOption, error) {
|
|
|
|
var joinOptions []libnetwork.EndpointOption
|
|
|
|
if epConfig, ok := container.NetworkSettings.Networks[n.Name()]; ok {
|
|
|
|
for _, str := range epConfig.Links {
|
|
|
|
name, alias, err := runconfigopts.ParseLink(str)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
joinOptions = append(joinOptions, libnetwork.CreateOptionAlias(name, alias))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return joinOptions, nil
|
|
|
|
}
|
|
|
|
|
2015-11-12 22:55:17 +03:00
|
|
|
// BuildCreateEndpointOptions builds endpoint options from a given network.
|
2016-01-26 06:55:18 +03:00
|
|
|
func (container *Container) BuildCreateEndpointOptions(n libnetwork.Network, epConfig *network.EndpointSettings, sb libnetwork.Sandbox) ([]libnetwork.EndpointOption, error) {
|
2015-11-12 22:55:17 +03:00
|
|
|
var (
|
|
|
|
portSpecs = make(nat.PortSet)
|
|
|
|
bindings = make(nat.PortMap)
|
|
|
|
pbList []types.PortBinding
|
|
|
|
exposeList []types.TransportPort
|
|
|
|
createOptions []libnetwork.EndpointOption
|
|
|
|
)
|
|
|
|
|
|
|
|
if n.Name() == "bridge" || container.NetworkSettings.IsAnonymousEndpoint {
|
|
|
|
createOptions = append(createOptions, libnetwork.CreateOptionAnonymous())
|
|
|
|
}
|
|
|
|
|
2016-01-25 22:14:29 +03:00
|
|
|
if epConfig != nil {
|
2016-01-08 03:18:34 +03:00
|
|
|
ipam := epConfig.IPAMConfig
|
|
|
|
if ipam != nil && (ipam.IPv4Address != "" || ipam.IPv6Address != "") {
|
|
|
|
createOptions = append(createOptions,
|
|
|
|
libnetwork.CreateOptionIpam(net.ParseIP(ipam.IPv4Address), net.ParseIP(ipam.IPv6Address), nil))
|
|
|
|
}
|
2016-01-08 16:45:56 +03:00
|
|
|
|
|
|
|
for _, alias := range epConfig.Aliases {
|
|
|
|
createOptions = append(createOptions, libnetwork.CreateOptionMyAlias(alias))
|
|
|
|
}
|
2016-01-08 03:18:34 +03:00
|
|
|
}
|
|
|
|
|
2016-01-22 07:49:02 +03:00
|
|
|
if !containertypes.NetworkMode(n.Name()).IsUserDefined() {
|
2016-01-09 00:38:52 +03:00
|
|
|
createOptions = append(createOptions, libnetwork.CreateOptionDisableResolution())
|
|
|
|
}
|
|
|
|
|
2016-01-26 06:55:18 +03:00
|
|
|
// configs that are applicable only for the endpoint in the network
|
2015-11-12 22:55:17 +03:00
|
|
|
// to which container was connected to on docker run.
|
2016-01-26 06:55:18 +03:00
|
|
|
// Ideally all these network-specific endpoint configurations must be moved under
|
|
|
|
// container.NetworkSettings.Networks[n.Name()]
|
|
|
|
if n.Name() == container.HostConfig.NetworkMode.NetworkName() ||
|
|
|
|
(n.Name() == "bridge" && container.HostConfig.NetworkMode.IsDefault()) {
|
|
|
|
if container.Config.MacAddress != "" {
|
|
|
|
mac, err := net.ParseMAC(container.Config.MacAddress)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
genericOption := options.Generic{
|
|
|
|
netlabel.MacAddress: mac,
|
|
|
|
}
|
|
|
|
|
|
|
|
createOptions = append(createOptions, libnetwork.EndpointOptionGeneric(genericOption))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Port-mapping rules belong to the container & applicable only to non-internal networks
|
|
|
|
portmaps := getSandboxPortMapInfo(sb)
|
|
|
|
if n.Info().Internal() || len(portmaps) > 0 {
|
2015-11-12 22:55:17 +03:00
|
|
|
return createOptions, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
if container.Config.ExposedPorts != nil {
|
|
|
|
portSpecs = container.Config.ExposedPorts
|
|
|
|
}
|
|
|
|
|
|
|
|
if container.HostConfig.PortBindings != nil {
|
|
|
|
for p, b := range container.HostConfig.PortBindings {
|
|
|
|
bindings[p] = []nat.PortBinding{}
|
|
|
|
for _, bb := range b {
|
|
|
|
bindings[p] = append(bindings[p], nat.PortBinding{
|
|
|
|
HostIP: bb.HostIP,
|
|
|
|
HostPort: bb.HostPort,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ports := make([]nat.Port, len(portSpecs))
|
|
|
|
var i int
|
|
|
|
for p := range portSpecs {
|
|
|
|
ports[i] = p
|
|
|
|
i++
|
|
|
|
}
|
|
|
|
nat.SortPortMap(ports, bindings)
|
|
|
|
for _, port := range ports {
|
|
|
|
expose := types.TransportPort{}
|
|
|
|
expose.Proto = types.ParseProtocol(port.Proto())
|
|
|
|
expose.Port = uint16(port.Int())
|
|
|
|
exposeList = append(exposeList, expose)
|
|
|
|
|
|
|
|
pb := types.PortBinding{Port: expose.Port, Proto: expose.Proto}
|
|
|
|
binding := bindings[port]
|
|
|
|
for i := 0; i < len(binding); i++ {
|
|
|
|
pbCopy := pb.GetCopy()
|
|
|
|
newP, err := nat.NewPort(nat.SplitProtoPort(binding[i].HostPort))
|
|
|
|
var portStart, portEnd int
|
|
|
|
if err == nil {
|
|
|
|
portStart, portEnd, err = newP.Range()
|
|
|
|
}
|
|
|
|
if err != nil {
|
Remove static errors from errors package.
Moving all strings to the errors package wasn't a good idea after all.
Our custom implementation of Go errors predates everything that's nice
and good about working with errors in Go. Take as an example what we
have to do to get an error message:
```go
func GetErrorMessage(err error) string {
switch err.(type) {
case errcode.Error:
e, _ := err.(errcode.Error)
return e.Message
case errcode.ErrorCode:
ec, _ := err.(errcode.ErrorCode)
return ec.Message()
default:
return err.Error()
}
}
```
This goes against every good practice for Go development. The language already provides a simple, intuitive and standard way to get error messages, that is calling the `Error()` method from an error. Reinventing the error interface is a mistake.
Our custom implementation also makes very hard to reason about errors, another nice thing about Go. I found several (>10) error declarations that we don't use anywhere. This is a clear sign about how little we know about the errors we return. I also found several error usages where the number of arguments was different than the parameters declared in the error, another clear example of how difficult is to reason about errors.
Moreover, our custom implementation didn't really make easier for people to return custom HTTP status code depending on the errors. Again, it's hard to reason about when to set custom codes and how. Take an example what we have to do to extract the message and status code from an error before returning a response from the API:
```go
switch err.(type) {
case errcode.ErrorCode:
daError, _ := err.(errcode.ErrorCode)
statusCode = daError.Descriptor().HTTPStatusCode
errMsg = daError.Message()
case errcode.Error:
// For reference, if you're looking for a particular error
// then you can do something like :
// import ( derr "github.com/docker/docker/errors" )
// if daError.ErrorCode() == derr.ErrorCodeNoSuchContainer { ... }
daError, _ := err.(errcode.Error)
statusCode = daError.ErrorCode().Descriptor().HTTPStatusCode
errMsg = daError.Message
default:
// This part of will be removed once we've
// converted everything over to use the errcode package
// FIXME: this is brittle and should not be necessary.
// If we need to differentiate between different possible error types,
// we should create appropriate error types with clearly defined meaning
errStr := strings.ToLower(err.Error())
for keyword, status := range map[string]int{
"not found": http.StatusNotFound,
"no such": http.StatusNotFound,
"bad parameter": http.StatusBadRequest,
"conflict": http.StatusConflict,
"impossible": http.StatusNotAcceptable,
"wrong login/password": http.StatusUnauthorized,
"hasn't been activated": http.StatusForbidden,
} {
if strings.Contains(errStr, keyword) {
statusCode = status
break
}
}
}
```
You can notice two things in that code:
1. We have to explain how errors work, because our implementation goes against how easy to use Go errors are.
2. At no moment we arrived to remove that `switch` statement that was the original reason to use our custom implementation.
This change removes all our status errors from the errors package and puts them back in their specific contexts.
IT puts the messages back with their contexts. That way, we know right away when errors used and how to generate their messages.
It uses custom interfaces to reason about errors. Errors that need to response with a custom status code MUST implementent this simple interface:
```go
type errorWithStatus interface {
HTTPErrorStatusCode() int
}
```
This interface is very straightforward to implement. It also preserves Go errors real behavior, getting the message is as simple as using the `Error()` method.
I included helper functions to generate errors that use custom status code in `errors/errors.go`.
By doing this, we remove the hard dependency we have eeverywhere to our custom errors package. Yes, you can use it as a helper to generate error, but it's still very easy to generate errors without it.
Please, read this fantastic blog post about errors in Go: http://dave.cheney.net/2014/12/24/inspecting-errors
Signed-off-by: David Calavera <david.calavera@gmail.com>
2016-02-25 18:53:35 +03:00
|
|
|
return nil, fmt.Errorf("Error parsing HostPort value(%s):%v", binding[i].HostPort, err)
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
pbCopy.HostPort = uint16(portStart)
|
|
|
|
pbCopy.HostPortEnd = uint16(portEnd)
|
|
|
|
pbCopy.HostIP = net.ParseIP(binding[i].HostIP)
|
|
|
|
pbList = append(pbList, pbCopy)
|
|
|
|
}
|
|
|
|
|
|
|
|
if container.HostConfig.PublishAllPorts && len(binding) == 0 {
|
|
|
|
pbList = append(pbList, pb)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
createOptions = append(createOptions,
|
|
|
|
libnetwork.CreateOptionPortMapping(pbList),
|
|
|
|
libnetwork.CreateOptionExposedPorts(exposeList))
|
|
|
|
|
|
|
|
return createOptions, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// appendNetworkMounts appends any network mounts to the array of mount points passed in
|
|
|
|
func appendNetworkMounts(container *Container, volumeMounts []volume.MountPoint) ([]volume.MountPoint, error) {
|
|
|
|
for _, mnt := range container.NetworkMounts() {
|
|
|
|
dest, err := container.GetResourcePath(mnt.Destination)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
volumeMounts = append(volumeMounts, volume.MountPoint{Destination: dest})
|
|
|
|
}
|
|
|
|
return volumeMounts, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// NetworkMounts returns the list of network mounts.
|
|
|
|
func (container *Container) NetworkMounts() []execdriver.Mount {
|
|
|
|
var mounts []execdriver.Mount
|
|
|
|
shared := container.HostConfig.NetworkMode.IsContainer()
|
|
|
|
if container.ResolvConfPath != "" {
|
|
|
|
if _, err := os.Stat(container.ResolvConfPath); err != nil {
|
|
|
|
logrus.Warnf("ResolvConfPath set to %q, but can't stat this filename (err = %v); skipping", container.ResolvConfPath, err)
|
|
|
|
} else {
|
|
|
|
label.Relabel(container.ResolvConfPath, container.MountLabel, shared)
|
|
|
|
writable := !container.HostConfig.ReadonlyRootfs
|
|
|
|
if m, exists := container.MountPoints["/etc/resolv.conf"]; exists {
|
|
|
|
writable = m.RW
|
|
|
|
}
|
|
|
|
mounts = append(mounts, execdriver.Mount{
|
|
|
|
Source: container.ResolvConfPath,
|
|
|
|
Destination: "/etc/resolv.conf",
|
|
|
|
Writable: writable,
|
2015-10-23 23:57:57 +03:00
|
|
|
Propagation: volume.DefaultPropagationMode,
|
2015-11-12 22:55:17 +03:00
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if container.HostnamePath != "" {
|
|
|
|
if _, err := os.Stat(container.HostnamePath); err != nil {
|
|
|
|
logrus.Warnf("HostnamePath set to %q, but can't stat this filename (err = %v); skipping", container.HostnamePath, err)
|
|
|
|
} else {
|
|
|
|
label.Relabel(container.HostnamePath, container.MountLabel, shared)
|
|
|
|
writable := !container.HostConfig.ReadonlyRootfs
|
|
|
|
if m, exists := container.MountPoints["/etc/hostname"]; exists {
|
|
|
|
writable = m.RW
|
|
|
|
}
|
|
|
|
mounts = append(mounts, execdriver.Mount{
|
|
|
|
Source: container.HostnamePath,
|
|
|
|
Destination: "/etc/hostname",
|
|
|
|
Writable: writable,
|
2015-10-23 23:57:57 +03:00
|
|
|
Propagation: volume.DefaultPropagationMode,
|
2015-11-12 22:55:17 +03:00
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if container.HostsPath != "" {
|
|
|
|
if _, err := os.Stat(container.HostsPath); err != nil {
|
|
|
|
logrus.Warnf("HostsPath set to %q, but can't stat this filename (err = %v); skipping", container.HostsPath, err)
|
|
|
|
} else {
|
|
|
|
label.Relabel(container.HostsPath, container.MountLabel, shared)
|
|
|
|
writable := !container.HostConfig.ReadonlyRootfs
|
|
|
|
if m, exists := container.MountPoints["/etc/hosts"]; exists {
|
|
|
|
writable = m.RW
|
|
|
|
}
|
|
|
|
mounts = append(mounts, execdriver.Mount{
|
|
|
|
Source: container.HostsPath,
|
|
|
|
Destination: "/etc/hosts",
|
|
|
|
Writable: writable,
|
2015-10-23 23:57:57 +03:00
|
|
|
Propagation: volume.DefaultPropagationMode,
|
2015-11-12 22:55:17 +03:00
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return mounts
|
|
|
|
}
|
|
|
|
|
|
|
|
// CopyImagePathContent copies files in destination to the volume.
|
|
|
|
func (container *Container) CopyImagePathContent(v volume.Volume, destination string) error {
|
|
|
|
rootfs, err := symlink.FollowSymlinkInScope(filepath.Join(container.BaseFS, destination), container.BaseFS)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
if _, err = ioutil.ReadDir(rootfs); err != nil {
|
|
|
|
if os.IsNotExist(err) {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
path, err := v.Mount()
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := copyExistingContents(rootfs, path); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
return v.Unmount()
|
|
|
|
}
|
|
|
|
|
|
|
|
// ShmResourcePath returns path to shm
|
|
|
|
func (container *Container) ShmResourcePath() (string, error) {
|
|
|
|
return container.GetRootResourcePath("shm")
|
|
|
|
}
|
|
|
|
|
|
|
|
// HasMountFor checks if path is a mountpoint
|
|
|
|
func (container *Container) HasMountFor(path string) bool {
|
|
|
|
_, exists := container.MountPoints[path]
|
|
|
|
return exists
|
|
|
|
}
|
|
|
|
|
|
|
|
// UnmountIpcMounts uses the provided unmount function to unmount shm and mqueue if they were mounted
|
|
|
|
func (container *Container) UnmountIpcMounts(unmount func(pth string) error) {
|
|
|
|
if container.HostConfig.IpcMode.IsContainer() || container.HostConfig.IpcMode.IsHost() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
var warnings []string
|
|
|
|
|
|
|
|
if !container.HasMountFor("/dev/shm") {
|
|
|
|
shmPath, err := container.ShmResourcePath()
|
|
|
|
if err != nil {
|
|
|
|
logrus.Error(err)
|
|
|
|
warnings = append(warnings, err.Error())
|
|
|
|
} else if shmPath != "" {
|
|
|
|
if err := unmount(shmPath); err != nil {
|
|
|
|
warnings = append(warnings, fmt.Sprintf("failed to umount %s: %v", shmPath, err))
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(warnings) > 0 {
|
|
|
|
logrus.Warnf("failed to cleanup ipc mounts:\n%v", strings.Join(warnings, "\n"))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// IpcMounts returns the list of IPC mounts
|
|
|
|
func (container *Container) IpcMounts() []execdriver.Mount {
|
|
|
|
var mounts []execdriver.Mount
|
|
|
|
|
|
|
|
if !container.HasMountFor("/dev/shm") {
|
|
|
|
label.SetFileLabel(container.ShmPath, container.MountLabel)
|
|
|
|
mounts = append(mounts, execdriver.Mount{
|
|
|
|
Source: container.ShmPath,
|
|
|
|
Destination: "/dev/shm",
|
|
|
|
Writable: true,
|
2015-10-23 23:57:57 +03:00
|
|
|
Propagation: volume.DefaultPropagationMode,
|
2015-11-12 22:55:17 +03:00
|
|
|
})
|
|
|
|
}
|
|
|
|
return mounts
|
|
|
|
}
|
|
|
|
|
2016-01-22 07:49:02 +03:00
|
|
|
func updateCommand(c *execdriver.Command, resources containertypes.Resources) {
|
2015-12-28 14:19:26 +03:00
|
|
|
c.Resources.BlkioWeight = resources.BlkioWeight
|
|
|
|
c.Resources.CPUShares = resources.CPUShares
|
|
|
|
c.Resources.CPUPeriod = resources.CPUPeriod
|
|
|
|
c.Resources.CPUQuota = resources.CPUQuota
|
|
|
|
c.Resources.CpusetCpus = resources.CpusetCpus
|
|
|
|
c.Resources.CpusetMems = resources.CpusetMems
|
|
|
|
c.Resources.Memory = resources.Memory
|
|
|
|
c.Resources.MemorySwap = resources.MemorySwap
|
|
|
|
c.Resources.MemoryReservation = resources.MemoryReservation
|
|
|
|
c.Resources.KernelMemory = resources.KernelMemory
|
|
|
|
}
|
|
|
|
|
2016-01-04 18:58:20 +03:00
|
|
|
// UpdateContainer updates configuration of a container.
|
2016-01-22 07:49:02 +03:00
|
|
|
func (container *Container) UpdateContainer(hostConfig *containertypes.HostConfig) error {
|
2015-12-28 14:19:26 +03:00
|
|
|
container.Lock()
|
|
|
|
|
2016-01-04 18:58:20 +03:00
|
|
|
// update resources of container
|
2015-12-28 14:19:26 +03:00
|
|
|
resources := hostConfig.Resources
|
|
|
|
cResources := &container.HostConfig.Resources
|
|
|
|
if resources.BlkioWeight != 0 {
|
|
|
|
cResources.BlkioWeight = resources.BlkioWeight
|
|
|
|
}
|
|
|
|
if resources.CPUShares != 0 {
|
|
|
|
cResources.CPUShares = resources.CPUShares
|
|
|
|
}
|
|
|
|
if resources.CPUPeriod != 0 {
|
|
|
|
cResources.CPUPeriod = resources.CPUPeriod
|
|
|
|
}
|
|
|
|
if resources.CPUQuota != 0 {
|
|
|
|
cResources.CPUQuota = resources.CPUQuota
|
|
|
|
}
|
|
|
|
if resources.CpusetCpus != "" {
|
|
|
|
cResources.CpusetCpus = resources.CpusetCpus
|
|
|
|
}
|
|
|
|
if resources.CpusetMems != "" {
|
|
|
|
cResources.CpusetMems = resources.CpusetMems
|
|
|
|
}
|
|
|
|
if resources.Memory != 0 {
|
|
|
|
cResources.Memory = resources.Memory
|
|
|
|
}
|
|
|
|
if resources.MemorySwap != 0 {
|
|
|
|
cResources.MemorySwap = resources.MemorySwap
|
|
|
|
}
|
|
|
|
if resources.MemoryReservation != 0 {
|
|
|
|
cResources.MemoryReservation = resources.MemoryReservation
|
|
|
|
}
|
|
|
|
if resources.KernelMemory != 0 {
|
|
|
|
cResources.KernelMemory = resources.KernelMemory
|
|
|
|
}
|
2016-01-04 18:58:20 +03:00
|
|
|
|
|
|
|
// update HostConfig of container
|
|
|
|
if hostConfig.RestartPolicy.Name != "" {
|
|
|
|
container.HostConfig.RestartPolicy = hostConfig.RestartPolicy
|
|
|
|
}
|
2015-12-28 14:19:26 +03:00
|
|
|
container.Unlock()
|
|
|
|
|
|
|
|
// If container is not running, update hostConfig struct is enough,
|
|
|
|
// resources will be updated when the container is started again.
|
|
|
|
// If container is running (including paused), we need to update
|
|
|
|
// the command so we can update configs to the real world.
|
|
|
|
if container.IsRunning() {
|
|
|
|
container.Lock()
|
2015-12-30 04:33:16 +03:00
|
|
|
updateCommand(container.Command, *cResources)
|
2015-12-28 14:19:26 +03:00
|
|
|
container.Unlock()
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := container.ToDiskLocking(); err != nil {
|
|
|
|
logrus.Errorf("Error saving updated container: %v", err)
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2015-11-12 22:55:17 +03:00
|
|
|
func detachMounted(path string) error {
|
|
|
|
return syscall.Unmount(path, syscall.MNT_DETACH)
|
|
|
|
}
|
|
|
|
|
|
|
|
// UnmountVolumes unmounts all volumes
|
2015-12-22 03:45:31 +03:00
|
|
|
func (container *Container) UnmountVolumes(forceSyscall bool, volumeEventLog func(name, action string, attributes map[string]string)) error {
|
2015-11-12 22:55:17 +03:00
|
|
|
var (
|
|
|
|
volumeMounts []volume.MountPoint
|
|
|
|
err error
|
|
|
|
)
|
|
|
|
|
|
|
|
for _, mntPoint := range container.MountPoints {
|
|
|
|
dest, err := container.GetResourcePath(mntPoint.Destination)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
volumeMounts = append(volumeMounts, volume.MountPoint{Destination: dest, Volume: mntPoint.Volume})
|
|
|
|
}
|
|
|
|
|
|
|
|
// Append any network mounts to the list (this is a no-op on Windows)
|
|
|
|
if volumeMounts, err = appendNetworkMounts(container, volumeMounts); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, volumeMount := range volumeMounts {
|
|
|
|
if forceSyscall {
|
|
|
|
if err := detachMounted(volumeMount.Destination); err != nil {
|
|
|
|
logrus.Warnf("%s unmountVolumes: Failed to do lazy umount %v", container.ID, err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if volumeMount.Volume != nil {
|
|
|
|
if err := volumeMount.Volume.Unmount(); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2015-12-22 03:45:31 +03:00
|
|
|
|
|
|
|
attributes := map[string]string{
|
|
|
|
"driver": volumeMount.Volume.DriverName(),
|
|
|
|
"container": container.ID,
|
|
|
|
}
|
|
|
|
volumeEventLog(volumeMount.Volume.Name(), "unmount", attributes)
|
2015-11-12 22:55:17 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// copyExistingContents copies from the source to the destination and
|
|
|
|
// ensures the ownership is appropriately set.
|
|
|
|
func copyExistingContents(source, destination string) error {
|
|
|
|
volList, err := ioutil.ReadDir(source)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
if len(volList) > 0 {
|
|
|
|
srcList, err := ioutil.ReadDir(destination)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
if len(srcList) == 0 {
|
2016-01-14 08:46:59 +03:00
|
|
|
// If the source volume is empty, copies files from the root into the volume
|
2015-11-12 22:55:17 +03:00
|
|
|
if err := chrootarchive.CopyWithTar(source, destination); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return copyOwnership(source, destination)
|
|
|
|
}
|
|
|
|
|
|
|
|
// copyOwnership copies the permissions and uid:gid of the source file
|
|
|
|
// to the destination file
|
|
|
|
func copyOwnership(source, destination string) error {
|
|
|
|
stat, err := system.Stat(source)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := os.Chown(destination, int(stat.UID()), int(stat.GID())); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
return os.Chmod(destination, os.FileMode(stat.Mode()))
|
|
|
|
}
|
|
|
|
|
|
|
|
// TmpfsMounts returns the list of tmpfs mounts
|
|
|
|
func (container *Container) TmpfsMounts() []execdriver.Mount {
|
|
|
|
var mounts []execdriver.Mount
|
|
|
|
for dest, data := range container.HostConfig.Tmpfs {
|
|
|
|
mounts = append(mounts, execdriver.Mount{
|
|
|
|
Source: "tmpfs",
|
|
|
|
Destination: dest,
|
|
|
|
Data: data,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
return mounts
|
|
|
|
}
|
2016-01-28 00:03:09 +03:00
|
|
|
|
|
|
|
// cleanResourcePath cleans a resource path and prepares to combine with mnt path
|
|
|
|
func cleanResourcePath(path string) string {
|
|
|
|
return filepath.Join(string(os.PathSeparator), path)
|
|
|
|
}
|