2013-01-19 04:13:39 +04:00
package docker
import (
"container/list"
"fmt"
2013-05-15 02:37:35 +04:00
"github.com/dotcloud/docker/utils"
2013-03-21 11:25:00 +04:00
"io"
2013-01-19 04:13:39 +04:00
"io/ioutil"
2013-04-19 07:47:24 +04:00
"log"
2013-01-19 04:13:39 +04:00
"os"
2013-04-01 04:40:39 +04:00
"os/exec"
2013-01-19 04:13:39 +04:00
"path"
2013-01-30 00:15:39 +04:00
"sort"
2013-04-01 04:40:39 +04:00
"strings"
2013-09-08 04:03:40 +04:00
"time"
2013-01-19 04:13:39 +04:00
)
2013-09-07 04:33:05 +04:00
var defaultDns = [ ] string { "8.8.8.8" , "8.8.4.4" }
2013-04-19 07:55:41 +04:00
type Capabilities struct {
2013-08-19 16:34:30 +04:00
MemoryLimit bool
SwapLimit bool
IPv4ForwardingDisabled bool
2013-04-19 07:55:41 +04:00
}
2013-03-21 11:41:15 +04:00
type Runtime struct {
2013-02-28 23:52:07 +04:00
root string
repository string
containers * list . List
networkManager * NetworkManager
2013-03-22 04:47:23 +04:00
graph * Graph
repositories * TagStore
2013-05-15 02:37:35 +04:00
idIndex * utils . TruncIndex
2013-04-19 07:55:41 +04:00
capabilities * Capabilities
2013-05-15 02:37:35 +04:00
kernelVersion * utils . KernelVersionInfo
2013-04-25 06:01:23 +04:00
autoRestart bool
2013-04-06 05:00:10 +04:00
volumes * Graph
2013-05-16 04:17:33 +04:00
srv * Server
2013-06-06 01:20:19 +04:00
Dns [ ] string
2013-03-21 11:25:00 +04:00
}
var sysInitPath string
func init ( ) {
2013-05-15 02:37:35 +04:00
sysInitPath = utils . SelfPath ( )
2013-01-19 04:13:39 +04:00
}
2013-09-07 04:43:34 +04:00
// List returns an array of all containers registered in the runtime.
2013-03-21 11:41:15 +04:00
func ( runtime * Runtime ) List ( ) [ ] * Container {
2013-01-30 00:15:39 +04:00
containers := new ( History )
2013-03-21 11:41:15 +04:00
for e := runtime . containers . Front ( ) ; e != nil ; e = e . Next ( ) {
2013-01-30 00:15:39 +04:00
containers . Add ( e . Value . ( * Container ) )
2013-01-29 15:24:31 +04:00
}
2013-01-30 00:15:39 +04:00
return * containers
2013-01-19 04:13:39 +04:00
}
2013-03-21 11:41:15 +04:00
func ( runtime * Runtime ) getContainerElement ( id string ) * list . Element {
for e := runtime . containers . Front ( ) ; e != nil ; e = e . Next ( ) {
2013-01-19 04:13:39 +04:00
container := e . Value . ( * Container )
2013-06-04 22:00:22 +04:00
if container . ID == id {
2013-01-19 04:13:39 +04:00
return e
}
}
return nil
}
2013-09-07 04:43:34 +04:00
// Get looks for a container by the specified ID or name, and returns it.
// If the container is not found, or if an error occurs, nil is returned.
2013-03-31 13:02:01 +04:00
func ( runtime * Runtime ) Get ( name string ) * Container {
id , err := runtime . idIndex . Get ( name )
if err != nil {
return nil
}
2013-03-21 11:41:15 +04:00
e := runtime . getContainerElement ( id )
2013-01-19 04:13:39 +04:00
if e == nil {
return nil
}
return e . Value . ( * Container )
}
2013-09-07 04:43:34 +04:00
// Exists returns a true if a container of the specified ID or name exists,
// false otherwise.
2013-03-21 11:41:15 +04:00
func ( runtime * Runtime ) Exists ( id string ) bool {
return runtime . Get ( id ) != nil
2013-01-19 04:13:39 +04:00
}
2013-03-21 11:41:15 +04:00
func ( runtime * Runtime ) containerRoot ( id string ) string {
return path . Join ( runtime . repository , id )
2013-03-21 11:25:00 +04:00
}
2013-09-07 04:43:34 +04:00
// Load reads the contents of a container from disk and registers
// it with Register.
// This is typically done at startup.
2013-03-21 11:41:15 +04:00
func ( runtime * Runtime ) Load ( id string ) ( * Container , error ) {
container := & Container { root : runtime . containerRoot ( id ) }
2013-03-21 11:25:00 +04:00
if err := container . FromDisk ( ) ; err != nil {
return nil , err
}
2013-06-04 22:00:22 +04:00
if container . ID != id {
return container , fmt . Errorf ( "Container %s is stored at %s" , container . ID , id )
2013-03-21 11:25:00 +04:00
}
2013-04-11 20:26:17 +04:00
if container . State . Running {
container . State . Ghost = true
}
2013-03-21 11:41:15 +04:00
if err := runtime . Register ( container ) ; err != nil {
2013-01-19 04:13:39 +04:00
return nil , err
}
return container , nil
}
2013-06-04 22:00:22 +04:00
// Register makes a container object usable by the runtime as <container.ID>
2013-03-21 11:41:15 +04:00
func ( runtime * Runtime ) Register ( container * Container ) error {
2013-06-04 22:00:22 +04:00
if container . runtime != nil || runtime . Exists ( container . ID ) {
2013-03-21 11:25:00 +04:00
return fmt . Errorf ( "Container is already loaded" )
}
2013-06-04 22:00:22 +04:00
if err := validateID ( container . ID ) ; err != nil {
2013-03-21 11:25:00 +04:00
return err
}
2013-04-01 04:40:39 +04:00
2013-04-10 04:40:02 +04:00
// init the wait lock
container . waitLock = make ( chan struct { } )
2013-03-21 11:41:15 +04:00
container . runtime = runtime
2013-04-09 18:57:59 +04:00
2013-03-21 11:25:00 +04:00
// Attach to stdout and stderr
2013-05-15 02:37:35 +04:00
container . stderr = utils . NewWriteBroadcaster ( )
container . stdout = utils . NewWriteBroadcaster ( )
2013-03-21 11:25:00 +04:00
// Attach to stdin
if container . Config . OpenStdin {
container . stdin , container . stdinPipe = io . Pipe ( )
} else {
2013-05-15 02:37:35 +04:00
container . stdinPipe = utils . NopWriteCloser ( ioutil . Discard ) // Silently drop stdin
2013-03-21 11:25:00 +04:00
}
// done
2013-03-21 11:41:15 +04:00
runtime . containers . PushBack ( container )
2013-06-04 22:00:22 +04:00
runtime . idIndex . Add ( container . ID )
2013-04-19 23:08:43 +04:00
2013-04-25 06:01:23 +04:00
// When we actually restart, Start() do the monitoring.
// However, when we simply 'reattach', we have to restart a monitor
nomonitor := false
// FIXME: if the container is supposed to be running but is not, auto restart it?
// if so, then we need to restart monitor and init a new lock
// If the container is supposed to be running, make sure of it
if container . State . Running {
2013-06-04 22:00:22 +04:00
output , err := exec . Command ( "lxc-info" , "-n" , container . ID ) . CombinedOutput ( )
2013-06-04 17:51:12 +04:00
if err != nil {
2013-04-25 06:01:23 +04:00
return err
2013-06-04 17:51:12 +04:00
}
if ! strings . Contains ( string ( output ) , "RUNNING" ) {
2013-06-04 22:00:22 +04:00
utils . Debugf ( "Container %s was supposed to be running be is not." , container . ID )
2013-06-04 17:51:12 +04:00
if runtime . autoRestart {
utils . Debugf ( "Restarting" )
container . State . Ghost = false
container . State . setStopped ( 0 )
2013-05-14 03:39:54 +04:00
hostConfig := & HostConfig { }
if err := container . Start ( hostConfig ) ; err != nil {
2013-06-04 17:51:12 +04:00
return err
}
nomonitor = true
} else {
utils . Debugf ( "Marking as stopped" )
container . State . setStopped ( - 127 )
if err := container . ToDisk ( ) ; err != nil {
return err
2013-04-25 06:01:23 +04:00
}
}
}
}
2013-04-19 23:08:43 +04:00
// If the container is not running or just has been flagged not running
// then close the wait lock chan (will be reset upon start)
if ! container . State . Running {
close ( container . waitLock )
2013-04-25 06:01:23 +04:00
} else if ! nomonitor {
2013-04-19 23:08:43 +04:00
container . allocateNetwork ( )
2013-08-15 22:48:05 +04:00
// hostConfig isn't needed here and can be nil
go container . monitor ( nil )
2013-04-19 23:08:43 +04:00
}
2013-03-21 11:25:00 +04:00
return nil
}
2013-07-11 21:18:28 +04:00
func ( runtime * Runtime ) LogToDisk ( src * utils . WriteBroadcaster , dst , stream string ) error {
2013-03-21 11:25:00 +04:00
log , err := os . OpenFile ( dst , os . O_RDWR | os . O_APPEND | os . O_CREATE , 0600 )
if err != nil {
return err
}
2013-07-11 21:18:28 +04:00
src . AddWriter ( log , stream )
2013-03-21 11:25:00 +04:00
return nil
}
2013-09-07 04:43:34 +04:00
// Destroy unregisters a container from the runtime and cleanly removes its contents from the filesystem.
2013-03-21 11:41:15 +04:00
func ( runtime * Runtime ) Destroy ( container * Container ) error {
2013-05-07 22:18:13 +04:00
if container == nil {
return fmt . Errorf ( "The given container is <nil>" )
}
2013-06-04 22:00:22 +04:00
element := runtime . getContainerElement ( container . ID )
2013-01-19 04:13:39 +04:00
if element == nil {
2013-06-04 22:00:22 +04:00
return fmt . Errorf ( "Container %v not found - maybe it was already destroyed?" , container . ID )
2013-01-19 04:13:39 +04:00
}
2013-05-10 08:53:56 +04:00
if err := container . Stop ( 3 ) ; err != nil {
2013-01-19 04:13:39 +04:00
return err
}
2013-03-21 11:25:00 +04:00
if mounted , err := container . Mounted ( ) ; err != nil {
return err
} else if mounted {
if err := container . Unmount ( ) ; err != nil {
2013-06-04 22:00:22 +04:00
return fmt . Errorf ( "Unable to unmount container %v: %v" , container . ID , err )
2013-01-28 23:58:59 +04:00
}
2013-03-14 15:06:57 +04:00
}
2013-03-21 11:25:00 +04:00
// Deregister the container before removing its directory, to avoid race conditions
2013-06-04 22:00:22 +04:00
runtime . idIndex . Delete ( container . ID )
2013-03-21 11:41:15 +04:00
runtime . containers . Remove ( element )
2013-03-21 11:25:00 +04:00
if err := os . RemoveAll ( container . root ) ; err != nil {
2013-06-04 22:00:22 +04:00
return fmt . Errorf ( "Unable to remove filesystem for %v: %v" , container . ID , err )
2013-01-19 04:13:39 +04:00
}
return nil
}
2013-03-21 11:41:15 +04:00
func ( runtime * Runtime ) restore ( ) error {
2013-08-16 17:31:50 +04:00
wheel := "-\\|/"
2013-08-30 02:59:34 +04:00
if os . Getenv ( "DEBUG" ) == "" && os . Getenv ( "TEST" ) == "" {
2013-08-16 17:31:50 +04:00
fmt . Printf ( "Loading containers: " )
}
2013-03-21 11:41:15 +04:00
dir , err := ioutil . ReadDir ( runtime . repository )
2013-01-19 04:13:39 +04:00
if err != nil {
return err
}
2013-08-16 17:31:50 +04:00
for i , v := range dir {
2013-03-21 11:25:00 +04:00
id := v . Name ( )
2013-03-21 11:41:15 +04:00
container , err := runtime . Load ( id )
2013-08-30 02:59:34 +04:00
if i % 21 == 0 && os . Getenv ( "DEBUG" ) == "" && os . Getenv ( "TEST" ) == "" {
2013-08-16 17:31:50 +04:00
fmt . Printf ( "\b%c" , wheel [ i % 4 ] )
}
2013-01-19 04:13:39 +04:00
if err != nil {
2013-05-15 02:37:35 +04:00
utils . Debugf ( "Failed to load container %v: %v" , id , err )
2013-01-19 04:13:39 +04:00
continue
}
2013-06-04 22:00:22 +04:00
utils . Debugf ( "Loaded container %v" , container . ID )
2013-01-19 04:13:39 +04:00
}
2013-08-30 02:59:34 +04:00
if os . Getenv ( "DEBUG" ) == "" && os . Getenv ( "TEST" ) == "" {
2013-08-16 17:31:50 +04:00
fmt . Printf ( "\bdone.\n" )
}
2013-01-19 04:13:39 +04:00
return nil
}
2013-09-07 04:43:34 +04:00
// FIXME: comment please!
2013-04-27 01:32:55 +04:00
func ( runtime * Runtime ) UpdateCapabilities ( quiet bool ) {
2013-05-15 02:37:35 +04:00
if cgroupMemoryMountpoint , err := utils . FindCgroupMountpoint ( "memory" ) ; err != nil {
2013-04-27 01:32:55 +04:00
if ! quiet {
log . Printf ( "WARNING: %s\n" , err )
}
} else {
_ , err1 := ioutil . ReadFile ( path . Join ( cgroupMemoryMountpoint , "memory.limit_in_bytes" ) )
_ , err2 := ioutil . ReadFile ( path . Join ( cgroupMemoryMountpoint , "memory.soft_limit_in_bytes" ) )
runtime . capabilities . MemoryLimit = err1 == nil && err2 == nil
if ! runtime . capabilities . MemoryLimit && ! quiet {
log . Printf ( "WARNING: Your kernel does not support cgroup memory limit." )
}
_ , err = ioutil . ReadFile ( path . Join ( cgroupMemoryMountpoint , "memory.memsw.limit_in_bytes" ) )
runtime . capabilities . SwapLimit = err == nil
if ! runtime . capabilities . SwapLimit && ! quiet {
log . Printf ( "WARNING: Your kernel does not support cgroup swap limit." )
}
2013-08-11 13:52:16 +04:00
}
2013-08-04 02:06:58 +04:00
2013-08-11 13:52:16 +04:00
content , err3 := ioutil . ReadFile ( "/proc/sys/net/ipv4/ip_forward" )
2013-08-19 16:34:30 +04:00
runtime . capabilities . IPv4ForwardingDisabled = err3 != nil || len ( content ) == 0 || content [ 0 ] != '1'
if runtime . capabilities . IPv4ForwardingDisabled && ! quiet {
2013-08-11 13:52:16 +04:00
log . Printf ( "WARNING: IPv4 forwarding is disabled." )
2013-04-27 01:32:55 +04:00
}
}
2013-09-07 04:33:05 +04:00
// Create creates a new container from the given configuration.
func ( runtime * Runtime ) Create ( config * Config ) ( * Container , error ) {
// Lookup image
img , err := runtime . repositories . LookupImage ( config . Image )
if err != nil {
return nil , err
}
if img . Config != nil {
MergeConfig ( config , img . Config )
}
if len ( config . Entrypoint ) != 0 && config . Cmd == nil {
config . Cmd = [ ] string { }
} else if config . Cmd == nil || len ( config . Cmd ) == 0 {
return nil , fmt . Errorf ( "No command specified" )
}
// Generate id
id := GenerateID ( )
// Generate default hostname
// FIXME: the lxc template no longer needs to set a default hostname
if config . Hostname == "" {
config . Hostname = id [ : 12 ]
}
var args [ ] string
var entrypoint string
if len ( config . Entrypoint ) != 0 {
entrypoint = config . Entrypoint [ 0 ]
args = append ( config . Entrypoint [ 1 : ] , config . Cmd ... )
} else {
entrypoint = config . Cmd [ 0 ]
args = config . Cmd [ 1 : ]
}
container := & Container {
// FIXME: we should generate the ID here instead of receiving it as an argument
ID : id ,
Created : time . Now ( ) ,
Path : entrypoint ,
Args : args , //FIXME: de-duplicate from config
Config : config ,
Image : img . ID , // Always use the resolved image id
NetworkSettings : & NetworkSettings { } ,
// FIXME: do we need to store this in the container?
SysInitPath : sysInitPath ,
}
container . root = runtime . containerRoot ( container . ID )
// Step 1: create the container directory.
// This doubles as a barrier to avoid race conditions.
if err := os . Mkdir ( container . root , 0700 ) ; err != nil {
return nil , err
}
resolvConf , err := utils . GetResolvConf ( )
if err != nil {
return nil , err
}
if len ( config . Dns ) == 0 && len ( runtime . Dns ) == 0 && utils . CheckLocalDns ( resolvConf ) {
//"WARNING: Docker detected local DNS server on resolv.conf. Using default external servers: %v", defaultDns
runtime . Dns = defaultDns
}
// If custom dns exists, then create a resolv.conf for the container
if len ( config . Dns ) > 0 || len ( runtime . Dns ) > 0 {
var dns [ ] string
if len ( config . Dns ) > 0 {
dns = config . Dns
} else {
dns = runtime . Dns
}
container . ResolvConfPath = path . Join ( container . root , "resolv.conf" )
f , err := os . Create ( container . ResolvConfPath )
if err != nil {
return nil , err
}
defer f . Close ( )
for _ , dns := range dns {
if _ , err := f . Write ( [ ] byte ( "nameserver " + dns + "\n" ) ) ; err != nil {
return nil , err
}
}
} else {
container . ResolvConfPath = "/etc/resolv.conf"
}
// Step 2: save the container json
if err := container . ToDisk ( ) ; err != nil {
return nil , err
}
2013-09-10 02:11:53 +04:00
// Step 3: if hostname, build hostname and hosts files
container . HostnamePath = path . Join ( container . root , "hostname" )
ioutil . WriteFile ( container . HostnamePath , [ ] byte ( container . Config . Hostname + "\n" ) , 0644 )
hostsContent := [ ] byte ( `
127.0 .0 .1 localhost
: : 1 localhost ip6 - localhost ip6 - loopback
fe00 : : 0 ip6 - localnet
ff00 : : 0 ip6 - mcastprefix
ff02 : : 1 ip6 - allnodes
ff02 : : 2 ip6 - allrouters
` )
container . HostsPath = path . Join ( container . root , "hosts" )
if container . Config . Domainname != "" {
hostsContent = append ( [ ] byte ( fmt . Sprintf ( "::1\t\t%s.%s %s\n" , container . Config . Hostname , container . Config . Domainname , container . Config . Hostname ) ) , hostsContent ... )
hostsContent = append ( [ ] byte ( fmt . Sprintf ( "127.0.0.1\t%s.%s %s\n" , container . Config . Hostname , container . Config . Domainname , container . Config . Hostname ) ) , hostsContent ... )
} else {
hostsContent = append ( [ ] byte ( fmt . Sprintf ( "::1\t\t%s\n" , container . Config . Hostname ) ) , hostsContent ... )
hostsContent = append ( [ ] byte ( fmt . Sprintf ( "127.0.0.1\t%s\n" , container . Config . Hostname ) ) , hostsContent ... )
}
ioutil . WriteFile ( container . HostsPath , hostsContent , 0644 )
// Step 4: register the container
2013-09-07 04:33:05 +04:00
if err := runtime . Register ( container ) ; err != nil {
return nil , err
}
return container , nil
}
// Commit creates a new filesystem image from the current state of a container.
// The image can optionally be tagged into a repository
func ( runtime * Runtime ) Commit ( container * Container , repository , tag , comment , author string , config * Config ) ( * Image , error ) {
// FIXME: freeze the container before copying it to avoid data corruption?
// FIXME: this shouldn't be in commands.
if err := container . EnsureMounted ( ) ; err != nil {
return nil , err
}
rwTar , err := container . ExportRw ( )
if err != nil {
return nil , err
}
// Create a new image from the container's base layers + a new layer from container changes
img , err := runtime . graph . Create ( rwTar , container , comment , author , config )
if err != nil {
return nil , err
}
// Register the image if needed
if repository != "" {
if err := runtime . repositories . Set ( repository , tag , img . ID , true ) ; err != nil {
return img , err
}
}
return img , nil
}
2013-03-31 13:02:01 +04:00
// FIXME: harmonize with NewGraph()
2013-06-21 01:29:54 +04:00
func NewRuntime ( flGraphPath string , autoRestart bool , dns [ ] string ) ( * Runtime , error ) {
runtime , err := NewRuntimeFromDirectory ( flGraphPath , autoRestart )
2013-04-19 07:47:24 +04:00
if err != nil {
return nil , err
}
2013-06-06 01:20:19 +04:00
runtime . Dns = dns
2013-04-19 07:47:24 +04:00
2013-05-16 04:40:47 +04:00
if k , err := utils . GetKernelVersion ( ) ; err != nil {
2013-04-22 22:26:34 +04:00
log . Printf ( "WARNING: %s\n" , err )
} else {
runtime . kernelVersion = k
2013-05-15 02:37:35 +04:00
if utils . CompareKernelVersion ( k , & utils . KernelVersionInfo { Kernel : 3 , Major : 8 , Minor : 0 } ) < 0 {
2013-04-22 22:26:34 +04:00
log . Printf ( "WARNING: You are running linux kernel version %s, which might be unstable running docker. Please upgrade your kernel to 3.8.0." , k . String ( ) )
}
2013-04-19 07:47:24 +04:00
}
2013-04-27 01:32:55 +04:00
runtime . UpdateCapabilities ( false )
2013-04-19 07:47:24 +04:00
return runtime , nil
2013-01-19 04:13:39 +04:00
}
2013-04-25 06:01:23 +04:00
func NewRuntimeFromDirectory ( root string , autoRestart bool ) ( * Runtime , error ) {
2013-03-29 04:12:23 +04:00
runtimeRepo := path . Join ( root , "containers" )
2013-03-14 05:48:50 +04:00
2013-03-29 04:12:23 +04:00
if err := os . MkdirAll ( runtimeRepo , 0700 ) ; err != nil && ! os . IsExist ( err ) {
2013-03-14 05:48:50 +04:00
return nil , err
}
2013-03-22 04:47:23 +04:00
g , err := NewGraph ( path . Join ( root , "graph" ) )
2013-02-27 05:45:46 +04:00
if err != nil {
return nil , err
}
2013-04-06 05:00:10 +04:00
volumes , err := NewGraph ( path . Join ( root , "volumes" ) )
if err != nil {
return nil , err
}
2013-03-22 04:47:23 +04:00
repositories , err := NewTagStore ( path . Join ( root , "repositories" ) , g )
2013-03-22 04:35:49 +04:00
if err != nil {
return nil , fmt . Errorf ( "Couldn't create Tag store: %s" , err )
}
2013-04-04 16:33:28 +04:00
if NetworkBridgeIface == "" {
NetworkBridgeIface = DefaultNetworkBridge
}
2013-04-04 01:53:09 +04:00
netManager , err := newNetworkManager ( NetworkBridgeIface )
2013-02-26 02:06:22 +04:00
if err != nil {
return nil , err
}
2013-03-21 11:41:15 +04:00
runtime := & Runtime {
2013-02-28 23:52:07 +04:00
root : root ,
2013-03-29 04:12:23 +04:00
repository : runtimeRepo ,
2013-02-28 23:52:07 +04:00
containers : list . New ( ) ,
networkManager : netManager ,
2013-03-22 04:35:49 +04:00
graph : g ,
repositories : repositories ,
2013-05-15 02:37:35 +04:00
idIndex : utils . NewTruncIndex ( ) ,
2013-04-19 07:55:41 +04:00
capabilities : & Capabilities { } ,
2013-04-25 06:01:23 +04:00
autoRestart : autoRestart ,
2013-04-06 05:00:10 +04:00
volumes : volumes ,
2013-01-19 04:13:39 +04:00
}
2013-03-21 11:41:15 +04:00
if err := runtime . restore ( ) ; err != nil {
2013-01-19 04:13:39 +04:00
return nil , err
}
2013-03-21 11:41:15 +04:00
return runtime , nil
2013-01-19 04:13:39 +04:00
}
2013-01-30 00:15:39 +04:00
2013-09-07 04:43:34 +04:00
// History is a convenience type for storing a list of containers,
// ordered by creation date.
2013-01-30 00:15:39 +04:00
type History [ ] * Container
func ( history * History ) Len ( ) int {
return len ( * history )
}
func ( history * History ) Less ( i , j int ) bool {
containers := * history
return containers [ j ] . When ( ) . Before ( containers [ i ] . When ( ) )
}
func ( history * History ) Swap ( i , j int ) {
containers := * history
tmp := containers [ i ]
containers [ i ] = containers [ j ]
containers [ j ] = tmp
}
func ( history * History ) Add ( container * Container ) {
* history = append ( * history , container )
sort . Sort ( history )
}