Merge pull request #16171 from vdemeester/lint-only-on-diff

Golint only on changed files
This commit is contained in:
Jess Frazelle 2015-09-09 10:19:16 -07:00
Родитель 5d67fd5fb2 1cca5ee98c
Коммит 0072896445
1 изменённых файлов: 6 добавлений и 7 удалений

Просмотреть файл

@ -2,15 +2,14 @@
source "${MAKEDIR}/.validate"
packages=( $(go list ./... 2> /dev/null | grep -vE "^github.com/docker/docker/vendor|^github.com/docker/docker/autogen" || true ) )
IFS=$'\n'
files=( $(validate_diff --diff-filter=ACMR --name-only -- '*.go' | grep -v '^vendor/' || true) )
unset IFS
errors=()
for p in "${packages[@]}"; do
# Remove the github.com/docker/docker/ prefix from listed package
package="${p#github.com/docker/docker/}"
# Run golint on package/*.go file explicitly to validate all go files
# and not just the ones for the current platform.
failedLint=$(golint $package/*.go)
for f in "${files[@]}"; do
# we use "git show" here to validate that what's committed passes go vet
failedLint=$(golint "$f")
if [ "$failedLint" ]; then
errors+=( "$failedLint" )
fi