Fix issue reloading mount options on restart

On daemon restart the local volume driver will read options that it
persisted to disk, however it was reading an incorrect path, causing
volume options to be silently ignored after a daemon restart.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This commit is contained in:
Brian Goff 2016-08-01 23:02:51 -04:00
Родитель ccbdc16b8e
Коммит c560dd9686
2 изменённых файлов: 18 добавлений и 1 удалений

Просмотреть файл

@ -88,7 +88,9 @@ func New(scope string, rootUID, rootGID int) (*Root, error) {
path: r.DataPath(name), path: r.DataPath(name),
} }
r.volumes[name] = v r.volumes[name] = v
if b, err := ioutil.ReadFile(filepath.Join(name, "opts.json")); err == nil { optsFilePath := filepath.Join(rootDirectory, name, "opts.json")
if b, err := ioutil.ReadFile(optsFilePath); err == nil {
v.opts = &optsConfig{}
if err := json.Unmarshal(b, v.opts); err != nil { if err := json.Unmarshal(b, v.opts); err != nil {
return nil, err return nil, err
} }

Просмотреть файл

@ -3,6 +3,7 @@ package local
import ( import (
"io/ioutil" "io/ioutil"
"os" "os"
"reflect"
"runtime" "runtime"
"strings" "strings"
"testing" "testing"
@ -246,4 +247,18 @@ func TestCreateWithOpts(t *testing.T) {
if !mounted { if !mounted {
t.Fatal("expected mount to still be active") t.Fatal("expected mount to still be active")
} }
r, err = New(rootDir, 0, 0)
if err != nil {
t.Fatal(err)
}
v2, exists := r.volumes["test"]
if !exists {
t.Fatal("missing volume on restart")
}
if !reflect.DeepEqual(v.opts, v2.opts) {
t.Fatal("missing volume options on restart")
}
} }