diff --git a/api/api.go b/api/api.go index fe965ddafa..0fe1eb0fee 100644 --- a/api/api.go +++ b/api/api.go @@ -50,10 +50,6 @@ func ValidateHost(val string) (string, error) { type HttpApiFunc func(eng *engine.Engine, version float64, w http.ResponseWriter, r *http.Request, vars map[string]string) error -func init() { - engine.Register("serveapi", ServeApi) -} - func hijackServer(w http.ResponseWriter) (io.ReadCloser, io.Writer, error) { conn, _, err := w.(http.Hijacker).Hijack() if err != nil { diff --git a/builtins/builtins.go b/builtins/builtins.go new file mode 100644 index 0000000000..5b146cd20f --- /dev/null +++ b/builtins/builtins.go @@ -0,0 +1,40 @@ +package builtins + +import ( + "github.com/dotcloud/docker/engine" + + "github.com/dotcloud/docker" + "github.com/dotcloud/docker/api" + "github.com/dotcloud/docker/networkdriver/lxc" +) + +func Register(eng *engine.Engine) { + daemon(eng) + remote(eng) +} + +// remote: a RESTful api for cross-docker communication +func remote(eng *engine.Engine) { + eng.Register("serveapi", api.ServeApi) +} + +// daemon: a default execution and storage backend for Docker on Linux, +// with the following underlying components: +// +// * Pluggable storage drivers including aufs, vfs, lvm and btrfs. +// * Pluggable execution drivers including lxc and chroot. +// +// In practice `daemon` still includes most core Docker components, including: +// +// * The reference registry client implementation +// * Image management +// * The build facility +// * Logging +// +// These components should be broken off into plugins of their own. +// +func daemon(eng *engine.Engine) { + eng.Register("initserver", docker.InitServer) + eng.Register("init_networkdriver", lxc.InitDriver) + eng.Register("version", docker.GetVersion) +} diff --git a/docker/docker.go b/docker/docker.go index 9e93b71767..a2e1184c83 100644 --- a/docker/docker.go +++ b/docker/docker.go @@ -6,8 +6,8 @@ import ( "os" "strings" - _ "github.com/dotcloud/docker" "github.com/dotcloud/docker/api" + "github.com/dotcloud/docker/builtins" "github.com/dotcloud/docker/dockerversion" "github.com/dotcloud/docker/engine" flag "github.com/dotcloud/docker/pkg/mflag" @@ -81,6 +81,8 @@ func main() { if err != nil { log.Fatal(err) } + // Load builtins + builtins.Register(eng) // load the daemon in the background so we can immediately start // the http api so that connections don't fail while the daemon // is booting diff --git a/integration/runtime_test.go b/integration/runtime_test.go index ca2119ce1f..9eaf778b96 100644 --- a/integration/runtime_test.go +++ b/integration/runtime_test.go @@ -123,19 +123,8 @@ func init() { } func setupBaseImage() { - eng, err := engine.New(unitTestStoreBase) - if err != nil { - log.Fatalf("Can't initialize engine at %s: %s", unitTestStoreBase, err) - } - job := eng.Job("initserver") - job.Setenv("Root", unitTestStoreBase) - job.SetenvBool("Autorestart", false) - job.Setenv("BridgeIface", unitTestNetworkBridge) - if err := job.Run(); err != nil { - log.Fatalf("Unable to create a runtime for tests: %s", err) - } - - job = eng.Job("inspect", unitTestImageName, "image") + eng := newTestEngine(log.New(os.Stderr, "", 0), false, unitTestStoreBase) + job := eng.Job("inspect", unitTestImageName, "image") img, _ := job.Stdout.AddEnv() // If the unit test is not found, try to download it. if err := job.Run(); err != nil || img.Get("id") != unitTestImageID { @@ -575,18 +564,7 @@ func TestRestore(t *testing.T) { // Here are are simulating a docker restart - that is, reloading all containers // from scratch - root := eng.Root() - eng, err := engine.New(root) - if err != nil { - t.Fatal(err) - } - job := eng.Job("initserver") - job.Setenv("Root", eng.Root()) - job.SetenvBool("Autorestart", false) - if err := job.Run(); err != nil { - t.Fatal(err) - } - + eng = newTestEngine(t, false, eng.Root()) runtime2 := mkRuntimeFromEngine(eng, t) if len(runtime2.List()) != 2 { t.Errorf("Expected 2 container, %v found", len(runtime2.List())) @@ -612,22 +590,14 @@ func TestRestore(t *testing.T) { } func TestReloadContainerLinks(t *testing.T) { - // FIXME: here we don't use NewTestEngine because it calls initserver with Autorestart=false, - // and we want to set it to true. root, err := newTestDirectory(unitTestStoreBase) if err != nil { t.Fatal(err) } - eng, err := engine.New(root) - if err != nil { - t.Fatal(err) - } - job := eng.Job("initserver") - job.Setenv("Root", eng.Root()) - job.SetenvBool("Autorestart", true) - if err := job.Run(); err != nil { - t.Fatal(err) - } + // FIXME: here we don't use NewTestEngine because it calls initserver with Autorestart=false, + // and we want to set it to true. + + eng := newTestEngine(t, true, root) runtime1 := mkRuntimeFromEngine(eng, t) defer nuke(runtime1) @@ -668,17 +638,7 @@ func TestReloadContainerLinks(t *testing.T) { // Here are are simulating a docker restart - that is, reloading all containers // from scratch - eng, err = engine.New(root) - if err != nil { - t.Fatal(err) - } - job = eng.Job("initserver") - job.Setenv("Root", eng.Root()) - job.SetenvBool("Autorestart", false) - if err := job.Run(); err != nil { - t.Fatal(err) - } - + eng = newTestEngine(t, false, root) runtime2 := mkRuntimeFromEngine(eng, t) if len(runtime2.List()) != 2 { t.Errorf("Expected 2 container, %v found", len(runtime2.List())) diff --git a/integration/server_test.go b/integration/server_test.go index 2b7ef13cbd..2234bcab08 100644 --- a/integration/server_test.go +++ b/integration/server_test.go @@ -2,7 +2,6 @@ package docker import ( "github.com/dotcloud/docker" - "github.com/dotcloud/docker/engine" "github.com/dotcloud/docker/runconfig" "strings" "testing" @@ -258,20 +257,7 @@ func TestRestartKillWait(t *testing.T) { t.Fatal(err) } - eng, err = engine.New(eng.Root()) - if err != nil { - t.Fatal(err) - } - - job = eng.Job("initserver") - job.Setenv("Root", eng.Root()) - job.SetenvBool("AutoRestart", false) - // TestGetEnabledCors and TestOptionsRoute require EnableCors=true - job.SetenvBool("EnableCors", true) - if err := job.Run(); err != nil { - t.Fatal(err) - } - + eng = newTestEngine(t, false, eng.Root()) srv = mkServerFromEngine(eng, t) job = srv.Eng.Job("containers") diff --git a/integration/utils_test.go b/integration/utils_test.go index 947ace11d9..fc66e8bcbd 100644 --- a/integration/utils_test.go +++ b/integration/utils_test.go @@ -15,6 +15,7 @@ import ( "time" "github.com/dotcloud/docker" + "github.com/dotcloud/docker/builtins" "github.com/dotcloud/docker/engine" "github.com/dotcloud/docker/runconfig" "github.com/dotcloud/docker/utils" @@ -27,26 +28,12 @@ import ( // Create a temporary runtime suitable for unit testing. // Call t.Fatal() at the first error. func mkRuntime(f utils.Fataler) *docker.Runtime { - root, err := newTestDirectory(unitTestStoreBase) - if err != nil { - f.Fatal(err) - } - config := &docker.DaemonConfig{ - Root: root, - AutoRestart: false, - Mtu: docker.GetDefaultNetworkMtu(), - } - - eng, err := engine.New(root) - if err != nil { - f.Fatal(err) - } - - r, err := docker.NewRuntimeFromDirectory(config, eng) - if err != nil { - f.Fatal(err) - } - return r + eng := newTestEngine(f, false, "") + return mkRuntimeFromEngine(eng, f) + // FIXME: + // [...] + // Mtu: docker.GetDefaultNetworkMtu(), + // [...] } func createNamedTestContainer(eng *engine.Engine, config *runconfig.Config, f utils.Fataler, name string) (shortId string) { @@ -185,20 +172,24 @@ func mkRuntimeFromEngine(eng *engine.Engine, t utils.Fataler) *docker.Runtime { return runtime } -func NewTestEngine(t utils.Fataler) *engine.Engine { - root, err := newTestDirectory(unitTestStoreBase) - if err != nil { - t.Fatal(err) +func newTestEngine(t utils.Fataler, autorestart bool, root string) *engine.Engine { + if root == "" { + if dir, err := newTestDirectory(unitTestStoreBase); err != nil { + t.Fatal(err) + } else { + root = dir + } } eng, err := engine.New(root) if err != nil { t.Fatal(err) } // Load default plugins + builtins.Register(eng) // (This is manually copied and modified from main() until we have a more generic plugin system) job := eng.Job("initserver") job.Setenv("Root", root) - job.SetenvBool("AutoRestart", false) + job.SetenvBool("AutoRestart", autorestart) // TestGetEnabledCors and TestOptionsRoute require EnableCors=true job.SetenvBool("EnableCors", true) if err := job.Run(); err != nil { @@ -207,6 +198,10 @@ func NewTestEngine(t utils.Fataler) *engine.Engine { return eng } +func NewTestEngine(t utils.Fataler) *engine.Engine { + return newTestEngine(t, false, "") +} + func newTestDirectory(templateDir string) (dir string, err error) { return utils.TestDirectory(templateDir) } diff --git a/networkdriver/lxc/driver.go b/networkdriver/lxc/driver.go index 0bc24b91b6..6185c42752 100644 --- a/networkdriver/lxc/driver.go +++ b/networkdriver/lxc/driver.go @@ -57,12 +57,6 @@ var ( currentInterfaces = make(map[string]*networkInterface) ) -func init() { - if err := engine.Register("init_networkdriver", InitDriver); err != nil { - panic(err) - } -} - func InitDriver(job *engine.Job) engine.Status { var ( network *net.IPNet diff --git a/server.go b/server.go index 0ed96fee31..190ccbcc4b 100644 --- a/server.go +++ b/server.go @@ -34,14 +34,10 @@ func (srv *Server) Close() error { return srv.runtime.Close() } -func init() { - engine.Register("initserver", jobInitServer) -} - // jobInitApi runs the remote api server `srv` as a daemon, // Only one api server can run at the same time - this is enforced by a pidfile. // The signals SIGINT, SIGQUIT and SIGTERM are intercepted for cleanup. -func jobInitServer(job *engine.Job) engine.Status { +func InitServer(job *engine.Job) engine.Status { job.Logf("Creating server") srv, err := NewServer(job.Eng, DaemonConfigFromJob(job)) if err != nil { diff --git a/version.go b/version.go index 88298a16cb..d88def9619 100644 --- a/version.go +++ b/version.go @@ -7,11 +7,7 @@ import ( "runtime" ) -func init() { - engine.Register("version", jobVersion) -} - -func jobVersion(job *engine.Job) engine.Status { +func GetVersion(job *engine.Job) engine.Status { if _, err := dockerVersion().WriteTo(job.Stdout); err != nil { job.Errorf("%s", err) return engine.StatusErr