210ab030bc
Format error by value
...
- Use `%v` verb to format errors.
- Give `param` constant in portallocator some better name.
Signed-off-by: Michal Minar <miminar@redhat.com>
2015-03-16 12:05:53 +01:00
82f390e139
Merge pull request #11076 from hqhq/hq_use_warning_in_sysinfo
...
use type WARN for warning
2015-03-15 21:13:23 -07:00
c0f7819905
Make errors from graphdriver init friendlier
...
In several cases graphdriver were just returning the low-level syscall
error and that was making it all the way up to the daemon logs and in
many cases was difficult to tell it was even coming from the graphdriver
at all.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2015-03-12 08:13:00 -07:00
ce1a0b612d
Fix minor typo
...
Signed-off-by: Deng Guangxing <dengguangxing@huawei.com>
2015-03-11 11:13:39 +08:00
bffe04b582
fix warning messages
...
Use log.Warnf instead of log.Infof, and remove redundant `WARNING` prefix.
Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
2015-03-11 08:47:45 +08:00
89bdaa35e0
Remove subdirectories MAINTAINERS files
...
Signed-off-by: Arnaud Porterie <arnaud.porterie@docker.com>
2015-03-06 18:21:51 -08:00
92e632c84e
Merge pull request #11064 from delftswa2014/10970-treesize
...
Move directory size calculation to pkg/ (fixes #10970 )
2015-03-05 13:06:02 -08:00
4eb2fd169f
Two SELinux Changes.
...
daemon/volumes.go
This SetFileCon call made no sense, it was changing the labels of any
directory mounted into the containers SELinux label. If it came from me,
then I apologize since it is a huge bug.
The Volumes Mount code should optionally do this, but it should not always
happen, and should never happen on a --privileged container.
The change to
daemon/graphdriver/vfs/driver.go, is a simplification since this it not
a relabel, it is only a setting of the shared label for docker volumes.
Docker-DCO-1.1-Signed-off-by: Dan Walsh <dwalsh@redhat.com> (github: rhatdan)
2015-03-05 13:55:44 -05:00
e2b8933d21
Move directory size calculation to pkg/ ( fixes #10970 )
...
Signed-off-by: Martijn Dwars <ikben@martijndwars.nl>
2015-03-04 21:16:31 +01:00
dd56fa1906
Add xfs fs magic to graphdriver/driver.go
...
Signed-off-by: Lei Jitang <leijitang@huawei.com>
2015-03-04 19:01:39 +08:00
32ccde46dd
Merge pull request #11106 from MabinGo/fix_log_info
...
Fix some revision about log output
2015-03-02 13:55:43 -08:00
82aa950f4e
Merge pull request #11054 from MabinGo/checkfileoper1
...
Add the file close operation before function return to advoid resource leaking
2015-03-02 10:44:26 -08:00
738bdec490
Merge pull request #11083 from MabinGo/minor_typo
...
Modify the minor typo in deviceset.go
2015-03-02 13:11:14 -05:00
adfd1ddfc6
Fix some revision about log output
...
Signed-off-by: Mabin <bin.ma@huawei.com>
2015-03-02 17:06:38 +08:00
f4ac86de84
fix typo of comments in daemon/graphdriver/devmapper/deviceset.go
...
Signed-off-by: Mabin <bin.ma@huawei.com>
2015-03-02 02:11:15 +08:00
5c1559a754
Modify the minor typo in deviceset.go
...
Signed-off-by: Mabin <bin.ma@huawei.com>
2015-02-28 18:04:10 +08:00
b5eeab6e06
Add the file close operation before function return to advoid resource leaking
...
Signed-off-by: Mabin <bin.ma@huawei.com>
2015-02-28 00:24:41 +08:00
7a9c944b82
Removing dependencies from pkg into Docker internal code
...
Closes #10922
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
2015-02-23 18:43:10 +00:00
f4dc496d36
Merge pull request #10474 from petervo/10473-availble-space
...
Add available space to devicemapper status output
2015-02-10 16:32:51 +01:00
6816d27591
Detail available space behavior on loop devices
...
Signed-off-by: Peter Volpe <petervo@redhat.com>
2015-02-09 14:51:48 -08:00
67a4f1db10
Merge pull request #10440 from rhvgoyal/skip-dot-prefix-files
...
devicemapper: Skip the files with prefix "." during device map construct...
2015-02-09 10:26:27 +01:00
414a37f90a
Merge pull request #10534 from unclejack/aufs_enable_dio
...
daemon/graphdriver/aufs: enable direct io
2015-02-06 18:26:09 -05:00
fcb975cfd1
Fix a small spelling error in the dm.blkdiscard docs
...
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
2015-02-05 10:57:33 +10:00
c809fc552b
Fix for running unit tests on a 3.18 kernel with btrfs.
...
Was failing on overlay before and comparing the wrong error.
Docker-DCO-1.1-Signed-off-by: Jessie Frazelle <jess@docker.com> (github: jfrazelle)
2015-02-04 13:51:44 -08:00
d18f5c3808
daemon/graphdriver/aufs: enable direct io
...
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
2015-02-03 18:30:37 +02:00
726f89d77a
Add available space to devicemapper status output
...
Signed-off-by: Peter Volpe <petervo@redhat.com>
2015-01-30 22:36:04 -08:00
080a6f1e4b
devicemapper: Skip the files with prefix "." during device map construction
...
Any file which starts with "." is not a valid metadata file. Skip it
during device map construction.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
2015-01-29 13:19:18 -05:00
ec953b0e7b
Blacklist zfs with overlay
...
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
2015-01-23 14:00:15 -08:00
b8fe989b9b
Merge pull request #10187 from jfrazelle/update-skip-graphtest
...
update graphtest
2015-01-21 14:09:16 -08:00
9b2afa04f8
Merge pull request #10222 from vbatts/vbatts-dm_flag_and_output
...
dm flag and output
2015-01-20 18:45:43 -05:00
0c8be9da37
devmapper: initialize log levels
...
Signed-off-by: Vincent Batts <vbatts@redhat.com>
2015-01-20 13:31:19 -05:00
a09a665d99
devmapper: some explination of `docker info`
...
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2015-01-19 17:37:08 -05:00
4cfe9df0a9
devicemapper: debug output specifics
...
moar information for the information gods
Signed-off-by: Vincent Batts <vbatts@redhat.com>
2015-01-19 17:21:10 -05:00
d2593546f9
devmapper: udev sync in `docker info`
...
now:
```
[...]
Storage Driver: devicemapper
Pool Name: docker-253:2-5767172-pool
[...]
Udev Sync Supported: true
[...]
```
Signed-off-by: Vincent Batts <vbatts@redhat.com>
2015-01-19 16:28:02 -05:00
022e1232f8
devmapper: udev sync on init
...
when initializing the devmapper driver, attempt to sync udev and device
mapper. If udev sync is not supported, print a warning. Eventually we'll
likely bail here to avoid unpredictable behavior for users.
Signed-off-by: Vincent Batts <vbatts@redhat.com>
2015-01-19 15:57:25 -05:00
f0d79c021d
Update graphtest so when overlay is tried over a non-supported backing
...
filesystem it will skip.
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
2015-01-19 10:28:57 -08:00
48b1dd0084
Add backing filesystem info to `docker info` command where applicable
...
Fixes #9960
This adds the output of a "Backing Filesystem:" entry to `docker info`
to overlay, aufs, and devicemapper graphdrivers. The default list
includes a fairly complete list of common filesystem names from
linux/include/uapi/linux/magic.h, but if the backing filesystem is not
recognized, the code will simply show "<unknown>"
Docker-DCO-1.1-Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
2015-01-16 14:43:43 -05:00
f88066fd43
ignore vfs from warning
...
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
2015-01-14 17:28:50 -08:00
bb96e53b0f
Fix vet error about passing Mutex by value
...
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
2015-01-14 14:03:00 -08:00
044d979f4e
Merge pull request #10003 from vbatts/vbatts-dm_loop_file_info
...
devmapper: show device and loop file , if used
2015-01-14 01:15:09 +02:00
16fe2ac6b2
Merge pull request #9988 from nponeccop/patch-1
...
FsMagic should avoid sign extension on i686
2015-01-12 12:02:09 -08:00
83ab6237ac
Merge pull request #10047 from vbatts/vbatts-graphdriver_driver_put_with_error
...
graphdriver: change (*Driver).Put signature
2015-01-12 11:42:11 -08:00
2b51d1a167
devmapper: remove newline string
...
Signed-off-by: Vincent Batts <vbatts@redhat.com>
2015-01-12 13:40:42 -05:00
00fd63e558
graphdriver: change (*Driver).Put signature
...
There are a couple of drivers that swallow errors that may occur in
their Put() implementation.
This changes the signature of (*Driver).Put for all the drivers implemented.
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
2015-01-12 13:34:35 -05:00
09c033ff87
devmapper: show device and loop file , if used
...
Presenly the "Data file:" shows either the loopback _file_ or the block device.
With this, the "Data file:" will always show the device, and if it is a
loopback, then there will additionally be a "Data loop file:".
(Same for "Metadata file:")
Signed-off-by: Vincent Batts <vbatts@redhat.com>
2015-01-09 11:20:07 -05:00
c754555b87
FsMagic should avoid sign extension on i686
...
`uint64(buf.Type)` on i686 is ffffffff9123683e on i686 due to sign extension, so it cannot be compared with `FsMagic(0x9123683E)`
Signed-off-by: Andrii Melnykov <andy.melnikov@gmail.com>
2015-01-09 02:44:04 +02:00
6d780139c4
Merge pull request #8748 from duglin/Issue8330
...
Have .dockerignore support Dockerfile/.dockerignore
2015-01-06 13:47:42 -08:00
9d1caf4272
Merge pull request #9834 from jfrazelle/9820-overlay-btrfs
...
Add error when running overlay over btrfs.
2015-01-06 13:16:17 -08:00
32f1025b22
Add error when running overlay over btrfs.
...
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
2015-01-06 11:22:45 -08:00
6d801a3caa
Have .dockerignore support Dockerfile/.dockerignore
...
If .dockerignore mentions either then the client will send them to the
daemon but the daemon will erase them after the Dockerfile has been parsed
to simulate them never being sent in the first place.
an events test kept failing for me so I tried to fix that too
Closes #8330
Signed-off-by: Doug Davis <dug@us.ibm.com>
2015-01-06 10:57:48 -08:00
Michal Minar
Arnaud Porterie
Brian Goff
Deng Guangxing
Qiang Huang
Michael Crosby
Dan Walsh
Martijn Dwars
Lei Jitang
Alexander Morozov
Jessie Frazelle
Phil Estes
Mabin
Srini Brahmaroutu
Vincent Batts
Peter Volpe
Tibor Vass
Sven Dowideit
Jessica Frazelle
unclejack
Vivek Goyal
Vincent Batts
Phil Estes
Alexander Morozov
unclejack
nponeccop
Doug Davis