Граф коммитов

588 Коммитов

Автор SHA1 Сообщение Дата
Shankar Seal 6af442038c
invalid prog data tests. (#3718)
* invalid prog data tests.

changes.

* analysis_assume.

* PR feedback.

---------

Co-authored-by: Anurag Saxena <43585259+saxena-anurag@users.noreply.github.com>
2024-07-29 22:46:29 +00:00
Sharmi 54632eb360
Set errno for bpf_object__find_map_by_name (#3712)
* Initial Commit

* Initialize errno

* Set errno for bpf_object__find_map_by_name

* Added Doxygen comment
2024-07-23 18:32:28 +00:00
Anurag Saxena ffb3638259
Implement `implicit_context` for helper functions. (#3656)
* backup

* backup

* fix build issues

* fix build

* fix analysis failures, fix tests

* seperate out sample for implicit context

* backup

* add ctx as last argument

* fix hash

* block implicit context for jit and interpret

* stabilize tests

* tail call fast path

* add check to reject change in context_header support

* enable implicit context for jit and interpret

* fix

* fix build

* fix analysis build

* update version, update expected files

* fix test failures

* fix test failures

* fix tests

* cleanup

* cleanup

* more cleanup

* enable performance tests

* enable performance tests

* remove tail_call changes

* remove tail_call changes

* remove tail_call changes

* remove tail_call changes

* fix analysis error

* update documentation

* code cleanup

* fix bad merge

* fix test case

* cr comments

* update expected files

* cr comments
2024-07-19 17:12:08 +00:00
Alan Jowett cb37e78295
_ebpf_link_instance_invoke_with_context_header should call correct batch_end api (#3709)
Signed-off-by: Alan Jowett (from Dev Box) <alanjo@microsoft.com>
2024-07-17 18:58:54 +00:00
Alan Jowett 50f513d002
Optimize integer size key in hash-tables. (#3710)
Signed-off-by: Alan Jowett (from Dev Box) <alanjo@microsoft.com>
2024-07-17 18:18:45 +00:00
Shankar Seal 6b75459f04
UM API to write into a ring buffer map. (#3689)
* UM API to write into a ring buffer map.

* PR Feedback.

* PR feedback.

* PR comments.
2024-07-17 07:57:37 +00:00
Sharmi 7ee9edfb44
[bpf_map_lookup_batch] Fix bpf_map_lookup_batch data retrieval and add test cases for percpu hash map batch lookup (#3590)
* Initial commit

* Initial commit

* debug

* Initial commit

* Initial commit

* Added BPF_MAP_TYPE_PER_CPU to get the map type
2024-07-16 18:48:17 +00:00
Alan Jowett a055146760
Upgrade all C_ASSERT to static_assert (#3702)
Signed-off-by: Alan Jowett (from Dev Box) <alanjo@microsoft.com>
2024-07-16 17:46:04 +00:00
Anurag Saxena 00c9138876
Use `context_header` for tail call perf improvement (#3698)
* fix

* fix

* fix

* fix tests

* fix tests

* change to capabilities, add check for prog_array map

* fix analysis build, add tests

* update documentation

* add context_header_support callback for maps

* CR comment

* change capabilities to bitfield

* Apply suggestions from code review

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>

* cr comments

* cr comments

* Apply suggestions from code review

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>

* CR comments

---------

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
2024-07-15 16:23:51 +00:00
D. Michael Agun 2efce152dc
Set empty program name to hash of instructions (#3493)
* Move C++ hashing lib from tests/libs/util/ to libs/shared/

This puts hash.cpp/hash.h in a more central location for use by other project files.

* Set empty program name to hash of instructions

ebpf_program_load_bytes now hashes the instructions and uses that for the name
instead of generating a random number.

Closes #3443

* fix signed/unsigned warning (and ensure windows helper id >= 0)

* add bcrypt.dll dependency for ebpfapi.dll

* WIP new test case for ebpf_program_load_bytes with nullptr program name

* WIP ebpf_program_load_bytes testing

* truncate SHA256 hash to 63 bytes to stay under BPF_OBJ_NAME_LEN

* remove bcrypt from release dependencies and suppress analyze warning

* PR feedback - fix comment and bpf2c include paths

---------

Co-authored-by: Michael Agun <danielagun@microsoft.com>
Co-authored-by: Alan Jowett <alanjo@microsoft.com>
2024-07-02 14:47:03 +00:00
dependabot[bot] 4667783ba1
Bump external/ubpf from `2c2a68a` to `d2a33c2` (#3676)
* Bump external/ubpf from `2c2a68a` to `d2a33c2`

Bumps [external/ubpf](https://github.com/iovisor/ubpf) from `2c2a68a` to `d2a33c2`.
- [Commits](2c2a68a2d9...d2a33c28db)

---
updated-dependencies:
- dependency-name: external/ubpf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix build break

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-06-26 21:38:07 +00:00
Alan Jowett 83a35d3c71
Speedup ebpf_handle_table_terminate by avoiding acquire/release of lock (#3605)
* Speedup ebpf_handle_table_terminate by avoiding acquire/release of lock

Signed-off-by: Alan Jowett (from Dev Box) <alanjo@microsoft.com>

* Add workaround for native module handle cleanup delay

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett (from Dev Box) <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-06-25 21:49:39 +00:00
Alan Jowett 3fca9f1348
Fix conflict between Windows and ubpf headers (#3665)
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-06-25 21:46:41 +00:00
Alan Jowett 8440c60ced
Add hint to LTCG that code should be inlined (#3658)
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-06-21 17:40:58 +00:00
Alan Jowett 7dc742e4e4
Simplify native module handle cleanup (#3653)
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Anurag Saxena <43585259+saxena-anurag@users.noreply.github.com>
2024-06-20 19:06:52 +00:00
dependabot[bot] 2cf8fa184e
Bump external/ebpf-verifier from `df34181` to `2018df9` (#3600)
* Bump external/ebpf-verifier from `df34181` to `2018df9`

Bumps [external/ebpf-verifier](https://github.com/vbpf/ebpf-verifier) from `df34181` to `2018df9`.
- [Release notes](https://github.com/vbpf/ebpf-verifier/releases)
- [Commits](df3418141c...2018df951b)

---
updated-dependencies:
- dependency-name: external/ebpf-verifier
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix build failures due to breaking change

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
2024-06-03 19:10:39 +00:00
Dave Thaler 7b3f682ded
Implement libbpf autoload APIs (#3592)
* Implement libbpf autoload APIs

Fixes #3555

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Suppress spurious compiler warning

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Fix test failure

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Update tests

Files with no program sections succeed loading

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Address PR comment from Anurag

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* PR feedback

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Fix test

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Prevent changing prog type of a native program

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* PR feedback

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Remove unused program_type from native load ioctl

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Update default autoload value

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* PR feedback

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Fix test

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Add check to unit_test to match api_test

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Fix api_test

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

---------

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
2024-06-03 15:28:04 +00:00
nullswan dfbcda9001
chore: rename (#3603) 2024-06-03 04:32:16 +00:00
Anurag Saxena 05a7189556
move enum to header (#3593) 2024-05-31 21:06:42 +00:00
Alan Jowett 22742b4d45
Add workaround for NmrRegisterClient calling detach (#3594)
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-05-31 03:51:03 +00:00
Dave Thaler 840269a9ec
Add support for multiple programs per section (#3557)
* Allow multiple programs per section

Temporarily use a fork of ebpf-verifier until
https://github.com/vbpf/ebpf-verifier/pull/642 is merged.

Per https://stackoverflow.com/questions/13147170/attribute-always-inline-failing
the __attribute__((always_inline)) doesn't do anything unless you also
have the "inline" keyword.

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Update verifier to latest

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Address comment from Alan

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Address API compat comment from Anurag

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

---------

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
2024-05-29 15:30:20 +00:00
Alan Jowett a5ebdba9d6
Cleanup batch APIs and remove unused parameter (#3580)
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Sharmi <shpalan@microsoft.com>
2024-05-29 15:06:50 +00:00
Alan Jowett bba08b58d3
Pickup latest ubpf and fix breaking changes (#3581)
* Pickup latest ubpf and fix breaking changes

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Pickup fix in ubpf

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Fix parsing issue

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Pickup fix in ubpf

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Sharmi <shpalan@microsoft.com>
2024-05-28 23:12:20 +00:00
Anurag Saxena f7ec168340
Add `total_size` to extension header. (#3573)
* change ebpf_extension_header_t to ebpf_version_header_t

* revert to ebpf_version_header_t

* revert to ebpf_version_header_t

* update header

* update doc

* update doc

* use total_size to get the actual struct size

* Apply suggestions from code review

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>

---------

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
2024-05-24 01:05:36 +00:00
Alan Jowett aed27b488b
Add option to control the level of verbosity emitted by verifier. (#3570)
* Add option to control the level of verbosity emitted by verifier.

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Re-order enums to make normal < informational < verbose

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Apply suggestions from code review

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Workaround for verifier failure #643

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Revert change in ebpf-service verification path

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
2024-05-23 14:02:34 +00:00
Alan Jowett aaad411354
Phase 1 of removing the rundown protection for invoke (#3534)
* Phase 1 of removing the rundown protection for invoke

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Fix SAL annotation error

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Phase 1 of removing the rundown protection for invoke

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Fix SAL annotation error

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Ensure that _ebpf_program_free always run outside of an epoch to prevent deadlocks

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Revert unrelated change

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback and leak fix

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-05-17 14:41:38 +00:00
Alan Jowett 1639d18586
Pickup latest ubpf and fix breaking contract changes (#3531)
* Pickup latest ubpf and fix breaking contract changes

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Suppress warnings in external code

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
2024-05-17 14:41:24 +00:00
Dave Thaler d096b21ac5
Update copyright to be eBPF for Windows contributors (#3508)
* Update copyright to be eBPF for Windows contributors

Fixes #3507

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>

* Undo gratuitous formatting changes in expected files

---------

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
2024-05-04 19:55:56 +00:00
Alan Jowett 2d27ca96f0
PR feedback (#3510)
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-05-04 00:39:25 +00:00
Alan Jowett 382e724688
Partition LRU key history to reduce contention. (#3459)
* Split LRU key history per CPU

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Experiment with merged entry

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Documentation

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Insert into hot-list on first access

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Limit to 8 partitions

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Keys can be deleted without ever being initialized

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Disable ebpf_performance with preemption to avoid timeouts

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Disabling old ebpf_performance tests due to usersim issue

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR Feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Apply suggestions from code review

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Make key state transitions explicit and block invalid transitions

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Restore user mode bpf_performance tests

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Fix OOM failure in verifier

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
2024-04-29 20:38:28 +00:00
Anurag Saxena 586fd21d96
Add support for unlimited map size (#3348)
* backup

* fix tests

* update tests

* add tests

* fix tests

* fix test

* fix

* fix tests

* cr comments

* Apply suggestions from code review

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>

* cr comments

---------

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
Co-authored-by: Alan Jowett <alanjo@microsoft.com>
2024-04-25 15:16:55 +00:00
Alan Jowett 92678e9238
Revert overly strict check in link attach to provider (#3495)
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-04-25 00:28:10 +00:00
Anurag Saxena cf05004d7b
Implement `bpf_get_socket_cookie()` (#3464)
* implement bpf_get_socket_cookie

* fix tests

* fix more tests

* fix tests

* cleanup

* Apply suggestions from code review

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>

* fix regression tests

---------

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
2024-04-24 23:39:57 +00:00
Anurag Saxena e1ac286653
Fixes for memory leaks and crashes (#3485)
* test

* fix

* fix

* fix

* fix

* fix

* more fixes

* fix

* fix

* fix

* Revert "test"

This reverts commit ff024068b6.

* fix

* fix
2024-04-24 23:02:11 +00:00
Dave Thaler c2419acd66
Update verifier to latest (#3454)
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
2024-04-22 19:28:46 +00:00
Anurag Saxena 177479a177
Fix memory leak in `_duplicate_program_descriptor()` (#3473)
* fix memory leak

* fix regression tests

* Revert "fix regression tests"

This reverts commit 6b9cd962d8.

* cr comments

---------

Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
2024-04-22 15:21:21 +00:00
Shankar Seal 4b40f9f6e9
Various fixes to the extension version logic. (#3432)
* various fixes.

* fix mem leak.

* fix double free/

fix one more leak.

* PR feedback.

s# Please enter the commit message for your changes. Lines starting
2024-04-19 19:36:02 +00:00
Shankar Seal 73647f801b
Reallocate packet (#3344)
* reallocate_packet.

* PR Feedback.
2024-04-04 00:49:27 +00:00
Shankar Seal e9fdc9ed84
fixes. (#3422) 2024-04-03 15:44:59 +00:00
Alan Jowett 17cebb0fc9
Fuzz verifier (#3417)
* Attempt to run the fuzzed BPF program

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-04-03 00:24:53 +00:00
Shankar Seal f75fffc82e
fix mem leak. (#3415) 2024-04-02 04:24:02 +00:00
Alan Jowett 6eccc187ba
Implement bpf_object__open_mem (#3416)
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-04-02 01:11:11 +00:00
Shankar Seal fc973542c9
extension_header (#3326)
* extension_header

* fix logic error.

* Re-purposing the size field to act as the "minor version". Additional validation checks are added.

* PR Feedback.

* fix break due to bad merge with PR #3372
2024-03-30 17:27:09 +00:00
Anurag Saxena ae6bdfd757
Fixes for program info hash computation in online mode (#3373)
* fix

* fix tests

* fix

* code cleanup

* fix

* fix

* cleanup
2024-03-29 15:10:35 +00:00
Anurag Saxena 37613367a0
Fix ring_buf issues (#3354)
* fix

* add tests

* code cleanup

* fix tests

* cr comments

* cr comments
2024-03-16 00:16:14 +00:00
Shankar Seal 99a4bbd2d9
fix tracing. (#3336) 2024-03-09 22:46:09 +00:00
Alan Jowett f7bf6d0c92
Switch synchronous thread to thread_local storage (#3330)
* Switch synchronous thread to thread_local storage

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Add dedicated calls to cleanup device handles on thread attach/detach

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Add dedicate test to stress device handling

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-03-06 16:50:54 +00:00
Anurag Saxena 5011c712f2
Fix the IOCTL numbers so that ebpfapi.dll for x64 and x64-NativeOnly are cross-compatible. (#3305)
* backup

* fix

* update tests

* fix cicd

* fix cicd

* copy usersim.dll from regular build

* fix tests

* fix

* cleanup

* cr comments

* cr comments

* cleanup

* fix

* cr comments
2024-03-05 06:26:48 +00:00
Alan Jowett dcd56fed2e
Eliminate calls with FILE_FLAG_OVERLAPPED set, but no overlapped (#3315)
* Eliminate calls with FILE_FLAG_OVERLAPPED set, but no overlapped

Signed-off-by: Alan Jowett (from Dev Box) <alanjo@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett (from Dev Box) <alanjo@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett (from Dev Box) <alanjo@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett (from Dev Box) <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-03-04 23:24:03 +00:00
Alan Jowett dccf443a19
Add utility memory functions (#3324)
* Add utility memory functions

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Code analysis failure

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* PR feedback

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
2024-03-04 20:58:38 +00:00