# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
Commensurate with the update of this repository to "design-to-code" all packages have been udpated. This means the following packages are now changed:
- `@microsoft/fast-tooling` -> `@microsoft/design-to-code`
- `@microsoft/fast-tooling-react` -> `@microsoft/design-to-code-react`
- `@microsoft/fast-tooling-wasm` -> `@microsoft/design-to-code-wasm`
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
#223
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
Check for any missed instances of FAST Tooling, fast-tooling etc.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [x] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- Publish packages
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change adds a deprecation warning at the top of the published package README files and points to what will be the new names of these packages. This is inline with the repository rename change.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [ ] I have tested my changes.
- [x] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- Rename packages and update documentation
# Pull Request
## 📖 Description
This PR adds file extensions to all relative import / export paths. This work enables NodeJS to correctly resolve the modules using ES module resolution.
<!--- Provide some background and a description of your work. -->
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [ ] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
Co-authored-by: nicholasrice <nicholasrice@users.noreply.github.com>
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.15 to 4.17.21.
<details>
<summary>Commits</summary>
<ul>
<li><a href="f299b52f39"><code>f299b52</code></a> Bump to v4.17.21</li>
<li><a href="c4847ebe7d"><code>c4847eb</code></a> Improve performance of <code>toNumber</code>, <code>trim</code> and <code>trimEnd</code> on large input strings</li>
<li><a href="3469357cff"><code>3469357</code></a> Prevent command injection through <code>_.template</code>'s <code>variable</code> option</li>
<li><a href="ded9bc6658"><code>ded9bc6</code></a> Bump to v4.17.20.</li>
<li><a href="63150ef764"><code>63150ef</code></a> Documentation fixes.</li>
<li><a href="00f0f62a97"><code>00f0f62</code></a> test.js: Remove trailing comma.</li>
<li><a href="846e434c7a"><code>846e434</code></a> Temporarily use a custom fork of <code>lodash-cli</code>.</li>
<li><a href="5d046f39cb"><code>5d046f3</code></a> Re-enable Travis tests on <code>4.17</code> branch.</li>
<li><a href="aa816b36d4"><code>aa816b3</code></a> Remove <code>/npm-package</code>.</li>
<li><a href="d7fbc52ee0"><code>d7fbc52</code></a> Bump to v4.17.19</li>
<li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.21">compare view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a href="https://www.npmjs.com/~bnjmnt4n">bnjmnt4n</a>, a new releaser for lodash-es since your current version.</p>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/microsoft/fast-tooling/network/alerts).
</details>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change updates the following:
- Allows a previous data message for an update to include removal of strings when it is the root level data type
- Allows remove to include a dictionary ID
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This fix checks to see if a single click is on the current elements dictionary ID while it is in inline editing mode. If it is, it will ignore the single click.
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
This could use some manual testing vis a vis the automatically deployed site.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change allows the propagation of keyDown events so that the Shortcuts service can capture all keyDown events.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
The previous fix addressed one issue with custom messages in the HTML Render, but there was a further attempt at processing custom messages on the HTML Render Layer. Additionally, the HTML Render was attempting to set the dataDictionary when a custom message was sent so the logic to understand when a message is one that needs attention has been moved to the parent if block.
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
This was checked using `npm link`. It appears to work correctly with no more runtime errors.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This PR fixes an issue where if a custom message was sent without an action property it would error.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
Custom messages cause the Form to error due to a previous refactor, this has been fixed in this change which should not look at dataDictionary or any other data structures internals unless the message is one known to contain those.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This pull request fixes an issue where the key was not capitalized, which it has to be because the special key shift is used. This also fixes an issue where the incorrect history index was used to fire the next message.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This update ensures that all messages sent back are either outgoing messages or null. This does not include tests as the strict null check should be enabled in the tsconfig, but that is not part of this task.
Another change in this PR is the removal of returning of IDs from the history function, this is because they are never assigned or used.
To better track navigation updates to determine how well shortcuts are working, a small check and indicator has been added to the shortcuts manual testing page.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- More robust testing of the shortcuts to ensure all use cases are covered.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change makes it so that all outgoing messages are an array of messages. This will allow for a single message update to create multiple messages that are then sent out. As this is dealt with internally, there are no breaking changes.
This change also adds a manual testing section for the new undo/redo alpha released shortcuts.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Resolves#179
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
This should now enable, in the manual testing app, seeing "delete" shortcut action followed by "undo".
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- More robust testing and implementation work is needed to ensure previous and next (undo/redo) maneuvering through the history stack does not cause errors to throw
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change adds undo/redo shortcuts as alpha released shortcuts.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Closes#158
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
Requires merging of #177 to pass local testing.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change allows messages to be sent to move forward and backwards through the history stack.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Initial work on #158
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
Complete a PR for undo/redo shortcuts
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change removes redundant `MessageSystemType` messages. This should simplify the message system interfaces as they are now always sending state data per updates from https://github.com/microsoft/fast-tooling/pull/167.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Closes#168
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- #158
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This work is necessary foundational work for #158 where the undo and redo will be moving through the history stack.
This changes the history interface, so far unused, to include a `next` and `previous` properties which will trigger depending on the direction that history is moving in the stack.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- Simplify some deprecated message system types #168
- Create undo and redo shortcuts #158
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This pull request includes the previously reviewed work:
- #161
- #165
- #166
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
These changes require a review and sign off as they are going into the `main` branch.
Co-authored-by: William Wagner <44823142+williamw2@users.noreply.github.com>
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change does the following:
- Adds the duplicate shortcut function (ctrl + d)
- Updates the test app to include a table of commands to keep track of them
- Updates the shortcuts service to store and provide the active dictionary id and data dictionary and supply this to actions
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Closes#23
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
Replaced the Wrap icon SVG in the CSS Layout (flexbox) component with versions that better fit the space.
Before / After
<!--- Provide some background and a description of your work. -->
### 🎫 Issues
Closes: #99
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change:
- Updates the window logic to check for search parameters which means the refresh during development now persists on the iframe page
- Adds a little styling update to the test app
- Updates out of date test app text for shortcuts
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change does the following:
- Update shortcut actions so they can directly assign the event listener to a provided HTML element
- Add an export for the delete shortcut action
Relies on the completion of #152 to pass the build.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Resolves#24
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change allows the remove linked data action to default to removing the active dictionary ID. This provides an easy way for shortcuts to act on a "delete" option.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Related to #24
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- Add a PR for shortcuts to execute using this updated API with an exported delete shortcuts action (see #153)
* Add Playwright and first test
* Change files
* More comments
* Add playwright to fast-tooling-react and wasm
* Change files
* Fix port numbers
* Fix eslint error
* Update change/@microsoft-fast-tooling-f25a09d2-ac4d-45db-827c-be83b473301f.json
Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
* Update change/@microsoft-fast-tooling-react-58c4c2d7-aeb2-4ce9-b796-2a751f0a0fe1.json
Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
FAST DevOps
Jane Chu
Nicholas Rice
dependabot[bot]
William Wagner
