# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
Custom messages cause the Form to error due to a previous refactor, this has been fixed in this change which should not look at dataDictionary or any other data structures internals unless the message is one known to contain those.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This pull request fixes an issue where the key was not capitalized, which it has to be because the special key shift is used. This also fixes an issue where the incorrect history index was used to fire the next message.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This update ensures that all messages sent back are either outgoing messages or null. This does not include tests as the strict null check should be enabled in the tsconfig, but that is not part of this task.
Another change in this PR is the removal of returning of IDs from the history function, this is because they are never assigned or used.
To better track navigation updates to determine how well shortcuts are working, a small check and indicator has been added to the shortcuts manual testing page.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- More robust testing of the shortcuts to ensure all use cases are covered.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change makes it so that all outgoing messages are an array of messages. This will allow for a single message update to create multiple messages that are then sent out. As this is dealt with internally, there are no breaking changes.
This change also adds a manual testing section for the new undo/redo alpha released shortcuts.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Resolves#179
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
This should now enable, in the manual testing app, seeing "delete" shortcut action followed by "undo".
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- More robust testing and implementation work is needed to ensure previous and next (undo/redo) maneuvering through the history stack does not cause errors to throw
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change adds undo/redo shortcuts as alpha released shortcuts.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Closes#158
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
Requires merging of #177 to pass local testing.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change allows messages to be sent to move forward and backwards through the history stack.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Initial work on #158
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
Complete a PR for undo/redo shortcuts
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change removes redundant `MessageSystemType` messages. This should simplify the message system interfaces as they are now always sending state data per updates from https://github.com/microsoft/fast-tooling/pull/167.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Closes#168
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- #158
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This work is necessary foundational work for #158 where the undo and redo will be moving through the history stack.
This changes the history interface, so far unused, to include a `next` and `previous` properties which will trigger depending on the direction that history is moving in the stack.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- Simplify some deprecated message system types #168
- Create undo and redo shortcuts #158
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This pull request includes the previously reviewed work:
- #161
- #165
- #166
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
These changes require a review and sign off as they are going into the `main` branch.
Co-authored-by: William Wagner <44823142+williamw2@users.noreply.github.com>
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change does the following:
- Adds the duplicate shortcut function (ctrl + d)
- Updates the test app to include a table of commands to keep track of them
- Updates the shortcuts service to store and provide the active dictionary id and data dictionary and supply this to actions
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Closes#23
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
Replaced the Wrap icon SVG in the CSS Layout (flexbox) component with versions that better fit the space.
Before / After
<!--- Provide some background and a description of your work. -->
### 🎫 Issues
Closes: #99
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change:
- Updates the window logic to check for search parameters which means the refresh during development now persists on the iframe page
- Adds a little styling update to the test app
- Updates out of date test app text for shortcuts
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change does the following:
- Update shortcut actions so they can directly assign the event listener to a provided HTML element
- Add an export for the delete shortcut action
Relies on the completion of #152 to pass the build.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Resolves#24
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change allows the remove linked data action to default to removing the active dictionary ID. This provides an easy way for shortcuts to act on a "delete" option.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Related to #24
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
- Add a PR for shortcuts to execute using this updated API with an exported delete shortcuts action (see #153)
* Add Playwright and first test
* Change files
* More comments
* Add playwright to fast-tooling-react and wasm
* Change files
* Fix port numbers
* Fix eslint error
* Update change/@microsoft-fast-tooling-f25a09d2-ac4d-45db-827c-be83b473301f.json
Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
* Update change/@microsoft-fast-tooling-react-58c4c2d7-aeb2-4ce9-b796-2a751f0a0fe1.json
Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
Co-authored-by: Jane Chu <7559015+janechu@users.noreply.github.com>
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
Adds additional documentation for the github token needed for workflows.
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
This is a relatively trivial documentation update, ensure that the wording is succinct.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [ ] I have tested my changes.
- [x] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This fixes an issue where, when typing inside an instance of the Monaco Editor, the whitespaces at the beginning of the values which are only used as indenting, were being interpreted as text nodes.
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
Try typing in the Monaco Editor, this should no longer show as multiple elements and empty text nodes.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
Fixes a bug in HTMLRender component that would throw a javascript error and place the renderer into an unrecoverable state when given a data dictionary with no markup.
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change updates the following:
- Adds the dictionary ID being edited to the data update sent by the inline editing control, this was assumed to be the active dictionary ID and was therefore not specified but this may cause async navigational issues
- Adds the dictionary ID to the message systems data updates for further information to message system handlers
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
The Form react component had a missing originatorId property, this assists in debugging and ensuring the components do not get stuck in loops.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This fixes a problem with calculating the correct size and position of the inline edit text area when all of the text is removed that would result in the text area vanishing and losing focus.
This fix introduces a new minimum size for the text area calculated from the target text node's calculated line-height or in the case line-height returns "normal" it is 1.5x the calculated font-size (which always returns a pixel value).
**This will not be fully fixed until https://github.com/microsoft/fast-creator/pull/85 is merged.**
### 🎫 Issues
<!---
List and link relevant issues here using the keyword "closes"
if this PR will close an issue, eg. closes#411
-->
Closes: #74
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change removes the soft remove (or undo/redo) button from the linked data control. It has been determined that this UI is confusing and would be confusing to maintain for linked data, which is a special data case outside of the regular data types defined in JSON schema.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change adds information to the CONTRIBUTING.md file on guidance for merging pull requests.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [ ] I have tested my changes.
- [x] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change fixes an issue with CSSLayout components type definitions and updates all packages to depend on TypeScript 4.3.x.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
The `postinstall` script is firing when the fast-tooling-react package is added as a dependency. To prevent this only the `prepare` script is utilized. It is unknown at this time why the change was made during migration.
Edit: well apparently it was because fast-tooling-react installs first even though fast-tooling is a dependency. Still looking for a solution.
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
Run installation locally to see if any issues arise.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change should add the wasm package to the build gate and prevent errors from being pushed. The package is currently private and requires `wasm-pack` to run.
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
The build gate should pass and include the tests in the wasm package. To run locally, follow the steps in the CONTRIBUTING.md file for the wasm package.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
# Pull Request
## 📖 Description
<!--- Provide some background and a description of your work. -->
This change converts the C permutator, which only includes permutating over numbers, to Rust.
## 👩💻 Reviewer Notes
<!---
Provide some notes for reviewers to help them provide targeted feedback and testing.
-->
Take a loot at this, pull down if necessary and update all dependencies. This may take some times. You will then be able to run the webpack app that utilizes the permutator and manually test.
## ✅ Checklist
### General
<!--- Review the list and put an x in the boxes that apply. -->
- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [x] I have updated the project documentation to reflect my changes.
## ⏭ Next Steps
<!---
If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.
-->
Jane Chu
FAST DevOps
William Wagner
Aaron Wentzel
