Граф коммитов

12 Коммитов

Автор SHA1 Сообщение Дата
lenahong c85943cf17
Android Native Module Documentation and Drawer example (#1519)
* show drawer

* add experimental-drawer ver to tester

* Add drawer content to tester

* update Drawer properties

* remove unused imports

* add documentation

* Change files

* remove unncessary change files"

* clean up code

* clean up tester code

* Fix tests

* Update dependencies

* menu button fix

* restore primary button for menuButton

* restore fluent tester package.jsoin

* fix import cycle

* add drawer dep to fluent tester

* temp fix e2e testing error for menuButton

* Change files

* remove unnecessary change filew

* change menu button content macro for e2e testing to null temp

* run prettier fix

Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
2022-03-28 23:47:05 +09:00
Ruriko Araki 0bbf3a115e
Ignore 429 error from markdown-link-check (#1534)
* Change links to point not using urls

* Ignore 429 status codes

* Change files

* Try adding a comment
2022-03-23 11:15:44 -07:00
Saad Najmi 2b95227026
Update Apple Native Module naming convention (MSF -> FRN) (#899)
* MSF -> FRN, podspec and podfile updates

* enable nuget publish

* more podfile / podspec renames

* some things I forgot to rename

* Change files

* more renaming

* more fixes

* Update package.nuspec

* Comment out NuGet Publish
2021-08-17 13:42:21 -04:00
Anna Dingler cbe7dd8b8e
Add documentation for Windows components (#846)
* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md
2021-08-13 08:23:07 -05:00
Saad Najmi 183bcbe111
Update Native Apple Code for better downstream integration (#710)
### Platforms Impacted
- [x] iOS
- [x] macOS
- [ ] win32 (Office)
- [ ] windows
- [ ] android

### Description of changes

This change refactors some of our native iOS and macOS code for better downstream integration into the office codebase.

Namely:
- Every native module's `<Component>-Bridging-Header.h` has been renamed to `<Component>ViewManager.h`. 
  - These files were never bridging headers, and cocoa pods / swift never interpreted them as such. There is potential to improve the RN docs on how to write a native swift module here as well.
- Adds the `BUILD_LIBRARY_FOR_DISTRIBUTION` flag to each native module's pod spec
  - This flag allows for ABI stability in our swift static libraries. Note that the main side effect of this flag is it produces a `.swiftinterface` file in the static libraries' swift module. I do not include the swift module in the NuGet to be included downstream in office. In my testing I found it was not needed to get iOS NativeButton to link, so I opted not to include the swif module. This may change in the future as I try to figure out why the macOS NativeButton static library won't link.
- Adds the `OTHER_SWIFT_FLAGS=-gline-tables-only` flag to each native module's pod spec
  - This is a potential security risk that is fixed, as per the comment here https://github.com/microsoft/fluentui-react-native/pull/710#discussion_r688016727 . 
- removes the `CLANG_DEBUG_INFORMATION_LEVEL=line-tables-only` build flag
  - This caused issues with the previous `BUILD_LIBRARY_FOR_DISTRIBUTION` flag and build failures. I'm not sure why. 
- Sets the Swift version to 5.0
  - I added this because I noticed that Azure pipelines would actually use the Swift 5.3.2 compiler, so I wanted to be explicit which version of swift we are compiling for.

Prior to this change, we could not link the NativeButton component downstream into office due to some linker issues. This change updates a few parts of our native iOS and macOS code such that we can now link the iOS NativeButton. The macOS NativeButton static library still does not properly link, I'll leave that as a followup.

### Verification

I had a local change downstream in office to consume an intermediate NuGet produced by this PR and test that linking worked. That's where I saw that iOS and not macOS works. Link for those who can see it: https://office.visualstudio.com/OE/_build/results?buildId=9621115&view=logs&j=4257c0a7-7659-5375-d6e0-cde9f28a3d36

### Pull request checklist

This PR has considered (when applicable):
- [x] Automated Tests
- [x] Documentation and examples
- [ ] Keyboard Accessibility
- [ ] Voiceover
- [ ] Internationalization and Right-to-left Layouts
2021-08-13 08:48:32 +00:00
Keven Arroyo b219de1417
Updating broken links (#884) 2021-08-10 19:59:24 -05:00
Tommy Nguyen 69c607cb93
chore: replace just-repo-utils with workspace-tools (#791)
* chore: replace just-repo-utils with workspace-tools

* Change files
2021-07-24 09:47:07 -07:00
Linda da070666ec
Update Contributing guide and Tester app launch guides (#793)
* Comment out tests that crash the app for iOS and macOS

* Delete tests that crash the tester app for iOs and macOS

* Change files

* Update contributing guide and readmes

* Update for most recent info

* Minor changes

* Clarify where to run pod install
2021-07-23 15:36:20 -04:00
Saad Najmi f8e19231d4
Update our contributing guide to mention the "@jsx withSlots" comment (#759)
* Add a comment about the UseSlots comment
2021-07-06 16:53:30 -05:00
Ruriko Araki 4cb0141902
Edit contributing and add link to contributing from readme (#707)
* Edit contributing and add link to contributing from readme

* Address feedback

* Address feedback
2021-05-28 02:56:27 +09:00
chiuam 27c0673e30
Add documentation on stagedComponent (#693) 2021-05-18 12:34:49 -04:00
Saad Najmi 818e996e48
Add a Contributing markdown file (#555)
* Initial Commit

* Restructuring

* Rewrite Slots summary

* Update Guide based on feedback

* More fixes

* Update from PR feedback
2021-04-26 14:58:39 -05:00