Best practice unit test module structure (#108)

* Moved api test to same package as api and removed module-info.java from test

* Moved parser test to same package as parser and removed module-info.java from test

* Moved sample test to same package as sample and removed module-info.java from test

* Moved vertx test to same package as vertx and removed module-info.java from test

api/pom.xml

@@ -1,5 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
     <parent>
@@ -11,6 +13,21 @@
 
     <artifactId>gctoolkit-api</artifactId>
 
+    <build>
+        <plugins>
+            <plugin>
+               <artifactId>maven-surefire-plugin</artifactId>
+                <configuration>
+                    <argLine>
+                        --add-opens com.microsoft.gctoolkit.api/com.microsoft.gctoolkit.time=ALL-UNNAMED
+                        --add-opens com.microsoft.gctoolkit.api/com.microsoft.gctoolkit.io=ALL-UNNAMED
+                    </argLine>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
+
+
     <dependencies>
         <dependency>
             <groupId>org.junit.jupiter</groupId>

api/src/test/java/com/microsoft/gctoolkit/io/RotatingGarbageCollectionLogFileTest.java

@@ -1,9 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.test.io;
+package com.microsoft.gctoolkit.io;
 
-import com.microsoft.gctoolkit.io.GarbageCollectionLogFileSegment;
-import com.microsoft.gctoolkit.io.RotatingGCLogFile;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;

api/src/test/java/com/microsoft/gctoolkit/time/DateTimeStampTest.java

@@ -1,8 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.test.time;
+package com.microsoft.gctoolkit.time;
 
-import com.microsoft.gctoolkit.time.DateTimeStamp;
 import org.junit.jupiter.api.Test;
 
 import java.time.ZonedDateTime;

api/src/test/java/com/microsoft/gctoolkit/util/concurrent/StartingGunTest.java

@@ -1,6 +1,5 @@
-package com.microsoft.gctoolkit.test.util.concurrent;
+package com.microsoft.gctoolkit.util.concurrent;
 
-import com.microsoft.gctoolkit.util.concurrent.StartingGun;
 import org.junit.jupiter.api.Test;
 
 import java.util.concurrent.locks.LockSupport;

api/src/test/java/module-info.java

@@ -1,8 +0,0 @@
-// Copyright (c) Microsoft Corporation.
-// Licensed under the MIT License.
-open module gctoolkit.api.test {
-    requires com.microsoft.gctoolkit.api;
-    requires java.logging;
-    requires org.junit.jupiter.api;
-    requires org.junit.jupiter.engine;
-}

parser/src/main/java/module-info.java

@@ -5,35 +5,24 @@
  * Contains the GCToolKit GC log parser. The parser is an internal module.
  */
 module com.microsoft.gctoolkit.parser {
-
     exports com.microsoft.gctoolkit.parser to
-            gctoolkit.parser.test,
             com.microsoft.gctoolkit.vertx;
 
-    exports com.microsoft.gctoolkit.parser.collection to
-            gctoolkit.parser.test;
-
     exports com.microsoft.gctoolkit.parser.io to
-            gctoolkit.parser.test,
             com.microsoft.gctoolkit.vertx;
 
     exports com.microsoft.gctoolkit.parser.jvm to
-            gctoolkit.parser.test,
             com.microsoft.gctoolkit.vertx;
 
     exports com.microsoft.gctoolkit.parser.unified to
-            gctoolkit.parser.test,
             com.microsoft.gctoolkit.vertx;
 
     exports com.microsoft.gctoolkit.parser.vmops to
-            gctoolkit.parser.test,
             com.microsoft.gctoolkit.vertx;
 
     exports com.microsoft.gctoolkit.parser.datatype to
-            gctoolkit.parser.test,
             com.microsoft.gctoolkit.vertx;
 
     requires com.microsoft.gctoolkit.api;
     requires java.logging;
-
 }

parser/src/test/java/com/microsoft/gctoolkit/parser/CommonTestHelper.java

@@ -1,4 +1,4 @@
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
 import com.microsoft.gctoolkit.parser.GCParseRule;
 

parser/src/test/java/com/microsoft/gctoolkit/parser/ConcurrentMarkSweepParserRulesTest.java

@@ -1,15 +1,9 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
-import com.microsoft.gctoolkit.parser.CMSPatterns;
-import com.microsoft.gctoolkit.parser.GCLogTrace;
-import com.microsoft.gctoolkit.parser.GCParseRule;
 import org.junit.jupiter.api.Test;
 
-import java.util.Arrays;
-import java.util.Objects;
-
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class ConcurrentMarkSweepParserRulesTest implements CMSPatterns {

parser/src/test/java/com/microsoft/gctoolkit/parser/ConcurrentMarkSweepPhaseParserRulesTest.java

@@ -1,10 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
-import com.microsoft.gctoolkit.parser.CMSPatterns;
-import com.microsoft.gctoolkit.parser.GCLogTrace;
-import com.microsoft.gctoolkit.parser.GCParseRule;
 import org.junit.jupiter.api.Test;
 
 import java.util.logging.Logger;

parser/src/test/java/com/microsoft/gctoolkit/parser/G1GCParserRulesTest.java

@@ -1,14 +1,9 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
-import com.microsoft.gctoolkit.parser.G1GCPatterns;
-import com.microsoft.gctoolkit.parser.GCLogTrace;
-import com.microsoft.gctoolkit.parser.GCParseRule;
 import org.junit.jupiter.api.Test;
 
-import java.util.Arrays;
-import java.util.Objects;
 import java.util.logging.Logger;
 
 import static org.junit.jupiter.api.Assertions.assertTrue;

parser/src/test/java/com/microsoft/gctoolkit/parser/G1GCUnifiedParserRulesTest.java

@@ -1,16 +1,14 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
-import com.microsoft.gctoolkit.parser.GCLogTrace;
-import com.microsoft.gctoolkit.parser.GCParseRule;
 import com.microsoft.gctoolkit.parser.unified.UnifiedG1GCPatterns;
 import com.microsoft.gctoolkit.parser.jvm.Decorators;
 import org.junit.jupiter.api.Test;
 
 import java.util.logging.Logger;
 
-import static com.microsoft.gctoolkit.parser.test.CommonTestHelper.captureTest;
+import static com.microsoft.gctoolkit.parser.CommonTestHelper.captureTest;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class G1GCUnifiedParserRulesTest implements UnifiedG1GCPatterns {

parser/src/test/java/com/microsoft/gctoolkit/parser/GenerationalHeapParserTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
 import com.microsoft.gctoolkit.event.generational.FullGC;
 import com.microsoft.gctoolkit.parser.GenerationalHeapParser;

parser/src/test/java/com/microsoft/gctoolkit/parser/IncrementialConcurrentMarkSweepParserRulesTest.java

@@ -1,10 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
-import com.microsoft.gctoolkit.parser.ICMSPatterns;
-import com.microsoft.gctoolkit.parser.GCLogTrace;
-import com.microsoft.gctoolkit.parser.GCParseRule;
 import org.junit.jupiter.api.Test;
 
 import java.util.logging.Logger;

parser/src/test/java/com/microsoft/gctoolkit/parser/ParallelParserRulesTest.java

@@ -1,15 +1,12 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
-import com.microsoft.gctoolkit.parser.ParallelPatterns;
-import com.microsoft.gctoolkit.parser.GCLogTrace;
-import com.microsoft.gctoolkit.parser.GCParseRule;
 import org.junit.jupiter.api.Test;
 
 import java.util.logging.Logger;
 
-import static com.microsoft.gctoolkit.parser.test.CommonTestHelper.captureTest;
+import static com.microsoft.gctoolkit.parser.CommonTestHelper.captureTest;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class ParallelParserRulesTest implements ParallelPatterns {

parser/src/test/java/com/microsoft/gctoolkit/parser/ShenandoahParserRulesTest.java

@@ -1,9 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
-import com.microsoft.gctoolkit.parser.GCLogTrace;
-import com.microsoft.gctoolkit.parser.GCParseRule;
 import com.microsoft.gctoolkit.parser.unified.ShenandoahPatterns;
 import org.junit.jupiter.api.Test;
 

parser/src/test/java/com/microsoft/gctoolkit/parser/ShenandoahParserTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
 import com.microsoft.gctoolkit.event.shenandoah.ShenandoahCycle;
 import com.microsoft.gctoolkit.event.zgc.OccupancySummary;

parser/src/test/java/com/microsoft/gctoolkit/parser/TestLogFile.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
 import java.io.File;
 import java.util.Arrays;

parser/src/test/java/com/microsoft/gctoolkit/parser/UnifiedGenerationalParserRulesTest.java

@@ -1,16 +1,14 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
-import com.microsoft.gctoolkit.parser.GCLogTrace;
-import com.microsoft.gctoolkit.parser.GCParseRule;
 import com.microsoft.gctoolkit.parser.unified.UnifiedGenerationalPatterns;
 import com.microsoft.gctoolkit.parser.jvm.Decorators;
 import org.junit.jupiter.api.Test;
 
 import java.util.logging.Logger;
 
-import static com.microsoft.gctoolkit.parser.test.CommonTestHelper.captureTest;
+import static com.microsoft.gctoolkit.parser.CommonTestHelper.captureTest;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class UnifiedGenerationalParserRulesTest implements UnifiedGenerationalPatterns {

parser/src/test/java/com/microsoft/gctoolkit/parser/ZGCParserRulesTest.java

@@ -1,9 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
-import com.microsoft.gctoolkit.parser.GCLogTrace;
-import com.microsoft.gctoolkit.parser.GCParseRule;
 import com.microsoft.gctoolkit.parser.unified.ZGCPatterns;
 import com.microsoft.gctoolkit.parser.jvm.Decorators;
 import org.junit.jupiter.api.Test;

parser/src/test/java/com/microsoft/gctoolkit/parser/ZGCParserTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test;
+package com.microsoft.gctoolkit.parser;
 
 import com.microsoft.gctoolkit.event.zgc.OccupancySummary;
 import com.microsoft.gctoolkit.event.zgc.ReclaimSummary;

parser/src/test/java/com/microsoft/gctoolkit/parser/collection/MRUQueueTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.collection;
+package com.microsoft.gctoolkit.parser.collection;
 
 
 import com.microsoft.gctoolkit.parser.collection.MRUQueue;

parser/src/test/java/com/microsoft/gctoolkit/parser/diary/CMSDefNewLogDiaryTest.java

@@ -1,10 +1,10 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.diary;
+package com.microsoft.gctoolkit.parser.diary;
 
 import com.microsoft.gctoolkit.io.SingleGCLogFile;
 import com.microsoft.gctoolkit.parser.jvm.JVMConfiguration;
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.fail;

parser/src/test/java/com/microsoft/gctoolkit/parser/diary/CMSLogDiaryTest.java

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.diary;
+package com.microsoft.gctoolkit.parser.diary;
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import com.microsoft.gctoolkit.io.SingleGCLogFile;
 import com.microsoft.gctoolkit.parser.jvm.JVMConfiguration;
 import org.junit.jupiter.api.Test;

parser/src/test/java/com/microsoft/gctoolkit/parser/diary/CMSParNewLogDiaryTest.java

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.diary;
+package com.microsoft.gctoolkit.parser.diary;
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Test;
 
 public class CMSParNewLogDiaryTest extends LogDiaryTest {

parser/src/test/java/com/microsoft/gctoolkit/parser/diary/CommandLineFlagsLogDiaryTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.diary;
+package com.microsoft.gctoolkit.parser.diary;
 
 import com.microsoft.gctoolkit.parser.jvm.JVMConfiguration;
 import com.microsoft.gctoolkit.parser.jvm.LoggingDiary;

parser/src/test/java/com/microsoft/gctoolkit/parser/diary/G1JVMConfigurationTest.java

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.diary;
+package com.microsoft.gctoolkit.parser.diary;
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Test;
 
 public class G1JVMConfigurationTest extends LogDiaryTest {

parser/src/test/java/com/microsoft/gctoolkit/parser/diary/LogDiaryTest.java

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.diary;
+package com.microsoft.gctoolkit.parser.diary;
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import com.microsoft.gctoolkit.io.GCLogFile;
 import com.microsoft.gctoolkit.io.SingleGCLogFile;
 import com.microsoft.gctoolkit.parser.jvm.JVMConfiguration;

parser/src/test/java/com/microsoft/gctoolkit/parser/diary/ParallelJVMConfigurationTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.diary;
+package com.microsoft.gctoolkit.parser.diary;
 
 import org.junit.jupiter.api.Test;
 

parser/src/test/java/com/microsoft/gctoolkit/parser/diary/SerialDefNewLogDiaryTest.java

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.diary;
+package com.microsoft.gctoolkit.parser.diary;
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Test;
 
 public class SerialDefNewLogDiaryTest extends LogDiaryTest {

parser/src/test/java/com/microsoft/gctoolkit/parser/diary/ShenandoahLogDiaryTest.java

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.diary;
+package com.microsoft.gctoolkit.parser.diary;
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 

parser/src/test/java/com/microsoft/gctoolkit/parser/diary/VerboseLogDiaryTest.java

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.diary;
+package com.microsoft.gctoolkit.parser.diary;
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Test;
 
 public class VerboseLogDiaryTest extends LogDiaryTest {

parser/src/test/java/com/microsoft/gctoolkit/parser/diary/ZGCLogDiaryTest.java

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.diary;
+package com.microsoft.gctoolkit.parser.diary;
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 

parser/src/test/java/com/microsoft/gctoolkit/parser/jvm/DecoratorsTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.jvm;
+package com.microsoft.gctoolkit.parser.jvm;
 
 import java.time.ZonedDateTime;
 

parser/src/test/java/com/microsoft/gctoolkit/parser/patterns/CMSTenuredParserTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.patterns;
+package com.microsoft.gctoolkit.parser.patterns;
 
 
 import com.microsoft.gctoolkit.event.generational.AbortablePreClean;

parser/src/test/java/com/microsoft/gctoolkit/parser/patterns/G1GCPatternsTest.java

@@ -1,15 +1,14 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.patterns;
+package com.microsoft.gctoolkit.parser.patterns;
 
 import com.microsoft.gctoolkit.parser.G1GCPatterns;
 import com.microsoft.gctoolkit.parser.GCParseRule;
-import com.microsoft.gctoolkit.parser.test.CommonTestHelper;
 import org.junit.jupiter.api.Test;
 
 import java.util.logging.Logger;
 
-import static com.microsoft.gctoolkit.parser.test.CommonTestHelper.captureTest;
+import static com.microsoft.gctoolkit.parser.CommonTestHelper.captureTest;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 

parser/src/test/java/com/microsoft/gctoolkit/parser/patterns/GenerationalParserTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.patterns;
+package com.microsoft.gctoolkit.parser.patterns;
 
 import com.microsoft.gctoolkit.event.GCCause;
 import com.microsoft.gctoolkit.event.generational.CMSRemark;

parser/src/test/java/com/microsoft/gctoolkit/parser/patterns/JVMPatternsTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.patterns;
+package com.microsoft.gctoolkit.parser.patterns;
 
 import com.microsoft.gctoolkit.parser.JVMPatterns;
 import org.junit.jupiter.api.Test;

parser/src/test/java/com/microsoft/gctoolkit/parser/patterns/ParserTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.patterns;
+package com.microsoft.gctoolkit.parser.patterns;
 
 
 import com.microsoft.gctoolkit.event.MemoryPoolSummary;

parser/src/test/java/com/microsoft/gctoolkit/parser/patterns/UnifiedGenerationalParserTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.patterns;
+package com.microsoft.gctoolkit.parser.patterns;
 
 
 import com.microsoft.gctoolkit.event.MemoryPoolSummary;

parser/src/test/java/com/microsoft/gctoolkit/parser/unittests/CMSParNewParserTest.java

@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.unittests;
+package com.microsoft.gctoolkit.parser.unittests;
 
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;

parser/src/test/java/com/microsoft/gctoolkit/parser/unittests/G1GCMetaspaceTest.java

@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.unittests;
+package com.microsoft.gctoolkit.parser.unittests;
 
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;

parser/src/test/java/com/microsoft/gctoolkit/parser/unittests/ICMSParNewParserTest.java

@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.unittests;
+package com.microsoft.gctoolkit.parser.unittests;
 
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;

parser/src/test/java/com/microsoft/gctoolkit/parser/unittests/ParallelCollectorParserTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.unittests;
+package com.microsoft.gctoolkit.parser.unittests;
 
 
 public class ParallelCollectorParserTest extends ParserTest {

parser/src/test/java/com/microsoft/gctoolkit/parser/unittests/ParserTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.unittests;
+package com.microsoft.gctoolkit.parser.unittests;
 
 import com.microsoft.gctoolkit.event.GCEvent;
 import com.microsoft.gctoolkit.event.GarbageCollectionTypes;

parser/src/test/java/com/microsoft/gctoolkit/parser/unittests/PreunifiedG1GCParserTest.java

@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.unittests;
+package com.microsoft.gctoolkit.parser.unittests;
 
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;

parser/src/test/java/com/microsoft/gctoolkit/parser/unittests/UnifiedG1GCParserTest.java

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.unittests;
+package com.microsoft.gctoolkit.parser.unittests;
 
-import com.microsoft.gctoolkit.parser.test.TestLogFile;
+import com.microsoft.gctoolkit.parser.TestLogFile;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;

parser/src/test/java/com/microsoft/gctoolkit/parser/vmops/SafepointPatternsTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.parser.test.vmops;
+package com.microsoft.gctoolkit.parser.vmops;
 
 
 import com.microsoft.gctoolkit.event.jvm.Safepoint;

parser/src/test/java/module-info.java

@@ -1,11 +0,0 @@
-// Copyright (c) Microsoft Corporation.
-// Licensed under the MIT License.
-open module gctoolkit.parser.test {
-
-    requires com.microsoft.gctoolkit.api;
-    requires com.microsoft.gctoolkit.parser;
-    requires java.logging;
-
-    requires org.junit.jupiter.engine;
-    requires org.junit.jupiter.api;
-}

sample/pom.xml

@@ -15,6 +15,7 @@
         <gcLogFile>../gclogs/preunified/cms/defnew/details/defnew.log</gcLogFile>
     </properties>
 
+
     <dependencies>
         <dependency>
             <groupId>com.microsoft.gctoolkit</groupId>
@@ -56,6 +57,9 @@
                             <value>${gcLogFile}</value>
                         </property>
                     </systemProperties>
+                    <argLine>
+                        --add-opens com.microsoft.gctoolkit.sample/com.microsoft.gctoolkit.sample.collections=ALL-UNNAMED
+                    </argLine>
                 </configuration>
             </plugin>
             <plugin>

sample/src/main/java/module-info.java

@@ -11,7 +11,6 @@ module com.microsoft.gctoolkit.sample {
     requires java.logging;
 
     exports com.microsoft.gctoolkit.sample.aggregation to com.microsoft.gctoolkit.vertx;
-    exports com.microsoft.gctoolkit.sample.collections to com.microsoft.gctoolkit.sample.test;
 
     exports com.microsoft.gctoolkit.sample;
 

sample/src/test/java/com/microsoft/gctoolkit/sample/TestMain.java

@@ -1,4 +1,4 @@
-package com.microsoft.gctoolkit.sample.test;
+package com.microsoft.gctoolkit.sample;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import org.junit.jupiter.api.Test;

sample/src/test/java/com/microsoft/gctoolkit/sample/collections/XYDataSetTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.sample.test.collections;
+package com.microsoft.gctoolkit.sample.collections;
 
 import com.microsoft.gctoolkit.sample.collections.XYDataSet;
 import com.microsoft.gctoolkit.sample.collections.XYDataSet.Point;

sample/src/test/java/module-info.java

@@ -1,10 +0,0 @@
-// Copyright (c) Microsoft Corporation.
-// Licensed under the MIT License.
-
-open module com.microsoft.gctoolkit.sample.test {
-    requires com.microsoft.gctoolkit.sample;
-
-    requires java.logging;
-    requires org.junit.jupiter.api;
-    requires org.junit.jupiter.engine;
-}

vertx/pom.xml

@@ -11,6 +11,19 @@
 
     <artifactId>gctoolkit-vertx</artifactId>
 
+    <build>
+        <plugins>
+            <plugin>
+               <artifactId>maven-surefire-plugin</artifactId>
+                <configuration>
+                    <argLine>
+                        --add-opens com.microsoft.gctoolkit.vertx/com.microsoft.gctoolkit.vertx.io=ALL-UNNAMED
+                    </argLine>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
+
     <dependencies>
         <dependency>
             <groupId>com.microsoft.gctoolkit</groupId>

vertx/src/main/java/module-info.java

@@ -6,18 +6,8 @@
  * @provides com.microsoft.gctoolkit.jvm.JavaVirtualMachine
  */
 module com.microsoft.gctoolkit.vertx {
-    exports com.microsoft.gctoolkit.vertx to
-            gctoolkit.vertx.test;
-
-    exports com.microsoft.gctoolkit.vertx.aggregator to
-            gctoolkit.vertx.test;
-
-    exports com.microsoft.gctoolkit.vertx.io to
-            gctoolkit.vertx.test;
-
     exports com.microsoft.gctoolkit.vertx.jvm to
-            com.microsoft.gctoolkit.api,
-            gctoolkit.vertx.test;
+            com.microsoft.gctoolkit.api;
 
     provides com.microsoft.gctoolkit.jvm.JavaVirtualMachine
             with com.microsoft.gctoolkit.vertx.jvm.DefaultJavaVirtualMachine;

vertx/src/test/java/com/microsoft/gctoolkit/vertx/io/GarbageCollectionEventSourceTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.vertx.test.io;
+package com.microsoft.gctoolkit.vertx.io;
 
 import com.microsoft.gctoolkit.event.GCCause;
 import com.microsoft.gctoolkit.event.GCEvent;

vertx/src/test/java/com/microsoft/gctoolkit/vertx/io/GarbageCollectionLogMetaDataTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.vertx.test.io;
+package com.microsoft.gctoolkit.vertx.io;
 
 import com.microsoft.gctoolkit.io.FileDataSourceMetaData;
 import org.junit.jupiter.api.Test;

vertx/src/test/java/com/microsoft/gctoolkit/vertx/io/StreamGarbageCollectionLogFileTest.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.vertx.test.io;
+package com.microsoft.gctoolkit.vertx.io;
 
 import com.microsoft.gctoolkit.io.GCLogFile;
 import com.microsoft.gctoolkit.io.RotatingGCLogFile;

vertx/src/test/java/com/microsoft/gctoolkit/vertx/io/TestLogFile.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
-package com.microsoft.gctoolkit.vertx.test.io;
+package com.microsoft.gctoolkit.vertx.io;
 
 import java.io.File;
 import java.util.Arrays;

vertx/src/test/java/module-info.java

@@ -1,12 +0,0 @@
-// Copyright (c) Microsoft Corporation.
-// Licensed under the MIT License.
-open module gctoolkit.vertx.test {
-    requires com.microsoft.gctoolkit.api;
-    requires com.microsoft.gctoolkit.parser;
-    requires com.microsoft.gctoolkit.vertx;
-    requires java.logging;
-    requires io.vertx.core;
-
-    requires org.junit.jupiter.engine;
-    requires org.junit.jupiter.api;
-}