2007-04-23 04:52:55 +04:00
|
|
|
#!/bin/sh
|
|
|
|
|
|
|
|
test_description='external diff interface test'
|
|
|
|
|
|
|
|
. ./test-lib.sh
|
|
|
|
|
|
|
|
test_expect_success setup '
|
|
|
|
|
|
|
|
test_tick &&
|
|
|
|
echo initial >file &&
|
|
|
|
git add file &&
|
|
|
|
git commit -m initial &&
|
|
|
|
|
|
|
|
test_tick &&
|
|
|
|
echo second >file &&
|
|
|
|
git add file &&
|
|
|
|
git commit -m second &&
|
|
|
|
|
|
|
|
test_tick &&
|
|
|
|
echo third >file
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'GIT_EXTERNAL_DIFF environment' '
|
|
|
|
|
|
|
|
GIT_EXTERNAL_DIFF=echo git diff | {
|
|
|
|
read path oldfile oldhex oldmode newfile newhex newmode &&
|
|
|
|
test "z$path" = zfile &&
|
|
|
|
test "z$oldmode" = z100644 &&
|
|
|
|
test "z$newhex" = "z$_z40" &&
|
|
|
|
test "z$newmode" = z100644 &&
|
|
|
|
oh=$(git rev-parse --verify HEAD:file) &&
|
|
|
|
test "z$oh" = "z$oldhex"
|
|
|
|
}
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'GIT_EXTERNAL_DIFF environment should apply only to diff' '
|
|
|
|
|
|
|
|
GIT_EXTERNAL_DIFF=echo git log -p -1 HEAD |
|
|
|
|
grep "^diff --git a/file b/file"
|
|
|
|
|
|
|
|
'
|
|
|
|
|
2008-11-26 20:58:41 +03:00
|
|
|
test_expect_success 'GIT_EXTERNAL_DIFF environment and --no-ext-diff' '
|
|
|
|
|
|
|
|
GIT_EXTERNAL_DIFF=echo git diff --no-ext-diff |
|
|
|
|
grep "^diff --git a/file b/file"
|
|
|
|
|
|
|
|
'
|
|
|
|
|
2012-07-18 09:08:59 +04:00
|
|
|
test_expect_success SYMLINKS 'typechange diff' '
|
|
|
|
rm -f file &&
|
|
|
|
ln -s elif file &&
|
|
|
|
GIT_EXTERNAL_DIFF=echo git diff | {
|
|
|
|
read path oldfile oldhex oldmode newfile newhex newmode &&
|
|
|
|
test "z$path" = zfile &&
|
|
|
|
test "z$oldmode" = z100644 &&
|
|
|
|
test "z$newhex" = "z$_z40" &&
|
|
|
|
test "z$newmode" = z120000 &&
|
|
|
|
oh=$(git rev-parse --verify HEAD:file) &&
|
|
|
|
test "z$oh" = "z$oldhex"
|
|
|
|
} &&
|
|
|
|
GIT_EXTERNAL_DIFF=echo git diff --no-ext-diff >actual &&
|
|
|
|
git diff >expect &&
|
|
|
|
test_cmp expect actual
|
|
|
|
'
|
|
|
|
|
diff: test precedence of external diff drivers
There are three ways to specify an external diff command:
GIT_EXTERNAL_DIFF in the environment, diff.external in the
config, or a "diff" gitattribute. The current order of
precedence is:
1. gitattribute
2. GIT_EXTERNAL_DIFF
3. diff.external
Usually our rule is that environment variables should take
precedence over on-disk config (i.e., option 2 should come
before option 1). However, this situation is trickier than
some, because option 1 is more specific to the individual
file than option 2 (which affects all files), so it might be
preferable. So the current behavior can be seen as
implementing "do the specific thing if we can, but fall back
to this general thing".
This is probably not what we would do if we were writing git
from scratch, but it has been this way for several years,
and is not worth changing. So let's at least document that
this is the way it's supposed to work with a test.
While we're there, let's also make sure that diff.external
(which was not previously tested at all) works by running it
through the same tests as GIT_EXTERNAL_DIFF.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-07-19 15:49:38 +04:00
|
|
|
test_expect_success 'diff.external' '
|
|
|
|
git reset --hard &&
|
|
|
|
echo third >file &&
|
|
|
|
test_config diff.external echo &&
|
|
|
|
git diff | {
|
|
|
|
read path oldfile oldhex oldmode newfile newhex newmode &&
|
|
|
|
test "z$path" = zfile &&
|
|
|
|
test "z$oldmode" = z100644 &&
|
|
|
|
test "z$newhex" = "z$_z40" &&
|
|
|
|
test "z$newmode" = z100644 &&
|
|
|
|
oh=$(git rev-parse --verify HEAD:file) &&
|
|
|
|
test "z$oh" = "z$oldhex"
|
|
|
|
}
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'diff.external should apply only to diff' '
|
|
|
|
test_config diff.external echo &&
|
|
|
|
git log -p -1 HEAD |
|
|
|
|
grep "^diff --git a/file b/file"
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'diff.external and --no-ext-diff' '
|
|
|
|
test_config diff.external echo &&
|
|
|
|
git diff --no-ext-diff |
|
|
|
|
grep "^diff --git a/file b/file"
|
|
|
|
'
|
|
|
|
|
2007-04-23 04:52:55 +04:00
|
|
|
test_expect_success 'diff attribute' '
|
2012-07-18 09:08:59 +04:00
|
|
|
git reset --hard &&
|
|
|
|
echo third >file &&
|
2007-04-23 04:52:55 +04:00
|
|
|
|
|
|
|
git config diff.parrot.command echo &&
|
|
|
|
|
|
|
|
echo >.gitattributes "file diff=parrot" &&
|
|
|
|
|
|
|
|
git diff | {
|
|
|
|
read path oldfile oldhex oldmode newfile newhex newmode &&
|
|
|
|
test "z$path" = zfile &&
|
|
|
|
test "z$oldmode" = z100644 &&
|
|
|
|
test "z$newhex" = "z$_z40" &&
|
|
|
|
test "z$newmode" = z100644 &&
|
|
|
|
oh=$(git rev-parse --verify HEAD:file) &&
|
|
|
|
test "z$oh" = "z$oldhex"
|
|
|
|
}
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'diff attribute should apply only to diff' '
|
|
|
|
|
|
|
|
git log -p -1 HEAD |
|
|
|
|
grep "^diff --git a/file b/file"
|
|
|
|
|
|
|
|
'
|
|
|
|
|
2008-11-26 20:58:41 +03:00
|
|
|
test_expect_success 'diff attribute and --no-ext-diff' '
|
|
|
|
|
|
|
|
git diff --no-ext-diff |
|
|
|
|
grep "^diff --git a/file b/file"
|
|
|
|
|
|
|
|
'
|
|
|
|
|
2007-04-23 04:52:55 +04:00
|
|
|
test_expect_success 'diff attribute' '
|
|
|
|
|
|
|
|
git config --unset diff.parrot.command &&
|
|
|
|
git config diff.color.command echo &&
|
|
|
|
|
|
|
|
echo >.gitattributes "file diff=color" &&
|
|
|
|
|
|
|
|
git diff | {
|
|
|
|
read path oldfile oldhex oldmode newfile newhex newmode &&
|
|
|
|
test "z$path" = zfile &&
|
|
|
|
test "z$oldmode" = z100644 &&
|
|
|
|
test "z$newhex" = "z$_z40" &&
|
|
|
|
test "z$newmode" = z100644 &&
|
|
|
|
oh=$(git rev-parse --verify HEAD:file) &&
|
|
|
|
test "z$oh" = "z$oldhex"
|
|
|
|
}
|
|
|
|
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'diff attribute should apply only to diff' '
|
|
|
|
|
|
|
|
git log -p -1 HEAD |
|
|
|
|
grep "^diff --git a/file b/file"
|
|
|
|
|
|
|
|
'
|
|
|
|
|
2008-11-26 20:58:41 +03:00
|
|
|
test_expect_success 'diff attribute and --no-ext-diff' '
|
|
|
|
|
|
|
|
git diff --no-ext-diff |
|
|
|
|
grep "^diff --git a/file b/file"
|
|
|
|
|
|
|
|
'
|
|
|
|
|
diff: test precedence of external diff drivers
There are three ways to specify an external diff command:
GIT_EXTERNAL_DIFF in the environment, diff.external in the
config, or a "diff" gitattribute. The current order of
precedence is:
1. gitattribute
2. GIT_EXTERNAL_DIFF
3. diff.external
Usually our rule is that environment variables should take
precedence over on-disk config (i.e., option 2 should come
before option 1). However, this situation is trickier than
some, because option 1 is more specific to the individual
file than option 2 (which affects all files), so it might be
preferable. So the current behavior can be seen as
implementing "do the specific thing if we can, but fall back
to this general thing".
This is probably not what we would do if we were writing git
from scratch, but it has been this way for several years,
and is not worth changing. So let's at least document that
this is the way it's supposed to work with a test.
While we're there, let's also make sure that diff.external
(which was not previously tested at all) works by running it
through the same tests as GIT_EXTERNAL_DIFF.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2012-07-19 15:49:38 +04:00
|
|
|
test_expect_success 'GIT_EXTERNAL_DIFF trumps diff.external' '
|
|
|
|
>.gitattributes &&
|
|
|
|
test_config diff.external "echo ext-global" &&
|
|
|
|
GIT_EXTERNAL_DIFF="echo ext-env" git diff | grep ext-env
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'attributes trump GIT_EXTERNAL_DIFF and diff.external' '
|
|
|
|
test_config diff.foo.command "echo ext-attribute" &&
|
|
|
|
test_config diff.external "echo ext-global" &&
|
|
|
|
echo "file diff=foo" >.gitattributes &&
|
|
|
|
GIT_EXTERNAL_DIFF="echo ext-env" git diff | grep ext-attribute
|
|
|
|
'
|
|
|
|
|
2007-07-07 23:25:11 +04:00
|
|
|
test_expect_success 'no diff with -diff' '
|
|
|
|
echo >.gitattributes "file -diff" &&
|
|
|
|
git diff | grep Binary
|
|
|
|
'
|
|
|
|
|
2013-10-29 05:23:03 +04:00
|
|
|
echo NULZbetweenZwords | perl -pe 'y/Z/\000/' > file
|
2007-07-07 23:25:11 +04:00
|
|
|
|
|
|
|
test_expect_success 'force diff with "diff"' '
|
|
|
|
echo >.gitattributes "file diff" &&
|
2008-03-13 00:37:37 +03:00
|
|
|
git diff >actual &&
|
2008-08-08 13:26:28 +04:00
|
|
|
test_cmp "$TEST_DIRECTORY"/t4020/diff.NUL actual
|
2007-07-07 23:25:11 +04:00
|
|
|
'
|
|
|
|
|
2009-02-12 16:36:14 +03:00
|
|
|
test_expect_success 'GIT_EXTERNAL_DIFF with more than one changed files' '
|
|
|
|
echo anotherfile > file2 &&
|
|
|
|
git add file2 &&
|
|
|
|
git commit -m "added 2nd file" &&
|
|
|
|
echo modified >file2 &&
|
|
|
|
GIT_EXTERNAL_DIFF=echo git diff
|
|
|
|
'
|
|
|
|
|
2013-12-06 03:38:46 +04:00
|
|
|
test_expect_success 'GIT_EXTERNAL_DIFF path counter/total' '
|
|
|
|
write_script external-diff.sh <<-\EOF &&
|
|
|
|
echo $GIT_DIFF_PATH_COUNTER of $GIT_DIFF_PATH_TOTAL >>counter.txt
|
|
|
|
EOF
|
|
|
|
>counter.txt &&
|
|
|
|
cat >expect <<-\EOF &&
|
|
|
|
1 of 2
|
|
|
|
2 of 2
|
|
|
|
EOF
|
|
|
|
GIT_EXTERNAL_DIFF=./external-diff.sh git diff &&
|
|
|
|
test_cmp expect counter.txt
|
|
|
|
'
|
|
|
|
|
2009-05-31 12:35:52 +04:00
|
|
|
test_expect_success 'GIT_EXTERNAL_DIFF generates pretty paths' '
|
|
|
|
touch file.ext &&
|
|
|
|
git add file.ext &&
|
|
|
|
echo with extension > file.ext &&
|
|
|
|
GIT_EXTERNAL_DIFF=echo git diff file.ext | grep ......_file\.ext &&
|
|
|
|
git update-index --force-remove file.ext &&
|
|
|
|
rm file.ext
|
|
|
|
'
|
|
|
|
|
2009-03-21 14:42:52 +03:00
|
|
|
echo "#!$SHELL_PATH" >fake-diff.sh
|
|
|
|
cat >> fake-diff.sh <<\EOF
|
|
|
|
cat $2 >> crlfed.txt
|
|
|
|
EOF
|
|
|
|
chmod a+x fake-diff.sh
|
|
|
|
|
|
|
|
keep_only_cr () {
|
|
|
|
tr -dc '\015'
|
|
|
|
}
|
|
|
|
|
|
|
|
test_expect_success 'external diff with autocrlf = true' '
|
2014-02-16 20:52:34 +04:00
|
|
|
test_config core.autocrlf true &&
|
2009-03-21 14:42:52 +03:00
|
|
|
GIT_EXTERNAL_DIFF=./fake-diff.sh git diff &&
|
|
|
|
test $(wc -l < crlfed.txt) = $(cat crlfed.txt | keep_only_cr | wc -c)
|
|
|
|
'
|
|
|
|
|
2009-03-23 01:26:07 +03:00
|
|
|
test_expect_success 'diff --cached' '
|
2014-02-16 20:52:34 +04:00
|
|
|
test_config core.autocrlf true &&
|
2009-03-23 01:26:07 +03:00
|
|
|
git add file &&
|
|
|
|
git update-index --assume-unchanged file &&
|
|
|
|
echo second >file &&
|
|
|
|
git diff --cached >actual &&
|
2009-08-09 12:37:52 +04:00
|
|
|
test_cmp "$TEST_DIRECTORY"/t4020/diff.NUL actual
|
2009-03-23 01:26:07 +03:00
|
|
|
'
|
|
|
|
|
2014-02-16 20:52:34 +04:00
|
|
|
test_expect_success 'clean up crlf leftovers' '
|
|
|
|
git update-index --no-assume-unchanged file &&
|
|
|
|
rm -f file* &&
|
|
|
|
git reset --hard
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'submodule diff' '
|
|
|
|
git init sub &&
|
|
|
|
( cd sub && test_commit sub1 ) &&
|
|
|
|
git add sub &&
|
|
|
|
test_tick &&
|
|
|
|
git commit -m "add submodule" &&
|
|
|
|
( cd sub && test_commit sub2 ) &&
|
|
|
|
write_script gather_pre_post.sh <<-\EOF &&
|
|
|
|
echo "$1 $4" # path, mode
|
|
|
|
cat "$2" # old file
|
|
|
|
cat "$5" # new file
|
|
|
|
EOF
|
|
|
|
GIT_EXTERNAL_DIFF=./gather_pre_post.sh git diff >actual &&
|
|
|
|
cat >expected <<-EOF &&
|
|
|
|
sub 160000
|
|
|
|
Subproject commit $(git rev-parse HEAD:sub)
|
|
|
|
Subproject commit $(cd sub && git rev-parse HEAD)
|
|
|
|
EOF
|
|
|
|
test_cmp expected actual
|
|
|
|
'
|
|
|
|
|
2007-04-23 04:52:55 +04:00
|
|
|
test_done
|