2010-02-19 10:18:58 +03:00
|
|
|
#!/bin/sh
|
|
|
|
|
|
|
|
test_description='Test automatic use of a pager.'
|
|
|
|
|
|
|
|
. ./test-lib.sh
|
2010-06-12 20:36:51 +04:00
|
|
|
. "$TEST_DIRECTORY"/lib-pager.sh
|
2010-02-19 10:18:58 +03:00
|
|
|
|
2010-04-15 04:38:07 +04:00
|
|
|
cleanup_fail() {
|
|
|
|
echo >&2 cleanup failed
|
|
|
|
(exit 1)
|
|
|
|
}
|
|
|
|
|
2010-02-20 11:50:25 +03:00
|
|
|
test_expect_success 'set up terminal for tests' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f stdout_is_tty ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
2010-02-19 10:18:58 +03:00
|
|
|
if test -t 1
|
|
|
|
then
|
2010-04-15 04:38:07 +04:00
|
|
|
>stdout_is_tty
|
2010-02-20 11:50:25 +03:00
|
|
|
elif
|
|
|
|
test_have_prereq PERL &&
|
|
|
|
"$PERL_PATH" "$TEST_DIRECTORY"/t7006/test-terminal.perl \
|
|
|
|
sh -c "test -t 1"
|
|
|
|
then
|
2010-04-15 04:38:07 +04:00
|
|
|
>test_terminal_works
|
2010-02-19 10:18:58 +03:00
|
|
|
fi
|
|
|
|
'
|
|
|
|
|
|
|
|
if test -e stdout_is_tty
|
|
|
|
then
|
2010-02-20 11:50:25 +03:00
|
|
|
test_terminal() { "$@"; }
|
|
|
|
test_set_prereq TTY
|
|
|
|
elif test -e test_terminal_works
|
|
|
|
then
|
|
|
|
test_terminal() {
|
|
|
|
"$PERL_PATH" "$TEST_DIRECTORY"/t7006/test-terminal.perl "$@"
|
|
|
|
}
|
2010-02-19 10:18:58 +03:00
|
|
|
test_set_prereq TTY
|
|
|
|
else
|
2010-06-24 21:44:48 +04:00
|
|
|
say "# no usable terminal, so skipping some tests"
|
2010-02-19 10:18:58 +03:00
|
|
|
fi
|
|
|
|
|
|
|
|
test_expect_success 'setup' '
|
2010-06-02 19:32:26 +04:00
|
|
|
unset GIT_PAGER GIT_PAGER_IN_USE;
|
2010-04-15 04:38:07 +04:00
|
|
|
test_might_fail git config --unset core.pager &&
|
|
|
|
|
|
|
|
PAGER="cat >paginated.out" &&
|
|
|
|
export PAGER &&
|
|
|
|
|
2010-02-19 10:18:58 +03:00
|
|
|
test_commit initial
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success TTY 'some commands use a pager' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f paginated.out ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
2010-02-20 11:50:25 +03:00
|
|
|
test_terminal git log &&
|
2010-02-19 10:18:58 +03:00
|
|
|
test -e paginated.out
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success TTY 'some commands do not use a pager' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f paginated.out ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
2010-02-20 11:50:25 +03:00
|
|
|
test_terminal git rev-list HEAD &&
|
2010-02-19 10:18:58 +03:00
|
|
|
! test -e paginated.out
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'no pager when stdout is a pipe' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f paginated.out ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
2010-02-19 10:18:58 +03:00
|
|
|
git log | cat &&
|
|
|
|
! test -e paginated.out
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'no pager when stdout is a regular file' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f paginated.out ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
|
|
|
git log >file &&
|
2010-02-19 10:18:58 +03:00
|
|
|
! test -e paginated.out
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success TTY 'git --paginate rev-list uses a pager' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f paginated.out ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
2010-02-20 11:50:25 +03:00
|
|
|
test_terminal git --paginate rev-list HEAD &&
|
2010-02-19 10:18:58 +03:00
|
|
|
test -e paginated.out
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'no pager even with --paginate when stdout is a pipe' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f file paginated.out ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
2010-02-19 10:18:58 +03:00
|
|
|
git --paginate log | cat &&
|
|
|
|
! test -e paginated.out
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success TTY 'no pager with --no-pager' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f paginated.out ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
2010-02-20 11:50:25 +03:00
|
|
|
test_terminal git --no-pager log &&
|
2010-02-19 10:18:58 +03:00
|
|
|
! test -e paginated.out
|
|
|
|
'
|
|
|
|
|
|
|
|
# A colored commit log will begin with an appropriate ANSI escape
|
|
|
|
# for the first color; the text "commit" comes later.
|
|
|
|
colorful() {
|
2010-04-15 04:38:07 +04:00
|
|
|
read firstline <$1
|
2010-06-21 22:18:54 +04:00
|
|
|
! expr "$firstline" : "[a-zA-Z]" >/dev/null
|
2010-02-19 10:18:58 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
test_expect_success 'tests can detect color' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f colorful.log colorless.log ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
|
|
|
git log --no-color >colorless.log &&
|
|
|
|
git log --color >colorful.log &&
|
2010-02-19 10:18:58 +03:00
|
|
|
! colorful colorless.log &&
|
|
|
|
colorful colorful.log
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'no color when stdout is a regular file' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f colorless.log &&
|
|
|
|
git config color.ui auto ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
|
|
|
git log >colorless.log &&
|
2010-02-19 10:18:58 +03:00
|
|
|
! colorful colorless.log
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success TTY 'color when writing to a pager' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f paginated.out &&
|
|
|
|
git config color.ui auto ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
|
|
|
(
|
|
|
|
TERM=vt100 &&
|
|
|
|
export TERM &&
|
|
|
|
test_terminal git log
|
|
|
|
) &&
|
2010-02-19 10:18:58 +03:00
|
|
|
colorful paginated.out
|
|
|
|
'
|
|
|
|
|
|
|
|
test_expect_success 'color when writing to a file intended for a pager' '
|
2010-04-15 04:38:07 +04:00
|
|
|
rm -f colorful.log &&
|
|
|
|
git config color.ui auto ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
|
|
|
(
|
|
|
|
TERM=vt100 &&
|
|
|
|
GIT_PAGER_IN_USE=true &&
|
|
|
|
export TERM GIT_PAGER_IN_USE &&
|
|
|
|
git log >colorful.log
|
|
|
|
) &&
|
2010-02-19 10:18:58 +03:00
|
|
|
colorful colorful.log
|
|
|
|
'
|
|
|
|
|
2010-06-12 20:36:51 +04:00
|
|
|
if test_have_prereq SIMPLEPAGER && test_have_prereq TTY
|
2010-02-19 10:18:58 +03:00
|
|
|
then
|
2010-06-12 20:36:51 +04:00
|
|
|
test_set_prereq SIMPLEPAGERTTY
|
2010-02-19 10:18:58 +03:00
|
|
|
fi
|
|
|
|
|
2010-06-26 23:23:02 +04:00
|
|
|
# Use this helper to make it easy for the caller of your
|
|
|
|
# terminal-using function to specify whether it should fail.
|
|
|
|
# If you write
|
|
|
|
#
|
|
|
|
# your_test() {
|
|
|
|
# parse_args "$@"
|
|
|
|
#
|
|
|
|
# $test_expectation "$cmd - behaves well" "
|
|
|
|
# ...
|
|
|
|
# $full_command &&
|
|
|
|
# ...
|
|
|
|
# "
|
|
|
|
# }
|
|
|
|
#
|
|
|
|
# then your test can be used like this:
|
|
|
|
#
|
|
|
|
# your_test expect_(success|failure) [test_must_fail] 'git foo'
|
|
|
|
#
|
|
|
|
parse_args() {
|
|
|
|
test_expectation="test_$1"
|
|
|
|
shift
|
|
|
|
if test "$1" = test_must_fail
|
|
|
|
then
|
|
|
|
full_command="test_must_fail test_terminal "
|
|
|
|
shift
|
|
|
|
else
|
|
|
|
full_command="test_terminal "
|
|
|
|
fi
|
|
|
|
cmd=$1
|
|
|
|
full_command="$full_command $1"
|
|
|
|
}
|
2010-04-15 04:38:07 +04:00
|
|
|
|
2010-06-26 23:24:50 +04:00
|
|
|
test_default_pager() {
|
|
|
|
parse_args "$@"
|
|
|
|
|
2010-07-15 23:09:14 +04:00
|
|
|
$test_expectation SIMPLEPAGERTTY "$cmd - default pager is used by default" "
|
2010-06-26 23:24:50 +04:00
|
|
|
unset PAGER GIT_PAGER;
|
|
|
|
test_might_fail git config --unset core.pager &&
|
|
|
|
rm -f default_pager_used ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
|
|
|
cat >\$less <<-\EOF &&
|
|
|
|
#!/bin/sh
|
|
|
|
wc >default_pager_used
|
|
|
|
EOF
|
|
|
|
chmod +x \$less &&
|
|
|
|
(
|
|
|
|
PATH=.:\$PATH &&
|
|
|
|
export PATH &&
|
|
|
|
$full_command
|
|
|
|
) &&
|
|
|
|
test -e default_pager_used
|
|
|
|
"
|
|
|
|
}
|
2010-02-19 10:18:58 +03:00
|
|
|
|
2010-06-26 23:24:50 +04:00
|
|
|
test_PAGER_overrides() {
|
|
|
|
parse_args "$@"
|
2010-04-15 04:38:07 +04:00
|
|
|
|
2010-06-26 23:24:50 +04:00
|
|
|
$test_expectation TTY "$cmd - PAGER overrides default pager" "
|
|
|
|
unset GIT_PAGER;
|
|
|
|
test_might_fail git config --unset core.pager &&
|
|
|
|
rm -f PAGER_used ||
|
|
|
|
cleanup_fail &&
|
2010-02-19 10:18:58 +03:00
|
|
|
|
2010-06-26 23:24:50 +04:00
|
|
|
PAGER='wc >PAGER_used' &&
|
|
|
|
export PAGER &&
|
|
|
|
$full_command &&
|
|
|
|
test -e PAGER_used
|
|
|
|
"
|
|
|
|
}
|
2010-04-15 04:38:07 +04:00
|
|
|
|
2010-06-26 23:24:50 +04:00
|
|
|
test_core_pager_overrides() {
|
git --paginate: do not commit pager choice too early
When git is passed the --paginate option, starting up a pager requires
deciding what pager to start, which requires access to the core.pager
configuration.
At the relevant moment, the repository has not been searched for yet.
Attempting to access the configuration at this point results in
git_dir being set to .git [*], which is almost certainly not what was
wanted. In particular, when run from a subdirectory of the toplevel,
git --paginate does not respect the core.pager setting from the
current repository.
[*] unless GIT_DIR or GIT_CONFIG is set
So delay the pager startup when possible:
1. run_argv() already commits pager choice inside run_builtin() if a
command is found. For commands that use RUN_SETUP, waiting until
then fixes the problem described above: once git knows where to
look, it happily respects the core.pager setting.
2. list_common_cmds_help() prints out 29 lines and exits. This can
benefit from pagination, so we need to commit the pager choice
before writing this output.
Luckily ‘git’ without subcommand has no other reason to access a
repository, so it would be intuitive to ignore repository-local
configuration in this case. Simpler for now to choose a pager
using the funny code that notices a repository that happens to be
at .git. That this accesses a repository when it is very
convenient to is a bug but not an important one.
3. help_unknown_cmd() prints out a few lines to stderr. It is not
important to paginate this, so don’t.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-06-26 23:26:37 +04:00
|
|
|
if_local_config=
|
|
|
|
used_if_wanted='overrides PAGER'
|
|
|
|
test_core_pager "$@"
|
|
|
|
}
|
2010-02-19 10:18:58 +03:00
|
|
|
|
git --paginate: do not commit pager choice too early
When git is passed the --paginate option, starting up a pager requires
deciding what pager to start, which requires access to the core.pager
configuration.
At the relevant moment, the repository has not been searched for yet.
Attempting to access the configuration at this point results in
git_dir being set to .git [*], which is almost certainly not what was
wanted. In particular, when run from a subdirectory of the toplevel,
git --paginate does not respect the core.pager setting from the
current repository.
[*] unless GIT_DIR or GIT_CONFIG is set
So delay the pager startup when possible:
1. run_argv() already commits pager choice inside run_builtin() if a
command is found. For commands that use RUN_SETUP, waiting until
then fixes the problem described above: once git knows where to
look, it happily respects the core.pager setting.
2. list_common_cmds_help() prints out 29 lines and exits. This can
benefit from pagination, so we need to commit the pager choice
before writing this output.
Luckily ‘git’ without subcommand has no other reason to access a
repository, so it would be intuitive to ignore repository-local
configuration in this case. Simpler for now to choose a pager
using the funny code that notices a repository that happens to be
at .git. That this accesses a repository when it is very
convenient to is a bug but not an important one.
3. help_unknown_cmd() prints out a few lines to stderr. It is not
important to paginate this, so don’t.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-06-26 23:26:37 +04:00
|
|
|
test_local_config_ignored() {
|
|
|
|
if_local_config='! '
|
|
|
|
used_if_wanted='is not used'
|
|
|
|
test_core_pager "$@"
|
|
|
|
}
|
2010-04-15 04:38:07 +04:00
|
|
|
|
git --paginate: do not commit pager choice too early
When git is passed the --paginate option, starting up a pager requires
deciding what pager to start, which requires access to the core.pager
configuration.
At the relevant moment, the repository has not been searched for yet.
Attempting to access the configuration at this point results in
git_dir being set to .git [*], which is almost certainly not what was
wanted. In particular, when run from a subdirectory of the toplevel,
git --paginate does not respect the core.pager setting from the
current repository.
[*] unless GIT_DIR or GIT_CONFIG is set
So delay the pager startup when possible:
1. run_argv() already commits pager choice inside run_builtin() if a
command is found. For commands that use RUN_SETUP, waiting until
then fixes the problem described above: once git knows where to
look, it happily respects the core.pager setting.
2. list_common_cmds_help() prints out 29 lines and exits. This can
benefit from pagination, so we need to commit the pager choice
before writing this output.
Luckily ‘git’ without subcommand has no other reason to access a
repository, so it would be intuitive to ignore repository-local
configuration in this case. Simpler for now to choose a pager
using the funny code that notices a repository that happens to be
at .git. That this accesses a repository when it is very
convenient to is a bug but not an important one.
3. help_unknown_cmd() prints out a few lines to stderr. It is not
important to paginate this, so don’t.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-06-26 23:26:37 +04:00
|
|
|
test_core_pager() {
|
2010-06-26 23:24:50 +04:00
|
|
|
parse_args "$@"
|
|
|
|
|
git --paginate: do not commit pager choice too early
When git is passed the --paginate option, starting up a pager requires
deciding what pager to start, which requires access to the core.pager
configuration.
At the relevant moment, the repository has not been searched for yet.
Attempting to access the configuration at this point results in
git_dir being set to .git [*], which is almost certainly not what was
wanted. In particular, when run from a subdirectory of the toplevel,
git --paginate does not respect the core.pager setting from the
current repository.
[*] unless GIT_DIR or GIT_CONFIG is set
So delay the pager startup when possible:
1. run_argv() already commits pager choice inside run_builtin() if a
command is found. For commands that use RUN_SETUP, waiting until
then fixes the problem described above: once git knows where to
look, it happily respects the core.pager setting.
2. list_common_cmds_help() prints out 29 lines and exits. This can
benefit from pagination, so we need to commit the pager choice
before writing this output.
Luckily ‘git’ without subcommand has no other reason to access a
repository, so it would be intuitive to ignore repository-local
configuration in this case. Simpler for now to choose a pager
using the funny code that notices a repository that happens to be
at .git. That this accesses a repository when it is very
convenient to is a bug but not an important one.
3. help_unknown_cmd() prints out a few lines to stderr. It is not
important to paginate this, so don’t.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-06-26 23:26:37 +04:00
|
|
|
$test_expectation TTY "$cmd - repository-local core.pager setting $used_if_wanted" "
|
2010-06-26 23:24:50 +04:00
|
|
|
unset GIT_PAGER;
|
|
|
|
rm -f core.pager_used ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
|
|
|
PAGER=wc &&
|
|
|
|
export PAGER &&
|
|
|
|
git config core.pager 'wc >core.pager_used' &&
|
|
|
|
$full_command &&
|
git --paginate: do not commit pager choice too early
When git is passed the --paginate option, starting up a pager requires
deciding what pager to start, which requires access to the core.pager
configuration.
At the relevant moment, the repository has not been searched for yet.
Attempting to access the configuration at this point results in
git_dir being set to .git [*], which is almost certainly not what was
wanted. In particular, when run from a subdirectory of the toplevel,
git --paginate does not respect the core.pager setting from the
current repository.
[*] unless GIT_DIR or GIT_CONFIG is set
So delay the pager startup when possible:
1. run_argv() already commits pager choice inside run_builtin() if a
command is found. For commands that use RUN_SETUP, waiting until
then fixes the problem described above: once git knows where to
look, it happily respects the core.pager setting.
2. list_common_cmds_help() prints out 29 lines and exits. This can
benefit from pagination, so we need to commit the pager choice
before writing this output.
Luckily ‘git’ without subcommand has no other reason to access a
repository, so it would be intuitive to ignore repository-local
configuration in this case. Simpler for now to choose a pager
using the funny code that notices a repository that happens to be
at .git. That this accesses a repository when it is very
convenient to is a bug but not an important one.
3. help_unknown_cmd() prints out a few lines to stderr. It is not
important to paginate this, so don’t.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-06-26 23:26:37 +04:00
|
|
|
${if_local_config}test -e core.pager_used
|
2010-06-26 23:24:50 +04:00
|
|
|
"
|
|
|
|
}
|
|
|
|
|
2010-06-26 23:25:37 +04:00
|
|
|
test_core_pager_subdir() {
|
git --paginate: do not commit pager choice too early
When git is passed the --paginate option, starting up a pager requires
deciding what pager to start, which requires access to the core.pager
configuration.
At the relevant moment, the repository has not been searched for yet.
Attempting to access the configuration at this point results in
git_dir being set to .git [*], which is almost certainly not what was
wanted. In particular, when run from a subdirectory of the toplevel,
git --paginate does not respect the core.pager setting from the
current repository.
[*] unless GIT_DIR or GIT_CONFIG is set
So delay the pager startup when possible:
1. run_argv() already commits pager choice inside run_builtin() if a
command is found. For commands that use RUN_SETUP, waiting until
then fixes the problem described above: once git knows where to
look, it happily respects the core.pager setting.
2. list_common_cmds_help() prints out 29 lines and exits. This can
benefit from pagination, so we need to commit the pager choice
before writing this output.
Luckily ‘git’ without subcommand has no other reason to access a
repository, so it would be intuitive to ignore repository-local
configuration in this case. Simpler for now to choose a pager
using the funny code that notices a repository that happens to be
at .git. That this accesses a repository when it is very
convenient to is a bug but not an important one.
3. help_unknown_cmd() prints out a few lines to stderr. It is not
important to paginate this, so don’t.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-06-26 23:26:37 +04:00
|
|
|
if_local_config=
|
|
|
|
used_if_wanted='overrides PAGER'
|
|
|
|
test_pager_subdir_helper "$@"
|
|
|
|
}
|
|
|
|
|
|
|
|
test_no_local_config_subdir() {
|
|
|
|
if_local_config='! '
|
|
|
|
used_if_wanted='is not used'
|
|
|
|
test_pager_subdir_helper "$@"
|
|
|
|
}
|
|
|
|
|
|
|
|
test_pager_subdir_helper() {
|
2010-06-26 23:25:37 +04:00
|
|
|
parse_args "$@"
|
|
|
|
|
git --paginate: do not commit pager choice too early
When git is passed the --paginate option, starting up a pager requires
deciding what pager to start, which requires access to the core.pager
configuration.
At the relevant moment, the repository has not been searched for yet.
Attempting to access the configuration at this point results in
git_dir being set to .git [*], which is almost certainly not what was
wanted. In particular, when run from a subdirectory of the toplevel,
git --paginate does not respect the core.pager setting from the
current repository.
[*] unless GIT_DIR or GIT_CONFIG is set
So delay the pager startup when possible:
1. run_argv() already commits pager choice inside run_builtin() if a
command is found. For commands that use RUN_SETUP, waiting until
then fixes the problem described above: once git knows where to
look, it happily respects the core.pager setting.
2. list_common_cmds_help() prints out 29 lines and exits. This can
benefit from pagination, so we need to commit the pager choice
before writing this output.
Luckily ‘git’ without subcommand has no other reason to access a
repository, so it would be intuitive to ignore repository-local
configuration in this case. Simpler for now to choose a pager
using the funny code that notices a repository that happens to be
at .git. That this accesses a repository when it is very
convenient to is a bug but not an important one.
3. help_unknown_cmd() prints out a few lines to stderr. It is not
important to paginate this, so don’t.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-06-26 23:26:37 +04:00
|
|
|
$test_expectation TTY "$cmd - core.pager $used_if_wanted from subdirectory" "
|
2010-06-26 23:25:37 +04:00
|
|
|
unset GIT_PAGER;
|
|
|
|
rm -f core.pager_used &&
|
|
|
|
rm -fr sub ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
|
|
|
PAGER=wc &&
|
|
|
|
stampname=\$(pwd)/core.pager_used &&
|
|
|
|
export PAGER stampname &&
|
|
|
|
git config core.pager 'wc >\"\$stampname\"' &&
|
|
|
|
mkdir sub &&
|
|
|
|
(
|
|
|
|
cd sub &&
|
|
|
|
$full_command
|
|
|
|
) &&
|
git --paginate: do not commit pager choice too early
When git is passed the --paginate option, starting up a pager requires
deciding what pager to start, which requires access to the core.pager
configuration.
At the relevant moment, the repository has not been searched for yet.
Attempting to access the configuration at this point results in
git_dir being set to .git [*], which is almost certainly not what was
wanted. In particular, when run from a subdirectory of the toplevel,
git --paginate does not respect the core.pager setting from the
current repository.
[*] unless GIT_DIR or GIT_CONFIG is set
So delay the pager startup when possible:
1. run_argv() already commits pager choice inside run_builtin() if a
command is found. For commands that use RUN_SETUP, waiting until
then fixes the problem described above: once git knows where to
look, it happily respects the core.pager setting.
2. list_common_cmds_help() prints out 29 lines and exits. This can
benefit from pagination, so we need to commit the pager choice
before writing this output.
Luckily ‘git’ without subcommand has no other reason to access a
repository, so it would be intuitive to ignore repository-local
configuration in this case. Simpler for now to choose a pager
using the funny code that notices a repository that happens to be
at .git. That this accesses a repository when it is very
convenient to is a bug but not an important one.
3. help_unknown_cmd() prints out a few lines to stderr. It is not
important to paginate this, so don’t.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-06-26 23:26:37 +04:00
|
|
|
${if_local_config}test -e core.pager_used
|
2010-06-26 23:25:37 +04:00
|
|
|
"
|
|
|
|
}
|
|
|
|
|
2010-06-26 23:24:50 +04:00
|
|
|
test_GIT_PAGER_overrides() {
|
|
|
|
parse_args "$@"
|
|
|
|
|
|
|
|
$test_expectation TTY "$cmd - GIT_PAGER overrides core.pager" "
|
|
|
|
rm -f GIT_PAGER_used ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
|
|
|
git config core.pager wc &&
|
|
|
|
GIT_PAGER='wc >GIT_PAGER_used' &&
|
|
|
|
export GIT_PAGER &&
|
|
|
|
$full_command &&
|
|
|
|
test -e GIT_PAGER_used
|
|
|
|
"
|
|
|
|
}
|
2010-04-15 04:38:07 +04:00
|
|
|
|
git --paginate: do not commit pager choice too early
When git is passed the --paginate option, starting up a pager requires
deciding what pager to start, which requires access to the core.pager
configuration.
At the relevant moment, the repository has not been searched for yet.
Attempting to access the configuration at this point results in
git_dir being set to .git [*], which is almost certainly not what was
wanted. In particular, when run from a subdirectory of the toplevel,
git --paginate does not respect the core.pager setting from the
current repository.
[*] unless GIT_DIR or GIT_CONFIG is set
So delay the pager startup when possible:
1. run_argv() already commits pager choice inside run_builtin() if a
command is found. For commands that use RUN_SETUP, waiting until
then fixes the problem described above: once git knows where to
look, it happily respects the core.pager setting.
2. list_common_cmds_help() prints out 29 lines and exits. This can
benefit from pagination, so we need to commit the pager choice
before writing this output.
Luckily ‘git’ without subcommand has no other reason to access a
repository, so it would be intuitive to ignore repository-local
configuration in this case. Simpler for now to choose a pager
using the funny code that notices a repository that happens to be
at .git. That this accesses a repository when it is very
convenient to is a bug but not an important one.
3. help_unknown_cmd() prints out a few lines to stderr. It is not
important to paginate this, so don’t.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-06-26 23:26:37 +04:00
|
|
|
test_doesnt_paginate() {
|
|
|
|
parse_args "$@"
|
|
|
|
|
|
|
|
$test_expectation TTY "no pager for '$cmd'" "
|
|
|
|
rm -f GIT_PAGER_used ||
|
|
|
|
cleanup_fail &&
|
|
|
|
|
|
|
|
GIT_PAGER='wc >GIT_PAGER_used' &&
|
|
|
|
export GIT_PAGER &&
|
|
|
|
$full_command &&
|
|
|
|
! test -e GIT_PAGER_used
|
|
|
|
"
|
|
|
|
}
|
|
|
|
|
2010-07-15 02:55:12 +04:00
|
|
|
test_pager_choices() {
|
|
|
|
test_default_pager expect_success "$@"
|
|
|
|
test_PAGER_overrides expect_success "$@"
|
|
|
|
test_core_pager_overrides expect_success "$@"
|
|
|
|
test_core_pager_subdir expect_success "$@"
|
|
|
|
test_GIT_PAGER_overrides expect_success "$@"
|
|
|
|
}
|
|
|
|
|
|
|
|
test_expect_success 'setup: some aliases' '
|
|
|
|
git config alias.aliasedlog log &&
|
|
|
|
git config alias.true "!true"
|
2010-02-19 10:18:58 +03:00
|
|
|
'
|
|
|
|
|
2010-07-15 02:55:12 +04:00
|
|
|
test_pager_choices 'git log'
|
|
|
|
test_pager_choices 'git -p log'
|
|
|
|
test_pager_choices 'git aliasedlog'
|
|
|
|
|
|
|
|
test_default_pager expect_success 'git -p aliasedlog'
|
|
|
|
test_PAGER_overrides expect_success 'git -p aliasedlog'
|
|
|
|
test_core_pager_overrides expect_success 'git -p aliasedlog'
|
|
|
|
test_core_pager_subdir expect_failure 'git -p aliasedlog'
|
|
|
|
test_GIT_PAGER_overrides expect_success 'git -p aliasedlog'
|
|
|
|
|
|
|
|
test_default_pager expect_success 'git -p true'
|
|
|
|
test_PAGER_overrides expect_success 'git -p true'
|
|
|
|
test_core_pager_overrides expect_success 'git -p true'
|
|
|
|
test_core_pager_subdir expect_failure 'git -p true'
|
|
|
|
test_GIT_PAGER_overrides expect_success 'git -p true'
|
|
|
|
|
|
|
|
test_default_pager expect_success test_must_fail 'git -p request-pull'
|
|
|
|
test_PAGER_overrides expect_success test_must_fail 'git -p request-pull'
|
|
|
|
test_core_pager_overrides expect_success test_must_fail 'git -p request-pull'
|
|
|
|
test_core_pager_subdir expect_failure test_must_fail 'git -p request-pull'
|
|
|
|
test_GIT_PAGER_overrides expect_success test_must_fail 'git -p request-pull'
|
2010-06-26 23:24:50 +04:00
|
|
|
|
|
|
|
test_default_pager expect_success test_must_fail 'git -p'
|
|
|
|
test_PAGER_overrides expect_success test_must_fail 'git -p'
|
git --paginate: do not commit pager choice too early
When git is passed the --paginate option, starting up a pager requires
deciding what pager to start, which requires access to the core.pager
configuration.
At the relevant moment, the repository has not been searched for yet.
Attempting to access the configuration at this point results in
git_dir being set to .git [*], which is almost certainly not what was
wanted. In particular, when run from a subdirectory of the toplevel,
git --paginate does not respect the core.pager setting from the
current repository.
[*] unless GIT_DIR or GIT_CONFIG is set
So delay the pager startup when possible:
1. run_argv() already commits pager choice inside run_builtin() if a
command is found. For commands that use RUN_SETUP, waiting until
then fixes the problem described above: once git knows where to
look, it happily respects the core.pager setting.
2. list_common_cmds_help() prints out 29 lines and exits. This can
benefit from pagination, so we need to commit the pager choice
before writing this output.
Luckily ‘git’ without subcommand has no other reason to access a
repository, so it would be intuitive to ignore repository-local
configuration in this case. Simpler for now to choose a pager
using the funny code that notices a repository that happens to be
at .git. That this accesses a repository when it is very
convenient to is a bug but not an important one.
3. help_unknown_cmd() prints out a few lines to stderr. It is not
important to paginate this, so don’t.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2010-06-26 23:26:37 +04:00
|
|
|
test_local_config_ignored expect_failure test_must_fail 'git -p'
|
|
|
|
test_no_local_config_subdir expect_success test_must_fail 'git -p'
|
2010-06-26 23:24:50 +04:00
|
|
|
test_GIT_PAGER_overrides expect_success test_must_fail 'git -p'
|
|
|
|
|
2010-07-15 02:55:12 +04:00
|
|
|
test_doesnt_paginate expect_failure test_must_fail 'git -p nonsense'
|
2010-02-19 10:18:58 +03:00
|
|
|
|
|
|
|
test_done
|