2009-10-19 16:38:32 +04:00
|
|
|
#include "cache.h"
|
|
|
|
#include "submodule.h"
|
|
|
|
#include "dir.h"
|
|
|
|
#include "diff.h"
|
|
|
|
#include "commit.h"
|
|
|
|
#include "revision.h"
|
2010-01-16 20:42:24 +03:00
|
|
|
#include "run-command.h"
|
2010-03-05 00:20:33 +03:00
|
|
|
#include "diffcore.h"
|
2010-07-07 17:39:13 +04:00
|
|
|
#include "refs.h"
|
2010-08-06 02:39:25 +04:00
|
|
|
#include "string-list.h"
|
2011-09-12 23:56:52 +04:00
|
|
|
#include "sha1-array.h"
|
2011-09-14 01:57:57 +04:00
|
|
|
#include "argv-array.h"
|
2010-08-06 02:39:25 +04:00
|
|
|
|
Fix sparse warnings
Fix warnings from 'make check'.
- These files don't include 'builtin.h' causing sparse to complain that
cmd_* isn't declared:
builtin/clone.c:364, builtin/fetch-pack.c:797,
builtin/fmt-merge-msg.c:34, builtin/hash-object.c:78,
builtin/merge-index.c:69, builtin/merge-recursive.c:22
builtin/merge-tree.c:341, builtin/mktag.c:156, builtin/notes.c:426
builtin/notes.c:822, builtin/pack-redundant.c:596,
builtin/pack-refs.c:10, builtin/patch-id.c:60, builtin/patch-id.c:149,
builtin/remote.c:1512, builtin/remote-ext.c:240,
builtin/remote-fd.c:53, builtin/reset.c:236, builtin/send-pack.c:384,
builtin/unpack-file.c:25, builtin/var.c:75
- These files have symbols which should be marked static since they're
only file scope:
submodule.c:12, diff.c:631, replace_object.c:92, submodule.c:13,
submodule.c:14, trace.c:78, transport.c:195, transport-helper.c:79,
unpack-trees.c:19, url.c:3, url.c:18, url.c:104, url.c:117, url.c:123,
url.c:129, url.c:136, thread-utils.c:21, thread-utils.c:48
- These files redeclare symbols to be different types:
builtin/index-pack.c:210, parse-options.c:564, parse-options.c:571,
usage.c:49, usage.c:58, usage.c:63, usage.c:72
- These files use a literal integer 0 when they really should use a NULL
pointer:
daemon.c:663, fast-import.c:2942, imap-send.c:1072, notes-merge.c:362
While we're in the area, clean up some unused #includes in builtin files
(mostly exec_cmd.h).
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2011-03-22 10:51:05 +03:00
|
|
|
static struct string_list config_name_for_path;
|
|
|
|
static struct string_list config_fetch_recurse_submodules_for_name;
|
|
|
|
static struct string_list config_ignore_for_name;
|
2011-03-07 01:10:46 +03:00
|
|
|
static int config_fetch_recurse_submodules = RECURSE_SUBMODULES_ON_DEMAND;
|
2011-04-05 02:02:01 +04:00
|
|
|
static struct string_list changed_submodule_paths;
|
2011-09-12 23:56:52 +04:00
|
|
|
static int initialized_fetch_ref_tips;
|
|
|
|
static struct sha1_array ref_tips_before_fetch;
|
|
|
|
static struct sha1_array ref_tips_after_fetch;
|
|
|
|
|
2011-05-14 20:26:58 +04:00
|
|
|
/*
|
|
|
|
* The following flag is set if the .gitmodules file is unmerged. We then
|
|
|
|
* disable recursion for all submodules where .git/config doesn't have a
|
|
|
|
* matching config entry because we can't guess what might be configured in
|
|
|
|
* .gitmodules unless the user resolves the conflict. When a command line
|
|
|
|
* option is given (which always overrides configuration) this flag will be
|
|
|
|
* ignored.
|
|
|
|
*/
|
|
|
|
static int gitmodules_is_unmerged;
|
2009-10-19 16:38:32 +04:00
|
|
|
|
2010-01-12 09:31:58 +03:00
|
|
|
static int add_submodule_odb(const char *path)
|
2009-10-19 16:38:32 +04:00
|
|
|
{
|
|
|
|
struct strbuf objects_directory = STRBUF_INIT;
|
|
|
|
struct alternate_object_database *alt_odb;
|
2010-01-31 19:43:49 +03:00
|
|
|
int ret = 0;
|
2010-04-10 21:01:12 +04:00
|
|
|
const char *git_dir;
|
2009-10-19 16:38:32 +04:00
|
|
|
|
2010-04-10 21:01:12 +04:00
|
|
|
strbuf_addf(&objects_directory, "%s/.git", path);
|
2011-08-23 01:04:56 +04:00
|
|
|
git_dir = read_gitfile(objects_directory.buf);
|
2010-04-10 21:01:12 +04:00
|
|
|
if (git_dir) {
|
|
|
|
strbuf_reset(&objects_directory);
|
|
|
|
strbuf_addstr(&objects_directory, git_dir);
|
|
|
|
}
|
|
|
|
strbuf_addstr(&objects_directory, "/objects/");
|
2010-01-31 19:43:49 +03:00
|
|
|
if (!is_directory(objects_directory.buf)) {
|
|
|
|
ret = -1;
|
|
|
|
goto done;
|
|
|
|
}
|
2009-10-19 16:38:32 +04:00
|
|
|
/* avoid adding it twice */
|
|
|
|
for (alt_odb = alt_odb_list; alt_odb; alt_odb = alt_odb->next)
|
|
|
|
if (alt_odb->name - alt_odb->base == objects_directory.len &&
|
|
|
|
!strncmp(alt_odb->base, objects_directory.buf,
|
|
|
|
objects_directory.len))
|
2010-01-31 19:43:49 +03:00
|
|
|
goto done;
|
2009-10-19 16:38:32 +04:00
|
|
|
|
|
|
|
alt_odb = xmalloc(objects_directory.len + 42 + sizeof(*alt_odb));
|
|
|
|
alt_odb->next = alt_odb_list;
|
|
|
|
strcpy(alt_odb->base, objects_directory.buf);
|
|
|
|
alt_odb->name = alt_odb->base + objects_directory.len;
|
|
|
|
alt_odb->name[2] = '/';
|
|
|
|
alt_odb->name[40] = '\0';
|
|
|
|
alt_odb->name[41] = '\0';
|
|
|
|
alt_odb_list = alt_odb;
|
2012-05-14 20:24:45 +04:00
|
|
|
|
|
|
|
/* add possible alternates from the submodule */
|
|
|
|
read_info_alternates(objects_directory.buf, 0);
|
2009-10-19 16:38:32 +04:00
|
|
|
prepare_alt_odb();
|
2010-01-31 19:43:49 +03:00
|
|
|
done:
|
|
|
|
strbuf_release(&objects_directory);
|
|
|
|
return ret;
|
2009-10-19 16:38:32 +04:00
|
|
|
}
|
|
|
|
|
2010-08-06 02:39:25 +04:00
|
|
|
void set_diffopt_flags_from_submodule_config(struct diff_options *diffopt,
|
|
|
|
const char *path)
|
|
|
|
{
|
|
|
|
struct string_list_item *path_option, *ignore_option;
|
|
|
|
path_option = unsorted_string_list_lookup(&config_name_for_path, path);
|
|
|
|
if (path_option) {
|
|
|
|
ignore_option = unsorted_string_list_lookup(&config_ignore_for_name, path_option->util);
|
|
|
|
if (ignore_option)
|
|
|
|
handle_ignore_submodules_arg(diffopt, ignore_option->util);
|
2011-05-14 20:26:58 +04:00
|
|
|
else if (gitmodules_is_unmerged)
|
|
|
|
DIFF_OPT_SET(diffopt, IGNORE_SUBMODULES);
|
2010-08-06 02:39:25 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-11-12 15:54:52 +03:00
|
|
|
int submodule_config(const char *var, const char *value, void *cb)
|
2010-08-06 02:40:48 +04:00
|
|
|
{
|
|
|
|
if (!prefixcmp(var, "submodule."))
|
|
|
|
return parse_submodule_config_option(var, value);
|
2010-11-11 02:55:02 +03:00
|
|
|
else if (!strcmp(var, "fetch.recursesubmodules")) {
|
2011-03-07 01:11:48 +03:00
|
|
|
config_fetch_recurse_submodules = parse_fetch_recurse_submodules_arg(var, value);
|
2010-11-11 02:55:02 +03:00
|
|
|
return 0;
|
|
|
|
}
|
2010-08-06 02:40:48 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
void gitmodules_config(void)
|
|
|
|
{
|
|
|
|
const char *work_tree = get_git_work_tree();
|
|
|
|
if (work_tree) {
|
|
|
|
struct strbuf gitmodules_path = STRBUF_INIT;
|
2011-05-14 20:26:58 +04:00
|
|
|
int pos;
|
2010-08-06 02:40:48 +04:00
|
|
|
strbuf_addstr(&gitmodules_path, work_tree);
|
|
|
|
strbuf_addstr(&gitmodules_path, "/.gitmodules");
|
2011-05-14 20:26:58 +04:00
|
|
|
if (read_cache() < 0)
|
|
|
|
die("index file corrupt");
|
|
|
|
pos = cache_name_pos(".gitmodules", 11);
|
|
|
|
if (pos < 0) { /* .gitmodules not found or isn't merged */
|
|
|
|
pos = -1 - pos;
|
|
|
|
if (active_nr > pos) { /* there is a .gitmodules */
|
|
|
|
const struct cache_entry *ce = active_cache[pos];
|
|
|
|
if (ce_namelen(ce) == 11 &&
|
|
|
|
!memcmp(ce->name, ".gitmodules", 11))
|
|
|
|
gitmodules_is_unmerged = 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!gitmodules_is_unmerged)
|
|
|
|
git_config_from_file(submodule_config, gitmodules_path.buf, NULL);
|
2010-08-06 02:40:48 +04:00
|
|
|
strbuf_release(&gitmodules_path);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-08-06 02:39:25 +04:00
|
|
|
int parse_submodule_config_option(const char *var, const char *value)
|
|
|
|
{
|
|
|
|
struct string_list_item *config;
|
2013-01-23 10:25:22 +04:00
|
|
|
const char *name, *key;
|
|
|
|
int namelen;
|
2010-08-06 02:39:25 +04:00
|
|
|
|
2013-01-23 10:25:22 +04:00
|
|
|
if (parse_config_key(var, "submodule", &name, &namelen, &key) < 0 || !name)
|
|
|
|
return 0;
|
2010-08-06 02:39:25 +04:00
|
|
|
|
2013-01-23 10:25:22 +04:00
|
|
|
if (!strcmp(key, "path")) {
|
2010-08-06 02:39:25 +04:00
|
|
|
config = unsorted_string_list_lookup(&config_name_for_path, value);
|
|
|
|
if (config)
|
|
|
|
free(config->util);
|
|
|
|
else
|
|
|
|
config = string_list_append(&config_name_for_path, xstrdup(value));
|
2013-01-23 10:26:42 +04:00
|
|
|
config->util = xmemdupz(name, namelen);
|
2013-01-23 10:25:22 +04:00
|
|
|
} else if (!strcmp(key, "fetchrecursesubmodules")) {
|
2013-01-23 10:26:42 +04:00
|
|
|
char *name_cstr = xmemdupz(name, namelen);
|
|
|
|
config = unsorted_string_list_lookup(&config_fetch_recurse_submodules_for_name, name_cstr);
|
2010-11-11 02:55:41 +03:00
|
|
|
if (!config)
|
2013-01-23 10:26:42 +04:00
|
|
|
config = string_list_append(&config_fetch_recurse_submodules_for_name, name_cstr);
|
|
|
|
else
|
|
|
|
free(name_cstr);
|
2011-03-07 01:12:19 +03:00
|
|
|
config->util = (void *)(intptr_t)parse_fetch_recurse_submodules_arg(var, value);
|
2013-01-23 10:25:22 +04:00
|
|
|
} else if (!strcmp(key, "ignore")) {
|
2013-01-23 10:26:42 +04:00
|
|
|
char *name_cstr;
|
|
|
|
|
2010-08-06 02:39:25 +04:00
|
|
|
if (strcmp(value, "untracked") && strcmp(value, "dirty") &&
|
|
|
|
strcmp(value, "all") && strcmp(value, "none")) {
|
|
|
|
warning("Invalid parameter \"%s\" for config option \"submodule.%s.ignore\"", value, var);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-01-23 10:26:42 +04:00
|
|
|
name_cstr = xmemdupz(name, namelen);
|
|
|
|
config = unsorted_string_list_lookup(&config_ignore_for_name, name_cstr);
|
|
|
|
if (config) {
|
2010-08-06 02:39:25 +04:00
|
|
|
free(config->util);
|
2013-01-23 10:26:42 +04:00
|
|
|
free(name_cstr);
|
|
|
|
} else
|
|
|
|
config = string_list_append(&config_ignore_for_name, name_cstr);
|
2010-08-06 02:39:25 +04:00
|
|
|
config->util = xstrdup(value);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-06-25 18:56:47 +04:00
|
|
|
void handle_ignore_submodules_arg(struct diff_options *diffopt,
|
|
|
|
const char *arg)
|
|
|
|
{
|
2010-08-05 12:49:55 +04:00
|
|
|
DIFF_OPT_CLR(diffopt, IGNORE_SUBMODULES);
|
|
|
|
DIFF_OPT_CLR(diffopt, IGNORE_UNTRACKED_IN_SUBMODULES);
|
|
|
|
DIFF_OPT_CLR(diffopt, IGNORE_DIRTY_SUBMODULES);
|
|
|
|
|
2010-06-25 18:56:47 +04:00
|
|
|
if (!strcmp(arg, "all"))
|
|
|
|
DIFF_OPT_SET(diffopt, IGNORE_SUBMODULES);
|
|
|
|
else if (!strcmp(arg, "untracked"))
|
|
|
|
DIFF_OPT_SET(diffopt, IGNORE_UNTRACKED_IN_SUBMODULES);
|
|
|
|
else if (!strcmp(arg, "dirty"))
|
|
|
|
DIFF_OPT_SET(diffopt, IGNORE_DIRTY_SUBMODULES);
|
2010-08-06 02:39:25 +04:00
|
|
|
else if (strcmp(arg, "none"))
|
2010-06-25 18:56:47 +04:00
|
|
|
die("bad --ignore-submodules argument: %s", arg);
|
|
|
|
}
|
|
|
|
|
2011-03-16 10:14:11 +03:00
|
|
|
static int prepare_submodule_summary(struct rev_info *rev, const char *path,
|
|
|
|
struct commit *left, struct commit *right,
|
|
|
|
int *fast_forward, int *fast_backward)
|
|
|
|
{
|
|
|
|
struct commit_list *merge_bases, *list;
|
|
|
|
|
|
|
|
init_revisions(rev, NULL);
|
|
|
|
setup_revisions(0, NULL, rev, NULL);
|
|
|
|
rev->left_right = 1;
|
|
|
|
rev->first_parent_only = 1;
|
|
|
|
left->object.flags |= SYMMETRIC_LEFT;
|
|
|
|
add_pending_object(rev, &left->object, path);
|
|
|
|
add_pending_object(rev, &right->object, path);
|
|
|
|
merge_bases = get_merge_bases(left, right, 1);
|
|
|
|
if (merge_bases) {
|
|
|
|
if (merge_bases->item == left)
|
|
|
|
*fast_forward = 1;
|
|
|
|
else if (merge_bases->item == right)
|
|
|
|
*fast_backward = 1;
|
|
|
|
}
|
|
|
|
for (list = merge_bases; list; list = list->next) {
|
|
|
|
list->item->object.flags |= UNINTERESTING;
|
|
|
|
add_pending_object(rev, &list->item->object,
|
|
|
|
sha1_to_hex(list->item->object.sha1));
|
|
|
|
}
|
|
|
|
return prepare_revision_walk(rev);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void print_submodule_summary(struct rev_info *rev, FILE *f,
|
|
|
|
const char *del, const char *add, const char *reset)
|
|
|
|
{
|
|
|
|
static const char format[] = " %m %s";
|
|
|
|
struct strbuf sb = STRBUF_INIT;
|
|
|
|
struct commit *commit;
|
|
|
|
|
|
|
|
while ((commit = get_revision(rev))) {
|
|
|
|
struct pretty_print_context ctx = {0};
|
|
|
|
ctx.date_mode = rev->date_mode;
|
|
|
|
strbuf_setlen(&sb, 0);
|
|
|
|
if (commit->object.flags & SYMMETRIC_LEFT) {
|
|
|
|
if (del)
|
|
|
|
strbuf_addstr(&sb, del);
|
|
|
|
}
|
|
|
|
else if (add)
|
|
|
|
strbuf_addstr(&sb, add);
|
|
|
|
format_commit_message(commit, format, &sb, &ctx);
|
|
|
|
if (reset)
|
|
|
|
strbuf_addstr(&sb, reset);
|
|
|
|
strbuf_addch(&sb, '\n');
|
|
|
|
fprintf(f, "%s", sb.buf);
|
|
|
|
}
|
|
|
|
strbuf_release(&sb);
|
|
|
|
}
|
|
|
|
|
2011-03-07 01:10:46 +03:00
|
|
|
int parse_fetch_recurse_submodules_arg(const char *opt, const char *arg)
|
|
|
|
{
|
|
|
|
switch (git_config_maybe_bool(opt, arg)) {
|
|
|
|
case 1:
|
|
|
|
return RECURSE_SUBMODULES_ON;
|
|
|
|
case 0:
|
|
|
|
return RECURSE_SUBMODULES_OFF;
|
|
|
|
default:
|
|
|
|
if (!strcmp(arg, "on-demand"))
|
|
|
|
return RECURSE_SUBMODULES_ON_DEMAND;
|
|
|
|
die("bad %s argument: %s", opt, arg);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-10-19 16:38:32 +04:00
|
|
|
void show_submodule_summary(FILE *f, const char *path,
|
|
|
|
unsigned char one[20], unsigned char two[20],
|
2012-11-13 19:42:47 +04:00
|
|
|
unsigned dirty_submodule, const char *meta,
|
2009-10-19 16:38:32 +04:00
|
|
|
const char *del, const char *add, const char *reset)
|
|
|
|
{
|
|
|
|
struct rev_info rev;
|
submodule: clarify logic in show_submodule_summary
There are two uses of the "left" and "right" commit variables that
make it hard to be sure what values they have (both for the reader,
and for gcc, which wrongly complains that they might be used
uninitialized).
The function starts with a cascading if statement, checking that the
input sha1s exist, and finally working up to preparing a revision
walk. We only prepare the walk if the cascading conditional did not
find any problems, which we check by seeing whether it set the
"message" variable or not. It's simpler and more obvious to just add
a condition to the end of the cascade.
Later, we check the same "message" variable when deciding whether to
clear commit marks on the left/right commits; if it is set, we
presumably never started the walk. This is wrong, though; we might
have started the walk and munged commit flags, only to encounter an
error afterwards. We should always clear the flags on left/right if
they exist, whether the walk was successful or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-03-22 20:19:56 +04:00
|
|
|
struct commit *left = NULL, *right = NULL;
|
2009-10-19 16:38:32 +04:00
|
|
|
const char *message = NULL;
|
|
|
|
struct strbuf sb = STRBUF_INIT;
|
|
|
|
int fast_forward = 0, fast_backward = 0;
|
|
|
|
|
|
|
|
if (is_null_sha1(two))
|
|
|
|
message = "(submodule deleted)";
|
|
|
|
else if (add_submodule_odb(path))
|
|
|
|
message = "(not checked out)";
|
|
|
|
else if (is_null_sha1(one))
|
|
|
|
message = "(new submodule)";
|
|
|
|
else if (!(left = lookup_commit_reference(one)) ||
|
|
|
|
!(right = lookup_commit_reference(two)))
|
|
|
|
message = "(commits not present)";
|
submodule: clarify logic in show_submodule_summary
There are two uses of the "left" and "right" commit variables that
make it hard to be sure what values they have (both for the reader,
and for gcc, which wrongly complains that they might be used
uninitialized).
The function starts with a cascading if statement, checking that the
input sha1s exist, and finally working up to preparing a revision
walk. We only prepare the walk if the cascading conditional did not
find any problems, which we check by seeing whether it set the
"message" variable or not. It's simpler and more obvious to just add
a condition to the end of the cascade.
Later, we check the same "message" variable when deciding whether to
clear commit marks on the left/right commits; if it is set, we
presumably never started the walk. This is wrong, though; we might
have started the walk and munged commit flags, only to encounter an
error afterwards. We should always clear the flags on left/right if
they exist, whether the walk was successful or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-03-22 20:19:56 +04:00
|
|
|
else if (prepare_submodule_summary(&rev, path, left, right,
|
|
|
|
&fast_forward, &fast_backward))
|
2011-03-16 10:14:11 +03:00
|
|
|
message = "(revision walker failed)";
|
2009-10-19 16:38:32 +04:00
|
|
|
|
2010-03-05 00:20:33 +03:00
|
|
|
if (dirty_submodule & DIRTY_SUBMODULE_UNTRACKED)
|
|
|
|
fprintf(f, "Submodule %s contains untracked content\n", path);
|
|
|
|
if (dirty_submodule & DIRTY_SUBMODULE_MODIFIED)
|
|
|
|
fprintf(f, "Submodule %s contains modified content\n", path);
|
|
|
|
|
|
|
|
if (!hashcmp(one, two)) {
|
|
|
|
strbuf_release(&sb);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-11-13 19:42:47 +04:00
|
|
|
strbuf_addf(&sb, "%sSubmodule %s %s..", meta, path,
|
2009-10-19 16:38:32 +04:00
|
|
|
find_unique_abbrev(one, DEFAULT_ABBREV));
|
|
|
|
if (!fast_backward && !fast_forward)
|
|
|
|
strbuf_addch(&sb, '.');
|
|
|
|
strbuf_addf(&sb, "%s", find_unique_abbrev(two, DEFAULT_ABBREV));
|
|
|
|
if (message)
|
2012-11-13 19:42:47 +04:00
|
|
|
strbuf_addf(&sb, " %s%s\n", message, reset);
|
2009-10-19 16:38:32 +04:00
|
|
|
else
|
2012-11-13 19:42:47 +04:00
|
|
|
strbuf_addf(&sb, "%s:%s\n", fast_backward ? " (rewind)" : "", reset);
|
2009-10-19 16:38:32 +04:00
|
|
|
fwrite(sb.buf, sb.len, 1, f);
|
|
|
|
|
submodule: clarify logic in show_submodule_summary
There are two uses of the "left" and "right" commit variables that
make it hard to be sure what values they have (both for the reader,
and for gcc, which wrongly complains that they might be used
uninitialized).
The function starts with a cascading if statement, checking that the
input sha1s exist, and finally working up to preparing a revision
walk. We only prepare the walk if the cascading conditional did not
find any problems, which we check by seeing whether it set the
"message" variable or not. It's simpler and more obvious to just add
a condition to the end of the cascade.
Later, we check the same "message" variable when deciding whether to
clear commit marks on the left/right commits; if it is set, we
presumably never started the walk. This is wrong, though; we might
have started the walk and munged commit flags, only to encounter an
error afterwards. We should always clear the flags on left/right if
they exist, whether the walk was successful or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-03-22 20:19:56 +04:00
|
|
|
if (!message) /* only NULL if we succeeded in setting up the walk */
|
2011-03-16 10:14:11 +03:00
|
|
|
print_submodule_summary(&rev, f, del, add, reset);
|
submodule: clarify logic in show_submodule_summary
There are two uses of the "left" and "right" commit variables that
make it hard to be sure what values they have (both for the reader,
and for gcc, which wrongly complains that they might be used
uninitialized).
The function starts with a cascading if statement, checking that the
input sha1s exist, and finally working up to preparing a revision
walk. We only prepare the walk if the cascading conditional did not
find any problems, which we check by seeing whether it set the
"message" variable or not. It's simpler and more obvious to just add
a condition to the end of the cascade.
Later, we check the same "message" variable when deciding whether to
clear commit marks on the left/right commits; if it is set, we
presumably never started the walk. This is wrong, though; we might
have started the walk and munged commit flags, only to encounter an
error afterwards. We should always clear the flags on left/right if
they exist, whether the walk was successful or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-03-22 20:19:56 +04:00
|
|
|
if (left)
|
2009-10-19 16:38:32 +04:00
|
|
|
clear_commit_marks(left, ~0);
|
submodule: clarify logic in show_submodule_summary
There are two uses of the "left" and "right" commit variables that
make it hard to be sure what values they have (both for the reader,
and for gcc, which wrongly complains that they might be used
uninitialized).
The function starts with a cascading if statement, checking that the
input sha1s exist, and finally working up to preparing a revision
walk. We only prepare the walk if the cascading conditional did not
find any problems, which we check by seeing whether it set the
"message" variable or not. It's simpler and more obvious to just add
a condition to the end of the cascade.
Later, we check the same "message" variable when deciding whether to
clear commit marks on the left/right commits; if it is set, we
presumably never started the walk. This is wrong, though; we might
have started the walk and munged commit flags, only to encounter an
error afterwards. We should always clear the flags on left/right if
they exist, whether the walk was successful or not.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-03-22 20:19:56 +04:00
|
|
|
if (right)
|
2009-10-19 16:38:32 +04:00
|
|
|
clear_commit_marks(right, ~0);
|
2011-03-16 10:14:11 +03:00
|
|
|
|
2009-10-19 16:38:32 +04:00
|
|
|
strbuf_release(&sb);
|
|
|
|
}
|
2010-01-16 20:42:24 +03:00
|
|
|
|
2010-11-11 02:55:02 +03:00
|
|
|
void set_config_fetch_recurse_submodules(int value)
|
|
|
|
{
|
|
|
|
config_fetch_recurse_submodules = value;
|
|
|
|
}
|
|
|
|
|
2011-08-20 02:08:47 +04:00
|
|
|
static int has_remote(const char *refname, const unsigned char *sha1, int flags, void *cb_data)
|
|
|
|
{
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int submodule_needs_pushing(const char *path, const unsigned char sha1[20])
|
|
|
|
{
|
|
|
|
if (add_submodule_odb(path) || !lookup_commit_reference(sha1))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) {
|
|
|
|
struct child_process cp;
|
|
|
|
const char *argv[] = {"rev-list", NULL, "--not", "--remotes", "-n", "1" , NULL};
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
int needs_pushing = 0;
|
|
|
|
|
|
|
|
argv[1] = sha1_to_hex(sha1);
|
|
|
|
memset(&cp, 0, sizeof(cp));
|
|
|
|
cp.argv = argv;
|
|
|
|
cp.env = local_repo_env;
|
|
|
|
cp.git_cmd = 1;
|
|
|
|
cp.no_stdin = 1;
|
|
|
|
cp.out = -1;
|
|
|
|
cp.dir = path;
|
|
|
|
if (start_command(&cp))
|
|
|
|
die("Could not run 'git rev-list %s --not --remotes -n 1' command in submodule %s",
|
|
|
|
sha1_to_hex(sha1), path);
|
|
|
|
if (strbuf_read(&buf, cp.out, 41))
|
|
|
|
needs_pushing = 1;
|
|
|
|
finish_command(&cp);
|
|
|
|
close(cp.out);
|
|
|
|
strbuf_release(&buf);
|
|
|
|
return needs_pushing;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void collect_submodules_from_diff(struct diff_queue_struct *q,
|
|
|
|
struct diff_options *options,
|
|
|
|
void *data)
|
|
|
|
{
|
|
|
|
int i;
|
2012-03-29 11:21:23 +04:00
|
|
|
struct string_list *needs_pushing = data;
|
2011-08-20 02:08:47 +04:00
|
|
|
|
|
|
|
for (i = 0; i < q->nr; i++) {
|
|
|
|
struct diff_filepair *p = q->queue[i];
|
|
|
|
if (!S_ISGITLINK(p->two->mode))
|
|
|
|
continue;
|
2012-03-29 11:21:23 +04:00
|
|
|
if (submodule_needs_pushing(p->two->path, p->two->sha1))
|
|
|
|
string_list_insert(needs_pushing, p->two->path);
|
2011-08-20 02:08:47 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-03-29 11:21:23 +04:00
|
|
|
static void find_unpushed_submodule_commits(struct commit *commit,
|
|
|
|
struct string_list *needs_pushing)
|
2011-08-20 02:08:47 +04:00
|
|
|
{
|
|
|
|
struct rev_info rev;
|
|
|
|
|
|
|
|
init_revisions(&rev, NULL);
|
|
|
|
rev.diffopt.output_format |= DIFF_FORMAT_CALLBACK;
|
|
|
|
rev.diffopt.format_callback = collect_submodules_from_diff;
|
|
|
|
rev.diffopt.format_callback_data = needs_pushing;
|
2011-12-17 14:27:19 +04:00
|
|
|
diff_tree_combined_merge(commit, 1, &rev);
|
2011-08-20 02:08:47 +04:00
|
|
|
}
|
|
|
|
|
2012-03-29 11:21:23 +04:00
|
|
|
int find_unpushed_submodules(unsigned char new_sha1[20],
|
|
|
|
const char *remotes_name, struct string_list *needs_pushing)
|
2011-08-20 02:08:47 +04:00
|
|
|
{
|
|
|
|
struct rev_info rev;
|
|
|
|
struct commit *commit;
|
|
|
|
const char *argv[] = {NULL, NULL, "--not", "NULL", NULL};
|
|
|
|
int argc = ARRAY_SIZE(argv) - 1;
|
|
|
|
char *sha1_copy;
|
2012-03-29 11:21:23 +04:00
|
|
|
|
2011-08-20 02:08:47 +04:00
|
|
|
struct strbuf remotes_arg = STRBUF_INIT;
|
|
|
|
|
|
|
|
strbuf_addf(&remotes_arg, "--remotes=%s", remotes_name);
|
|
|
|
init_revisions(&rev, NULL);
|
|
|
|
sha1_copy = xstrdup(sha1_to_hex(new_sha1));
|
|
|
|
argv[1] = sha1_copy;
|
|
|
|
argv[3] = remotes_arg.buf;
|
|
|
|
setup_revisions(argc, argv, &rev, NULL);
|
|
|
|
if (prepare_revision_walk(&rev))
|
|
|
|
die("revision walk setup failed");
|
|
|
|
|
2012-03-29 11:21:23 +04:00
|
|
|
while ((commit = get_revision(&rev)) != NULL)
|
|
|
|
find_unpushed_submodule_commits(commit, needs_pushing);
|
2011-08-20 02:08:47 +04:00
|
|
|
|
2012-03-29 11:21:21 +04:00
|
|
|
reset_revision_walk();
|
2011-08-20 02:08:47 +04:00
|
|
|
free(sha1_copy);
|
|
|
|
strbuf_release(&remotes_arg);
|
|
|
|
|
2012-03-29 11:21:23 +04:00
|
|
|
return needs_pushing->nr;
|
2011-08-20 02:08:47 +04:00
|
|
|
}
|
|
|
|
|
2012-03-29 11:21:24 +04:00
|
|
|
static int push_submodule(const char *path)
|
|
|
|
{
|
|
|
|
if (add_submodule_odb(path))
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) {
|
|
|
|
struct child_process cp;
|
|
|
|
const char *argv[] = {"push", NULL};
|
|
|
|
|
|
|
|
memset(&cp, 0, sizeof(cp));
|
|
|
|
cp.argv = argv;
|
|
|
|
cp.env = local_repo_env;
|
|
|
|
cp.git_cmd = 1;
|
|
|
|
cp.no_stdin = 1;
|
|
|
|
cp.dir = path;
|
|
|
|
if (run_command(&cp))
|
|
|
|
return 0;
|
|
|
|
close(cp.out);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
int push_unpushed_submodules(unsigned char new_sha1[20], const char *remotes_name)
|
|
|
|
{
|
|
|
|
int i, ret = 1;
|
|
|
|
struct string_list needs_pushing;
|
|
|
|
|
|
|
|
memset(&needs_pushing, 0, sizeof(struct string_list));
|
|
|
|
needs_pushing.strdup_strings = 1;
|
|
|
|
|
|
|
|
if (!find_unpushed_submodules(new_sha1, remotes_name, &needs_pushing))
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
for (i = 0; i < needs_pushing.nr; i++) {
|
|
|
|
const char *path = needs_pushing.items[i].string;
|
|
|
|
fprintf(stderr, "Pushing submodule '%s'\n", path);
|
|
|
|
if (!push_submodule(path)) {
|
|
|
|
fprintf(stderr, "Unable to push submodule '%s'\n", path);
|
|
|
|
ret = 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
string_list_clear(&needs_pushing, 0);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2011-03-07 01:12:58 +03:00
|
|
|
static int is_submodule_commit_present(const char *path, unsigned char sha1[20])
|
|
|
|
{
|
|
|
|
int is_present = 0;
|
|
|
|
if (!add_submodule_odb(path) && lookup_commit_reference(sha1)) {
|
|
|
|
/* Even if the submodule is checked out and the commit is
|
|
|
|
* present, make sure it is reachable from a ref. */
|
|
|
|
struct child_process cp;
|
|
|
|
const char *argv[] = {"rev-list", "-n", "1", NULL, "--not", "--all", NULL};
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
|
|
|
|
argv[3] = sha1_to_hex(sha1);
|
|
|
|
memset(&cp, 0, sizeof(cp));
|
|
|
|
cp.argv = argv;
|
|
|
|
cp.env = local_repo_env;
|
|
|
|
cp.git_cmd = 1;
|
|
|
|
cp.no_stdin = 1;
|
|
|
|
cp.out = -1;
|
|
|
|
cp.dir = path;
|
|
|
|
if (!run_command(&cp) && !strbuf_read(&buf, cp.out, 1024))
|
|
|
|
is_present = 1;
|
|
|
|
|
|
|
|
close(cp.out);
|
|
|
|
strbuf_release(&buf);
|
|
|
|
}
|
|
|
|
return is_present;
|
|
|
|
}
|
|
|
|
|
2011-03-07 01:10:46 +03:00
|
|
|
static void submodule_collect_changed_cb(struct diff_queue_struct *q,
|
|
|
|
struct diff_options *options,
|
|
|
|
void *data)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
for (i = 0; i < q->nr; i++) {
|
|
|
|
struct diff_filepair *p = q->queue[i];
|
|
|
|
if (!S_ISGITLINK(p->two->mode))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (S_ISGITLINK(p->one->mode)) {
|
|
|
|
/* NEEDSWORK: We should honor the name configured in
|
|
|
|
* the .gitmodules file of the commit we are examining
|
|
|
|
* here to be able to correctly follow submodules
|
|
|
|
* being moved around. */
|
|
|
|
struct string_list_item *path;
|
|
|
|
path = unsorted_string_list_lookup(&changed_submodule_paths, p->two->path);
|
2011-03-07 01:12:58 +03:00
|
|
|
if (!path && !is_submodule_commit_present(p->two->path, p->two->sha1))
|
2011-03-07 01:10:46 +03:00
|
|
|
string_list_append(&changed_submodule_paths, xstrdup(p->two->path));
|
|
|
|
} else {
|
|
|
|
/* Submodule is new or was moved here */
|
|
|
|
/* NEEDSWORK: When the .git directories of submodules
|
|
|
|
* live inside the superprojects .git directory some
|
|
|
|
* day we should fetch new submodules directly into
|
|
|
|
* that location too when config or options request
|
|
|
|
* that so they can be checked out from there. */
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-09-12 23:56:52 +04:00
|
|
|
static int add_sha1_to_array(const char *ref, const unsigned char *sha1,
|
|
|
|
int flags, void *data)
|
|
|
|
{
|
|
|
|
sha1_array_append(data, sha1);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-03-07 01:10:46 +03:00
|
|
|
void check_for_new_submodule_commits(unsigned char new_sha1[20])
|
2011-09-12 23:56:52 +04:00
|
|
|
{
|
|
|
|
if (!initialized_fetch_ref_tips) {
|
|
|
|
for_each_ref(add_sha1_to_array, &ref_tips_before_fetch);
|
|
|
|
initialized_fetch_ref_tips = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
sha1_array_append(&ref_tips_after_fetch, new_sha1);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void add_sha1_to_argv(const unsigned char sha1[20], void *data)
|
|
|
|
{
|
2011-09-14 01:57:57 +04:00
|
|
|
argv_array_push(data, sha1_to_hex(sha1));
|
2011-09-12 23:56:52 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static void calculate_changed_submodule_paths(void)
|
2011-03-07 01:10:46 +03:00
|
|
|
{
|
|
|
|
struct rev_info rev;
|
|
|
|
struct commit *commit;
|
2011-09-14 01:57:57 +04:00
|
|
|
struct argv_array argv = ARGV_ARRAY_INIT;
|
2011-03-07 01:10:46 +03:00
|
|
|
|
2011-09-09 22:22:03 +04:00
|
|
|
/* No need to check if there are no submodules configured */
|
|
|
|
if (!config_name_for_path.nr)
|
|
|
|
return;
|
|
|
|
|
2011-03-07 01:10:46 +03:00
|
|
|
init_revisions(&rev, NULL);
|
2011-09-14 01:57:57 +04:00
|
|
|
argv_array_push(&argv, "--"); /* argv[0] program name */
|
2011-09-12 23:56:52 +04:00
|
|
|
sha1_array_for_each_unique(&ref_tips_after_fetch,
|
|
|
|
add_sha1_to_argv, &argv);
|
2011-09-14 01:57:57 +04:00
|
|
|
argv_array_push(&argv, "--not");
|
2011-09-12 23:56:52 +04:00
|
|
|
sha1_array_for_each_unique(&ref_tips_before_fetch,
|
|
|
|
add_sha1_to_argv, &argv);
|
|
|
|
setup_revisions(argv.argc, argv.argv, &rev, NULL);
|
2011-03-07 01:10:46 +03:00
|
|
|
if (prepare_revision_walk(&rev))
|
|
|
|
die("revision walk setup failed");
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Collect all submodules (whether checked out or not) for which new
|
|
|
|
* commits have been recorded upstream in "changed_submodule_paths".
|
|
|
|
*/
|
|
|
|
while ((commit = get_revision(&rev))) {
|
|
|
|
struct commit_list *parent = commit->parents;
|
|
|
|
while (parent) {
|
|
|
|
struct diff_options diff_opts;
|
|
|
|
diff_setup(&diff_opts);
|
2011-06-20 22:18:03 +04:00
|
|
|
DIFF_OPT_SET(&diff_opts, RECURSIVE);
|
2011-03-07 01:10:46 +03:00
|
|
|
diff_opts.output_format |= DIFF_FORMAT_CALLBACK;
|
|
|
|
diff_opts.format_callback = submodule_collect_changed_cb;
|
2012-08-03 16:16:24 +04:00
|
|
|
diff_setup_done(&diff_opts);
|
2011-03-07 01:10:46 +03:00
|
|
|
diff_tree_sha1(parent->item->object.sha1, commit->object.sha1, "", &diff_opts);
|
|
|
|
diffcore_std(&diff_opts);
|
|
|
|
diff_flush(&diff_opts);
|
|
|
|
parent = parent->next;
|
|
|
|
}
|
|
|
|
}
|
2011-09-12 23:56:52 +04:00
|
|
|
|
2011-09-14 01:57:57 +04:00
|
|
|
argv_array_clear(&argv);
|
2011-09-12 23:56:52 +04:00
|
|
|
sha1_array_clear(&ref_tips_before_fetch);
|
|
|
|
sha1_array_clear(&ref_tips_after_fetch);
|
|
|
|
initialized_fetch_ref_tips = 0;
|
2011-03-07 01:10:46 +03:00
|
|
|
}
|
|
|
|
|
2012-09-01 19:27:06 +04:00
|
|
|
int fetch_populated_submodules(const struct argv_array *options,
|
2011-03-07 01:11:21 +03:00
|
|
|
const char *prefix, int command_line_option,
|
2010-11-11 02:55:02 +03:00
|
|
|
int quiet)
|
2010-11-12 15:54:52 +03:00
|
|
|
{
|
2012-09-01 19:27:06 +04:00
|
|
|
int i, result = 0;
|
2010-11-12 15:54:52 +03:00
|
|
|
struct child_process cp;
|
2012-09-01 19:27:06 +04:00
|
|
|
struct argv_array argv = ARGV_ARRAY_INIT;
|
2010-11-12 15:54:52 +03:00
|
|
|
struct string_list_item *name_for_path;
|
|
|
|
const char *work_tree = get_git_work_tree();
|
|
|
|
if (!work_tree)
|
2011-03-07 01:10:46 +03:00
|
|
|
goto out;
|
2010-11-12 15:54:52 +03:00
|
|
|
|
|
|
|
if (!the_index.initialized)
|
|
|
|
if (read_cache() < 0)
|
|
|
|
die("index file corrupt");
|
|
|
|
|
2012-09-01 19:27:06 +04:00
|
|
|
argv_array_push(&argv, "fetch");
|
|
|
|
for (i = 0; i < options->argc; i++)
|
|
|
|
argv_array_push(&argv, options->argv[i]);
|
|
|
|
argv_array_push(&argv, "--recurse-submodules-default");
|
|
|
|
/* default value, "--submodule-prefix" and its value are added later */
|
2010-11-12 15:54:52 +03:00
|
|
|
|
|
|
|
memset(&cp, 0, sizeof(cp));
|
|
|
|
cp.env = local_repo_env;
|
|
|
|
cp.git_cmd = 1;
|
|
|
|
cp.no_stdin = 1;
|
|
|
|
|
2011-09-12 23:56:52 +04:00
|
|
|
calculate_changed_submodule_paths();
|
|
|
|
|
2010-11-12 15:54:52 +03:00
|
|
|
for (i = 0; i < active_nr; i++) {
|
|
|
|
struct strbuf submodule_path = STRBUF_INIT;
|
|
|
|
struct strbuf submodule_git_dir = STRBUF_INIT;
|
|
|
|
struct strbuf submodule_prefix = STRBUF_INIT;
|
|
|
|
struct cache_entry *ce = active_cache[i];
|
2011-03-07 01:10:46 +03:00
|
|
|
const char *git_dir, *name, *default_argv;
|
2010-11-12 15:54:52 +03:00
|
|
|
|
|
|
|
if (!S_ISGITLINK(ce->ce_mode))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
name = ce->name;
|
|
|
|
name_for_path = unsorted_string_list_lookup(&config_name_for_path, ce->name);
|
|
|
|
if (name_for_path)
|
|
|
|
name = name_for_path->util;
|
|
|
|
|
2011-03-07 01:10:46 +03:00
|
|
|
default_argv = "yes";
|
2011-03-07 01:11:21 +03:00
|
|
|
if (command_line_option == RECURSE_SUBMODULES_DEFAULT) {
|
2010-11-11 02:55:41 +03:00
|
|
|
struct string_list_item *fetch_recurse_submodules_option;
|
|
|
|
fetch_recurse_submodules_option = unsorted_string_list_lookup(&config_fetch_recurse_submodules_for_name, name);
|
|
|
|
if (fetch_recurse_submodules_option) {
|
2011-03-07 01:12:19 +03:00
|
|
|
if ((intptr_t)fetch_recurse_submodules_option->util == RECURSE_SUBMODULES_OFF)
|
2010-11-11 02:55:41 +03:00
|
|
|
continue;
|
2011-03-07 01:12:19 +03:00
|
|
|
if ((intptr_t)fetch_recurse_submodules_option->util == RECURSE_SUBMODULES_ON_DEMAND) {
|
|
|
|
if (!unsorted_string_list_lookup(&changed_submodule_paths, ce->name))
|
|
|
|
continue;
|
|
|
|
default_argv = "on-demand";
|
|
|
|
}
|
2010-11-11 02:55:41 +03:00
|
|
|
} else {
|
2011-05-14 20:26:58 +04:00
|
|
|
if ((config_fetch_recurse_submodules == RECURSE_SUBMODULES_OFF) ||
|
|
|
|
gitmodules_is_unmerged)
|
2010-11-11 02:55:41 +03:00
|
|
|
continue;
|
2011-03-07 01:10:46 +03:00
|
|
|
if (config_fetch_recurse_submodules == RECURSE_SUBMODULES_ON_DEMAND) {
|
|
|
|
if (!unsorted_string_list_lookup(&changed_submodule_paths, ce->name))
|
|
|
|
continue;
|
|
|
|
default_argv = "on-demand";
|
|
|
|
}
|
2010-11-11 02:55:41 +03:00
|
|
|
}
|
2011-03-07 01:11:21 +03:00
|
|
|
} else if (command_line_option == RECURSE_SUBMODULES_ON_DEMAND) {
|
|
|
|
if (!unsorted_string_list_lookup(&changed_submodule_paths, ce->name))
|
|
|
|
continue;
|
|
|
|
default_argv = "on-demand";
|
2010-11-11 02:55:02 +03:00
|
|
|
}
|
|
|
|
|
2010-11-12 15:54:52 +03:00
|
|
|
strbuf_addf(&submodule_path, "%s/%s", work_tree, ce->name);
|
|
|
|
strbuf_addf(&submodule_git_dir, "%s/.git", submodule_path.buf);
|
|
|
|
strbuf_addf(&submodule_prefix, "%s%s/", prefix, ce->name);
|
2011-08-23 01:04:56 +04:00
|
|
|
git_dir = read_gitfile(submodule_git_dir.buf);
|
2010-11-12 15:54:52 +03:00
|
|
|
if (!git_dir)
|
|
|
|
git_dir = submodule_git_dir.buf;
|
|
|
|
if (is_directory(git_dir)) {
|
|
|
|
if (!quiet)
|
|
|
|
printf("Fetching submodule %s%s\n", prefix, ce->name);
|
|
|
|
cp.dir = submodule_path.buf;
|
2012-09-01 19:27:06 +04:00
|
|
|
argv_array_push(&argv, default_argv);
|
|
|
|
argv_array_push(&argv, "--submodule-prefix");
|
|
|
|
argv_array_push(&argv, submodule_prefix.buf);
|
|
|
|
cp.argv = argv.argv;
|
2010-11-12 15:54:52 +03:00
|
|
|
if (run_command(&cp))
|
|
|
|
result = 1;
|
2012-09-01 19:27:06 +04:00
|
|
|
argv_array_pop(&argv);
|
|
|
|
argv_array_pop(&argv);
|
|
|
|
argv_array_pop(&argv);
|
2010-11-12 15:54:52 +03:00
|
|
|
}
|
|
|
|
strbuf_release(&submodule_path);
|
|
|
|
strbuf_release(&submodule_git_dir);
|
|
|
|
strbuf_release(&submodule_prefix);
|
|
|
|
}
|
2012-09-01 19:27:06 +04:00
|
|
|
argv_array_clear(&argv);
|
2011-03-07 01:10:46 +03:00
|
|
|
out:
|
|
|
|
string_list_clear(&changed_submodule_paths, 1);
|
2010-11-12 15:54:52 +03:00
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2010-03-14 01:00:27 +03:00
|
|
|
unsigned is_submodule_modified(const char *path, int ignore_untracked)
|
2010-01-16 20:42:24 +03:00
|
|
|
{
|
2010-03-05 00:20:33 +03:00
|
|
|
ssize_t len;
|
2010-01-16 20:42:24 +03:00
|
|
|
struct child_process cp;
|
|
|
|
const char *argv[] = {
|
|
|
|
"status",
|
|
|
|
"--porcelain",
|
|
|
|
NULL,
|
2010-03-14 01:00:27 +03:00
|
|
|
NULL,
|
2010-01-16 20:42:24 +03:00
|
|
|
};
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
2010-03-05 00:20:33 +03:00
|
|
|
unsigned dirty_submodule = 0;
|
|
|
|
const char *line, *next_line;
|
2010-04-10 21:01:12 +04:00
|
|
|
const char *git_dir;
|
2010-01-16 20:42:24 +03:00
|
|
|
|
2010-04-10 21:01:12 +04:00
|
|
|
strbuf_addf(&buf, "%s/.git", path);
|
2011-08-23 01:04:56 +04:00
|
|
|
git_dir = read_gitfile(buf.buf);
|
2010-04-10 21:01:12 +04:00
|
|
|
if (!git_dir)
|
|
|
|
git_dir = buf.buf;
|
|
|
|
if (!is_directory(git_dir)) {
|
2010-01-16 20:42:24 +03:00
|
|
|
strbuf_release(&buf);
|
|
|
|
/* The submodule is not checked out, so it is not modified */
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
}
|
|
|
|
strbuf_reset(&buf);
|
|
|
|
|
2010-03-14 01:00:27 +03:00
|
|
|
if (ignore_untracked)
|
|
|
|
argv[2] = "-uno";
|
|
|
|
|
2010-01-16 20:42:24 +03:00
|
|
|
memset(&cp, 0, sizeof(cp));
|
|
|
|
cp.argv = argv;
|
2010-04-10 21:01:12 +04:00
|
|
|
cp.env = local_repo_env;
|
2010-01-16 20:42:24 +03:00
|
|
|
cp.git_cmd = 1;
|
|
|
|
cp.no_stdin = 1;
|
|
|
|
cp.out = -1;
|
2010-04-10 21:01:12 +04:00
|
|
|
cp.dir = path;
|
2010-01-16 20:42:24 +03:00
|
|
|
if (start_command(&cp))
|
2011-12-08 01:50:14 +04:00
|
|
|
die("Could not run 'git status --porcelain' in submodule %s", path);
|
2010-01-16 20:42:24 +03:00
|
|
|
|
|
|
|
len = strbuf_read(&buf, cp.out, 1024);
|
2010-03-05 00:20:33 +03:00
|
|
|
line = buf.buf;
|
|
|
|
while (len > 2) {
|
|
|
|
if ((line[0] == '?') && (line[1] == '?')) {
|
|
|
|
dirty_submodule |= DIRTY_SUBMODULE_UNTRACKED;
|
|
|
|
if (dirty_submodule & DIRTY_SUBMODULE_MODIFIED)
|
|
|
|
break;
|
|
|
|
} else {
|
|
|
|
dirty_submodule |= DIRTY_SUBMODULE_MODIFIED;
|
2010-03-14 01:00:27 +03:00
|
|
|
if (ignore_untracked ||
|
|
|
|
(dirty_submodule & DIRTY_SUBMODULE_UNTRACKED))
|
2010-03-05 00:20:33 +03:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
next_line = strchr(line, '\n');
|
|
|
|
if (!next_line)
|
|
|
|
break;
|
|
|
|
next_line++;
|
|
|
|
len -= (next_line - line);
|
|
|
|
line = next_line;
|
|
|
|
}
|
2010-01-16 20:42:24 +03:00
|
|
|
close(cp.out);
|
|
|
|
|
|
|
|
if (finish_command(&cp))
|
2011-12-08 01:50:14 +04:00
|
|
|
die("'git status --porcelain' failed in submodule %s", path);
|
2010-01-16 20:42:24 +03:00
|
|
|
|
|
|
|
strbuf_release(&buf);
|
2010-03-05 00:20:33 +03:00
|
|
|
return dirty_submodule;
|
2010-01-16 20:42:24 +03:00
|
|
|
}
|
2010-07-07 17:39:13 +04:00
|
|
|
|
2012-09-26 22:21:13 +04:00
|
|
|
int submodule_uses_gitfile(const char *path)
|
|
|
|
{
|
|
|
|
struct child_process cp;
|
|
|
|
const char *argv[] = {
|
|
|
|
"submodule",
|
|
|
|
"foreach",
|
|
|
|
"--quiet",
|
|
|
|
"--recursive",
|
|
|
|
"test -f .git",
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
const char *git_dir;
|
|
|
|
|
|
|
|
strbuf_addf(&buf, "%s/.git", path);
|
|
|
|
git_dir = read_gitfile(buf.buf);
|
|
|
|
if (!git_dir) {
|
|
|
|
strbuf_release(&buf);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
strbuf_release(&buf);
|
|
|
|
|
|
|
|
/* Now test that all nested submodules use a gitfile too */
|
|
|
|
memset(&cp, 0, sizeof(cp));
|
|
|
|
cp.argv = argv;
|
|
|
|
cp.env = local_repo_env;
|
|
|
|
cp.git_cmd = 1;
|
|
|
|
cp.no_stdin = 1;
|
|
|
|
cp.no_stderr = 1;
|
|
|
|
cp.no_stdout = 1;
|
|
|
|
cp.dir = path;
|
|
|
|
if (run_command(&cp))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
int ok_to_remove_submodule(const char *path)
|
|
|
|
{
|
|
|
|
struct stat st;
|
|
|
|
ssize_t len;
|
|
|
|
struct child_process cp;
|
|
|
|
const char *argv[] = {
|
|
|
|
"status",
|
|
|
|
"--porcelain",
|
|
|
|
"-u",
|
|
|
|
"--ignore-submodules=none",
|
|
|
|
NULL,
|
|
|
|
};
|
|
|
|
struct strbuf buf = STRBUF_INIT;
|
|
|
|
int ok_to_remove = 1;
|
|
|
|
|
|
|
|
if ((lstat(path, &st) < 0) || is_empty_dir(path))
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
if (!submodule_uses_gitfile(path))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
memset(&cp, 0, sizeof(cp));
|
|
|
|
cp.argv = argv;
|
|
|
|
cp.env = local_repo_env;
|
|
|
|
cp.git_cmd = 1;
|
|
|
|
cp.no_stdin = 1;
|
|
|
|
cp.out = -1;
|
|
|
|
cp.dir = path;
|
|
|
|
if (start_command(&cp))
|
|
|
|
die("Could not run 'git status --porcelain -uall --ignore-submodules=none' in submodule %s", path);
|
|
|
|
|
|
|
|
len = strbuf_read(&buf, cp.out, 1024);
|
|
|
|
if (len > 2)
|
|
|
|
ok_to_remove = 0;
|
|
|
|
close(cp.out);
|
|
|
|
|
|
|
|
if (finish_command(&cp))
|
|
|
|
die("'git status --porcelain -uall --ignore-submodules=none' failed in submodule %s", path);
|
|
|
|
|
|
|
|
strbuf_release(&buf);
|
|
|
|
return ok_to_remove;
|
|
|
|
}
|
|
|
|
|
2010-07-07 17:39:13 +04:00
|
|
|
static int find_first_merges(struct object_array *result, const char *path,
|
|
|
|
struct commit *a, struct commit *b)
|
|
|
|
{
|
|
|
|
int i, j;
|
|
|
|
struct object_array merges;
|
|
|
|
struct commit *commit;
|
|
|
|
int contains_another;
|
|
|
|
|
|
|
|
char merged_revision[42];
|
|
|
|
const char *rev_args[] = { "rev-list", "--merges", "--ancestry-path",
|
|
|
|
"--all", merged_revision, NULL };
|
|
|
|
struct rev_info revs;
|
|
|
|
struct setup_revision_opt rev_opts;
|
|
|
|
|
|
|
|
memset(&merges, 0, sizeof(merges));
|
|
|
|
memset(result, 0, sizeof(struct object_array));
|
|
|
|
memset(&rev_opts, 0, sizeof(rev_opts));
|
|
|
|
|
|
|
|
/* get all revisions that merge commit a */
|
|
|
|
snprintf(merged_revision, sizeof(merged_revision), "^%s",
|
|
|
|
sha1_to_hex(a->object.sha1));
|
|
|
|
init_revisions(&revs, NULL);
|
|
|
|
rev_opts.submodule = path;
|
|
|
|
setup_revisions(sizeof(rev_args)/sizeof(char *)-1, rev_args, &revs, &rev_opts);
|
|
|
|
|
|
|
|
/* save all revisions from the above list that contain b */
|
|
|
|
if (prepare_revision_walk(&revs))
|
|
|
|
die("revision walk setup failed");
|
|
|
|
while ((commit = get_revision(&revs)) != NULL) {
|
|
|
|
struct object *o = &(commit->object);
|
2012-08-28 01:46:01 +04:00
|
|
|
if (in_merge_bases(b, commit))
|
2010-07-07 17:39:13 +04:00
|
|
|
add_object_array(o, NULL, &merges);
|
|
|
|
}
|
2012-03-29 11:21:21 +04:00
|
|
|
reset_revision_walk();
|
2010-07-07 17:39:13 +04:00
|
|
|
|
|
|
|
/* Now we've got all merges that contain a and b. Prune all
|
|
|
|
* merges that contain another found merge and save them in
|
|
|
|
* result.
|
|
|
|
*/
|
|
|
|
for (i = 0; i < merges.nr; i++) {
|
|
|
|
struct commit *m1 = (struct commit *) merges.objects[i].item;
|
|
|
|
|
|
|
|
contains_another = 0;
|
|
|
|
for (j = 0; j < merges.nr; j++) {
|
|
|
|
struct commit *m2 = (struct commit *) merges.objects[j].item;
|
2012-08-28 01:46:01 +04:00
|
|
|
if (i != j && in_merge_bases(m2, m1)) {
|
2010-07-07 17:39:13 +04:00
|
|
|
contains_another = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!contains_another)
|
|
|
|
add_object_array(merges.objects[i].item,
|
|
|
|
merges.objects[i].name, result);
|
|
|
|
}
|
|
|
|
|
|
|
|
free(merges.objects);
|
|
|
|
return result->nr;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void print_commit(struct commit *commit)
|
|
|
|
{
|
|
|
|
struct strbuf sb = STRBUF_INIT;
|
|
|
|
struct pretty_print_context ctx = {0};
|
|
|
|
ctx.date_mode = DATE_NORMAL;
|
|
|
|
format_commit_message(commit, " %h: %m %s", &sb, &ctx);
|
|
|
|
fprintf(stderr, "%s\n", sb.buf);
|
|
|
|
strbuf_release(&sb);
|
|
|
|
}
|
|
|
|
|
|
|
|
#define MERGE_WARNING(path, msg) \
|
|
|
|
warning("Failed to merge submodule %s (%s)", path, msg);
|
|
|
|
|
|
|
|
int merge_submodule(unsigned char result[20], const char *path,
|
|
|
|
const unsigned char base[20], const unsigned char a[20],
|
2011-10-13 16:59:05 +04:00
|
|
|
const unsigned char b[20], int search)
|
2010-07-07 17:39:13 +04:00
|
|
|
{
|
|
|
|
struct commit *commit_base, *commit_a, *commit_b;
|
|
|
|
int parent_count;
|
|
|
|
struct object_array merges;
|
|
|
|
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* store a in result in case we fail */
|
|
|
|
hashcpy(result, a);
|
|
|
|
|
|
|
|
/* we can not handle deletion conflicts */
|
|
|
|
if (is_null_sha1(base))
|
|
|
|
return 0;
|
|
|
|
if (is_null_sha1(a))
|
|
|
|
return 0;
|
|
|
|
if (is_null_sha1(b))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (add_submodule_odb(path)) {
|
|
|
|
MERGE_WARNING(path, "not checked out");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!(commit_base = lookup_commit_reference(base)) ||
|
|
|
|
!(commit_a = lookup_commit_reference(a)) ||
|
|
|
|
!(commit_b = lookup_commit_reference(b))) {
|
|
|
|
MERGE_WARNING(path, "commits not present");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check whether both changes are forward */
|
2012-08-28 01:46:01 +04:00
|
|
|
if (!in_merge_bases(commit_base, commit_a) ||
|
|
|
|
!in_merge_bases(commit_base, commit_b)) {
|
2010-07-07 17:39:13 +04:00
|
|
|
MERGE_WARNING(path, "commits don't follow merge-base");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Case #1: a is contained in b or vice versa */
|
2012-08-28 01:46:01 +04:00
|
|
|
if (in_merge_bases(commit_a, commit_b)) {
|
2010-07-07 17:39:13 +04:00
|
|
|
hashcpy(result, b);
|
|
|
|
return 1;
|
|
|
|
}
|
2012-08-28 01:46:01 +04:00
|
|
|
if (in_merge_bases(commit_b, commit_a)) {
|
2010-07-07 17:39:13 +04:00
|
|
|
hashcpy(result, a);
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Case #2: There are one or more merges that contain a and b in
|
|
|
|
* the submodule. If there is only one, then present it as a
|
|
|
|
* suggestion to the user, but leave it marked unmerged so the
|
|
|
|
* user needs to confirm the resolution.
|
|
|
|
*/
|
|
|
|
|
2011-10-13 16:59:05 +04:00
|
|
|
/* Skip the search if makes no sense to the calling context. */
|
|
|
|
if (!search)
|
|
|
|
return 0;
|
|
|
|
|
2010-07-07 17:39:13 +04:00
|
|
|
/* find commit which merges them */
|
|
|
|
parent_count = find_first_merges(&merges, path, commit_a, commit_b);
|
|
|
|
switch (parent_count) {
|
|
|
|
case 0:
|
|
|
|
MERGE_WARNING(path, "merge following commits not found");
|
|
|
|
break;
|
|
|
|
|
|
|
|
case 1:
|
|
|
|
MERGE_WARNING(path, "not fast-forward");
|
|
|
|
fprintf(stderr, "Found a possible merge resolution "
|
|
|
|
"for the submodule:\n");
|
|
|
|
print_commit((struct commit *) merges.objects[0].item);
|
|
|
|
fprintf(stderr,
|
|
|
|
"If this is correct simply add it to the index "
|
|
|
|
"for example\n"
|
|
|
|
"by using:\n\n"
|
|
|
|
" git update-index --cacheinfo 160000 %s \"%s\"\n\n"
|
|
|
|
"which will accept this suggestion.\n",
|
|
|
|
sha1_to_hex(merges.objects[0].item->sha1), path);
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
MERGE_WARNING(path, "multiple merges found");
|
|
|
|
for (i = 0; i < merges.nr; i++)
|
|
|
|
print_commit((struct commit *) merges.objects[i].item);
|
|
|
|
}
|
|
|
|
|
|
|
|
free(merges.objects);
|
|
|
|
return 0;
|
|
|
|
}
|