зеркало из https://github.com/microsoft/git.git
add_to_index(): free unused cache-entry
We allocate a cache-entry pretty early in the function and then decide either not to do anything when we are pretending to add, or add it and then get an error (another possibility is obviously to succeed). When pretending or failing to add, we forgot to free the cache-entry. Noticed during a discussion on Stefan's patch to change the coding style without fixing the issue ;-) Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
5d0b9bf86d
Коммит
067178ed8a
|
@ -707,9 +707,11 @@ int add_to_index(struct index_state *istate, const char *path, struct stat *st,
|
|||
ce->ce_mode == alias->ce_mode);
|
||||
|
||||
if (pretend)
|
||||
;
|
||||
else if (add_index_entry(istate, ce, add_option))
|
||||
return error("unable to add %s to index",path);
|
||||
free(ce);
|
||||
else if (add_index_entry(istate, ce, add_option)) {
|
||||
free(ce);
|
||||
return error("unable to add %s to index", path);
|
||||
}
|
||||
if (verbose && !was_same)
|
||||
printf("add '%s'\n", path);
|
||||
return 0;
|
||||
|
|
Загрузка…
Ссылка в новой задаче