зеркало из https://github.com/microsoft/git.git
Makefile: fix unaligned loads in sha1dc with UBSan
The sha1dc library uses unaligned loads on platforms that support them. This is normally what you'd want for performance, but it does cause UBSan to complain when we compile with SANITIZE=undefined. Just like we set -DNO_UNALIGNED_LOADS for our own code in that case, we should set -DSHA1DC_FORCE_ALIGNED_ACCESS. Of course that does nothing without pulling in the patches from sha1dc to respect that define. So let's do that, too, updating both the submodule link and our in-tree copy (from the same commit). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
aeb582a983
Коммит
07a20f569b
1
Makefile
1
Makefile
|
@ -1183,6 +1183,7 @@ BASIC_CFLAGS += -fsanitize=$(SANITIZE) -fno-sanitize-recover=$(SANITIZE)
|
|||
BASIC_CFLAGS += -fno-omit-frame-pointer
|
||||
ifneq ($(filter undefined,$(SANITIZERS)),)
|
||||
BASIC_CFLAGS += -DNO_UNALIGNED_LOADS
|
||||
BASIC_CFLAGS += -DSHA1DC_FORCE_ALIGNED_ACCESS
|
||||
endif
|
||||
ifneq ($(filter leak,$(SANITIZERS)),)
|
||||
BASIC_CFLAGS += -DSUPPRESS_ANNOTATED_LEAKS
|
||||
|
|
|
@ -1 +1 @@
|
|||
Subproject commit 232357eb2ea0397388254a4b188333a227bf5b10
|
||||
Subproject commit 16033998da4b273aebd92c84b1e1b12e4aaf7009
|
|
@ -124,10 +124,11 @@
|
|||
#endif
|
||||
/*ENDIANNESS SELECTION*/
|
||||
|
||||
#ifndef SHA1DC_FORCE_ALIGNED_ACCESS
|
||||
#if defined(SHA1DC_FORCE_UNALIGNED_ACCESS) || defined(SHA1DC_ON_INTEL_LIKE_PROCESSOR)
|
||||
#define SHA1DC_ALLOW_UNALIGNED_ACCESS
|
||||
#endif /*UNALIGNMENT DETECTION*/
|
||||
|
||||
#endif /*UNALIGNED ACCESS DETECTION*/
|
||||
#endif /*FORCE ALIGNED ACCESS*/
|
||||
|
||||
#define rotate_right(x,n) (((x)>>(n))|((x)<<(32-(n))))
|
||||
#define rotate_left(x,n) (((x)<<(n))|((x)>>(32-(n))))
|
||||
|
|
Загрузка…
Ссылка в новой задаче