зеркало из https://github.com/microsoft/git.git
name-rev: don't leak path copy in name_ref()
name_ref() duplicates the path string and passes it to name_rev(), which either puts it into a commit slab or ignores it if there is already a better name, leaking it. Move the duplication to name_rev() and release the copy in the latter case. Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
36d2419c9a
Коммит
15a4205d96
|
@ -121,6 +121,8 @@ static void name_rev(struct commit *start_commit,
|
|||
|
||||
if (deref)
|
||||
tip_name = to_free = xstrfmt("%s^0", tip_name);
|
||||
else
|
||||
tip_name = to_free = xstrdup(tip_name);
|
||||
|
||||
if (!create_or_update_name(start_commit, tip_name, taggerdate, 0, 0,
|
||||
from_tag)) {
|
||||
|
@ -323,7 +325,7 @@ static int name_ref(const char *path, const struct object_id *oid, int flags, vo
|
|||
if (taggerdate == TIME_MAX)
|
||||
taggerdate = commit->date;
|
||||
path = name_ref_abbrev(path, can_abbreviate_output);
|
||||
name_rev(commit, xstrdup(path), taggerdate, from_tag, deref);
|
||||
name_rev(commit, path, taggerdate, from_tag, deref);
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
|
Загрузка…
Ссылка в новой задаче