зеркало из https://github.com/microsoft/git.git
Merge branch 'jk/graph-padding-fix' into maint
The "graph" API used in "git log --graph" miscounted the number of output columns consumed so far when drawing a padding line, which has been fixed; this did not affect any existing code as nobody tried to write anything after the padding on such a line, though. * jk/graph-padding-fix: graph: fix extra spaces in graph_padding_line
This commit is contained in:
Коммит
18fd96f1d7
16
graph.c
16
graph.c
|
@ -1145,6 +1145,7 @@ int graph_next_line(struct git_graph *graph, struct strbuf *sb)
|
||||||
static void graph_padding_line(struct git_graph *graph, struct strbuf *sb)
|
static void graph_padding_line(struct git_graph *graph, struct strbuf *sb)
|
||||||
{
|
{
|
||||||
int i;
|
int i;
|
||||||
|
int chars_written = 0;
|
||||||
|
|
||||||
if (graph->state != GRAPH_COMMIT) {
|
if (graph->state != GRAPH_COMMIT) {
|
||||||
graph_next_line(graph, sb);
|
graph_next_line(graph, sb);
|
||||||
|
@ -1160,14 +1161,21 @@ static void graph_padding_line(struct git_graph *graph, struct strbuf *sb)
|
||||||
*/
|
*/
|
||||||
for (i = 0; i < graph->num_columns; i++) {
|
for (i = 0; i < graph->num_columns; i++) {
|
||||||
struct column *col = &graph->columns[i];
|
struct column *col = &graph->columns[i];
|
||||||
|
|
||||||
strbuf_write_column(sb, col, '|');
|
strbuf_write_column(sb, col, '|');
|
||||||
if (col->commit == graph->commit && graph->num_parents > 2)
|
chars_written++;
|
||||||
strbuf_addchars(sb, ' ', (graph->num_parents - 2) * 2);
|
|
||||||
else
|
if (col->commit == graph->commit && graph->num_parents > 2) {
|
||||||
|
int len = (graph->num_parents - 2) * 2;
|
||||||
|
strbuf_addchars(sb, ' ', len);
|
||||||
|
chars_written += len;
|
||||||
|
} else {
|
||||||
strbuf_addch(sb, ' ');
|
strbuf_addch(sb, ' ');
|
||||||
|
chars_written++;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
graph_pad_horizontally(graph, sb, graph->num_columns);
|
graph_pad_horizontally(graph, sb, chars_written);
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Update graph->prev_state since we have output a padding line
|
* Update graph->prev_state since we have output a padding line
|
||||||
|
|
Загрузка…
Ссылка в новой задаче