From 29753cddc8007ac63754855d026fe5eca8897d04 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Fri, 9 Sep 2011 11:54:58 -0700 Subject: [PATCH] rename "match_refs()" to "match_push_refs()" Yes, there is a warning that says the function is only used by push in big red letters in front of this function, but it didn't say a more important thing it should have said: what the function is for and what it does. Rename it and document it to avoid future confusion. Signed-off-by: Junio C Hamano --- builtin/remote.c | 4 ++-- builtin/send-pack.c | 2 +- http-push.c | 4 ++-- remote.c | 13 ++++++++----- remote.h | 4 ++-- transport.c | 4 ++-- 6 files changed, 17 insertions(+), 14 deletions(-) diff --git a/builtin/remote.c b/builtin/remote.c index f2a9c26dc3..f16b5443cc 100644 --- a/builtin/remote.c +++ b/builtin/remote.c @@ -389,8 +389,8 @@ static int get_push_ref_states(const struct ref *remote_refs, local_refs = get_local_heads(); push_map = copy_ref_list(remote_refs); - match_refs(local_refs, &push_map, remote->push_refspec_nr, - remote->push_refspec, MATCH_REFS_NONE); + match_push_refs(local_refs, &push_map, remote->push_refspec_nr, + remote->push_refspec, MATCH_REFS_NONE); states->push.strdup_strings = 1; for (ref = push_map; ref; ref = ref->next) { diff --git a/builtin/send-pack.c b/builtin/send-pack.c index 87833f4902..e0b8030f2b 100644 --- a/builtin/send-pack.c +++ b/builtin/send-pack.c @@ -509,7 +509,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix) flags |= MATCH_REFS_MIRROR; /* match them up */ - if (match_refs(local_refs, &remote_refs, nr_refspecs, refspecs, flags)) + if (match_push_refs(local_refs, &remote_refs, nr_refspecs, refspecs, flags)) return -1; set_ref_status_for_push(remote_refs, args.send_mirror, diff --git a/http-push.c b/http-push.c index 376331a76f..02f46a538b 100644 --- a/http-push.c +++ b/http-push.c @@ -1877,8 +1877,8 @@ int main(int argc, char **argv) } /* match them up */ - if (match_refs(local_refs, &remote_refs, - nr_refspec, (const char **) refspec, push_all)) { + if (match_push_refs(local_refs, &remote_refs, + nr_refspec, (const char **) refspec, push_all)) { rc = -1; goto cleanup; } diff --git a/remote.c b/remote.c index b8ecfa5d95..536ffa35cd 100644 --- a/remote.c +++ b/remote.c @@ -1170,12 +1170,15 @@ static struct ref **tail_ref(struct ref **head) } /* - * Note. This is used only by "push"; refspec matching rules for - * push and fetch are subtly different, so do not try to reuse it - * without thinking. + * Given the set of refs the local repository has, the set of refs the + * remote repository has, and the refspec used for push, determine + * what remote refs we will update and with what value by setting + * peer_ref (which object is being pushed) and force (if the push is + * forced) in elements of "dst". The function may add new elements to + * dst (e.g. pushing to a new branch, done in match_explicit_refs). */ -int match_refs(struct ref *src, struct ref **dst, - int nr_refspec, const char **refspec, int flags) +int match_push_refs(struct ref *src, struct ref **dst, + int nr_refspec, const char **refspec, int flags) { struct refspec *rs; int send_all = flags & MATCH_REFS_ALL; diff --git a/remote.h b/remote.h index 9a30a9dba6..67294778b6 100644 --- a/remote.h +++ b/remote.h @@ -96,8 +96,8 @@ void free_refspec(int nr_refspec, struct refspec *refspec); char *apply_refspecs(struct refspec *refspecs, int nr_refspec, const char *name); -int match_refs(struct ref *src, struct ref **dst, - int nr_refspec, const char **refspec, int all); +int match_push_refs(struct ref *src, struct ref **dst, + int nr_refspec, const char **refspec, int all); void set_ref_status_for_push(struct ref *remote_refs, int send_mirror, int force_update); diff --git a/transport.c b/transport.c index fa279d531f..740a73935c 100644 --- a/transport.c +++ b/transport.c @@ -1033,8 +1033,8 @@ int transport_push(struct transport *transport, if (flags & TRANSPORT_PUSH_MIRROR) match_flags |= MATCH_REFS_MIRROR; - if (match_refs(local_refs, &remote_refs, - refspec_nr, refspec, match_flags)) { + if (match_push_refs(local_refs, &remote_refs, + refspec_nr, refspec, match_flags)) { return -1; }