зеркало из https://github.com/microsoft/git.git
Merge branch 'jk/trailers-use-config'
"git interpret-trailers" always treated '#' as the comment character, regardless of core.commentChar setting, which has been corrected. * jk/trailers-use-config: interpret-trailers: load default config
This commit is contained in:
Коммит
3a506079d2
|
@ -10,6 +10,7 @@
|
|||
#include "parse-options.h"
|
||||
#include "string-list.h"
|
||||
#include "trailer.h"
|
||||
#include "config.h"
|
||||
|
||||
static const char * const git_interpret_trailers_usage[] = {
|
||||
N_("git interpret-trailers [--in-place] [--trim-empty] [(--trailer <token>[(=|:)<value>])...] [<file>...]"),
|
||||
|
@ -112,6 +113,8 @@ int cmd_interpret_trailers(int argc, const char **argv, const char *prefix)
|
|||
OPT_END()
|
||||
};
|
||||
|
||||
git_config(git_default_config, NULL);
|
||||
|
||||
argc = parse_options(argc, argv, prefix, options,
|
||||
git_interpret_trailers_usage, 0);
|
||||
|
||||
|
|
|
@ -538,9 +538,23 @@ test_expect_success 'with 2 files arguments' '
|
|||
test_cmp expected actual
|
||||
'
|
||||
|
||||
test_expect_success 'with message that has comments' '
|
||||
# Cover multiple comment characters with the same test input.
|
||||
for char in "#" ";"
|
||||
do
|
||||
case "$char" in
|
||||
"#")
|
||||
# This is the default, so let's explicitly _not_
|
||||
# set any config to make sure it behaves as we expect.
|
||||
;;
|
||||
*)
|
||||
config="-c core.commentChar=$char"
|
||||
;;
|
||||
esac
|
||||
|
||||
test_expect_success "with message that has comments ($char)" '
|
||||
cat basic_message >message_with_comments &&
|
||||
sed -e "s/ Z\$/ /" >>message_with_comments <<-\EOF &&
|
||||
sed -e "s/ Z\$/ /" \
|
||||
-e "s/#/$char/g" >>message_with_comments <<-EOF &&
|
||||
# comment
|
||||
|
||||
# other comment
|
||||
|
@ -553,7 +567,7 @@ test_expect_success 'with message that has comments' '
|
|||
EOF
|
||||
cat basic_patch >>message_with_comments &&
|
||||
cat basic_message >expected &&
|
||||
cat >>expected <<-\EOF &&
|
||||
sed -e "s/#/$char/g" >>expected <<-\EOF &&
|
||||
# comment
|
||||
|
||||
Reviewed-by: Johan
|
||||
|
@ -562,9 +576,12 @@ test_expect_success 'with message that has comments' '
|
|||
|
||||
EOF
|
||||
cat basic_patch >>expected &&
|
||||
git interpret-trailers --trim-empty --trailer "Cc: Peff" message_with_comments >actual &&
|
||||
git $config interpret-trailers \
|
||||
--trim-empty --trailer "Cc: Peff" \
|
||||
message_with_comments >actual &&
|
||||
test_cmp expected actual
|
||||
'
|
||||
'
|
||||
done
|
||||
|
||||
test_expect_success 'with message that has an old style conflict block' '
|
||||
cat basic_message >message_with_comments &&
|
||||
|
|
Загрузка…
Ссылка в новой задаче