зеркало из https://github.com/microsoft/git.git
pretty: pass graph width to pretty formatting for use in '%>|(N)'
Pass graph width to pretty formatting, to make N in '%>|(N)' include columns consumed by graph rendered when --graph option is in use. For example, in the output of git log --all --graph --pretty='format: [%>|(20)%h] %ar%d' this change will make all commit hashes align at 20th column from the edge of the terminal, not from the edge of the graph. Signed-off-by: Josef Kufner <josef@kufner.cz> Signed-off-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
05219a1276
Коммит
3ad87c807c
1
commit.h
1
commit.h
|
@ -161,6 +161,7 @@ struct pretty_print_context {
|
|||
* should not be counted on by callers.
|
||||
*/
|
||||
struct string_list in_body_headers;
|
||||
int graph_width;
|
||||
};
|
||||
|
||||
struct userformat_want {
|
||||
|
|
7
graph.c
7
graph.c
|
@ -669,6 +669,13 @@ static void graph_output_padding_line(struct git_graph *graph,
|
|||
graph_pad_horizontally(graph, sb, graph->num_new_columns * 2);
|
||||
}
|
||||
|
||||
|
||||
int graph_width(struct git_graph *graph)
|
||||
{
|
||||
return graph->width;
|
||||
}
|
||||
|
||||
|
||||
static void graph_output_skip_line(struct git_graph *graph, struct strbuf *sb)
|
||||
{
|
||||
/*
|
||||
|
|
5
graph.h
5
graph.h
|
@ -67,6 +67,11 @@ int graph_is_commit_finished(struct git_graph const *graph);
|
|||
int graph_next_line(struct git_graph *graph, struct strbuf *sb);
|
||||
|
||||
|
||||
/*
|
||||
* Return current width of the graph in on-screen characters.
|
||||
*/
|
||||
int graph_width(struct git_graph *graph);
|
||||
|
||||
/*
|
||||
* graph_show_*: helper functions for printing to stdout
|
||||
*/
|
||||
|
|
|
@ -687,6 +687,8 @@ void show_log(struct rev_info *opt)
|
|||
ctx.output_encoding = get_log_output_encoding();
|
||||
if (opt->from_ident.mail_begin && opt->from_ident.name_begin)
|
||||
ctx.from_ident = &opt->from_ident;
|
||||
if (opt->graph)
|
||||
ctx.graph_width = graph_width(opt->graph);
|
||||
pretty_print_commit(&ctx, commit, &msgbuf);
|
||||
|
||||
if (opt->add_signoff)
|
||||
|
|
1
pretty.c
1
pretty.c
|
@ -1299,6 +1299,7 @@ static size_t format_and_pad_commit(struct strbuf *sb, /* in UTF-8 */
|
|||
if (!start)
|
||||
start = sb->buf;
|
||||
occupied = utf8_strnwidth(start, -1, 1);
|
||||
occupied += c->pretty_ctx->graph_width;
|
||||
padding = (-padding) - occupied;
|
||||
}
|
||||
while (1) {
|
||||
|
|
|
@ -319,6 +319,19 @@ EOF
|
|||
test_cmp expected actual
|
||||
'
|
||||
|
||||
# Note: Space between 'message' and 'two' should be in the same column
|
||||
# as in previous test.
|
||||
test_expect_success 'right alignment formatting at the nth column with --graph. i18n.logOutputEncoding' '
|
||||
git -c i18n.logOutputEncoding=$test_encoding log --graph --pretty="tformat:%h %>|(40)%s" >actual &&
|
||||
iconv -f utf-8 -t $test_encoding >expected <<EOF&&
|
||||
* $head1 message two
|
||||
* $head2 message one
|
||||
* $head3 add bar
|
||||
* $head4 $(commit_msg)
|
||||
EOF
|
||||
test_cmp expected actual
|
||||
'
|
||||
|
||||
test_expect_success 'right alignment formatting with no padding' '
|
||||
git log --pretty="tformat:%>(1)%s" >actual &&
|
||||
cat <<EOF >expected &&
|
||||
|
@ -330,6 +343,17 @@ EOF
|
|||
test_cmp expected actual
|
||||
'
|
||||
|
||||
test_expect_success 'right alignment formatting with no padding and with --graph' '
|
||||
git log --graph --pretty="tformat:%>(1)%s" >actual &&
|
||||
cat <<EOF >expected &&
|
||||
* message two
|
||||
* message one
|
||||
* add bar
|
||||
* $(commit_msg)
|
||||
EOF
|
||||
test_cmp expected actual
|
||||
'
|
||||
|
||||
test_expect_success 'right alignment formatting with no padding. i18n.logOutputEncoding' '
|
||||
git -c i18n.logOutputEncoding=$test_encoding log --pretty="tformat:%>(1)%s" >actual &&
|
||||
cat <<EOF | iconv -f utf-8 -t $test_encoding >expected &&
|
||||
|
|
Загрузка…
Ссылка в новой задаче