зеркало из https://github.com/microsoft/git.git
merge-recursive: use subtraction to flip stage
The flip_stage() helper uses a bit-flipping xor to switch between "2" and "3". While clever, this relies on a property of those two numbers that is mostly coincidence. Let's write it as a subtraction; that's more clear and would extend to other numbers if somebody copies the logic. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
ee798742bd
Коммит
4c616c2ba1
|
@ -1713,12 +1713,11 @@ static char *find_path_for_conflict(struct merge_options *opt,
|
|||
}
|
||||
|
||||
/*
|
||||
* Toggle the stage number between "ours" and "theirs" (2 and 3) by flipping
|
||||
* the 1-bit.
|
||||
* Toggle the stage number between "ours" and "theirs" (2 and 3).
|
||||
*/
|
||||
static inline int flip_stage(int stage)
|
||||
{
|
||||
return stage ^ 1;
|
||||
return (2 + 3) - stage;
|
||||
}
|
||||
|
||||
static int handle_rename_rename_1to2(struct merge_options *opt,
|
||||
|
|
Загрузка…
Ссылка в новой задаче