зеркало из https://github.com/microsoft/git.git
imap-send: avoid buffer overflow
We format the password prompt in an 80-character static buffer. It contains the remote host and username, so it's unlikely to overflow (or be exploitable by a remote attacker), but there's no reason not to be careful and use a strbuf. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
861444f6d7
Коммит
50d0158fbb
|
@ -1209,9 +1209,10 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)
|
|||
goto bail;
|
||||
}
|
||||
if (!srvc->pass) {
|
||||
char prompt[80];
|
||||
sprintf(prompt, "Password (%s@%s): ", srvc->user, srvc->host);
|
||||
arg = git_getpass(prompt);
|
||||
struct strbuf prompt = STRBUF_INIT;
|
||||
strbuf_addf(&prompt, "Password (%s@%s): ", srvc->user, srvc->host);
|
||||
arg = git_getpass(prompt.buf);
|
||||
strbuf_release(&prompt);
|
||||
if (!arg) {
|
||||
perror("getpass");
|
||||
exit(1);
|
||||
|
|
Загрузка…
Ссылка в новой задаче