зеркало из https://github.com/microsoft/git.git
commit.c: remove print_commit_list()
The helper function tries to offer a way to conveniently show the last one differently from others, presumably to allow you to say something like A, B, and C. while iterating over a list that has these three elements. However, there is only one caller, and it passes the same format string "%s\n" for both the last one and the other ones. Retire the helper function and update the caller with a simplified version. Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
dabd35f4cd
Коммит
54307ea7c3
5
bisect.c
5
bisect.c
|
@ -646,7 +646,10 @@ static void exit_if_skipped_commits(struct commit_list *tried,
|
|||
|
||||
printf("There are only 'skip'ped commits left to test.\n"
|
||||
"The first %s commit could be any of:\n", term_bad);
|
||||
print_commit_list(tried, "%s\n", "%s\n");
|
||||
|
||||
for ( ; tried; tried = tried->next)
|
||||
printf("%s\n", oid_to_hex(&tried->item->object.oid));
|
||||
|
||||
if (bad)
|
||||
printf("%s\n", oid_to_hex(bad));
|
||||
printf("We cannot bisect more!\n");
|
||||
|
|
10
commit.c
10
commit.c
|
@ -1617,16 +1617,6 @@ struct commit_list **commit_list_append(struct commit *commit,
|
|||
return &new->next;
|
||||
}
|
||||
|
||||
void print_commit_list(struct commit_list *list,
|
||||
const char *format_cur,
|
||||
const char *format_last)
|
||||
{
|
||||
for ( ; list; list = list->next) {
|
||||
const char *format = list->next ? format_cur : format_last;
|
||||
printf(format, oid_to_hex(&list->item->object.oid));
|
||||
}
|
||||
}
|
||||
|
||||
const char *find_commit_header(const char *msg, const char *key, size_t *out_len)
|
||||
{
|
||||
int key_len = strlen(key);
|
||||
|
|
4
commit.h
4
commit.h
|
@ -376,10 +376,6 @@ extern int parse_signed_commit(const struct commit *commit,
|
|||
struct strbuf *message, struct strbuf *signature);
|
||||
extern int remove_signature(struct strbuf *buf);
|
||||
|
||||
extern void print_commit_list(struct commit_list *list,
|
||||
const char *format_cur,
|
||||
const char *format_last);
|
||||
|
||||
/*
|
||||
* Check the signature of the given commit. The result of the check is stored
|
||||
* in sig->check_result, 'G' for a good signature, 'U' for a good signature
|
||||
|
|
Загрузка…
Ссылка в новой задаче