зеркало из https://github.com/microsoft/git.git
submodule: drop unused sm_name parameter from append_fetch_remotes()
Commitc21fb4676f
(submodule--helper: fix incorrect newlines in an error message, 2021-10-23) accidentally added a new, unused parameter while changing the name and signature of show_fetch_remotes() to append_fetch_remotes(). We can drop this to keep things simpler (and satisfy -Wunused-parameter). The error is likely becausec21fb4676f
is fixing a problem from8c8195e9c3
(submodule--helper: introduce add-clone subcommand, 2021-07-10). An earlier iteration of that second commit introduced the same unused parameter (though it was dropped before it finally made it to 'next'), and the fix on top accidentally carried forward the extra parameter. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
c21fb4676f
Коммит
6b615dbece
|
@ -2776,7 +2776,7 @@ struct add_data {
|
|||
};
|
||||
#define ADD_DATA_INIT { .depth = -1 }
|
||||
|
||||
static void append_fetch_remotes(struct strbuf *msg, const char *sm_name, const char *git_dir_path)
|
||||
static void append_fetch_remotes(struct strbuf *msg, const char *git_dir_path)
|
||||
{
|
||||
struct child_process cp_remote = CHILD_PROCESS_INIT;
|
||||
struct strbuf sb_remote_out = STRBUF_INIT;
|
||||
|
@ -2831,8 +2831,7 @@ static int add_submodule(const struct add_data *add_data)
|
|||
"locally with remote(s):\n"),
|
||||
add_data->sm_name);
|
||||
|
||||
append_fetch_remotes(&msg, add_data->sm_name,
|
||||
submod_gitdir_path);
|
||||
append_fetch_remotes(&msg, submod_gitdir_path);
|
||||
free(submod_gitdir_path);
|
||||
|
||||
strbuf_addf(&msg, _("If you want to reuse this local git "
|
||||
|
|
Загрузка…
Ссылка в новой задаче