зеркало из https://github.com/microsoft/git.git
Merge branch 'ss/fix-config-fd-leak' into maint
* ss/fix-config-fd-leak: config: close config file handle in case of error
This commit is contained in:
Коммит
8136099a31
5
config.c
5
config.c
|
@ -1954,7 +1954,7 @@ int git_config_set_multivar_in_file(const char *config_filename,
|
|||
const char *key, const char *value,
|
||||
const char *value_regex, int multi_replace)
|
||||
{
|
||||
int fd = -1, in_fd;
|
||||
int fd = -1, in_fd = -1;
|
||||
int ret;
|
||||
struct lock_file *lock = NULL;
|
||||
char *filename_buf = NULL;
|
||||
|
@ -2084,6 +2084,7 @@ int git_config_set_multivar_in_file(const char *config_filename,
|
|||
goto out_free;
|
||||
}
|
||||
close(in_fd);
|
||||
in_fd = -1;
|
||||
|
||||
if (chmod(lock->filename.buf, st.st_mode & 07777) < 0) {
|
||||
error("chmod on %s failed: %s",
|
||||
|
@ -2167,6 +2168,8 @@ out_free:
|
|||
free(filename_buf);
|
||||
if (contents)
|
||||
munmap(contents, contents_sz);
|
||||
if (in_fd >= 0)
|
||||
close(in_fd);
|
||||
return ret;
|
||||
|
||||
write_err_out:
|
||||
|
|
Загрузка…
Ссылка в новой задаче