зеркало из https://github.com/microsoft/git.git
gitk: Fix bug causing "can't read commitrow(0,n)" error
In commit 66e46f37de
I changed gitk to
store ids in rowrangelist and idrowranges rather than row numbers,
but I missed two places in the layouttail procedure. This resulted
in occasional errors such as the "can't read "commitrow(0,8572)":
no such element in array" error reported by Mark Levedahl. This fixes
it by using the id rather than the row number.
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Родитель
096e96b493
Коммит
8c93917d23
4
gitk
4
gitk
|
@ -2885,7 +2885,7 @@ proc layouttail {} {
|
||||||
set id [lindex $idlist $col]
|
set id [lindex $idlist $col]
|
||||||
addextraid $id $row
|
addextraid $id $row
|
||||||
unset idinlist($id)
|
unset idinlist($id)
|
||||||
lappend idrowranges($id) $row
|
lappend idrowranges($id) $id
|
||||||
lappend rowrangelist $idrowranges($id)
|
lappend rowrangelist $idrowranges($id)
|
||||||
unset idrowranges($id)
|
unset idrowranges($id)
|
||||||
incr row
|
incr row
|
||||||
|
@ -2901,7 +2901,7 @@ proc layouttail {} {
|
||||||
lset rowidlist $row [list $id]
|
lset rowidlist $row [list $id]
|
||||||
lset rowoffsets $row 0
|
lset rowoffsets $row 0
|
||||||
makeuparrow $id 0 $row 0
|
makeuparrow $id 0 $row 0
|
||||||
lappend idrowranges($id) $row
|
lappend idrowranges($id) $id
|
||||||
lappend rowrangelist $idrowranges($id)
|
lappend rowrangelist $idrowranges($id)
|
||||||
unset idrowranges($id)
|
unset idrowranges($id)
|
||||||
incr row
|
incr row
|
||||||
|
|
Загрузка…
Ссылка в новой задаче