зеркало из https://github.com/microsoft/git.git
remote-curl: Fix Accept header for smart HTTP connections
We actually expect to see an application/x-git-upload-pack-result but we lied and said we Accept *-response. This was a typo on my part when I was writing the code. Fortunately the wrong Accept header had no real impact, as the deployed git-http-backend servers were not testing the Accept header before they returned their content. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
fbb9971aca
Коммит
8efa5f629e
|
@ -480,7 +480,7 @@ static int rpc_service(struct rpc_state *rpc, struct discovery *heads)
|
||||||
strbuf_addf(&buf, "Content-Type: application/x-%s-request", svc);
|
strbuf_addf(&buf, "Content-Type: application/x-%s-request", svc);
|
||||||
rpc->hdr_content_type = strbuf_detach(&buf, NULL);
|
rpc->hdr_content_type = strbuf_detach(&buf, NULL);
|
||||||
|
|
||||||
strbuf_addf(&buf, "Accept: application/x-%s-response", svc);
|
strbuf_addf(&buf, "Accept: application/x-%s-result", svc);
|
||||||
rpc->hdr_accept = strbuf_detach(&buf, NULL);
|
rpc->hdr_accept = strbuf_detach(&buf, NULL);
|
||||||
|
|
||||||
while (!err) {
|
while (!err) {
|
||||||
|
|
|
@ -38,7 +38,7 @@ cat >exp <<EOF
|
||||||
> POST /smart/repo.git/git-upload-pack HTTP/1.1
|
> POST /smart/repo.git/git-upload-pack HTTP/1.1
|
||||||
> Accept-Encoding: deflate, gzip
|
> Accept-Encoding: deflate, gzip
|
||||||
> Content-Type: application/x-git-upload-pack-request
|
> Content-Type: application/x-git-upload-pack-request
|
||||||
> Accept: application/x-git-upload-pack-response
|
> Accept: application/x-git-upload-pack-result
|
||||||
> Content-Length: xxx
|
> Content-Length: xxx
|
||||||
< HTTP/1.1 200 OK
|
< HTTP/1.1 200 OK
|
||||||
< Pragma: no-cache
|
< Pragma: no-cache
|
||||||
|
|
Загрузка…
Ссылка в новой задаче