From 925bdc928e3debdc6dbf28b5648711eb1c5583d3 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Fri, 21 Oct 2016 06:42:10 -0400 Subject: [PATCH] test-lib: handle TEST_OUTPUT_DIRECTORY with spaces We are careful in test_done to handle a results directory with a space in it, but the "--tee" code path does not. Doing: export TEST_OUTPUT_DIRECTORY='/tmp/path with spaces' ./t000-init.sh --tee results in errors. Let's consistently double-quote our path variables so that this works. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- t/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 39c70f0326..01bb58ef00 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -58,8 +58,8 @@ done,*) mkdir -p "$TEST_OUTPUT_DIRECTORY/test-results" BASE="$TEST_OUTPUT_DIRECTORY/test-results/$(basename "$0" .sh)" (GIT_TEST_TEE_STARTED=done ${SHELL_PATH} "$0" "$@" 2>&1; - echo $? > $BASE.exit) | tee $BASE.out - test "$(cat $BASE.exit)" = 0 + echo $? >"$BASE.exit") | tee "$BASE.out" + test "$(cat "$BASE.exit")" = 0 exit ;; esac